Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disabled for Element-R] Flaky cypress test crypto.spec.ts > should allow verification when there is no existing DM #26447

Closed
florianduros opened this issue Oct 25, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11979
Closed

[Disabled for Element-R] Flaky cypress test crypto.spec.ts > should allow verification when there is no existing DM #26447

florianduros opened this issue Oct 25, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11979
Assignees
@richvdh
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Testing Testing, code coverage, etc. T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default Z-Flaky-Test A test is raising false alarms Z-Labs

Comments

@florianduros
Copy link
Member

florianduros commented Oct 25, 2023 •
edited
Loading

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6639269932/job/18037292903

  1) Cryptography
       should allow verification when there is no existing DM:
     AssertionError: Timed out retrying after 30000ms: Unable to find an accessible element with the role "button" and name "Verify by emoji"

There are no accessible roles. But there might be some inaccessible roles. If you wish to access them, then set the `hidden` option to `true`. Learn more about this here: https://testing-library.com/docs/dom-testing-library/api-queries#byrole
@florianduros florianduros added T-Defect Z-Flaky-Test A test is raising false alarms labels Oct 25, 2023
@Johennes Johennes added the A-Testing Testing, code coverage, etc. label Oct 26, 2023
@richvdh richvdh added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label Oct 26, 2023
@richvdh
Copy link
Member

richvdh commented Oct 26, 2023

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6642883792/job/18048683460#step:8:348

This was referenced Oct 26, 2023
Merged
Merged
@richvdh richvdh changed the title Flaky cypress test crypto.spec.ts > should allow verification when there is no existing DM [Disabled for Element-R] Flaky cypress test crypto.spec.ts > should allow verification when there is no existing DM Oct 26, 2023
@florianduros
Copy link
Member Author

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6653878293/job/18080788697

@BillCarsonFr BillCarsonFr added the Z-Element-R-Blocker A blocker for enabling Element R by default label Nov 8, 2023
@richvdh richvdh self-assigned this Nov 29, 2023
@richvdh richvdh mentioned this issue Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Testing Testing, code coverage, etc. T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default Z-Flaky-Test A test is raising false alarms Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable disabled cypress test matrix-org/matrix-react-sdk
4 participants
@Johennes @richvdh @florianduros @BillCarsonFr