-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for including release notes in update dialog #13
Comments
@davej I'm in favor of this. Do you want to give it a try? |
@zeke Ok, I could have a go at the JavaScript stuff. I think the collapsible release notes would require changes to Electron core and some C code though. Any tips on that? Or perhaps there's a way to approach it without touching Electron core? |
Yeah that would be ideal. Since this is designed for use with GitHub Release, we could also offer the user a link to the release page... 🤔 @MarshallOfSound @zcbenz is there a way to know at app startup that the app itself was recently updated? Don't see a hook for that in the autoUpdater docs. |
The native auto-update frameworks used in Electron do not provide the functionality, it is usually implemented in apps by storing current version in a configuration file. |
electron/electron#12437 would make this easier to implement. |
This comment has been minimized.
This comment has been minimized.
Not exactly the toggle, but definitely and improved experience |
No more updates? |
Just wondering if showing the release notes when prompting the user to restart is on the roadmap? Release notes would be taken from the github release.
Here's a potential mock-up with a toggle to show/hide:
An option could toggle whether to show them or not:
Even if release notes are turned on they would only be shown if there are actually release notes associated with the release. The release notes would probably need to be contained with a maximum height and overflow content should scroll because otherwise the height of the dialog may be too large. Perhaps this should be configurable or perhaps not.
The text was updated successfully, but these errors were encountered: