Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for including release notes in update dialog #13

Open
davej opened this issue Apr 22, 2018 · 9 comments
Open

Add option for including release notes in update dialog #13

davej opened this issue Apr 22, 2018 · 9 comments

Comments

@davej
Copy link

davej commented Apr 22, 2018

Just wondering if showing the release notes when prompting the user to restart is on the roadmap? Release notes would be taken from the github release.

Here's a potential mock-up with a toggle to show/hide:

release-notes

An option could toggle whether to show them or not:

require('update-electron-app')({
  repo: 'ummoji/ummoji-desktop',
  releaseNotes: true
})

Even if release notes are turned on they would only be shown if there are actually release notes associated with the release. The release notes would probably need to be contained with a maximum height and overflow content should scroll because otherwise the height of the dialog may be too large. Perhaps this should be configurable or perhaps not.

@davej davej changed the title Add option for including release notes in update dialog? Add option for including release notes in update dialog Apr 22, 2018
@zeke
Copy link
Contributor

zeke commented Apr 23, 2018

@davej I'm in favor of this. Do you want to give it a try?

@davej
Copy link
Author

davej commented Apr 23, 2018

@zeke Ok, I could have a go at the JavaScript stuff. I think the collapsible release notes would require changes to Electron core and some C code though. Any tips on that? Or perhaps there's a way to approach it without touching Electron core?

@davej
Copy link
Author

davej commented Apr 23, 2018

Windows also has the concept of collapsible text in a dialog. Perhaps this would be a useful addition to Electron core? It's much nicer UX than plonking all the release notes inline on a dialog. Is it worth me opening an issue on Electron Core?

image

image

@zeke
Copy link
Contributor

zeke commented Apr 23, 2018

Or perhaps there's a way to approach it without touching Electron core?

Yeah that would be ideal. Since this is designed for use with GitHub Release, we could also offer the user a link to the release page... 🤔

@MarshallOfSound @zcbenz is there a way to know at app startup that the app itself was recently updated? Don't see a hook for that in the autoUpdater docs.

@zcbenz
Copy link

zcbenz commented Apr 23, 2018

@MarshallOfSound @zcbenz is there a way to know at app startup that the app itself was recently updated? Don't see a hook for that in the autoUpdater docs.

The native auto-update frameworks used in Electron do not provide the functionality, it is usually implemented in apps by storing current version in a configuration file.

@sindresorhus
Copy link

electron/electron#12437 would make this easier to implement.

@quanganh1906

This comment has been minimized.

@erickzhao
Copy link
Member

Ref: electron/electron#23692

Not exactly the toggle, but definitely and improved experience

@jhaemin
Copy link

jhaemin commented Aug 8, 2024

No more updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants