Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAR Integrity assumes a single asar file is present #116

Open
t3chguy opened this issue Jan 22, 2025 · 1 comment
Open

ASAR Integrity assumes a single asar file is present #116

t3chguy opened this issue Jan 22, 2025 · 1 comment

Comments

@t3chguy
Copy link

t3chguy commented Jan 22, 2025

An application may use multiple ASARs and want integrity for all of them, but merging packages using @electron/universal breaks that.

Related electron-userland/electron-builder#8660

The main process code lives in app.asar and the renderer/webapp code lives in webapp.asar (for complicated reasons). We'd like integrity enabled at least on the app.asar but it seems like the fuse applies to all ASARs, and due to merging universal packages causing the integrity to get clobbered that is problematic.

[7727:0122/164306.527723:FATAL:archive.cc(239)] Failed to get integrity for validatable asar archive: Resources/webapp.asar

@mmaietta
Copy link
Contributor

mmaietta commented Jan 27, 2025

Note to the electron devs, I'm happy to pick up working on this issue after #117. 🙃 I just rewrote electron-builders asar integrity calculation to handle multi-asar project setups, so it should be easy to port over to electron/universal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants