Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add support for Yarn Modern, and require node-modules linker instead #3410

Closed
3 tasks done
trulysinclair opened this issue Nov 16, 2023 · 1 comment · Fixed by #3411
Closed
3 tasks done

Re-add support for Yarn Modern, and require node-modules linker instead #3410

trulysinclair opened this issue Nov 16, 2023 · 1 comment · Fixed by #3411
Assignees

Comments

@trulysinclair
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

Electron Forge has locked Yarn support to v1, I don't fully understand why, compatibility issues can be solved by yarnrc.yml settings such as nodeLinker: node-modules to use the node_modules folder instead of Plug'n'Play mode. I've used this setting for years when needed and it solves any issues immediately. I do not believe in locking Yarn support when solutions exist to negate its necessity.

Proposed solution

IF and only if the cause was due to PnP, then it is the developers responsibility to research their tool. PnP issues can be avoided by setting nodeLinker to node-modules to store packages as usual, while also still allowing plugins, and cache to stay active.

Alternatives considered

Not understanding the true scope of the cause, and considering I could be wrong in posting this issue, no other alternatives have been considered.

Additional information

No response

@erickzhao erickzhao self-assigned this Nov 17, 2023
@erickzhao
Copy link
Member

I've used this setting for years when needed and it solves any issues immediately. I do not believe in locking Yarn support when solutions exist to negate its necessity.

I think that makes sense, will make a PR amending this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants