Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Revise generated policies when using the shipper #158937

Closed
faec opened this issue Jun 2, 2023 · 2 comments
Closed

[Fleet] Revise generated policies when using the shipper #158937

faec opened this issue Jun 2, 2023 · 2 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@faec
Copy link

faec commented Jun 2, 2023

An impending change in elastic-agent affects how the shipper is enabled on an output. Previously this was done by setting shipper.enabled: true, or similar options described in #141508 (comment). After this PR is merged, the shipper will be enabled on an output by adding the use_shipper: true flag. (Internally this is a more significant change: the previous syntax enabled one specific shipper, named shipper, which was statically configured in the agent repository. The new syntax no longer cares about the specific name of the shipper, and just signals agent to allow any shipper that supports the given output type.)

This will also affect queue configuration. The queue options described in #141508 (comment) were based on plans at the time, but were never implemented -- the current plan calls for queue settings to be included directly in the output configuration block (see the implementation issue). For example the shipper could be enabled with the disk queue as follows:

output:
  default:
    type: elasticsearch
    use_shipper: true
    queue.disk:
      max_size: 10GB
      retry_interval: 500ms

(Ownership of this issue is still being discussed, Agent team might end up taking on the implementation work for this issue.)

@faec faec added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jlind23
Copy link
Contributor

jlind23 commented Jun 5, 2024

Shipper project has been revisited since then hence closing.

@jlind23 jlind23 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

3 participants