Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Mark shipper feature as experimental in Fleet UI #153845

Closed
criamico opened this issue Mar 28, 2023 · 6 comments · Fixed by #154228
Closed

[Fleet] Mark shipper feature as experimental in Fleet UI #153845

criamico opened this issue Mar 28, 2023 · 6 comments · Fixed by #154228
Assignees
@criamico
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@criamico
Copy link
Contributor

In 8.8.x the shipper will be available in fleet UI as an experimental feature.

Add some UI element to warn the user that the feature is experimental.

shipper
@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico
Copy link
Contributor Author

I think that we could add a tooltip with some description or a beta badge.
@nimarezainia What do you think?

@nimarezainia
Copy link
Contributor

@criamico I think a beta badge next to the "Advanced" would suffice. Would the advanced section only appear when the shipper.enabled is TRUE?

@criamico
Copy link
Contributor Author

@nimarezainia yes exactly, the advanced section appears if one the following conditions is added to the yaml editor and saved:

shipper: {}

# Or
shipper:
  enabled: true

@jlind23
Copy link
Contributor

jlind23 commented Mar 29, 2023

@nimarezainia you want beta for 8.9, not for 8.8 right? Then what should we do in 8.8? Experimental as Cristina mentioned?

@nimarezainia
Copy link
Contributor

@criamico @jlind23 yes Experimental, all hidden behind the feature flag so user can't see at the moment.

@criamico criamico self-assigned this Apr 3, 2023
@criamico criamico mentioned this issue Apr 3, 2023
Merged
criamico added a commit that referenced this issue Apr 3, 2023
@criamico @kibanamachine
[Fleet] Mark shipper feature as experimental in Fleet UI (#154228)
9c67d83 
Fixes #153845

## Summary

The new Outputs Shipper section will be available as an experimental
feature in 8.8.0. This PR adds a badge to clearly indicate it as
experimental in UI.



To test it:
Enable the shipper options by adding one of the following in outputs
yaml editor:

```
shipper: {}
```
OR
```
shipper:
  enabled: true
```

You should see a badge besides "Advanced options":
<img width="734" alt="Screenshot 2023-04-03 at 12 13 37"
src="https://user-images.githubusercontent.com/16084106/229481384-cce7d105-1e03-4e97-9815-a7cef3a29d11.png">
<img width="737" alt="Screenshot 2023-04-03 at 12 13 30"
src="https://user-images.githubusercontent.com/16084106/229481485-ff963b86-da9d-4f8e-ab23-277f7f9290f6.png">

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criamico criamico

Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Mark shipper feature as experimental in Fleet UI criamico/kibana
4 participants
@nimarezainia @elasticmachine @criamico @jlind23