Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input fields append + prepend with icon padding error #8056

Closed
tomitank opened this issue Oct 2, 2024 · 4 comments
Closed

Input fields append + prepend with icon padding error #8056

tomitank opened this issue Oct 2, 2024 · 4 comments
Labels

Comments

@tomitank
Copy link

tomitank commented Oct 2, 2024

https://eui.elastic.co/#/forms/form-controls#text-field

here is the append and prepend with icon (without actions) don't have padding.

Image

@mgadewoll
Copy link
Contributor

Hei @tomitank! I can't seem to reproduce this by opening the provided link.
Could you provide further details on when you encounter this? Did you select a specific EUI version in the docs? What browser/OS + versions are you on?

@mgadewoll mgadewoll added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible and removed accessibility labels Oct 2, 2024
@tomitank
Copy link
Author

tomitank commented Oct 2, 2024

Interesting, because of i had only on my work laptop.
Firefox: 115.0.2 (64 bites)

@tkajtoch tkajtoch changed the title Input fields appen + prepend with icon padding error Input fields append + prepend with icon padding error Oct 8, 2024
@mgadewoll
Copy link
Contributor

Thanks for the additional info @tomitank, it's useful to provide your setup for us to easier pin point the issue your facing 🙂
I was now able to reproduce the mentioned issue in Firefox 115 on Windows.

Note

The issue stems from :has() selector not being supported in Firefox version 115 yet (see on caniuse) and the expected padding not being applied. It's supported from Firefox version 121 on.

Given that we support the latest 2 versions of browsers and the :has() selector feature is part of the web baseline since December 2023 we will not address this specifically for older browsers that don't support this feature.

@mgadewoll mgadewoll removed the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Oct 8, 2024
@tomitank
Copy link
Author

tomitank commented Oct 8, 2024

We use this version at a large company, which also uses Kibana.
Unfortunately, you can't say more.
Please consider to fix this for older browse as well.
Thank you in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants