From 4618641e42204d776f1e60c4883c6569b83fe159 Mon Sep 17 00:00:00 2001 From: Lene Gadewoll Date: Fri, 13 Dec 2024 09:48:45 +0100 Subject: [PATCH] [Visual Refresh] Remove support for accentSecondary badges (#8227) --- .../src-docs/src/views/badge/beta_badge.tsx | 8 +---- .../badge/__snapshots__/badge.test.tsx.snap | 35 ------------------- .../eui/src/components/badge/badge.styles.ts | 1 - packages/eui/src/components/badge/badge.tsx | 1 - .../__snapshots__/beta_badge.test.tsx.snap | 11 ------ .../badge/beta_badge/beta_badge.styles.ts | 3 -- .../badge/beta_badge/beta_badge.tsx | 8 +---- .../badge_notification.test.tsx.snap | 8 ----- .../badge_notification.styles.ts | 1 - .../notification_badge/badge_notification.tsx | 7 +--- 10 files changed, 3 insertions(+), 80 deletions(-) diff --git a/packages/eui/src-docs/src/views/badge/beta_badge.tsx b/packages/eui/src-docs/src/views/badge/beta_badge.tsx index 71173c0199d..0d72a59bb4d 100644 --- a/packages/eui/src-docs/src/views/badge/beta_badge.tsx +++ b/packages/eui/src-docs/src/views/badge/beta_badge.tsx @@ -3,13 +3,7 @@ import { css } from '@emotion/react'; import { EuiBetaBadge, EuiSpacer, EuiTitle } from '../../../../src/components'; -const colors = [ - 'hollow', - 'accent', - 'accentSecondary', - 'subdued', - 'warning', -] as const; +const colors = ['hollow', 'accent', 'subdued', 'warning'] as const; export default () => ( <> diff --git a/packages/eui/src/components/badge/__snapshots__/badge.test.tsx.snap b/packages/eui/src/components/badge/__snapshots__/badge.test.tsx.snap index fd18535655e..ce00526e2f1 100644 --- a/packages/eui/src/components/badge/__snapshots__/badge.test.tsx.snap +++ b/packages/eui/src/components/badge/__snapshots__/badge.test.tsx.snap @@ -175,23 +175,6 @@ exports[`EuiBadge props color accent is rendered 1`] = ` `; -exports[`EuiBadge props color accentSecondary is rendered 1`] = ` - - - - Content - - - -`; - exports[`EuiBadge props color accepts hex 1`] = ` `; -exports[`EuiBadge props style is rendered with accentSecondary 1`] = ` - - - - Content - - - -`; - exports[`EuiBadge props style is rendered with danger 1`] = ` { `, primary: css(setBadgeColorVars(badgeColors.primary)), accent: css(setBadgeColorVars(badgeColors.accent)), - accentSecondary: css(setBadgeColorVars(badgeColors.accentSecondary)), warning: css(setBadgeColorVars(badgeColors.warning)), danger: css(setBadgeColorVars(badgeColors.danger)), success: css(setBadgeColorVars(badgeColors.success)), diff --git a/packages/eui/src/components/badge/badge.tsx b/packages/eui/src/components/badge/badge.tsx index edfda98531c..735576b30b6 100644 --- a/packages/eui/src/components/badge/badge.tsx +++ b/packages/eui/src/components/badge/badge.tsx @@ -40,7 +40,6 @@ export const COLORS = [ 'primary', 'success', 'accent', - 'accentSecondary', 'warning', 'danger', ] as const; diff --git a/packages/eui/src/components/badge/beta_badge/__snapshots__/beta_badge.test.tsx.snap b/packages/eui/src/components/badge/beta_badge/__snapshots__/beta_badge.test.tsx.snap index 270a131ec10..c50cd2d1393 100644 --- a/packages/eui/src/components/badge/beta_badge/__snapshots__/beta_badge.test.tsx.snap +++ b/packages/eui/src/components/badge/beta_badge/__snapshots__/beta_badge.test.tsx.snap @@ -46,17 +46,6 @@ exports[`EuiBetaBadge props color accent is rendered 1`] = ` `; -exports[`EuiBetaBadge props color accentSecondary is rendered 1`] = ` - - - Beta - - -`; - exports[`EuiBetaBadge props color hollow is rendered 1`] = ` { accent: hasVisColorAdjustment ? css(badgeColors.accentText) : css(badgeColors.accent), - accentSecondary: hasVisColorAdjustment - ? css(badgeColors.accentSecondaryText) - : css(badgeColors.accentSecondary), subdued: css(badgeColors.subdued), hollow: css` color: ${badgeColors.hollow.color}; diff --git a/packages/eui/src/components/badge/beta_badge/beta_badge.tsx b/packages/eui/src/components/badge/beta_badge/beta_badge.tsx index 75dd6550018..77e3e5d4363 100644 --- a/packages/eui/src/components/badge/beta_badge/beta_badge.tsx +++ b/packages/eui/src/components/badge/beta_badge/beta_badge.tsx @@ -22,13 +22,7 @@ import { EuiIcon, IconType } from '../../icon'; import { euiBetaBadgeStyles } from './beta_badge.styles'; -export const COLORS = [ - 'accent', - 'accentSecondary', - 'subdued', - 'hollow', - 'warning', -] as const; +export const COLORS = ['accent', 'subdued', 'hollow', 'warning'] as const; export type BetaBadgeColor = (typeof COLORS)[number]; export const SIZES = ['s', 'm'] as const; diff --git a/packages/eui/src/components/badge/notification_badge/__snapshots__/badge_notification.test.tsx.snap b/packages/eui/src/components/badge/notification_badge/__snapshots__/badge_notification.test.tsx.snap index 99c6b71878a..e49b8ef8f7c 100644 --- a/packages/eui/src/components/badge/notification_badge/__snapshots__/badge_notification.test.tsx.snap +++ b/packages/eui/src/components/badge/notification_badge/__snapshots__/badge_notification.test.tsx.snap @@ -18,14 +18,6 @@ exports[`EuiNotificationBadge props color accent is rendered 1`] = ` `; -exports[`EuiNotificationBadge props color accentSecondary is rendered 1`] = ` - - 5 - -`; - exports[`EuiNotificationBadge props color subdued is rendered 1`] = ` { `, // Colors accent: css(badgeColors.accentText), - accentSecondary: css(badgeColors.accentSecondaryText), success: css(badgeColors.success), subdued: css(badgeColors.subdued), }; diff --git a/packages/eui/src/components/badge/notification_badge/badge_notification.tsx b/packages/eui/src/components/badge/notification_badge/badge_notification.tsx index 00d3f13644a..c68cfa21510 100644 --- a/packages/eui/src/components/badge/notification_badge/badge_notification.tsx +++ b/packages/eui/src/components/badge/notification_badge/badge_notification.tsx @@ -14,12 +14,7 @@ import { CommonProps } from '../../common'; import { euiNotificationBadgeStyles } from './badge_notification.styles'; -export const COLORS = [ - 'accent', - 'accentSecondary', - 'subdued', - 'success', -] as const; +export const COLORS = ['accent', 'subdued', 'success'] as const; export type BadgeNotificationColor = (typeof COLORS)[number]; export const SIZES = ['s', 'm'] as const;