Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 8.2 does not work with with Nodejs 12 and below due to the new version of undici #74

Closed
bugb opened this issue Nov 28, 2023 · 1 comment

Comments

@bugb
Copy link

bugb commented Nov 28, 2023

It's not uncommon that somebody already opened an issue or in the best case it's already fixed but not merged. That's the reason why you should search at first before submitting a new one.

Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here that does not follow the instructions, your issue might be closed,
locked, and assigned the not reproducible label.

🐛 Bug Report

  • Since undici version 5.28.0, they will not support Nodejs 12 and below. It has been confirmed Undici does not work with Nodejs 12 and below nodejs/undici#2469 (comment) or you can check the diff from the version v5.27 latest to the version 5.28 here where you can see a lot of ?? (optional chainning) and ?. (nullish coalescing) synxtax those are not availble in Nodejs 12 and below.

  • This problem happens due to the line below:

image

undici will be resolved to the version under 6.0, due to npm follows semver spec. Or you can check the online version of npm semver calculation here.

image

To Reproduce

Steps to reproduce the behavior:

  • Use elastic-transport-js version 8.2 in Nodejs 12 and below

Expected behavior

  • elastic-transport-js should work with Nodejs 12 because it is in high demand :)
    (Source)
    image

Your Environment

  • node version: 12 and below
  • @elastic/elasticsearch version: 8.2
  • os: Mac, Windows, Linux
  • any other relevant information

Additional information

@bugb bugb changed the title Compatible with Nodejs 12 and below Version 8.2 does not work with with Nodejs 12 and below due to the new version of undici Nov 28, 2023
@JoshMock
Copy link
Member

As noted in the client's documentation, the Elasticsearch Node.js client and supporting libraries like this one will drop support for Node.js versions that have reached end of life between minor versions. Node.js v12 reached EOL in April of 2022, so we no longer support it as of client version 8.4.0. Support for v14 and v16 will end when I ship 8.11.0 of the client in the next few days.

@JoshMock JoshMock closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants