Remove .package-version file and its usage #6840
Conversation
pazone
added
enhancement
|
| # There is a time when the current snapshot is not available on cloud yet, so we cannot use the latest version automatically | ||
| # This file is managed by an automation (mage integration:UpdateAgentPackageVersion) that check if the snapshot is ready. | ||
|
|
||
| STACK_VERSION="$(cat .package-version)" |
There was a problem hiding this comment.
OK reading everything this does, we actually want to keep this as a way to have a lagging update of the stack version. Since we will bump the agent version from N to N+1 but need to test against stack version N until the first snapshot for N+1 is produced.
Let's keep that part of this.
We should not need to change the actual agent version anymore, the fact that we do this without consequence is a hint we can just relax the version constraints for convenience where necessary. We already did this for minors, but didn't handle majors properly yet.
There was a problem hiding this comment.
I would rename the file to .stack-version (and the associated mage target) and remove anything that sets the agent package version (which is the version agent reports itself as to the stack).
There was a problem hiding this comment.
Then the .stack-version should also be auto-updated, right?
There was a problem hiding this comment.
Do I understand it correctly that this PR doesn't make much sense?
What does this PR do?
Removes the
.package-versionfile and all usages.Why is it important?
The
.package-versionfile is not required anymore and brings unnecessary complexity to the CI and related codebaseChecklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself