-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(go.mod): update beats dependency #6837
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
adcf784
to
4ff5a48
Compare
Decided to update to elastic/beats@d813311 instead, since it includes a fix for default processors in fbreceiver. |
Waiting on elastic/beats#42725 so I can include the fix to the batch of changes. |
c2e64e2
to
d4b7d5c
Compare
@@ -887,6 +887,8 @@ func TestOtelFBReceiverE2E(t *testing.T) { | |||
enabled: true | |||
paths: | |||
- {{.InputPath}} | |||
prospector.scanner.fingerprint.enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering is this a valid chore
PR if we do changes of configuration in our integration tests? Is this change required to happen because the previous config is no longer valid with the prior version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a leftover, it is like this for other tests. Long story short filebeat now has fingerprint fiile identity by default, which causes issues in tests that ingest a small file that is not big enough to produce a valid fingerprint. These options are used in most tests because of this.
c4fec38
to
a1f567d
Compare
/test |
|
* chore(go.mod): update beats dependency * update beats to d813311 * update beats to ef79280, fix tests (cherry picked from commit e274a84) # Conflicts: # NOTICE.txt # go.mod # testing/integration/otel_test.go
* chore(go.mod): update beats dependency * update beats to d813311 * update beats to ef79280, fix tests (cherry picked from commit e274a84) # Conflicts: # go.sum
* chore(go.mod): update beats dependency (#6837) * chore(go.mod): update beats dependency * update beats to d813311 * update beats to ef79280, fix tests (cherry picked from commit e274a84) # Conflicts: # NOTICE.txt # go.mod # testing/integration/otel_test.go * resolve conflicts --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
* chore(go.mod): update beats dependency (#6837) * chore(go.mod): update beats dependency * update beats to d813311 * update beats to ef79280, fix tests (cherry picked from commit e274a84) # Conflicts: # go.sum * resolve conflicts --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
This PR updates beats/v7 to point to elastic/beats@ef79280.
This is needed for the recent fixes and work on the beats receivers, for example elastic/beats#42412, elastic/beats#42658, elastic/beats#42707 and elastic/beats#42725.