-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.16](backport #6675) resolve proxy to inject using http package #6755
Conversation
* resolve proxy to inject using http package * unit tests * golint * golint * changelog fragment * changelog fragment * move environment manipulation, trying to fix test run in CI * fix unit test, localhost never goes through environment proxy * use internal function to be able to unit test the behavior * make lint happy * fix build * update NOTICE (cherry picked from commit be179d8) # Conflicts: # NOTICE.txt # go.mod
Cherry-pick of be179d8 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request has not been merged yet. Could you please review and merge it @intxgo? 🙏 |
@intxgo could you please take care of this PR? The |
|
What does this PR do?
Agent is injecting proxy env variables into components configs if no proxy is already specified by the config. Unfortunately with this approach the NO_PROXY variable is lost, so the target URL has to be evaluated against the environment proxy to determine if the proxy should be used. Go http provides such functionality.
Why is it important?
The environment proxy may be defined with exclusion for Fleet and Output addresses.
Checklist
./changelog/fragments
using the changelog toolRelated issues
HTTP_PROXY/HTTPS_PROXY/NO_PROXY
to components. #2602This is an automatic backport of pull request #6675 done by [Mergify](https://mergify.com).