Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add linter that denies importing math/rand #6650

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Jan 30, 2025

What does this PR do?

We had previous PRs at #5335 and elastic/beats#42025 moving away from math/rand to the newer math/rand/v2 package. Currently there is nothing preventing contributors to commiting code using math/rand and regressing these changes.

Introduce a linter that catches math/rand imports in Go files.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Cleanup backport-8.x Automated backport to the 8.x branch with mergify labels Jan 30, 2025
@mauri870 mauri870 self-assigned this Jan 30, 2025
@mauri870 mauri870 requested a review from a team as a code owner January 30, 2025 14:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Member Author

/test

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mauri870 mauri870 merged commit cc84f9e into elastic:main Jan 30, 2025
11 of 15 checks passed
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
mauri870 added a commit that referenced this pull request Jan 31, 2025
(cherry picked from commit cc84f9e)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
@mauri870 mauri870 added the backport-9.0 Automated backport to the 9.0 branch label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch Cleanup skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants