Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0](backport #42652) Wait for the beat to exit during shutdown of beats receivers #42662

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 10, 2025

Proposed commit message

Wait for the beat to exit during shutdown of beats receivers.

According to the otel component interface, Shutdown should wait for global resources to be freed. In particular, Shutdown returning means that the collector may create and start another component with the same name, which in case of beats receivers leads to a panic due to registry conflicts.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

Related issues

According to the otel component interface, Shutdown should wait for
global resources to be freed. In particular, Shutdown returning means
that the collector may create and start another component with the same
name, which in case of beats receivers leads to a panic due to registry
conflicts.

(cherry picked from commit 7514fa9)
@mergify mergify bot requested a review from a team as a code owner February 10, 2025 16:36
@mergify mergify bot added the backport label Feb 10, 2025
@mergify mergify bot requested review from belimawr and rdner and removed request for a team February 10, 2025 16:36
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 10, 2025
@github-actions github-actions bot added bug Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Feb 10, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 10, 2025
@swiatekm swiatekm merged commit 58ac9cc into 9.0 Feb 10, 2025
31 checks passed
@swiatekm swiatekm deleted the mergify/bp/9.0/pr-42652 branch February 10, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants