Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate replace directive in go.mod #38950

Open
leehinman opened this issue Apr 15, 2024 · 1 comment
Open

evaluate replace directive in go.mod #38950

leehinman opened this issue Apr 15, 2024 · 1 comment
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@leehinman
Copy link
Contributor

Currently the beats go.mod file has 20 replace directives, and many of these replace all versions of the module with the specified one. Many of these were added to get around a specific bug, but upstream has often fixed the issue. We should be removing the replace directives when possible, and documenting why they are required. We should also come up with some best practices for adding replace directives, examples might be forks should be maintained by elastic, include version number on left side when possible to reduce scope, etc.

One example:

	github.com/fsnotify/fsnotify => github.com/adriansr/fsnotify v1.4.8-0.20211018144411-a81f2b630e7c

This replaces all versions of fsnotify with a very specific fork that is not maintained by elastic. The last time this was updated was to get around a limitation in fsnotify that has now been fixed.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 15, 2024
@leehinman leehinman added Team:Elastic-Agent Label for the Agent team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 15, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants