Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to guarantee data is not reingested when the journald input is restarted #37876

Closed
2 of 3 tasks
Tracked by #37086
pierrehilbert opened this issue Feb 6, 2024 · 4 comments · Fixed by #42596
Closed
2 of 3 tasks
Tracked by #37086
Assignees
Labels
enhancement Team:Elastic-Agent Label for the Agent team

Comments

@pierrehilbert
Copy link
Collaborator

pierrehilbert commented Feb 6, 2024

Issue

Meta issue: #37086
To have journald GA, we should ensure that we are covering key scenarios with enough testing.

Acceptance Criteria

Tests are in place to confirm:

  • We don't have data duplication when the input is restarted
  • We have an at least once delivery guarantee
  • Performances are comparable with filestream reading syslog
@pierrehilbert pierrehilbert added enhancement Team:Elastic-Agent Label for the Agent team labels Feb 6, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@cmacknz cmacknz changed the title [journald] Review and add missing tests Add test to guarantee data is not reingested when the journald input is restarted Dec 18, 2024
@belimawr belimawr self-assigned this Feb 4, 2025
@belimawr
Copy link
Contributor

belimawr commented Feb 4, 2025

@pierrehilbert I believe it does not make sense to compare the performance of the Journald input with Filestream reading from syslog, at least not as part of this issue that is about not duplicating data on restart.

If we need a comparison in performance between Filestream reading syslog logs and Journald input reading the same data, we can create a separated issue for this.

What do you think?

@pierrehilbert
Copy link
Collaborator Author

Agree this doesn't need to be covered in this issue.
I still think we should run a performance comparison to measure the impact and be able to share the information to our customers if this is relevant (and therefore highlight rsyslog as an alternative to avoid this performance impact).
WDYT?

@belimawr
Copy link
Contributor

belimawr commented Feb 5, 2025

Agree this doesn't need to be covered in this issue. I still think we should run a performance comparison to measure the impact and be able to share the information to our customers if this is relevant (and therefore highlight rsyslog as an alternative to avoid this performance impact). WDYT?

Yes, we can run those benchmarks, it's gonna be an interesting exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants