Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request cookie header and response headers are not being redacted #2066

Closed
david-luna opened this issue May 5, 2023 · 0 comments · Fixed by #2290
Closed

Request cookie header and response headers are not being redacted #2066

david-luna opened this issue May 5, 2023 · 0 comments · Fixed by #2290

Comments

@david-luna
Copy link
Member

david-luna commented May 5, 2023

Edited by @stevejgordon.

The agent is redacting request headers based on SanitizeFieldNames config. This list of names contains set-cookie name but not cookie resulting in transactions with request cookies not being redacted. The agent must redact the cookies based on that config. Response headers are also currently not being sanitized.

Other agents like Java & Python are parsing the cookies into an object and place it in context.request.cookies which is accepted by the intake API then sanitization is applied for each cookie individually. The cookie header itself is removed or redacted (it varies from implementation)

@stevejgordon stevejgordon changed the title Request cookie header not being redacted Request cookie header and response headers are not being redacted Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant