Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ws argument in _on_open callback #36

Open
edwinofsakh opened this issue Aug 26, 2019 · 0 comments
Open

Missing ws argument in _on_open callback #36

edwinofsakh opened this issue Aug 26, 2019 · 0 comments

Comments

@edwinofsakh
Copy link

I got next errors when I try to use last version of websocket (0.56.0):

error from callback <bound method Connection._on_open of <Connection(Thread-8, started daemon 14424)>>: _on_open() missing 1 required positional argument: 'ws'
error from callback <bound method Connection._on_message of <Connection(Thread-8, started daemon 14424)>>: _on_message() missing 1 required positional argument: 'message'

It works good if I downgrade websocket-client to version 0.48.0.

It seems like according to recent changes of websocket-client, the callback function does not receive WebSocketApp instance if it is a method of any class.

Recent changes of websocket-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant