[Bug] cluster name is not validated

[cartermckinnon]

What were you trying to accomplish?

What happened?

eksctl uses the cluster name:

eksctl/pkg/apis/eksctl.io/v1alpha5/types.go

Line 695 in aa58c6a

Name string `json:"name"`

as a label value on e.g. Node objects:

eksctl/pkg/apis/eksctl.io/v1alpha5/types.go

Line 314 in aa58c6a

ClusterNameLabel = "alpha.eksctl.io/cluster-name"

But the requirements for a label value are more restrictive than cluster names on EKS. Kubernetes label values can be up to 63 characters in length, while EKS cluster names can be up to 100 characters in length.

k8s docs: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set
EKS docs: https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateCluster.html#AmazonEKS-CreateCluster-request-name

eksctl should enforce its more strict requirements.

How to reproduce it?

Anything else we need to know?

N/A

Versions

All.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.