Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter set as endpoint in integration test #49

Open
ghost opened this issue Mar 3, 2020 · 0 comments
Open

Parameter set as endpoint in integration test #49

ghost opened this issue Mar 3, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers to start with

Comments

@ghost
Copy link

ghost commented Mar 3, 2020

Description

In ServiceIntegrationSteps.java line 208 the parameter account_id=1000000 is set using .setEndpoint(). This will not work when upgrading eiffel-commons to the latest version. To be able to run integarion tests after updating eiffel-commons version the account_id parameter must be set using addParameter method.

Motivation

Integration test will not work if eiffel-commons is updated to latest version.

Exemplification

Make the code look more decent.

final HttpRequest requestLogin = new HttpRequest(HttpMethod.GET, httpExecutor);

requestLogin.setBaseUrl(GERRIT_BASE_URL)
            .setEndpoint("/login/")
            .addParameter("account_id", "1000000")
            .addParameter("http.protocol.handle-redirects", "false");

final ResponseEntity response = requestLogin.performRequest();
@ghost ghost added bug Something isn't working good first issue Good for newcomers to start with labels Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers to start with
Projects
None yet
Development

No branches or pull requests

0 participants