From 5f4c48aa40042036d57b924bf65f6033cd097aad Mon Sep 17 00:00:00 2001 From: Barak Schmookler Date: Fri, 15 Nov 2024 10:59:56 -0500 Subject: [PATCH 1/2] Added parameter --- src/algorithms/tracking/OrthogonalTrackSeedingConfig.h | 2 ++ src/algorithms/tracking/TrackSeeding.cc | 1 + src/global/tracking/TrackSeeding_factory.h | 1 + 3 files changed, 4 insertions(+) diff --git a/src/algorithms/tracking/OrthogonalTrackSeedingConfig.h b/src/algorithms/tracking/OrthogonalTrackSeedingConfig.h index 048be3973a..08d1113603 100644 --- a/src/algorithms/tracking/OrthogonalTrackSeedingConfig.h +++ b/src/algorithms/tracking/OrthogonalTrackSeedingConfig.h @@ -38,6 +38,8 @@ namespace eicrecon { float rMinMiddle = 20. * Acts::UnitConstants::mm; // Middle spacepoint must fall between these two radii float rMaxMiddle = 400. * Acts::UnitConstants::mm; + float deltaPhiMax = 0.085; // Max difference in phi between middle and either top or bottom sp + ////////////////////////////////////////////////////////////////////////// /// SEED FILTER GENERAL PARAMETERS /// The parameters below control the process of filtering out seeds before diff --git a/src/algorithms/tracking/TrackSeeding.cc b/src/algorithms/tracking/TrackSeeding.cc index c1094e78c8..3c285d631b 100644 --- a/src/algorithms/tracking/TrackSeeding.cc +++ b/src/algorithms/tracking/TrackSeeding.cc @@ -104,6 +104,7 @@ void eicrecon::TrackSeeding::configure() { m_seedFinderConfig.impactMax = m_cfg.impactMax; m_seedFinderConfig.rMinMiddle = m_cfg.rMinMiddle; m_seedFinderConfig.rMaxMiddle = m_cfg.rMaxMiddle; + m_seedFinderConfig.deltaPhiMax = m_cfg.deltaPhiMax; m_seedFinderOptions.beamPos = Acts::Vector2(m_cfg.beamPosX, m_cfg.beamPosY); m_seedFinderOptions.bFieldInZ = m_cfg.bFieldInZ; diff --git a/src/global/tracking/TrackSeeding_factory.h b/src/global/tracking/TrackSeeding_factory.h index 181e36cdba..a180d33f0a 100644 --- a/src/global/tracking/TrackSeeding_factory.h +++ b/src/global/tracking/TrackSeeding_factory.h @@ -50,6 +50,7 @@ class TrackSeeding_factory : ParameterRef m_impactMax {this, "impactMax", config().impactMax, "maximum impact parameter allowed for seeds for Acts::OrthogonalSeedFinder. rMin should be larger than impactMax."}; ParameterRef m_rMinMiddle {this, "rMinMiddle", config().rMinMiddle, "min radius for middle space point for Acts::OrthogonalSeedFinder"}; ParameterRef m_rMaxMiddle {this, "rMaxMiddle", config().rMaxMiddle, "max radius for middle space point for Acts::OrthogonalSeedFinder"}; + ParameterRef m_deltaPhiMax {this, "deltaPhiMax", config().deltaPhiMax, "Max phi difference between middle and top/bottom space point"}; ParameterRef m_locaError {this, "loc_a_Error", config().locaError, "Error on Loc a for Acts::OrthogonalSeedFinder"}; ParameterRef m_locbError {this, "loc_b_Error", config().locbError, "Error on Loc b for Acts::OrthogonalSeedFinder"}; ParameterRef m_phiError {this, "phi_Error", config().phiError, "Error on phi for Acts::OrthogonalSeedFinder"}; From 0c7cfbc7201ce135a6c344d3d9477d50f3b015ac Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 15 Nov 2024 16:19:37 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/algorithms/tracking/OrthogonalTrackSeedingConfig.h | 2 +- src/global/tracking/TrackSeeding_factory.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/algorithms/tracking/OrthogonalTrackSeedingConfig.h b/src/algorithms/tracking/OrthogonalTrackSeedingConfig.h index 08d1113603..5339977846 100644 --- a/src/algorithms/tracking/OrthogonalTrackSeedingConfig.h +++ b/src/algorithms/tracking/OrthogonalTrackSeedingConfig.h @@ -38,7 +38,7 @@ namespace eicrecon { float rMinMiddle = 20. * Acts::UnitConstants::mm; // Middle spacepoint must fall between these two radii float rMaxMiddle = 400. * Acts::UnitConstants::mm; - float deltaPhiMax = 0.085; // Max difference in phi between middle and either top or bottom sp + float deltaPhiMax = 0.085; // Max difference in phi between middle and either top or bottom sp ////////////////////////////////////////////////////////////////////////// /// SEED FILTER GENERAL PARAMETERS diff --git a/src/global/tracking/TrackSeeding_factory.h b/src/global/tracking/TrackSeeding_factory.h index a180d33f0a..12695bc721 100644 --- a/src/global/tracking/TrackSeeding_factory.h +++ b/src/global/tracking/TrackSeeding_factory.h @@ -50,7 +50,7 @@ class TrackSeeding_factory : ParameterRef m_impactMax {this, "impactMax", config().impactMax, "maximum impact parameter allowed for seeds for Acts::OrthogonalSeedFinder. rMin should be larger than impactMax."}; ParameterRef m_rMinMiddle {this, "rMinMiddle", config().rMinMiddle, "min radius for middle space point for Acts::OrthogonalSeedFinder"}; ParameterRef m_rMaxMiddle {this, "rMaxMiddle", config().rMaxMiddle, "max radius for middle space point for Acts::OrthogonalSeedFinder"}; - ParameterRef m_deltaPhiMax {this, "deltaPhiMax", config().deltaPhiMax, "Max phi difference between middle and top/bottom space point"}; + ParameterRef m_deltaPhiMax {this, "deltaPhiMax", config().deltaPhiMax, "Max phi difference between middle and top/bottom space point"}; ParameterRef m_locaError {this, "loc_a_Error", config().locaError, "Error on Loc a for Acts::OrthogonalSeedFinder"}; ParameterRef m_locbError {this, "loc_b_Error", config().locbError, "Error on Loc b for Acts::OrthogonalSeedFinder"}; ParameterRef m_phiError {this, "phi_Error", config().phiError, "Error on phi for Acts::OrthogonalSeedFinder"};