Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert back to retaining NULL instead of coalescing empty list-col elements into nested NAs #139

Open
egouldo opened this issue Sep 1, 2024 · 0 comments
Assignees
Labels
feature a feature request or enhancement upkeep maintenance, infrastructure, and similar

Comments

@egouldo
Copy link
Owner

egouldo commented Sep 1, 2024

Replacing NULLs with NAs results in the missing vals being a PITA to work with... can't call fns like drop_na() or easily filter out missing elements of the list-column.

Also, from replace_na():

# Replace NULLs in a list: NULLs are the list-col equivalent of NAs
df_list <- tibble(z = list(1:5, NULL, 10:20))
df_list %>% replace_na(list(z = list(5)))
#> # A tibble: 3 × 1
#>   z         
#>   <list>    
#> 1 <int [5]> 
#> 2 <dbl [1]> 
#> 3 <int [11]>

so I think we should stick with what the equivalent is for list-columns as above.

@egouldo egouldo added feature a feature request or enhancement upkeep maintenance, infrastructure, and similar labels Sep 1, 2024
@egouldo egouldo added this to the Software Manuscript Submit milestone Sep 1, 2024
@egouldo egouldo self-assigned this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

1 participant