Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support looping of a video without timestamps #6

Open
pinballpower opened this issue Jun 2, 2022 · 1 comment
Open

Support looping of a video without timestamps #6

pinballpower opened this issue Jun 2, 2022 · 1 comment

Comments

@pinballpower
Copy link
Contributor

The "repeat" parameter in the "play" definition is only working if "t" and "v" are defined. It would be good to have this working without timestamps - just loop the whole video.
Otherwise the requesting program first needs to parse the file to detect its length.

@egnor
Copy link
Owner

egnor commented Jun 3, 2022

I can certainly see how that would be handy. For what it's worth, you can use the /media/... URL to get metadata about the file, including the length; you don't have to literally parse it yourself. (https://github.com/egnor/pivid/blob/main/doc/protocol.md#get-mediafile---fetch-media-file-metadata)

In the general case one might want to do various things based on the media length, but it might be worth adding some direct support for the simple common cases that don't require the app making a separate request to load media metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants