Adding typescript definitions

[s0rthak]

Hi again!

I was wondering if it's possible to add a typescript definition file in the project.
I'm using this package on a project and have written typings for some of the functions.

Would be happy to complete them if it's possible to add them to this project (an extra index.d.ts file I think) or could even contribute them to @DefinitelyTyped

[jakesjews]

That sounds good to me. I'll definitely merge a PR for it.

[simultsop]

Hey there, cool to see type definition.

However im running into this case
https://stackoverflow.com/questions/53186841/exports-and-export-assignements-are-not-permitted-in-module-augmentations

Feels like you may need to export types from index.js, am new to ts to, idk the proper way. So our pipeline halts on 49,3 (last line) index.d.ts TS2666.

[simultsop]

Hey there, cool to see type definition.

However im running into this case https://stackoverflow.com/questions/53186841/exports-and-export-assignements-are-not-permitted-in-module-augmentations

Feels like you may need to export types from index.js, am new to ts to, idk the proper way. So our pipeline halts on 49,3 (last line) index.d.ts TS2666.

So the worst way to keep pipelines running was adding skipLibCheck to compileroptions in tsconfig.

Locally as workaround, I went to your index.d.ts and removed declare module samba client, with its pairing brackets.

And by googling did a TopLevelDeclaration by adding declare keyword near class SambaClient. Locally got no error on the tsc build.

[jakesjews]

to be honest I don't really use typescript so I dont know much about it but I'll definitely accept a PR for it

[drubetti]

Hi @jakesjews, I've opened a pull request that should fix error TS2666 here: #48.