Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update style imports #32

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix: update style imports #32

merged 1 commit into from
Jul 17, 2024

Conversation

alangsto
Copy link
Member

COSMO-388

This frontend is not picking up on brand styles in the staging or production environments. This PR updates how the style sheets are imported to better match other MFE's that do properly pick up brand styles (see https://github.com/openedx/frontend-app-learning/blob/bf2f123367047def9928aff3dccb1d087cf12e31/src/index.scss#L1-L4).

@alangsto alangsto force-pushed the alangsto/update_style_imports branch from fbe4793 to f0cb112 Compare July 17, 2024 12:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (bf86ca3) to head (f0cb112).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   77.11%   77.53%   +0.41%     
==========================================
  Files          22       22              
  Lines         319      316       -3     
  Branches       38       38              
==========================================
- Hits          246      245       -1     
+ Misses         70       68       -2     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alangsto alangsto merged commit aff56a8 into main Jul 17, 2024
5 checks passed
@alangsto alangsto deleted the alangsto/update_style_imports branch July 17, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants