feat: add allowances tab #31
Conversation
|
Leaving this in draft until openedx/paragon#3138 is merged. After the paragon PR is merged, I will update the package.json file, and the test failure should go away. |
src/index.scss
Outdated
| @import "@edx/brand/paragon/variables.scss"; | ||
| @import "@openedx/paragon/scss/core/core.scss"; | ||
| @import "@edx/brand/paragon/overrides.scss"; | ||
| @import "~@edx/brand/paragon/fonts"; |
There was a problem hiding this comment.
Updated this to match other MFEs.
alangsto
force-pushed
the
alangsto/add_allowances_tab
branch
from
1d20088 to
2b90f9f
Compare
| @@ -25,19 +32,29 @@ const ExamsPage = ({ courseId }) => { | |||
| const { | |||
| attemptsList, | |||
| } = useExamAttemptsData(); | |||
| const { | |||
| allowancesList, | |||
| } = useAllowancesData(); | |||
There was a problem hiding this comment.
Nice! I like how this matches with the attemptsList above.
| </Container> | ||
| <Tabs variant="tabs" mountOnEnter defaultActiveKey="attempts"> |
There was a problem hiding this comment.
Question: is there a reason that the Tabs component no longer needs the defaultActiveKey?
There was a problem hiding this comment.
It's because I modified the tabs component from an uncontrolled usage to a controlled usage (see https://paragon-openedx.netlify.app/components/tabs/). I had to do this to expose the current key, which is used to toggle whether or not the exams selector is disabled.
| @@ -20,6 +21,7 @@ jest.mock('./hooks', () => ({ | |||
| describe('ExamsPage', () => { | |||
| beforeAll(() => { | |||
| hooks.useExamAttemptsData.mockReturnValue(testUtils.defaultAttemptsData); | |||
| hooks.useAllowancesData.mockReturnValue({ allowancesList: [] }); | |||
There was a problem hiding this comment.
Question: I took a look at the epic and it looks like actually having allowances is not in the scope of this work, right? That is, for now, we only need to test this case and not the case where there are allowances? Thanks for clarifying.
There was a problem hiding this comment.
Yes, this ticket is only for the case where there are no allowances
| href="#" | ||
| role="tab" | ||
| > | ||
| Allowances |
There was a problem hiding this comment.
Question: Is there a reason that "Allowances" isn't set as a message (for potential future internationalization, as with AllowanceList below) here? Is this just to be consistent with others (like Review Dashboard above)? Thanks for clarifying?
There was a problem hiding this comment.
Good question! I'm not entirely sure why the other tabs aren't translated, but yes, I did this to be consistent with them.
alangsto
force-pushed
the
alangsto/add_allowances_tab
branch
4 times, most recently
from
064d48c to
979eff7
Compare
alangsto
force-pushed
the
alangsto/add_allowances_tab
branch
from
979eff7 to
f9d3871
Compare
COSMO-366
This PR adds an additional tab to allow instructors to add exam allowances. As of now, this is not hooked up to the backend, so the tab always renders as though there are no allowances.