feat: add loading circles to modals #21
Conversation
- reset, reject, and verify buttons all have loading circles now - also, renamed the components to modals since that's what they are
|
Whoops I hit the close button by accident, ignore that. Also this PR does still need test fixes. |
|
Planned next steps:
|
ilee2u
force-pushed
the
ilee2u/buttons-add-loading
branch
from
7ab9d79 to
e75c81a
Compare
|
NOTE: Apparently linking the "completed" status of the request to the button's state makes the button get stuck in the "completed" state after fulfilling one request, so I'm going to remove the completed state but keep the pending one.
|
|
Added a demo of the error button to the original post, which does the same thing as the "completed" button where it stays in the modal even if you open a new one, though I suppose one would refresh the page on an error anyhow so I will keep this status |
- it didn't work
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 75.75% 76.75% +0.99%
==========================================
Files 22 22
Lines 297 314 +17
Branches 31 34 +3
==========================================
+ Hits 225 241 +16
- Misses 69 70 +1
Partials 3 3 ☔ View full report in Codecov by Sentry. |
ilee2u
force-pushed
the
ilee2u/buttons-add-loading
branch
from
190704e to
46bfb73
Compare
- also fixed some nits
| import * as testUtils from '../../../testUtils'; | ||
|
|
||
| import * as hooks from '../hooks'; | ||
|
|
||
| jest.mock('../data/api', () => { |
There was a problem hiding this comment.
we removed the lines assigning a response to this mock so I don't think this is doing anything
src/pages/ExamsPage/hooks.js
Outdated
| @@ -54,6 +54,8 @@ export const useDeleteExamAttempt = () => { | |||
| }; | |||
|
|
|||
| export const useModifyExamAttempt = () => { | |||
| // something's up with useMakeNetworkRequest here? | |||
| // ok it says line 1473... but there's only like 200 in this file | |||
Issue: https://2u-internal.atlassian.net/browse/COSMO-121
Demo:
Screen.Recording.2023-12-13.at.10.13.30.AM.mov
Error Button: