ci: add e2e test for OpenSSL #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msanft
force-pushed
the
feat/ci/e2e-openssl
branch
from
93ab112 to
2fd4a05
Compare
|
Marking this as a draft while I try to find out what the issue is. Locally, the test works. Kubectl exec also seems quite brittle in a failing case like this, as it doesn't report the output reliably. Working on a fix |
Co-authored-by: Markus Rudy <[email protected]>
burgerdev
force-pushed
the
feat/ci/e2e-openssl
branch
from
9bb94bb to
b198cc5
Compare
burgerdev
reviewed
Feb 22, 2024
Comment on lines
+31
to
+54
| - name: Log in to ghcr.io Container registry | ||
| uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Login to Azure | ||
| uses: azure/login@cb79c773a3cfa27f31f25eb3f677781210c9ce3d # v1.6.1 | ||
| with: | ||
| creds: ${{ secrets.NUNKI_CI_INFRA_AZURE }} | ||
| - uses: nicknovitski/nix-develop@a2060d116a50b36dfab02280af558e73ab52427d # v1.1.0 | ||
| - name: Generate namespace suffix | ||
| id: ns | ||
| run: | | ||
| uuid=$(cat /proc/sys/kernel/random/uuid) | ||
| uid=${uuid##*-} | ||
| echo "namespace_suffix=$uid" >> "$GITHUB_OUTPUT" | ||
| - name: Create justfile.env | ||
| run: | | ||
| cat <<EOF > justfile.env | ||
| container_registry=${{ env.container_registry }} | ||
| azure_resource_group=${{ env.azure_resource_group }} | ||
| namespace_suffix=-${{ steps.ns.outputs.namespace_suffix }} | ||
| EOF |
There was a problem hiding this comment.
The common steps should maybe go into an action someday.
| // namespace the tests are executed in. | ||
| const namespaceEnv = "K8S_NAMESPACE" |
There was a problem hiding this comment.
This should probably be part of the library.
Co-authored-by: Markus Rudy <[email protected]>
Co-authored-by: Markus Rudy <[email protected]>
burgerdev
force-pushed
the
feat/ci/e2e-openssl
branch
from
b198cc5 to
63c37ef
Compare
katexochen
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a tentative E2E test for the OpenSSL deployment. It tries to set up the Nunki cluster in the same way a user would do it, using
kubectlto deploy. The actual test's logic is then packed into a Go test, exec'ing into the pods of the deployment and running the actualopensslcommands. This does not give much value for this test, as the assertions and orchestration of the execs is very simple, but may take some of the boilerplate away for other, more complicated tests.Run of the test: https://github.com/edgelesssys/nunki/actions/runs/7875034691