-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy support for GPU containers #1160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0938fb2
to
d956036
Compare
60a66f5
to
b8b5b31
Compare
f80e7b6
to
216aba1
Compare
b8b5b31
to
e91c280
Compare
64bd82d
to
cd90bfe
Compare
e91c280
to
3bd65be
Compare
cd90bfe
to
7999e42
Compare
3bd65be
to
3592c49
Compare
7999e42
to
a57e9f8
Compare
burgerdev
reviewed
Jan 20, 2025
packages/by-name/kata/kata-runtime/0020-genpolicy-support-dynamic-annotations.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0020-genpolicy-support-dynamic-annotations.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0020-genpolicy-support-dynamic-annotations.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0020-genpolicy-support-dynamic-annotations.patch
Outdated
Show resolved
Hide resolved
a57e9f8
to
5f3e78f
Compare
a0c1f64
to
721a4c6
Compare
20c0a82
to
35a77d4
Compare
35a77d4
to
7bc61e0
Compare
c7ebadd
to
c201276
Compare
c30af05
to
b2c0181
Compare
c201276
to
4ed3505
Compare
b2c0181
to
2c1b9b6
Compare
4ed3505
to
1dc1300
Compare
2c1b9b6
to
2c1e0c0
Compare
1dc1300
to
776afff
Compare
b6e016a
to
ec02c4d
Compare
burgerdev
reviewed
Jan 23, 2025
packages/by-name/kata/kata-runtime/0020-genpolicy-support-dynamic-annotations.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0020-genpolicy-support-dynamic-annotations.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0020-genpolicy-support-dynamic-annotations.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0020-genpolicy-support-dynamic-annotations.patch
Outdated
Show resolved
Hide resolved
776afff
to
4fbe39a
Compare
4cad4fa
to
f97ca15
Compare
Base automatically changed from
msanft/gpu-e2e-test
to
msanft/gpu-runtime-class
January 23, 2025 12:13
This adds the required patches to Genpolicy to allow launching GPU containers on bare-metal Contrast.
Previously, the GPU test statically used an allow-all policy. This is now changed, as our Genpolicy supports GPU pods. Now, an ad-hoc and per-pod generated policy will be used in the test, similar to what the other tests do.
f97ca15
to
b2dd96a
Compare
burgerdev
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great now!
katexochen
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds patches to support GPU containers in genpolicy, and incorporates those into our GPU E2E test.