Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy support for GPU containers #1160

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add policy support for GPU containers #1160

merged 2 commits into from
Jan 24, 2025

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jan 16, 2025

This adds patches to support GPU containers in genpolicy, and incorporates those into our GPU E2E test.

@msanft msanft added the no changelog PRs not listed in the release notes label Jan 16, 2025
@msanft msanft added this to the v1.4.0 milestone Jan 16, 2025
@msanft msanft force-pushed the msanft/gpu-policy branch from 0938fb2 to d956036 Compare January 16, 2025 09:12
@msanft msanft force-pushed the msanft/gpu-e2e-test branch 2 times, most recently from 60a66f5 to b8b5b31 Compare January 16, 2025 09:59
@msanft msanft force-pushed the msanft/gpu-policy branch 2 times, most recently from f80e7b6 to 216aba1 Compare January 16, 2025 12:21
@msanft msanft marked this pull request as ready for review January 16, 2025 13:00
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from b8b5b31 to e91c280 Compare January 17, 2025 15:18
@msanft msanft force-pushed the msanft/gpu-policy branch 6 times, most recently from 64bd82d to cd90bfe Compare January 17, 2025 15:40
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from e91c280 to 3bd65be Compare January 17, 2025 16:38
@msanft msanft force-pushed the msanft/gpu-policy branch from cd90bfe to 7999e42 Compare January 17, 2025 16:38
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from 3bd65be to 3592c49 Compare January 20, 2025 10:03
@msanft msanft force-pushed the msanft/gpu-policy branch from 7999e42 to a57e9f8 Compare January 20, 2025 10:04
@msanft msanft force-pushed the msanft/gpu-policy branch from a57e9f8 to 5f3e78f Compare January 20, 2025 12:11
@msanft msanft force-pushed the msanft/gpu-e2e-test branch 3 times, most recently from a0c1f64 to 721a4c6 Compare January 20, 2025 12:32
@msanft msanft force-pushed the msanft/gpu-policy branch 2 times, most recently from 20c0a82 to 35a77d4 Compare January 20, 2025 12:33
@msanft msanft requested a review from burgerdev January 20, 2025 13:14
@msanft msanft force-pushed the msanft/gpu-policy branch from 35a77d4 to 7bc61e0 Compare January 20, 2025 13:17
@msanft msanft force-pushed the msanft/gpu-e2e-test branch 2 times, most recently from c7ebadd to c201276 Compare January 22, 2025 09:39
@msanft msanft force-pushed the msanft/gpu-policy branch 2 times, most recently from c30af05 to b2c0181 Compare January 22, 2025 09:40
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from c201276 to 4ed3505 Compare January 22, 2025 15:23
@msanft msanft force-pushed the msanft/gpu-policy branch from b2c0181 to 2c1b9b6 Compare January 22, 2025 15:23
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from 4ed3505 to 1dc1300 Compare January 22, 2025 15:25
@msanft msanft force-pushed the msanft/gpu-policy branch from 2c1b9b6 to 2c1e0c0 Compare January 22, 2025 15:25
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from 1dc1300 to 776afff Compare January 23, 2025 07:17
@msanft msanft force-pushed the msanft/gpu-policy branch 2 times, most recently from b6e016a to ec02c4d Compare January 23, 2025 07:18
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from 776afff to 4fbe39a Compare January 23, 2025 07:54
@msanft msanft force-pushed the msanft/gpu-policy branch 3 times, most recently from 4cad4fa to f97ca15 Compare January 23, 2025 11:30
Base automatically changed from msanft/gpu-e2e-test to msanft/gpu-runtime-class January 23, 2025 12:13
Base automatically changed from msanft/gpu-runtime-class to msanft/gpu-image January 23, 2025 12:14
Base automatically changed from msanft/gpu-image to main January 23, 2025 12:14
This adds the required patches to Genpolicy to allow launching GPU
containers on bare-metal Contrast.
Previously, the GPU test statically used an allow-all policy. This is
now changed, as our Genpolicy supports GPU pods. Now, an ad-hoc and
per-pod generated policy will be used in the test, similar to what the
other tests do.
@msanft msanft force-pushed the msanft/gpu-policy branch from f97ca15 to b2dd96a Compare January 23, 2025 13:01
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great now!

@msanft
Copy link
Contributor Author

msanft commented Jan 24, 2025

GPU E2E Test

@msanft msanft merged commit 9e99c25 into main Jan 24, 2025
16 of 17 checks passed
@msanft msanft deleted the msanft/gpu-policy branch January 24, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants