Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HARK dependency to 0.12.0 #6

Closed
sbenthall opened this issue Jan 13, 2023 · 3 comments
Closed

Update HARK dependency to 0.12.0 #6

sbenthall opened this issue Jan 13, 2023 · 3 comments
Assignees

Comments

@sbenthall
Copy link

Update HARK dependency to latest stable release. Currently, 0.12.0

@sbenthall sbenthall self-assigned this Jan 13, 2023
@alanlujan91
Copy link
Member

It is now working with master branch which will be released soon, so presumably it's working with 0.13 already in PR #4

@sbenthall
Copy link
Author

Ok. Do the results on the master branch meet the substantive result requirement as described in #7 ?

What I was going to do is:

  1. Make the automated test for the substantive results An automated test that makes sure the results match the paper #7
  2. Use it to test the results using HARK 0.12.0. If passing, upgrade.
  3. Use the test to check 0.13.0 with your PR. If passing, upgrade by merging the PR.

But if the substantive results are all still good with master, then this may be more procedural than necessary.

@alanlujan91 alanlujan91 self-assigned this Jan 20, 2023
@sbenthall
Copy link
Author

I tested the results with HARK 0.12.0 with the test script manually.
Then I pushed the update to the requirements file.
I've cut a release, 1.0, for this version of the REMARK.

https://github.com/econ-ark/DistributionOfWealthMPC/releases/tag/1.0

I will now change the master branch so that it uses an unpinned version of HARK. This makes master into a 'development branch', which is not guaranteed to work.

External deployments of the REMARK, such as to hosted mybinder instances, should use the tagged version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants