Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved message buffer handling for remote fdb #58

Open
Ozaq opened this issue Dec 10, 2024 · 0 comments
Open

Improved message buffer handling for remote fdb #58

Ozaq opened this issue Dec 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Ozaq
Copy link
Contributor

Ozaq commented Dec 10, 2024

Context

This is a followup task based on the code review of remote FDB.

When sending and receiving serialized mars request we allocate a 1MB fixed size buffer. For most requests this buffer is too large but still there might be the odd request that will get rejected because the buffer is too small.

Task

We assume that the MarsRequest class contains all information required to at least provide a lower bound for the memory required to serialize a request. The MarsRequest should be extended to compute this value. The code doing the serialization should then use this information to create a buffer of the appropriate size.

@Ozaq Ozaq added the enhancement New feature or request label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants