Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename valid_time variable name #129

Open
veenstrajelmer opened this issue Oct 30, 2024 · 1 comment
Open

Rename valid_time variable name #129

veenstrajelmer opened this issue Oct 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@veenstrajelmer
Copy link

Is your feature request related to a problem? Please describe.

The time variable is called time for most netcdf datasets around. Since the update to the "new CDS", the data retrieved from CDS instead has a time variable called valid_time. This is inconvenient in our processes, so we rename it. I understand it is only a minor edit we have to do, but I was wondering if it could be considered to rename it back to time anyway.

Describe the solution you'd like

Rename the time variable to time instead of valid_time

Describe alternatives you've considered

Our current workaround, renaming the variable ourselves.

Additional context

No response

Organisation

Deltares

@veenstrajelmer veenstrajelmer added the enhancement New feature or request label Oct 30, 2024
@jreniel
Copy link

jreniel commented Nov 5, 2024

Yes, this is one of the things that broke my workflow as well, and it is quite inconvenient to do this kind of compat breaking changes in the upstream. It's an unfortunate and hard to justify change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants