Realize buttons in property table using GEF instead of SWT #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
force-pushed
the
cleanup-property-buttons
branch
from
703b715 to
518285f
Compare
With this, the buttons used to open the property editors are now created using GEF, rather than SWT. The problem with SWT is that those buttons are not handled by the GEF layout manager and thus need to be explicitly created, moved and disposed whenever the property table is changed.
|
In order: SWT, GEF, MacOS
|
ptziegler
force-pushed
the
cleanup-property-buttons
branch
from
518285f to
1ef0d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the buttons used to open the property editors are now created using GEF, rather than SWT.
The problem with SWT is that those buttons are not handled by the GEF layout manager and thus need to be explicitly created, moved and disposed whenever the property table is changed.