Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The combination of resource ID of source and sink #166

Closed
evshary opened this issue Jul 23, 2024 · 2 comments · Fixed by #167
Closed

The combination of resource ID of source and sink #166

evshary opened this issue Jul 23, 2024 · 2 comments · Fixed by #167
Labels
bug Something isn't working

Comments

@evshary
Copy link
Contributor

evshary commented Jul 23, 2024

When I'm using the L2 API, I found that InMemoryRpcServer call register_listener with source UUri UUri::any(), which means //*/FFFF/FF/FFFF.

origin_filter.unwrap_or(&UUri::any()),

I created a table here before to list all the combinations of resource ID for register_listener.
image
The reason I removed source resource_id=FFFF & sink resource_id=[1-7FFF] is that the source resource_id should always be 0 here. However, I agree that in the L2 API case, it might be annoying for users to use //*/FFFF/FF/0 as the source Uri.

Furthermore, if we decided to add back the combination of {FFFF, 1-7FFF}, then it will come across the question I met before. Should we also add back the other cases?

@sophokles73 WDYT?

@sophokles73
Copy link
Contributor

I agree that in line 232 we should use //*/FFFF/FF/0 as the origin filter if not specified explicitly by the user.

@sophokles73
Copy link
Contributor

Would you like to create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants