From 969aac6a676bf2d3f03950b2a2f5fea9ec3c0e41 Mon Sep 17 00:00:00 2001 From: Heiko Klare Date: Thu, 4 Jul 2024 17:53:23 +0200 Subject: [PATCH] Remove sorting parameter from ConfigurationSessionTestSuite #903 The ConfigurationSessionTestSuite sorts the test methods by default. A field identifies whether sorting is activated, but the field cannot even be set but is always true. So, this parameterization is completely obsolete and only introduces unnecessary complexity to the session test framework. Contributes to https://github.com/eclipse-platform/eclipse.platform/issues/903 --- .../core/tests/session/ConfigurationSessionTestSuite.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/runtime/tests/org.eclipse.core.tests.harness/src/org/eclipse/core/tests/session/ConfigurationSessionTestSuite.java b/runtime/tests/org.eclipse.core.tests.harness/src/org/eclipse/core/tests/session/ConfigurationSessionTestSuite.java index 49cf6b044e3..1ff2af3790d 100644 --- a/runtime/tests/org.eclipse.core.tests.harness/src/org/eclipse/core/tests/session/ConfigurationSessionTestSuite.java +++ b/runtime/tests/org.eclipse.core.tests.harness/src/org/eclipse/core/tests/session/ConfigurationSessionTestSuite.java @@ -62,12 +62,9 @@ public class ConfigurationSessionTestSuite extends SessionTestSuite { private IPath configurationPath = FileSystemHelper.getRandomLocation(FileSystemHelper.getTempDir()); private boolean prime = true; private boolean readOnly; - // should the test cases be run in alphabetical order? - private boolean shouldSort; public ConfigurationSessionTestSuite(String pluginId, Class theClass) { super(pluginId, theClass); - this.shouldSort = true; } public ConfigurationSessionTestSuite(String pluginId, String name) { @@ -269,11 +266,6 @@ public void run(TestResult result) { fail(e); } } - if (!shouldSort) { - // for shared sessions, we don't control the execution of test cases - super.run(result); - return; - } // we have to sort the tests cases Test[] allTests = getTests(true); // now run the tests in order