Remove org.eclipse.ecf.ssl fragment from the Eclipse IDE

[scottslewis]

As per the investigation described in comments on this issue:

eclipse/ecf#140

the org.eclipse.ecf.ssl fragment should be removed from the Eclipse IDE.

[merks]

You mention just the fragment org.eclipse.ecf.ssl but there's there's also the org.eclipse.ecf.core.ssl.feature which includes that fragment so presumably that must go too, right? With the only plugin that it includes removed it would be pointless That feature in turn is included by org.eclipse.ecf.filetransfer.ssl.feature so presumably with the previous bundle and feature removed, the org.eclipse.ecf.filetransfer.ssl.feature would include only the single fragment org.eclipse.ecf.provider.filetransfer.ssl. Is that being removed as well? That bundle has just a single class org.eclipse.ecf.internal.provider.filetransfer.ssl.ECFURLConnectionModifier. In my test environment I tried running without the class ECFURLConnectionModifier and that worked fine. Even when I tried running with that class present, ECFURLConnectionModifier.setSocketFactoryForConnection(URLConnection) was never called.

Given that the only ECF-specific subclass of javax.net.ssl.SSLSocketFactory that I see is org.eclipse.ecf.internal.ssl.ECFSSLSocketFactory the ECFURLConnectionModifier class is maybe worse than useless.

A connection modifier appears to be used only from URLFileSystemBrowser.runRequest() but that class is used only when there is no more specific provider present for the protocol. For http and https different implementation classes are used without using the modifier.

And then the support only works for httpsURLConnection for which we are not even using the URLFileSystemBrowser

All that would explain why it's just never used.

So I assume it is safe to assume that we should be removing references to all of the following:

• org.eclipse.ecf.ssl
• org.eclipse.ecf.provider.filetransfer.ssl
• org.eclipse.ecf.core.ssl.feature
• org.eclipse.ecf.filetransfer.ssl.feature

[scottslewis]

Even when I tried running with that class present, ECFURLConnectionModifier.setSocketFactoryForConnection(URLConnection) was never called.

The explanation for this is the URLConnectionModifier was used with old providers (prior to the ones that are used/tested now), and the maintenance to remove these classes was never done by the provider authors (nor me).

Given that the only ECF-specific subclass of javax.net.ssl.SSLSocketFactory that I see is org.eclipse.ecf.internal.ssl.ECFSSLSocketFactory the ECFURLConnectionModifier class is maybe worse than useless.

Yeah...now it is.

All that would explain why it's just never used.

...now. It was used 5+ years ago...and I believe there is unused code that references it in both httpclient5 and jreproviders...as the classes were (mostly) copied from previously provider impls based upon httpclient4.5,4,3.

So I assume it is safe to assume that we should be removing references to all of the following:

* org.eclipse.ecf.ssl

* org.eclipse.ecf.provider.filetransfer.ssl

* org.eclipse.ecf.core.ssl.feature

* org.eclipse.ecf.filetransfer.ssl.feature

That would be my assumption too. I've done no testing on that, however.