Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoo of logging frameworks #76

Open
eparovyshnaya opened this issue Dec 9, 2019 · 2 comments
Open

Zoo of logging frameworks #76

eparovyshnaya opened this issue Dec 9, 2019 · 2 comments
Labels
issue::discussion Deprecated. Let's use discussions instead. Not intended to boil down to sourcebase change directly.

Comments

@eparovyshnaya
Copy link
Contributor

eparovyshnaya commented Dec 9, 2019

During the work on 553877 spend some time investigating logging frameworks used in Eclipse Passage. Results are interesting and worth to be discussed.

We use

  • JUL directly,
  • OSGi logging in some equinox-based bundles,
  • SLF4J in a sporadic way,
  • Jetty logging for JettyServer

How we do this

  1. JUL directly
    • all the *Messages.java
    • org.eclipse.passage.lbc.internal.equinox.conditions.ServerConditionArbiter
    • org.eclipse.passage.lic.internal.equinox.requirements.BundleCapabilityResolver
    • org.eclipse.passage.lic.internal.hc.HcConditionMiner
    • org.eclipse.passage.loc.internal.licenses.core.LicenseMailSupport
    • org.eclipse.passage.loc.workbench.dialogs
  2. OSGi logging
    • org.eclipse.passage.lbc.internal.equinox.ServerRunnerImpl
    • org.eclipse.passage.lic.internal.equinox.requirements.ComponentConfigurationResolver
  3. SLF4J
    • org.eclipse.passage.lbc.internal.equinox.conditions.AcquireConditionActionExecutor
    • org.eclipse.passage.lic.hc.HttpRequests
    • org.eclipse.passage.loc.internal.workbench.LocDomainRegistryAccess

Findings

  1. One physical package exploits several logging frameworks
  2. Each particular framework does not seem to have a peculiar reason to be used here or there.

Question

Should we put things here in some order?

Suggestion

I think, that, for understandable causes (like, say, logging configuration),
there should be

  • either a static choice (like, JUL)
  • or some reasonable strategy for choosing a framework.
    Like:
    • OSGi logging for OSGi/Equinox dependent packages
    • SLF4J+JUL for the rest of the bundles

What do you think, colleagues?

@eparovyshnaya eparovyshnaya added the issue::discussion Deprecated. Let's use discussions instead. Not intended to boil down to sourcebase change directly. label Dec 9, 2019
@eparovyshnaya eparovyshnaya pinned this issue Jun 18, 2020
@eparovyshnaya
Copy link
Contributor Author

572145 Jetty integration logs through log4j2

@eparovyshnaya
Copy link
Contributor Author

eparovyshnaya commented Mar 21, 2021

  1. JUL
    • *Messages
    • org.eclipse.passage.loc.workbench.dialogs
  2. OSGi logging eliminated
  3. SLF4J eliminted
  4. Jetty-logging eliminated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue::discussion Deprecated. Let's use discussions instead. Not intended to boil down to sourcebase change directly.
Projects
None yet
Development

No branches or pull requests

1 participant