Retry failed profiled very-hot compilations at hot instead of warm #21053
+31
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, a profiled-very-hot compilation that fails due to excessiveComplexity would not be retried, relying on the existing compiled body. If the existing compiled body is at warm (or even cold) opt level, then the performance could be suboptimal. With this commit profiled-very-hot compilations that fail will be retried at the hot optimization level, but without any profiling. We avoid profiling compilations because they are more complex than non-profiled ones and the likelihood of a failure for a profiled-hot compilation is relatively high when we know that a profiled-very-hot compilation for the same method already failed. Signed-off-by: Marius Pirvu <[email protected]>
|
jenkins test sanity all jdk8 |
vijaysun-omr
approved these changes
Feb 3, 2025
|
I would appreciate a quick look from @dsouzai too |
|
jenkins test sanity xmac jdk8 |
|
I restarted the xmac build since it failed due to not finding a machine to run. |
|
All checks have passed. This PR is ready to be merged. |
|
I ran this change against a testcase that demonstrated the problem and confirmed that it restored the expected performance. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, a profiled-very-hot compilation that fails due to excessiveComplexity would not be retried, relying on the existing compiled body. If the existing compiled body is at warm (or even cold) opt level, then the performance could be suboptimal.
With this commit profiled-very-hot compilations that fail will be retried at the hot optimization level, but without any profiling. We avoid profiling compilations because they are more complex than non-profiled ones and the likelihood of a failure for a profiled-hot compilation is relatively high when we know that a profiled-very-hot compilation for the same method already failed.