Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print string contents for "this" references #20933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h3110n3rv3
Copy link
Contributor

The changes reflect the feature request #20878.

Print string contents for this references.
Also, print address for string arguments and returns.

Closes: #20878
Signed-off-by: Nick Kamal <[email protected]>

@h3110n3rv3
Copy link
Contributor Author

@TobiAjila Could you please take a look?
Does this need to be done for compiled and native methods as well?

@h3110n3rv3 h3110n3rv3 force-pushed the print-string-improvements branch 2 times, most recently from 34fd8b7 to ca5dd4d Compare January 17, 2025 19:25
@h3110n3rv3 h3110n3rv3 changed the title WIP: Print string contents for "this" references Print string contents for "this" references Jan 17, 2025
runtime/rastrace/mt.tdf Outdated Show resolved Hide resolved
@tajila
Copy link
Contributor

tajila commented Jan 21, 2025

@keithc-ca Please review these changes

runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved
runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved
runtime/rastrace/mt.tdf Outdated Show resolved Hide resolved
@h3110n3rv3 h3110n3rv3 requested a review from dsouzai as a code owner January 23, 2025 23:24
@h3110n3rv3 h3110n3rv3 force-pushed the print-string-improvements branch 5 times, most recently from 26dfab8 to ff2e56f Compare January 24, 2025 00:42
@h3110n3rv3 h3110n3rv3 requested a review from keithc-ca January 24, 2025 00:46
runtime/rastrace/mt.tdf Outdated Show resolved Hide resolved
runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved
runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved
runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved
@h3110n3rv3 h3110n3rv3 force-pushed the print-string-improvements branch 2 times, most recently from 7c853ff to a1819ed Compare January 27, 2025 12:44
@h3110n3rv3 h3110n3rv3 requested a review from keithc-ca January 27, 2025 12:45
@keithc-ca
Copy link
Contributor

Please resolve the merge conflict.

@h3110n3rv3 h3110n3rv3 force-pushed the print-string-improvements branch 2 times, most recently from a2e8718 to 6874c43 Compare February 3, 2025 16:48
@h3110n3rv3 h3110n3rv3 requested a review from keithc-ca February 3, 2025 16:52
runtime/rastrace/mt.tdf Outdated Show resolved Hide resolved
runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved
runtime/rastrace/method_trace.c Outdated Show resolved Hide resolved
@h3110n3rv3 h3110n3rv3 force-pushed the print-string-improvements branch 2 times, most recently from 1ba6399 to c8eb717 Compare February 4, 2025 15:33
The changes reflect the feature request eclipse-openj9#20878.

Print string contents for this references.
Also, print address for string arguments and returns.

Closes: eclipse-openj9#20878
Signed-off-by: Nick Kamal <[email protected]>
@h3110n3rv3 h3110n3rv3 force-pushed the print-string-improvements branch from 5aa88f6 to 05c5572 Compare February 4, 2025 15:40
@h3110n3rv3 h3110n3rv3 requested a review from keithc-ca February 4, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements for Xtrace String printing feature
3 participants