-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print string contents for "this" references #20933
Open
h3110n3rv3
wants to merge
1
commit into
eclipse-openj9:master
Choose a base branch
from
h3110n3rv3:print-string-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Print string contents for "this" references #20933
h3110n3rv3
wants to merge
1
commit into
eclipse-openj9:master
from
h3110n3rv3:print-string-improvements
+43
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@TobiAjila Could you please take a look? |
h3110n3rv3
commented
Jan 14, 2025
tajila
reviewed
Jan 16, 2025
34fd8b7
to
ca5dd4d
Compare
tajila
reviewed
Jan 21, 2025
@keithc-ca Please review these changes |
keithc-ca
requested changes
Jan 21, 2025
26dfab8
to
ff2e56f
Compare
keithc-ca
requested changes
Jan 24, 2025
7c853ff
to
a1819ed
Compare
keithc-ca
reviewed
Jan 31, 2025
Please resolve the merge conflict. |
a2e8718
to
6874c43
Compare
keithc-ca
requested changes
Feb 3, 2025
1ba6399
to
c8eb717
Compare
The changes reflect the feature request eclipse-openj9#20878. Print string contents for this references. Also, print address for string arguments and returns. Closes: eclipse-openj9#20878 Signed-off-by: Nick Kamal <[email protected]>
5aa88f6
to
05c5572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes reflect the feature request #20878.
Print string contents for
this
references.Also, print address for string arguments and returns.
Closes: #20878
Signed-off-by: Nick Kamal <[email protected]>