WIP:RamClass: Segment allocation enhancements #20896
Open
+425
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
reviewed
Jan 9, 2025
h3110n3rv3
changed the title
h3110n3rv3
force-pushed
the
ramclass-changes
branch
2 times, most recently
from
8be826c to
de5ff00
Compare
h3110n3rv3
force-pushed
the
ramclass-changes
branch
from
161d945 to
7fc2a01
Compare
tajila
reviewed
Jan 22, 2025
tajila
reviewed
Jan 22, 2025
runtime/vm/createramclass.cpp
Outdated
| @@ -2997,17 +3017,18 @@ internalCreateRAMClassFromROMClassImpl(J9VMThread *vmThread, J9ClassLoader *clas | |||
| allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].alignment = OMR_MAX(sizeof(J9Class *), sizeof(UDATA)); | |||
| allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].alignedSize = flattenedClassCacheAllocSize; | |||
| allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].address = NULL; | |||
| allocationRequests[RAM_CLASS_FLATTENED_CLASS_CACHE].segmentKind = SUB4G; | |||
h3110n3rv3
force-pushed
the
ramclass-changes
branch
2 times, most recently
from
9b66ef1 to
2ed701c
Compare
The changes reflect the feature request eclipse-openj9#20644. Adding segment categories for RAMClass fragments: sub4G Frequently accessed Infrequently accessed Closes: eclipse-openj9#20644 Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
force-pushed
the
ramclass-changes
branch
from
2ed701c to
2f1befc
Compare
h3110n3rv3
commented
Jan 30, 2025
| @@ -2925,67 +2934,78 @@ internalCreateRAMClassFromROMClassImpl(J9VMThread *vmThread, J9ClassLoader *clas | |||
| } | |||
| allocationRequests[RAM_SUPERCLASSES_FRAGMENT].alignedSize = OMR_MAX(superclassSizeBytes, minimumSuperclassArraySizeBytes); | |||
| allocationRequests[RAM_SUPERCLASSES_FRAGMENT].address = NULL; | |||
| allocationRequests[RAM_SUPERCLASSES_FRAGMENT].segmentKind = SUB4G; | |||
There was a problem hiding this comment.
if I don't put the shared class fragments in sub4g then these extended.openjdk tests fail: SharedClasses.SCM01.MultiThread_1,SharedClasses.SCM23.MultiThread_1
h3110n3rv3
commented
Jan 30, 2025
|
|
||
| /* Add sizeof(UDATA) to hold the "lastAllocatedClass" pointer */ | ||
| newSegmentSize += sizeof(UDATA); | ||
| if(!isNotLoadedByAnonClassLoader) |
There was a problem hiding this comment.
i have been trying to figure out how to deal with anonymous class fragments but I am stuck.
There is comment in cleanUpSegmentsInAnonymousClassLoader function that /* Anonymous classes expected to be allocated one per segment */. That function causes segfault without this code for one of the sanity.perf tests
|
all jenkins tests passing for the current shelve |
|
@gacholio Please take a look |
|
Has there been any testing or performance analysis on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes reflect the feature request #20644.
Adding segment categories for RAMClass fragments:
sub4G
Frequently accessed
Infrequently accessed
Closes: #20644
Signed-off-by: Nick Kamal <[email protected]>