Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DAA related implementations down to OpenJ9 #20893

Merged

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Jan 8, 2025

Move DAA related implementations from OMR TR_ResolvedMethod to OpenJ9 TR_ResolvedJ9Method.

Closes: eclipse-omr/omr#2037

@a7ehuo a7ehuo requested a review from dsouzai as a code owner January 8, 2025 21:02
@a7ehuo a7ehuo added depends:omr Pull request is dependent on a corresponding change in OMR comp:jit tech debt labels Jan 8, 2025
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Jan 8, 2025

@0xdaryl May I ask you to review this change? Thank you! This change depends on eclipse-omr/omr#7603. Two PRs should be reviewed together.

@a7ehuo a7ehuo requested review from 0xdaryl and removed request for dsouzai January 8, 2025 21:06
@0xdaryl 0xdaryl self-assigned this Jan 13, 2025
Move DAA related implementations from OMR TR_ResolvedMethod
to OpenJ9 TR_ResolvedJ9Method.

Closes: eclipse-omr/omr#2037

Signed-off-by: Annabelle Huo <[email protected]>
@a7ehuo a7ehuo force-pushed the cleanup-relocate-DAA-functions branch from 1be5c8f to 36ef30c Compare January 15, 2025 13:23
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Jan 15, 2025

Addressed review comments in 36ef30c. Ready for another review. Thank you!

@0xdaryl
Copy link
Contributor

0xdaryl commented Jan 20, 2025

Jenkins test sanity zlinux,plinux,xlinux,osx jdk21 depends eclipse-omr/omr#7603

@0xdaryl 0xdaryl merged commit f328cad into eclipse-openj9:master Jan 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit depends:omr Pull request is dependent on a corresponding change in OMR tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relocate TR_ResolvedMethod DAA functions to OpenJ9
2 participants