From fd5047059fa1fe178e3754a057f9bc889a8c8466 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 02:42:10 -0300 Subject: [PATCH 001/191] refactor: remove redundant methods in records Signed-off-by: Maximillian Arruda --- .../mapping/metadata/InheritanceMetadata.java | 45 +++---------------- 1 file changed, 7 insertions(+), 38 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/main/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadata.java b/jnosql-mapping/jnosql-mapping-api-core/src/main/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadata.java index 8d8ef75bf..f627db437 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/main/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadata.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/main/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadata.java @@ -18,48 +18,17 @@ /** * The mapping information about {@link org.eclipse.jnosql.mapping.Inheritance} + * + * @param discriminatorValue the information from the annotation {@link org.eclipse.jnosql.mapping.DiscriminatorValue} + * from entity or the {@link Class#getSimpleName()} of the entity + * @param discriminatorColumn the information parent from the annotation {@link org.eclipse.jnosql.mapping.DiscriminatorColumn} + * * or the "type" + * @param parent the parent class + * @param entity the entity class */ public record InheritanceMetadata(String discriminatorValue, String discriminatorColumn, Class parent, Class entity) { - /** - * Return the information from the class the annotation {@link org.eclipse.jnosql.mapping.DiscriminatorValue} - * or the {@link Class#getSimpleName()}. - * - * @return the {@link org.eclipse.jnosql.mapping.DiscriminatorValue} from entity - */ - @Override - public String discriminatorValue() { - return discriminatorValue; - } - - /** - * Return the information parent from the annotation {@link org.eclipse.jnosql.mapping.DiscriminatorColumn} - * or the "type". - * - * @return the {@link org.eclipse.jnosql.mapping.DiscriminatorValue} from entity - */ - @Override - public String discriminatorColumn() { - return discriminatorColumn; - } - - /** - * @return The parent class - */ - @Override - public Class parent() { - return parent; - } - - /** - * @return the entity class - */ - @Override - public Class entity() { - return entity; - } - /** * Checks if the parent is equals to the parameter * From eb5e0dbf24b79e353fa37c3c6cc95e233915c419 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 02:53:27 -0300 Subject: [PATCH 002/191] test: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/metadata/InheritanceMetadataTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadataTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadataTest.java index bfe006ce3..2300f6fc5 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadataTest.java @@ -19,10 +19,10 @@ import static org.junit.jupiter.api.Assertions.*; -public class InheritanceMetadataTest { +class InheritanceMetadataTest { @Test - public void shouldConstructorAndGetters() { + void shouldConstructorAndGetters() { String discriminatorValue = "testValue"; String discriminatorColumn = "testColumn"; Class parentClass = Object.class; @@ -37,7 +37,7 @@ public void shouldConstructorAndGetters() { } @Test - public void shouldEqualsAndHashCode() { + void shouldEqualsAndHashCode() { InheritanceMetadata metadata1 = new InheritanceMetadata("value1", "column1", String.class, Integer.class); InheritanceMetadata metadata2 = new InheritanceMetadata("value1", "column1", String.class, Integer.class); InheritanceMetadata metadata3 = new InheritanceMetadata("value2", "column1", String.class, Integer.class); @@ -60,7 +60,7 @@ public void shouldEqualsAndHashCode() { } @Test - public void shouldIsParent() { + void shouldIsParent() { Class parentClass = String.class; InheritanceMetadata metadata = new InheritanceMetadata("value", "column", parentClass, Integer.class); @@ -69,13 +69,13 @@ public void shouldIsParent() { } @Test - public void shouldIsParentWithNull() { + void shouldIsParentWithNull() { InheritanceMetadata metadata = new InheritanceMetadata("value", "column", String.class, Integer.class); assertThrows(NullPointerException.class, () -> metadata.isParent(null)); } @Test - public void shouldToString() { + void shouldToString() { InheritanceMetadata metadata = new InheritanceMetadata("testValue", "testColumn", String.class, Integer.class); String expected = "InheritanceMetadata{discriminatorValue='testValue', discriminatorColumn='testColumn', parent=class java.lang.String}"; assertEquals(expected, metadata.toString()); From 5bd780c5bd04899e624abc627c8f621a5a7df771 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 02:56:09 -0300 Subject: [PATCH 003/191] test: using soft assertions with assertj and enhance test methods Signed-off-by: Maximillian Arruda --- .../metadata/InheritanceMetadataTest.java | 45 ++++++++++++------- 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadataTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadataTest.java index 2300f6fc5..83a3d7d1f 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/InheritanceMetadataTest.java @@ -14,8 +14,11 @@ */ package org.eclipse.jnosql.mapping.metadata; +import org.assertj.core.api.SoftAssertionsProvider; import org.junit.jupiter.api.Test; +import static org.assertj.core.api.SoftAssertions.assertSoftly; +import static org.assertj.core.api.SoftAssertionsProvider.assertSoftly; import static org.junit.jupiter.api.Assertions.*; @@ -30,10 +33,12 @@ void shouldConstructorAndGetters() { InheritanceMetadata metadata = new InheritanceMetadata(discriminatorValue, discriminatorColumn, parentClass, entityClass); - assertEquals(discriminatorValue, metadata.discriminatorValue()); - assertEquals(discriminatorColumn, metadata.discriminatorColumn()); - assertEquals(parentClass, metadata.parent()); - assertEquals(entityClass, metadata.entity()); + assertSoftly(softly -> { + softly.assertThat(metadata.discriminatorValue()).as("unexpected discriminatorValue value").isEqualTo(discriminatorValue); + softly.assertThat(metadata.discriminatorColumn()).as("unexpected discriminatorColumn value").isEqualTo(discriminatorColumn); + softly.assertThat(metadata.parent()).as("unexpected parent value").isEqualTo(parentClass); + softly.assertThat(metadata.entity()).as("unexpected entity value").isEqualTo(entityClass); + }); } @Test @@ -45,18 +50,23 @@ void shouldEqualsAndHashCode() { InheritanceMetadata metadata5 = new InheritanceMetadata("value1", "column1", Integer.class, Integer.class); InheritanceMetadata metadata6 = new InheritanceMetadata("value1", "column1", String.class, String.class); - // Reflexive - assertEquals(metadata1, metadata1); - // Symmetric - assertEquals(metadata1, metadata2); - assertEquals(metadata2, metadata1); - assertEquals(metadata1, metadata2); + assertSoftly(softly -> { + softly.assertThat(metadata1).as("it should be reflexive").isEqualTo(metadata1); - assertNotEquals(metadata1, metadata4); - assertNotEquals(metadata1, metadata5); + softly.assertThat(metadata1).as("it should be symmetric").isEqualTo(metadata2); + softly.assertThat(metadata2).as("it should be symmetric").isEqualTo(metadata1); + softly.assertThat(metadata1).as("it should be symmetric").isEqualTo(metadata6); + softly.assertThat(metadata6).as("it should be symmetric").isEqualTo(metadata1); - assertNotEquals(metadata1, null); - assertEquals(metadata1.hashCode(), metadata2.hashCode()); + softly.assertThat(metadata1).isNotEqualTo(metadata3); + softly.assertThat(metadata1).isNotEqualTo(metadata4); + softly.assertThat(metadata1).isNotEqualTo(metadata5); + + softly.assertThat(metadata1).isNotEqualTo(null); + softly.assertThat(metadata1).isNotEqualTo(new Object()); + + softly.assertThat(metadata1).hasSameHashCodeAs(metadata2); + }); } @Test @@ -64,8 +74,11 @@ void shouldIsParent() { Class parentClass = String.class; InheritanceMetadata metadata = new InheritanceMetadata("value", "column", parentClass, Integer.class); - assertTrue(metadata.isParent(parentClass)); - assertFalse(metadata.isParent(Integer.class)); + assertSoftly(softly -> { + softly.assertThat(metadata.isParent(parentClass)).isTrue(); + softly.assertThat(metadata.isParent(Integer.class)).isFalse(); + }); + } @Test From d6d696637431941b2740f80f5086c4e13922f4ec Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:17:49 -0300 Subject: [PATCH 004/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/spi/AbstractBeanTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/spi/AbstractBeanTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/spi/AbstractBeanTest.java index 56bba0279..372d5952f 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/spi/AbstractBeanTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/spi/AbstractBeanTest.java @@ -31,7 +31,7 @@ class AbstractBeanTest { @Test - public void shouldGetInjectionPoints() { + void shouldGetInjectionPoints() { // Create the AbstractBean instance AbstractBean abstractBean = getInstance(); @@ -43,7 +43,7 @@ public void shouldGetInjectionPoints() { } @Test - public void shouldReturnScope() { + void shouldReturnScope() { // Create the AbstractBean instance AbstractBean abstractBean = getInstance(); @@ -55,7 +55,7 @@ public void shouldReturnScope() { } @Test - public void shouldReturnNameAsNull() { + void shouldReturnNameAsNull() { // Create the AbstractBean instance AbstractBean abstractBean = getInstance(); @@ -67,7 +67,7 @@ public void shouldReturnNameAsNull() { } @Test - public void shouldReturnEmptyStereotypes() { + void shouldReturnEmptyStereotypes() { // Create the AbstractBean instance AbstractBean abstractBean = getInstance(); @@ -79,7 +79,7 @@ public void shouldReturnEmptyStereotypes() { } @Test - public void shouldReturnIsAlternativeAsFalse() { + void shouldReturnIsAlternativeAsFalse() { // Create the AbstractBean instance AbstractBean abstractBean = getInstance(); From 5532d9716e124ab7f42e6ceda4249a7301bf3686 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:18:04 -0300 Subject: [PATCH 005/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/util/AnnotationLiteralUtilTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/AnnotationLiteralUtilTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/AnnotationLiteralUtilTest.java index b4fe3fa41..811b55bc1 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/AnnotationLiteralUtilTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/AnnotationLiteralUtilTest.java @@ -26,20 +26,20 @@ class AnnotationLiteralUtilTest { @Test - public void shouldDefaultAnnotationLiteral() { + void shouldDefaultAnnotationLiteral() { AnnotationLiteral defaultAnnotation = AnnotationLiteralUtil.DEFAULT_ANNOTATION; assertEquals(Default.class, defaultAnnotation.annotationType()); } @Test - public void shouldAnyAnnotationLiteral() { + void shouldAnyAnnotationLiteral() { AnnotationLiteral anyAnnotation = AnnotationLiteralUtil.ANY_ANNOTATION; assertEquals(Any.class, anyAnnotation.annotationType()); } @Test - public void shouldCustomAnnotationLiteral() { + void shouldCustomAnnotationLiteral() { AnnotationLiteral namedLiteral = NamedLiteral.of("test"); assertEquals(Named.class, namedLiteral.annotationType()); From 4bcda0f45757bd1a9107d460662b47679ad42dd1 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:18:21 -0300 Subject: [PATCH 006/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/graph/BookTemplateTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/BookTemplateTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/BookTemplateTest.java index ac037d594..9ab4eb03d 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/BookTemplateTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/BookTemplateTest.java @@ -40,7 +40,7 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class BookTemplateTest { +class BookTemplateTest { @Inject private BookTemplate template; @@ -49,7 +49,7 @@ public class BookTemplateTest { private Graph graph; @Test - public void shouldSaveWithTransaction() { + void shouldSaveWithTransaction() { AtomicReference status = new AtomicReference<>(); Book book = Book.builder().withName("The Book").build(); @@ -61,7 +61,7 @@ public void shouldSaveWithTransaction() { } @Test - public void shouldSaveWithRollback() { + void shouldSaveWithRollback() { AtomicReference status = new AtomicReference<>(); Book book = Book.builder().withName("The Book").build(); @@ -79,7 +79,7 @@ public void shouldSaveWithRollback() { } @Test - public void shouldUseAutomaticNormalTransaction() { + void shouldUseAutomaticNormalTransaction() { AtomicReference status = new AtomicReference<>(); Book book = Book.builder().withName("The Book").build(); From 929abfac465ad50e0403a842448a3aa971253748 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:18:33 -0300 Subject: [PATCH 007/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/query/BooleanQueryValueTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/BooleanQueryValueTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/BooleanQueryValueTest.java index aa73ac3c1..f31a7fd25 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/BooleanQueryValueTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/BooleanQueryValueTest.java @@ -21,28 +21,28 @@ class BooleanQueryValueTest { @Test - public void shouldReturnType() { + void shouldReturnType() { BooleanQueryValue value = TRUE; Assertions.assertThat(value).isNotNull().extracting(BooleanQueryValue::type) .isEqualTo(ValueType.BOOLEAN); } @Test - public void shouldGet() { + void shouldGet() { BooleanQueryValue value = TRUE; Assertions.assertThat(value).isNotNull().extracting(BooleanQueryValue::get) .isEqualTo(Boolean.TRUE); } @Test - public void shouldEquals() { + void shouldEquals() { assertEquals(TRUE, TRUE); assertNotEquals(TRUE, FALSE); assertNotEquals(TRUE, Boolean.TRUE); } @Test - public void shouldHashCode() { + void shouldHashCode() { assertEquals(TRUE.hashCode(), TRUE.hashCode()); } } \ No newline at end of file From 0171b69104307728ebe4704991676d09e9ca9005 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:18:56 -0300 Subject: [PATCH 008/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../configuration/BucketManagerSupplierTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/configuration/BucketManagerSupplierTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/configuration/BucketManagerSupplierTest.java index 90896cf58..227c70e86 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/configuration/BucketManagerSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/configuration/BucketManagerSupplierTest.java @@ -46,13 +46,13 @@ class BucketManagerSupplierTest { private BucketManagerSupplier supplier; @BeforeEach - public void beforeEach(){ + void beforeEach(){ System.clearProperty(KEY_VALUE_PROVIDER.get()); System.clearProperty(KEY_VALUE_DATABASE.get()); } @Test - public void shouldGetBucketManager() { + void shouldGetBucketManager() { System.setProperty(KEY_VALUE_PROVIDER.get(), KeyValueConfigurationMock.class.getName()); System.setProperty(KEY_VALUE_DATABASE.get(), "database"); BucketManager manager = supplier.get(); @@ -62,7 +62,7 @@ public void shouldGetBucketManager() { @Test - public void shouldUseDefaultConfigurationWhenProviderIsWrong() { + void shouldUseDefaultConfigurationWhenProviderIsWrong() { System.setProperty(KEY_VALUE_PROVIDER.get(), Integer.class.getName()); System.setProperty(KEY_VALUE_DATABASE.get(), "database"); BucketManager manager = supplier.get(); @@ -71,7 +71,7 @@ public void shouldUseDefaultConfigurationWhenProviderIsWrong() { } @Test - public void shouldUseDefaultConfiguration() { + void shouldUseDefaultConfiguration() { System.setProperty(KEY_VALUE_DATABASE.get(), "database"); BucketManager manager = supplier.get(); Assertions.assertNotNull(manager); @@ -79,12 +79,12 @@ public void shouldUseDefaultConfiguration() { } @Test - public void shouldReturnErrorWhenThereIsNotDatabase() { + void shouldReturnErrorWhenThereIsNotDatabase() { Assertions.assertThrows(MappingException.class, () -> supplier.get()); } @Test - public void shouldClose(){ + void shouldClose(){ BucketManager manager = Mockito.mock(BucketManager.class); supplier.close(manager); Mockito.verify(manager).close(); From fb64beb9d1482f9626c330e465527bdf8dd1f75e Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:19:02 -0300 Subject: [PATCH 009/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../java/org/eclipse/jnosql/mapping/ClassConverterTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/ClassConverterTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/ClassConverterTest.java index 75a6d5c12..6d202a718 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/ClassConverterTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/ClassConverterTest.java @@ -22,7 +22,7 @@ class ClassConverterTest { @Test - public void shouldCreateClassConverter() { + void shouldCreateClassConverter() { ClassConverter converter = ClassConverter.load(); assertNotNull(converter); } From 8d1210ed0d07a23a60dea22e1996c9751ef17bba Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:19:13 -0300 Subject: [PATCH 010/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/ClassGraphClassScannerTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ClassGraphClassScannerTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ClassGraphClassScannerTest.java index d9bd707c4..46a0c64b3 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ClassGraphClassScannerTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ClassGraphClassScannerTest.java @@ -35,7 +35,7 @@ class ClassGraphClassScannerTest { private ClassGraphClassScanner classScanner = ClassGraphClassScanner.INSTANCE; @Test - public void shouldReturnEntities() { + void shouldReturnEntities() { Set> entities = classScanner.entities(); Assertions.assertNotNull(entities); assertThat(entities).hasSize(26) @@ -43,7 +43,7 @@ public void shouldReturnEntities() { } @Test - public void shouldReturnEmbeddables() { + void shouldReturnEmbeddables() { Set> embeddables = classScanner.embeddables(); Assertions.assertNotNull(embeddables); assertThat(embeddables).hasSize(4) @@ -52,7 +52,7 @@ public void shouldReturnEmbeddables() { @Test - public void shouldReturnRepositories() { + void shouldReturnRepositories() { Set> reepositores = classScanner.repositories(); Assertions.assertNotNull(reepositores); @@ -63,7 +63,7 @@ public void shouldReturnRepositories() { } @Test - public void shouldFilterRepositories() { + void shouldFilterRepositories() { Set> repositories = classScanner.repositories(NoSQLVendor.class); Assertions.assertNotNull(repositories); @@ -72,7 +72,7 @@ public void shouldFilterRepositories() { } @Test - public void shouldFieldByCrudRepository() { + void shouldFieldByCrudRepository() { Set> repositories = classScanner.repositories(CrudRepository.class); Assertions.assertNotNull(repositories); @@ -81,7 +81,7 @@ public void shouldFieldByCrudRepository() { } @Test - public void shouldFieldByPageable() { + void shouldFieldByPageable() { Set> repositories = classScanner.repositories(PageableRepository.class); Assertions.assertNotNull(repositories); @@ -90,7 +90,7 @@ public void shouldFieldByPageable() { } @Test - public void shouldReturnStandardRepositories() { + void shouldReturnStandardRepositories() { Set> repositories = classScanner.repositoriesStandard(); assertThat(repositories).hasSize(2) .contains(PersonRepository.class, MovieRepository.class); From aa28e11de37600bc7fa6883f15900f6645f1e1a6 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:19:22 -0300 Subject: [PATCH 011/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/metadata/ClassInformationNotFoundExceptionTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/ClassInformationNotFoundExceptionTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/ClassInformationNotFoundExceptionTest.java index 766b599bd..926a63fa3 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/ClassInformationNotFoundExceptionTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/ClassInformationNotFoundExceptionTest.java @@ -21,7 +21,7 @@ class ClassInformationNotFoundExceptionTest { @Test - public void shouldConstructWithValidMessage() { + void shouldConstructWithValidMessage() { String errorMessage = "Class information not found."; ClassInformationNotFoundException exception = new ClassInformationNotFoundException(errorMessage); assertEquals(errorMessage, exception.getMessage()); From 326f5a056fd80a925180bb655f7f861181b3e5f8 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:19:28 -0300 Subject: [PATCH 012/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../configuration/CollectionSupplierTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/configuration/CollectionSupplierTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/configuration/CollectionSupplierTest.java index be48b8640..192cb8f4d 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/configuration/CollectionSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/configuration/CollectionSupplierTest.java @@ -73,53 +73,53 @@ class CollectionSupplierTest { @BeforeAll - public static void beforeAll(){ + static void beforeAll(){ System.clearProperty(KEY_VALUE_PROVIDER.get()); System.setProperty(KEY_VALUE_PROVIDER.get(), KeyValueConfigurationMock.class.getName()); } @AfterAll - public static void afterAll(){ + static void afterAll(){ System.clearProperty(KEY_VALUE_PROVIDER.get()); } @Test - public void shouldGetList() { + void shouldGetList() { Assertions.assertNotNull(names); assertThat(names) .isInstanceOf(ArrayList.class); } @Test - public void shouldGetMap() { + void shouldGetMap() { Assertions.assertNotNull(map); assertThat(map) .isInstanceOf(HashMap.class); } @Test - public void shouldGetQueue() { + void shouldGetQueue() { Assertions.assertNotNull(orders); assertThat(orders) .isInstanceOf(LinkedList.class); } @Test - public void shouldGetSet() { + void shouldGetSet() { Assertions.assertNotNull(fruits); assertThat(fruits) .isInstanceOf(HashSet.class); } @Test - public void shouldStructure() { + void shouldStructure() { Assertions.assertNotNull(structure); } @Test - public void shouldGetFromQualifier() { + void shouldGetFromQualifier() { CDI current = CDI.current(); TypeLiteral> literal = new TypeLiteral<>(){}; List integers = current.select(literal, KeyValueDatabaseQualifier.of("numbers")).get(); From ad4d94bdd952a224bdae78301e67708cfa691c00 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:19:40 -0300 Subject: [PATCH 013/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../ColumnEntityConverterConstructorTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterConstructorTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterConstructorTest.java index 4c693ca47..44d88ec0e 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterConstructorTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterConstructorTest.java @@ -54,7 +54,7 @@ class ColumnEntityConverterConstructorTest { private ColumnEntityConverter converter; @Test - public void shouldConverterEntityComputer() { + void shouldConverterEntityComputer() { ColumnEntity communication = ColumnEntity.of("Computer"); communication.add("_id", 10L); communication.add("name", "Dell"); @@ -71,7 +71,7 @@ public void shouldConverterEntityComputer() { } @Test - public void shouldConvertComputerToCommunication() { + void shouldConvertComputerToCommunication() { Computer computer = new Computer(10L, "Dell", 2020, "Dell 2020", Money.parse("USD 20")); ColumnEntity communication = this.converter.toColumn(computer); @@ -85,7 +85,7 @@ public void shouldConvertComputerToCommunication() { } @Test - public void shouldConvertPetOwner() { + void shouldConvertPetOwner() { ColumnEntity communication = ColumnEntity.of("PetOwner"); communication.add("_id", 10L); communication.add("name", "Otavio"); @@ -102,7 +102,7 @@ public void shouldConvertPetOwner() { } @Test - public void shouldConvertPetOwnerCommunication() { + void shouldConvertPetOwnerCommunication() { Animal ada = new Animal("Ada"); PetOwner petOwner = new PetOwner(10L, "Poliana", ada); ColumnEntity communication = this.converter.toColumn(petOwner); @@ -115,7 +115,7 @@ public void shouldConvertPetOwnerCommunication() { } @Test - public void shouldConvertBookUser() { + void shouldConvertBookUser() { ColumnEntity communication = ColumnEntity.of("BookUser"); communication.add("_id", "otaviojava"); communication.add("native_name", "Otavio Santana"); @@ -135,7 +135,7 @@ public void shouldConvertBookUser() { } @Test - public void shouldConverterFieldsOnEntityComputer() { + void shouldConverterFieldsOnEntityComputer() { ColumnEntity communication = ColumnEntity.of("Computer"); communication.add("_id", "10"); communication.add("name", "Dell"); @@ -152,7 +152,7 @@ public void shouldConverterFieldsOnEntityComputer() { } @Test - public void shouldConverterEntityBookRelease() { + void shouldConverterEntityBookRelease() { ColumnEntity communication = ColumnEntity.of("BookRelease"); communication.add("isbn", "9780132345286"); communication.add("title", "Effective Java"); @@ -167,7 +167,7 @@ public void shouldConverterEntityBookRelease() { } @Test - public void shouldConverterEntityBookReleaseOnStringYear() { + void shouldConverterEntityBookReleaseOnStringYear() { ColumnEntity communication = ColumnEntity.of("BookRelease"); communication.add("isbn", "9780132345286"); communication.add("title", "Effective Java"); From cf71ba65d81f107f4509827fa9751993277557f1 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:19:45 -0300 Subject: [PATCH 014/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../ColumnEntityConverterInheritanceTest.java | 40 +++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterInheritanceTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterInheritanceTest.java index 47cf905ac..85dcf4745 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterInheritanceTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterInheritanceTest.java @@ -59,7 +59,7 @@ class ColumnEntityConverterInheritanceTest { private ColumnEntityConverter converter; @Test - public void shouldConvertProjectToSmallProject() { + void shouldConvertProjectToSmallProject() { ColumnEntity entity = ColumnEntity.of("Project"); entity.add("_id", "Small Project"); entity.add("investor", "Otavio Santana"); @@ -72,7 +72,7 @@ public void shouldConvertProjectToSmallProject() { } @Test - public void shouldConvertProjectToLargeProject() { + void shouldConvertProjectToLargeProject() { ColumnEntity entity = ColumnEntity.of("Project"); entity.add("_id", "Large Project"); entity.add("budget", BigDecimal.TEN); @@ -85,7 +85,7 @@ public void shouldConvertProjectToLargeProject() { } @Test - public void shouldConvertLargeProjectToCommunicationEntity() { + void shouldConvertLargeProjectToCommunicationEntity() { LargeProject project = new LargeProject(); project.setName("Large Project"); project.setBudget(BigDecimal.TEN); @@ -98,7 +98,7 @@ public void shouldConvertLargeProjectToCommunicationEntity() { } @Test - public void shouldConvertSmallProjectToCommunicationEntity() { + void shouldConvertSmallProjectToCommunicationEntity() { SmallProject project = new SmallProject(); project.setName("Small Project"); project.setInvestor("Otavio Santana"); @@ -111,7 +111,7 @@ public void shouldConvertSmallProjectToCommunicationEntity() { } @Test - public void shouldConvertProject() { + void shouldConvertProject() { ColumnEntity entity = ColumnEntity.of("Project"); entity.add("_id", "Project"); entity.add("size", "Project"); @@ -120,7 +120,7 @@ public void shouldConvertProject() { } @Test - public void shouldConvertProjectToCommunicationEntity() { + void shouldConvertProjectToCommunicationEntity() { Project project = new Project(); project.setName("Large Project"); ColumnEntity entity = this.converter.toColumn(project); @@ -131,7 +131,7 @@ public void shouldConvertProjectToCommunicationEntity() { } @Test - public void shouldConvertColumnEntityToSocialMedia(){ + void shouldConvertColumnEntityToSocialMedia(){ LocalDate date = LocalDate.now(); ColumnEntity entity = ColumnEntity.of("Notification"); entity.add("_id", 100L); @@ -147,7 +147,7 @@ public void shouldConvertColumnEntityToSocialMedia(){ } @Test - public void shouldConvertColumnEntityToSms(){ + void shouldConvertColumnEntityToSms(){ LocalDate date = LocalDate.now(); ColumnEntity entity = ColumnEntity.of("Notification"); entity.add("_id", 100L); @@ -163,7 +163,7 @@ public void shouldConvertColumnEntityToSms(){ } @Test - public void shouldConvertColumnEntityToEmail(){ + void shouldConvertColumnEntityToEmail(){ LocalDate date = LocalDate.now(); ColumnEntity entity = ColumnEntity.of("Notification"); entity.add("_id", 100L); @@ -179,7 +179,7 @@ public void shouldConvertColumnEntityToEmail(){ } @Test - public void shouldConvertSocialMediaToCommunicationEntity(){ + void shouldConvertSocialMediaToCommunicationEntity(){ SocialMediaNotification notification = new SocialMediaNotification(); notification.setId(100L); notification.setName("Social Media"); @@ -195,7 +195,7 @@ public void shouldConvertSocialMediaToCommunicationEntity(){ } @Test - public void shouldConvertSmsToCommunicationEntity(){ + void shouldConvertSmsToCommunicationEntity(){ SmsNotification notification = new SmsNotification(); notification.setId(100L); notification.setName("SMS"); @@ -211,7 +211,7 @@ public void shouldConvertSmsToCommunicationEntity(){ } @Test - public void shouldConvertEmailToCommunicationEntity(){ + void shouldConvertEmailToCommunicationEntity(){ EmailNotification notification = new EmailNotification(); notification.setId(100L); notification.setName("Email Media"); @@ -227,7 +227,7 @@ public void shouldConvertEmailToCommunicationEntity(){ } @Test - public void shouldReturnErrorWhenConvertMissingColumn(){ + void shouldReturnErrorWhenConvertMissingColumn(){ LocalDate date = LocalDate.now(); ColumnEntity entity = ColumnEntity.of("Notification"); entity.add("_id", 100L); @@ -238,7 +238,7 @@ public void shouldReturnErrorWhenConvertMissingColumn(){ } @Test - public void shouldReturnErrorWhenMismatchField() { + void shouldReturnErrorWhenMismatchField() { LocalDate date = LocalDate.now(); ColumnEntity entity = ColumnEntity.of("Notification"); entity.add("_id", 100L); @@ -252,7 +252,7 @@ public void shouldReturnErrorWhenMismatchField() { @Test - public void shouldConvertCommunicationNotificationReaderEmail() { + void shouldConvertCommunicationNotificationReaderEmail() { ColumnEntity entity = ColumnEntity.of("NotificationReader"); entity.add("_id", "poli"); entity.add("name", "Poliana Santana"); @@ -278,7 +278,7 @@ public void shouldConvertCommunicationNotificationReaderEmail() { } @Test - public void shouldConvertCommunicationNotificationReaderSms() { + void shouldConvertCommunicationNotificationReaderSms() { ColumnEntity entity = ColumnEntity.of("NotificationReader"); entity.add("_id", "poli"); entity.add("name", "Poliana Santana"); @@ -304,7 +304,7 @@ public void shouldConvertCommunicationNotificationReaderSms() { } @Test - public void shouldConvertCommunicationNotificationReaderSocial() { + void shouldConvertCommunicationNotificationReaderSocial() { ColumnEntity entity = ColumnEntity.of("NotificationReader"); entity.add("_id", "poli"); entity.add("name", "Poliana Santana"); @@ -330,7 +330,7 @@ public void shouldConvertCommunicationNotificationReaderSocial() { } @Test - public void shouldConvertSocialCommunication() { + void shouldConvertSocialCommunication() { SocialMediaNotification notification = new SocialMediaNotification(); notification.setId(10L); notification.setName("Ada"); @@ -353,7 +353,7 @@ public void shouldConvertSocialCommunication() { } @Test - public void shouldConvertConvertProjectManagerCommunication() { + void shouldConvertConvertProjectManagerCommunication() { LargeProject large = new LargeProject(); large.setBudget(BigDecimal.TEN); large.setName("large"); @@ -393,7 +393,7 @@ public void shouldConvertConvertProjectManagerCommunication() { } @Test - public void shouldConvertConvertCommunicationProjectManager() { + void shouldConvertConvertCommunicationProjectManager() { ColumnEntity communication = ColumnEntity.of("ProjectManager"); communication.add("_id", 10L); communication.add("name", "manager"); From 957b618f61a2a6e6dabac797182492929db45df2 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:19:50 -0300 Subject: [PATCH 015/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/ColumnEntityConverterTest.java | 52 +++++++++---------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterTest.java index 3adf3e487..c5f8caf86 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityConverterTest.java @@ -66,7 +66,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, ColumnExtension.class}) -public class ColumnEntityConverterTest { +class ColumnEntityConverterTest { @Inject private DefaultColumnEntityConverter converter; @@ -82,7 +82,7 @@ public class ColumnEntityConverterTest { .build(); @BeforeEach - public void init() { + void init() { columns = new Column[]{Column.of("_id", 12L), Column.of("age", 10), Column.of("name", "Otavio"), @@ -92,7 +92,7 @@ public void init() { } @Test - public void shouldConvertEntityFromColumnEntity() { + void shouldConvertEntityFromColumnEntity() { Person person = Person.builder().withAge() .withId(12) @@ -109,7 +109,7 @@ public void shouldConvertEntityFromColumnEntity() { } @Test - public void shouldConvertColumnEntityFromEntity() { + void shouldConvertColumnEntityFromEntity() { ColumnEntity entity = converter.toColumn(actor); assertEquals("Actor", entity.name()); @@ -119,7 +119,7 @@ public void shouldConvertColumnEntityFromEntity() { } @Test - public void shouldConvertColumnEntityToEntity() { + void shouldConvertColumnEntityToEntity() { ColumnEntity entity = ColumnEntity.of("Actor"); Stream.of(columns).forEach(entity::add); @@ -133,7 +133,7 @@ public void shouldConvertColumnEntityToEntity() { } @Test - public void shouldConvertColumnEntityToEntity2() { + void shouldConvertColumnEntityToEntity2() { ColumnEntity entity = ColumnEntity.of("Actor"); Stream.of(columns).forEach(entity::add); @@ -147,7 +147,7 @@ public void shouldConvertColumnEntityToEntity2() { } @Test - public void shouldConvertColumnEntityToExistEntity() { + void shouldConvertColumnEntityToExistEntity() { ColumnEntity entity = ColumnEntity.of("Actor"); Stream.of(columns).forEach(entity::add); Actor actor = Actor.actorBuilder().build(); @@ -162,7 +162,7 @@ public void shouldConvertColumnEntityToExistEntity() { } @Test - public void shouldReturnErrorWhenToEntityIsNull() { + void shouldReturnErrorWhenToEntityIsNull() { ColumnEntity entity = ColumnEntity.of("Actor"); Stream.of(columns).forEach(entity::add); Actor actor = Actor.actorBuilder().build(); @@ -174,7 +174,7 @@ public void shouldReturnErrorWhenToEntityIsNull() { @Test - public void shouldConvertEntityToColumnEntity2() { + void shouldConvertEntityToColumnEntity2() { Movie movie = new Movie("Matrix", 2012, Collections.singleton("Actor")); Director director = Director.builderDirector().withAge(12) @@ -205,7 +205,7 @@ public void shouldConvertEntityToColumnEntity2() { } @Test - public void shouldConvertToEmbeddedClassWhenHasSubColumn() { + void shouldConvertToEmbeddedClassWhenHasSubColumn() { Movie movie = new Movie("Matrix", 2012, Collections.singleton("Actor")); Director director = Director.builderDirector().withAge(12) .withId(12) @@ -222,7 +222,7 @@ public void shouldConvertToEmbeddedClassWhenHasSubColumn() { } @Test - public void shouldConvertToEmbeddedClassWhenHasSubColumn2() { + void shouldConvertToEmbeddedClassWhenHasSubColumn2() { Movie movie = new Movie("Matrix", 2012, singleton("Actor")); Director director = Director.builderDirector().withAge(12) .withId(12) @@ -242,7 +242,7 @@ public void shouldConvertToEmbeddedClassWhenHasSubColumn2() { } @Test - public void shouldConvertToEmbeddedClassWhenHasSubColumn3() { + void shouldConvertToEmbeddedClassWhenHasSubColumn3() { Movie movie = new Movie("Matrix", 2012, singleton("Actor")); Director director = Director.builderDirector().withAge(12) .withId(12) @@ -266,7 +266,7 @@ public void shouldConvertToEmbeddedClassWhenHasSubColumn3() { } @Test - public void shouldConvertToColumnWhenHaConverter() { + void shouldConvertToColumnWhenHaConverter() { Worker worker = new Worker(); Job job = new Job(); job.setCity("Sao Paulo"); @@ -283,7 +283,7 @@ public void shouldConvertToColumnWhenHaConverter() { } @Test - public void shouldConvertToEntityWhenHasConverter() { + void shouldConvertToEntityWhenHasConverter() { Worker worker = new Worker(); Job job = new Job(); job.setCity("Sao Paulo"); @@ -299,7 +299,7 @@ public void shouldConvertToEntityWhenHasConverter() { } @Test - public void shouldConvertEmbeddableLazily() { + void shouldConvertEmbeddableLazily() { ColumnEntity entity = ColumnEntity.of("Worker"); entity.add("name", "Otavio"); entity.add("money", "BRL 10"); @@ -313,7 +313,7 @@ public void shouldConvertEmbeddableLazily() { @Test - public void shouldConvertToListEmbeddable() { + void shouldConvertToListEmbeddable() { AppointmentBook appointmentBook = new AppointmentBook("ids"); appointmentBook.add(Contact.builder().withType(ContactType.EMAIL) .withName("Ada").withInformation("ada@lovelace.com").build()); @@ -333,7 +333,7 @@ public void shouldConvertToListEmbeddable() { } @Test - public void shouldConvertFromListEmbeddable() { + void shouldConvertFromListEmbeddable() { ColumnEntity entity = ColumnEntity.of("AppointmentBook"); entity.add(Column.of("_id", "ids")); List> columns = new ArrayList<>(); @@ -359,7 +359,7 @@ public void shouldConvertFromListEmbeddable() { @Test - public void shouldConvertSubEntity() { + void shouldConvertSubEntity() { ZipCode zipcode = new ZipCode(); zipcode.setZip("12321"); zipcode.setPlusFour("1234"); @@ -385,7 +385,7 @@ public void shouldConvertSubEntity() { } @Test - public void shouldConvertColumnInSubEntity() { + void shouldConvertColumnInSubEntity() { ColumnEntity entity = ColumnEntity.of("Address"); @@ -406,7 +406,7 @@ public void shouldConvertColumnInSubEntity() { } @Test - public void shouldReturnNullWhenThereIsNotSubEntity() { + void shouldReturnNullWhenThereIsNotSubEntity() { ColumnEntity entity = ColumnEntity.of("Address"); entity.add(Column.of("street", "Rua Engenheiro Jose Anasoh")); @@ -424,7 +424,7 @@ public void shouldReturnNullWhenThereIsNotSubEntity() { } @Test - public void shouldConvertAndDoNotUseUnmodifiableCollection() { + void shouldConvertAndDoNotUseUnmodifiableCollection() { ColumnEntity entity = ColumnEntity.of("vendors"); entity.add("name", "name"); entity.add("prefixes", Arrays.asList("value", "value2")); @@ -437,7 +437,7 @@ public void shouldConvertAndDoNotUseUnmodifiableCollection() { } @Test - public void shouldConvertEntityToDocumentWithArray() { + void shouldConvertEntityToDocumentWithArray() { byte[] contents = {1, 2, 3, 4, 5, 6}; ColumnEntity entity = ColumnEntity.of("download"); @@ -450,7 +450,7 @@ public void shouldConvertEntityToDocumentWithArray() { } @Test - public void shouldConvertDocumentToEntityWithArray() { + void shouldConvertDocumentToEntityWithArray() { byte[] contents = {1, 2, 3, 4, 5, 6}; Download download = new Download(); @@ -465,7 +465,7 @@ public void shouldConvertDocumentToEntityWithArray() { } @Test - public void shouldCreateUserScope() { + void shouldCreateUserScope() { ColumnEntity entity = ColumnEntity.of("UserScope"); entity.add("_id", "userName"); entity.add("scope", "scope"); @@ -480,7 +480,7 @@ public void shouldCreateUserScope() { } @Test - public void shouldCreateUserScope2() { + void shouldCreateUserScope2() { ColumnEntity entity = ColumnEntity.of("UserScope"); entity.add("_id", "userName"); entity.add("scope", "scope"); @@ -495,7 +495,7 @@ public void shouldCreateUserScope2() { } @Test - public void shouldCreateLazilyEntity() { + void shouldCreateLazilyEntity() { ColumnEntity entity = ColumnEntity.of("Citizen"); entity.add("id", "10"); entity.add("name", "Salvador"); From 3c5c1bd331759dff7dc872140973ed9792637339 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:19:55 -0300 Subject: [PATCH 016/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/ColumnEntityImmutableTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityImmutableTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityImmutableTest.java index 230126c84..10f9dc17a 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityImmutableTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEntityImmutableTest.java @@ -41,7 +41,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, ColumnExtension.class}) -public class ColumnEntityImmutableTest { +class ColumnEntityImmutableTest { @Inject private DefaultColumnEntityConverter converter; @@ -51,7 +51,7 @@ public class ColumnEntityImmutableTest { private Car car; @BeforeEach - public void init() { + void init() { this.car = new Car("123456789", "SF90", "Ferrari", Year.now()); @@ -63,7 +63,7 @@ public void init() { } @Test - public void shouldConvertCommunicationEntity() { + void shouldConvertCommunicationEntity() { ColumnEntity entity = converter.toColumn(car); assertEquals("Car", entity.name()); @@ -75,7 +75,7 @@ public void shouldConvertCommunicationEntity() { } @Test - public void shouldConvertCommunicationEntity2() { + void shouldConvertCommunicationEntity2() { ColumnEntity entity = converter.toColumn(car); assertEquals("Car", entity.name()); @@ -85,7 +85,7 @@ public void shouldConvertCommunicationEntity2() { } @Test - public void shouldConvertEntity() { + void shouldConvertEntity() { ColumnEntity entity = ColumnEntity.of("Car"); Stream.of(columns).forEach(entity::add); @@ -99,7 +99,7 @@ public void shouldConvertEntity() { } @Test - public void shouldConvertExistRecord() { + void shouldConvertExistRecord() { ColumnEntity entity = ColumnEntity.of("Car"); Stream.of(columns).forEach(entity::add); Car ferrari = new Car(null, null, null, null); @@ -124,7 +124,7 @@ public void shouldConvertExistRecord() { } @Test - public void shouldConvertExist() { + void shouldConvertExist() { ColumnEntity entity = ColumnEntity.of("Hero"); entity.add("_id", "2342"); entity.add("name", "Iron man"); From 55c31085666a33e29e0e15676fe32c4ce18c03f2 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:04 -0300 Subject: [PATCH 017/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/ColumnEntityTest.java | 81 ++++++++++--------- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnEntityTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnEntityTest.java index 719e9876b..83b47c850 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnEntityTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnEntityTest.java @@ -33,26 +33,27 @@ import static java.util.Collections.singletonList; import static java.util.Collections.singletonMap; import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNotSame; import static org.junit.jupiter.api.Assertions.assertTrue; -public class ColumnEntityTest { +class ColumnEntityTest { @Test - public void shouldReturnErrorWhenNameIsNull() { + void shouldReturnErrorWhenNameIsNull() { Assertions.assertThrows(NullPointerException.class, () -> ColumnEntity.of(null)); } @Test - public void shouldReturnErrorWhenColumnsIsNull() { + void shouldReturnErrorWhenColumnsIsNull() { Assertions.assertThrows(NullPointerException.class, () -> ColumnEntity.of("entity", null)); } @Test - public void shouldReturnOneColumn() { + void shouldReturnOneColumn() { ColumnEntity entity = ColumnEntity.of("entity"); assertEquals(Integer.valueOf(0), Integer.valueOf(entity.size())); assertTrue(entity.isEmpty()); @@ -65,7 +66,7 @@ public void shouldReturnOneColumn() { } @Test - public void shouldDoCopy() { + void shouldDoCopy() { ColumnEntity entity = ColumnEntity.of("entity", singletonList(Column.of("name", "name"))); ColumnEntity copy = entity.copy(); assertNotSame(entity, copy); @@ -74,7 +75,7 @@ public void shouldDoCopy() { } @Test - public void shouldFindColumn() { + void shouldFindColumn() { Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(column)); Optional name = entity.find("name"); @@ -85,16 +86,16 @@ public void shouldFindColumn() { } @Test - public void shouldReturnErrorWhenFindColumnIsNull() { + void shouldReturnErrorWhenFindColumnIsNull() { + Column column = Column.of("name", "name"); Assertions.assertThrows(NullPointerException.class, () -> { - Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(column)); entity.find(null); }); } @Test - public void shouldFindValue() { + void shouldFindValue() { Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(column)); Optional name = entity.find("name", String.class); @@ -104,7 +105,7 @@ public void shouldFindValue() { } @Test - public void shouldNotFindValue() { + void shouldNotFindValue() { Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(column)); Optional name = entity.find("not_found", String.class); @@ -113,7 +114,7 @@ public void shouldNotFindValue() { } @Test - public void shouldFindTypeSupplier() { + void shouldFindTypeSupplier() { Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(column)); List names = entity.find("name", new TypeReference>() {}) @@ -124,7 +125,7 @@ public void shouldFindTypeSupplier() { } @Test - public void shouldNotFindTypeSupplier() { + void shouldNotFindTypeSupplier() { Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(column)); List names = entity.find("not_find", new TypeReference>() {}) @@ -134,7 +135,7 @@ public void shouldNotFindTypeSupplier() { } @Test - public void shouldRemoveColumn() { + void shouldRemoveColumn() { Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(column)); assertTrue(entity.remove("name")); @@ -142,7 +143,7 @@ public void shouldRemoveColumn() { } @Test - public void shouldConvertToMap() { + void shouldConvertToMap() { Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(column)); Map result = entity.toMap(); @@ -152,7 +153,7 @@ public void shouldConvertToMap() { } @Test - public void shouldConvertSubColumn() { + void shouldConvertSubColumn() { Column column = Column.of("name", "name"); ColumnEntity entity = ColumnEntity.of("entity", singletonList(Column.of("sub", column))); Map result = entity.toMap(); @@ -164,7 +165,7 @@ public void shouldConvertSubColumn() { @Test - public void shouldConvertSubColumnListToMap() { + void shouldConvertSubColumnListToMap() { ColumnEntity entity = ColumnEntity.of("entity"); entity.add(Column.of("_id", "id")); List columns = asList(Column.of("name", "Ada"), Column.of("type", "type"), @@ -181,7 +182,7 @@ public void shouldConvertSubColumnListToMap() { } @Test - public void shouldConvertSubColumnListToMap2() { + void shouldConvertSubColumnListToMap2() { ColumnEntity entity = ColumnEntity.of("entity"); entity.add(Column.of("_id", "id")); List> columns = new ArrayList<>(); @@ -201,20 +202,20 @@ public void shouldConvertSubColumnListToMap2() { } @Test - public void shouldCreateANewInstance() { + void shouldCreateANewInstance() { String name = "name"; ColumnEntity entity = new ColumnEntity(name); assertEquals(name, entity.name()); } @Test - public void shouldCreateAnEmptyEntity() { + void shouldCreateAnEmptyEntity() { ColumnEntity entity = new ColumnEntity("name"); assertTrue(entity.isEmpty()); } @Test - public void shouldReturnAnErrorWhenAddANullColumn() { + void shouldReturnAnErrorWhenAddANullColumn() { Assertions.assertThrows(NullPointerException.class, () -> { ColumnEntity entity = new ColumnEntity("name"); entity.add(null); @@ -222,7 +223,7 @@ public void shouldReturnAnErrorWhenAddANullColumn() { } @Test - public void shouldAddANewColumn() { + void shouldAddANewColumn() { ColumnEntity entity = new ColumnEntity("name"); entity.add(Column.of("column", 12)); assertFalse(entity.isEmpty()); @@ -230,7 +231,7 @@ public void shouldAddANewColumn() { } @Test - public void shouldReturnErrorWhenAddAnNullIterable() { + void shouldReturnErrorWhenAddAnNullIterable() { Assertions.assertThrows(NullPointerException.class, () -> { ColumnEntity entity = new ColumnEntity("name"); entity.addAll(null); @@ -238,7 +239,7 @@ public void shouldReturnErrorWhenAddAnNullIterable() { } @Test - public void shouldAddAllColumns() { + void shouldAddAllColumns() { ColumnEntity entity = new ColumnEntity("name"); entity.addAll(Arrays.asList(Column.of("name", 12), Column.of("value", "value"))); assertFalse(entity.isEmpty()); @@ -247,14 +248,14 @@ public void shouldAddAllColumns() { @Test - public void shouldNotFindColumn() { + void shouldNotFindColumn() { ColumnEntity entity = new ColumnEntity("name"); Optional column = entity.find("name"); assertFalse(column.isPresent()); } @Test - public void shouldRemoveByName() { + void shouldRemoveByName() { ColumnEntity entity = new ColumnEntity("name"); entity.add(Column.of("value", 32D)); assertTrue(entity.remove("value")); @@ -262,7 +263,7 @@ public void shouldRemoveByName() { } @Test - public void shouldReturnErrorWhenRemovedNameIsNull() { + void shouldReturnErrorWhenRemovedNameIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { ColumnEntity entity = new ColumnEntity("name"); entity.remove(null); @@ -270,7 +271,7 @@ public void shouldReturnErrorWhenRemovedNameIsNull() { } @Test - public void shouldNotRemoveByName() { + void shouldNotRemoveByName() { ColumnEntity entity = new ColumnEntity("name"); entity.add(Column.of("value", 32D)); @@ -280,7 +281,7 @@ public void shouldNotRemoveByName() { @Test - public void shouldReturnErrorWhenRemoveByNameIsNull() { + void shouldReturnErrorWhenRemoveByNameIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { ColumnEntity entity = new ColumnEntity("name"); entity.remove(null); @@ -289,7 +290,7 @@ public void shouldReturnErrorWhenRemoveByNameIsNull() { @Test - public void shouldAddColumnAsNameAndObject() { + void shouldAddColumnAsNameAndObject() { ColumnEntity entity = new ColumnEntity("columnFamily"); entity.add("name", 10); assertEquals(1, entity.size()); @@ -299,7 +300,7 @@ public void shouldAddColumnAsNameAndObject() { } @Test - public void shouldAddColumnAsNameAndValue() { + void shouldAddColumnAsNameAndValue() { ColumnEntity entity = new ColumnEntity("columnFamily"); entity.add("name", Value.of(10)); assertEquals(1, entity.size()); @@ -309,7 +310,7 @@ public void shouldAddColumnAsNameAndValue() { } @Test - public void shouldReturnErrorWhenAddColumnsObjectWhenHasNullObject() { + void shouldReturnErrorWhenAddColumnsObjectWhenHasNullObject() { Assertions.assertThrows(NullPointerException.class, () -> { ColumnEntity entity = new ColumnEntity("columnFamily"); entity.add("name", null); @@ -317,7 +318,7 @@ public void shouldReturnErrorWhenAddColumnsObjectWhenHasNullObject() { } @Test - public void shouldReturnErrorWhenAddColumnsObjectWhenHasNullColumnName() { + void shouldReturnErrorWhenAddColumnsObjectWhenHasNullColumnName() { Assertions.assertThrows(NullPointerException.class, () -> { ColumnEntity entity = new ColumnEntity("columnFamily"); entity.add(null, 10); @@ -325,7 +326,7 @@ public void shouldReturnErrorWhenAddColumnsObjectWhenHasNullColumnName() { } @Test - public void shouldReturnErrorWhenAddColumnsValueWhenHasNullColumnName() { + void shouldReturnErrorWhenAddColumnsValueWhenHasNullColumnName() { Assertions.assertThrows(NullPointerException.class, () -> { ColumnEntity entity = new ColumnEntity("columnFamily"); entity.add(null, Value.of(12)); @@ -334,7 +335,7 @@ public void shouldReturnErrorWhenAddColumnsValueWhenHasNullColumnName() { @Test - public void shouldAvoidDuplicatedColumn() { + void shouldAvoidDuplicatedColumn() { ColumnEntity entity = new ColumnEntity("columnFamily"); entity.add("name", 10); entity.add("name", 13); @@ -344,7 +345,7 @@ public void shouldAvoidDuplicatedColumn() { } @Test - public void shouldAvoidDuplicatedColumnWhenAddList() { + void shouldAvoidDuplicatedColumnWhenAddList() { List columns = asList(Column.of("name", 10), Column.of("name", 13)); ColumnEntity entity = new ColumnEntity("columnFamily"); entity.addAll(columns); @@ -353,7 +354,7 @@ public void shouldAvoidDuplicatedColumnWhenAddList() { } @Test - public void shouldReturnsTheColumnNames() { + void shouldReturnsTheColumnNames() { List columns = asList(Column.of("name", 10), Column.of("name2", 11), Column.of("name3", 12), Column.of("name4", 13), Column.of("name5", 14), Column.of("name5", 16)); @@ -366,7 +367,7 @@ public void shouldReturnsTheColumnNames() { } @Test - public void shouldReturnsTheColumnValues() { + void shouldReturnsTheColumnValues() { List columns = asList(Column.of("name", 10), Column.of("name2", 11), Column.of("name3", 12), Column.of("name4", 13), Column.of("name5", 14), Column.of("name5", 16)); @@ -377,7 +378,7 @@ public void shouldReturnsTheColumnValues() { } @Test - public void shouldReturnTrueWhenContainsElement() { + void shouldReturnTrueWhenContainsElement() { List columns = asList(Column.of("name", 10), Column.of("name2", 11), Column.of("name3", 12), Column.of("name4", 13), Column.of("name5", 14), Column.of("name5", 16)); @@ -392,7 +393,7 @@ public void shouldReturnTrueWhenContainsElement() { } @Test - public void shouldReturnFalseWhenDoesNotContainElement() { + void shouldReturnFalseWhenDoesNotContainElement() { List columns = asList(Column.of("name", 10), Column.of("name2", 11), Column.of("name3", 12), Column.of("name4", 13), Column.of("name5", 14), Column.of("name5", 16)); @@ -407,7 +408,7 @@ public void shouldReturnFalseWhenDoesNotContainElement() { } @Test - public void shouldRemoveAllElementsWhenUseClearMethod() { + void shouldRemoveAllElementsWhenUseClearMethod() { List columns = asList(Column.of("name", 10), Column.of("name2", 11), Column.of("name3", 12), Column.of("name4", 13), Column.of("name5", 14), Column.of("name5", 16)); From e1f9f4626f6b146febfbcb97c34bd4e7fb35c293 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:11 -0300 Subject: [PATCH 018/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/ColumnEventPersistManagerTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEventPersistManagerTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEventPersistManagerTest.java index 970419dc0..4e6c059e8 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEventPersistManagerTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnEventPersistManagerTest.java @@ -28,7 +28,7 @@ import static org.mockito.Mockito.verify; @ExtendWith(MockitoExtension.class) -public class ColumnEventPersistManagerTest { +class ColumnEventPersistManagerTest { @InjectMocks @@ -47,7 +47,7 @@ public class ColumnEventPersistManagerTest { @Test - public void shouldFirePreEntity() { + void shouldFirePreEntity() { Jedi jedi = new Jedi(); jedi.name = "Luke"; subject.firePreEntity(jedi); @@ -58,7 +58,7 @@ public void shouldFirePreEntity() { } @Test - public void shouldFirePostEntity() { + void shouldFirePostEntity() { Jedi jedi = new Jedi(); jedi.name = "Luke"; subject.firePostEntity(jedi); From 3c9c990b48fa820e118c92ff119cd14c7666d022 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:19 -0300 Subject: [PATCH 019/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/column/spi/ColumnExtensionTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/spi/ColumnExtensionTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/spi/ColumnExtensionTest.java index 8172a2be0..aacfaa2a2 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/spi/ColumnExtensionTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/spi/ColumnExtensionTest.java @@ -38,7 +38,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, ColumnExtension.class}) -public class ColumnExtensionTest { +class ColumnExtensionTest { @Inject @Database(value = DatabaseType.COLUMN, provider = "columnRepositoryMock") @@ -56,13 +56,13 @@ public class ColumnExtensionTest { private PersonRepository repositoryMock; @Test - public void shouldInstance() { + void shouldInstance() { assertNotNull(template); assertNotNull(templateMock); } @Test - public void shouldSave() { + void shouldSave() { Person person = template.insert(Person.builder().build()); Person personMock = templateMock.insert(Person.builder().build()); @@ -71,13 +71,13 @@ public void shouldSave() { } @Test - public void shouldInjectRepository() { + void shouldInjectRepository() { assertNotNull(repository); assertNotNull(repositoryMock); } @Test - public void shouldInjectTemplate() { + void shouldInjectTemplate() { assertNotNull(templateMock); assertNotNull(template); } From 718caa01a423ff1a12ac7208b122797986cd6961 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:24 -0300 Subject: [PATCH 020/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../configuration/ColumnManagerSupplierTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/configuration/ColumnManagerSupplierTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/configuration/ColumnManagerSupplierTest.java index 3a56e892f..5a8e08a72 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/configuration/ColumnManagerSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/configuration/ColumnManagerSupplierTest.java @@ -46,13 +46,13 @@ class ColumnManagerSupplierTest { private ColumnManagerSupplier supplier; @BeforeEach - public void beforeEach(){ + void beforeEach(){ System.clearProperty(COLUMN_PROVIDER.get()); System.clearProperty(COLUMN_DATABASE.get()); } @Test - public void shouldGetManager() { + void shouldGetManager() { System.setProperty(COLUMN_PROVIDER.get(), ColumnConfigurationMock.class.getName()); System.setProperty(COLUMN_DATABASE.get(), "database"); ColumnManager manager = supplier.get(); @@ -62,7 +62,7 @@ public void shouldGetManager() { @Test - public void shouldUseDefaultConfigurationWhenProviderIsWrong() { + void shouldUseDefaultConfigurationWhenProviderIsWrong() { System.setProperty(COLUMN_PROVIDER.get(), Integer.class.getName()); System.setProperty(COLUMN_DATABASE.get(), "database"); ColumnManager manager = supplier.get(); @@ -71,7 +71,7 @@ public void shouldUseDefaultConfigurationWhenProviderIsWrong() { } @Test - public void shouldUseDefaultConfiguration() { + void shouldUseDefaultConfiguration() { System.setProperty(COLUMN_DATABASE.get(), "database"); ColumnManager manager = supplier.get(); Assertions.assertNotNull(manager); @@ -79,12 +79,12 @@ public void shouldUseDefaultConfiguration() { } @Test - public void shouldReturnErrorWhenThereIsNotDatabase() { + void shouldReturnErrorWhenThereIsNotDatabase() { Assertions.assertThrows(MappingException.class, () -> supplier.get()); } @Test - public void shouldClose(){ + void shouldClose(){ ColumnManager manager = Mockito.mock(ColumnManager.class); supplier.close(manager); Mockito.verify(manager).close(); From e8d757ee34863c1e1f709f1546a8a7104d00e48f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:32 -0300 Subject: [PATCH 021/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/ColumnMapperObserverTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnMapperObserverTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnMapperObserverTest.java index 47c14a9db..84d1dd235 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnMapperObserverTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnMapperObserverTest.java @@ -45,48 +45,48 @@ class ColumnMapperObserverTest { private ColumnObserverParser parser; @BeforeEach - public void setUp() { + void setUp() { this.parser = new ColumnMapperObserver(mappings); } @Test - public void shouldFireEntity(){ + void shouldFireEntity(){ var entity = parser.fireEntity("Vendor"); Assertions.assertEquals("vendors", entity); } @Test - public void shouldFireFromClass(){ + void shouldFireFromClass(){ var entity = parser.fireEntity(Car.class.getSimpleName()); Assertions.assertEquals("Car", entity); } @Test - public void shouldFireFromClassName(){ + void shouldFireFromClassName(){ var entity = parser.fireEntity(Car.class.getSimpleName()); Assertions.assertEquals("Car", entity); } @Test - public void shouldFireField(){ + void shouldFireField(){ var field = parser.fireField("Worker", "salary"); Assertions.assertEquals("money", field); } @Test - public void shouldFireFieldFromClassName(){ + void shouldFireFieldFromClassName(){ var field = parser.fireField(Worker.class.getName(), "salary"); Assertions.assertEquals("money", field); } @Test - public void shouldFireFieldFromSimplesName(){ + void shouldFireFieldFromSimplesName(){ var field = parser.fireField(Worker.class.getSimpleName(), "salary"); Assertions.assertEquals("money", field); } @Test - public void shouldFireFieldFromEntity(){ + void shouldFireFieldFromEntity(){ var field = parser.fireField(Vendor.class.getSimpleName(), "name"); Assertions.assertEquals("_id", field); } From 1431a09cda165764d5b68799f7c77488d820b1e0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:37 -0300 Subject: [PATCH 022/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/communication/column/ColumnParamsTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnParamsTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnParamsTest.java index fbfe00955..681516a15 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnParamsTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnParamsTest.java @@ -26,7 +26,7 @@ class ColumnParamsTest { @Test - public void shouldSetParameter() { + void shouldSetParameter() { Params params = Params.newParams(); Value name = params.add("name"); Column column = Column.of("name", name); From 30feff34d60a7997acd70e6315d52b7704d44a76 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:41 -0300 Subject: [PATCH 023/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/query/ColumnRepositoryExtensionTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ColumnRepositoryExtensionTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ColumnRepositoryExtensionTest.java index 444e25f71..ac00c6708 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ColumnRepositoryExtensionTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ColumnRepositoryExtensionTest.java @@ -38,7 +38,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, ColumnExtension.class}) -public class ColumnRepositoryExtensionTest { +class ColumnRepositoryExtensionTest { @Inject @Database(value = DatabaseType.COLUMN) @@ -49,14 +49,14 @@ public class ColumnRepositoryExtensionTest { private PersonRepository repositoryMock; @Test - public void shouldInitiate() { + void shouldInitiate() { assertNotNull(repository); Person person = repository.save(Person.builder().build()); assertEquals("Default", person.getName()); } @Test - public void shouldUseInstantiation(){ + void shouldUseInstantiation(){ assertNotNull(repositoryMock); Person person = repositoryMock.save(Person.builder().build()); assertEquals("columnRepositoryMock", person.getName()); From 2645af87a9aecafb5f93e88f6dd0fe3dd4f9b1ad Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:45 -0300 Subject: [PATCH 024/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/query/ColumnRepositoryProxyTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ColumnRepositoryProxyTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ColumnRepositoryProxyTest.java index 01e25acc1..9b37d65db 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ColumnRepositoryProxyTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ColumnRepositoryProxyTest.java @@ -94,7 +94,7 @@ class ColumnRepositoryProxyTest { @BeforeEach - public void setUp() { + void setUp() { this.template = Mockito.mock(JNoSQLColumnTemplate.class); ColumnRepositoryProxy personHandler = new ColumnRepositoryProxy(template, @@ -333,14 +333,14 @@ void shouldDeleteAll() { } @Test - public void shouldDeleteEntity(){ + void shouldDeleteEntity(){ Person person = Person.builder().withId(1L).withAge(20).withName("Ada").build(); personRepository.delete(person); verify(template).delete(Person.class, 1L); } @Test - public void shouldDeleteEntities(){ + void shouldDeleteEntities(){ Person person = Person.builder().withId(1L).withAge(20).withName("Ada").build(); personRepository.deleteAll(List.of(person)); verify(template).delete(Person.class, 1L); @@ -791,7 +791,7 @@ void shouldUseDefaultMethodFromOtherInterface() { } @Test - public void shouldExecuteCustomRepository(){ + void shouldExecuteCustomRepository(){ PersonStatisticRepository.PersonStatistic statistics = personRepository.statistics("Salvador"); assertThat(statistics).isNotNull(); SoftAssertions.assertSoftly(softly -> { From 7f09c7864de69fc74df979c6f40a05cecdf0ba49 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:20:58 -0300 Subject: [PATCH 025/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/communication/column/ColumnsTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnsTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnsTest.java index 721fb1ce2..981322c8d 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnsTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnsTest.java @@ -30,17 +30,17 @@ import static org.junit.jupiter.api.Assertions.assertFalse; -public class ColumnsTest { +class ColumnsTest { @Test - public void shouldCreateColumn() { + void shouldCreateColumn() { Column column = Columns.of("name", "Ada"); assertEquals("name", column.name()); assertEquals("Ada", column.get()); } @Test - public void shouldCreateColumnsFromMap() { + void shouldCreateColumnsFromMap() { Map map = singletonMap("name", "Ada"); List columns = Columns.of(map); assertFalse(columns.isEmpty()); @@ -49,7 +49,7 @@ public void shouldCreateColumnsFromMap() { @Test - public void shouldCreateRecursiveMap() { + void shouldCreateRecursiveMap() { List>> list = new ArrayList<>(); Map map = singletonMap("mobile", "55 1234-4567"); list.add(singletonList(map)); From 450f5ffc9040f3782d02b61c2938601ef864999e Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:21:03 -0300 Subject: [PATCH 026/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../org/eclipse/jnosql/mapping/column/ColumnTemplateTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnTemplateTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnTemplateTest.java index 3e3e74d68..e764b609b 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnTemplateTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/ColumnTemplateTest.java @@ -44,12 +44,12 @@ class ColumnTemplateTest { private Template qualifier; @Test - public void shouldInjectTemplate() { + void shouldInjectTemplate() { Assertions.assertNotNull(template); } @Test - public void shouldInjectQualifier() { + void shouldInjectQualifier() { Assertions.assertNotNull(qualifier); } } From fba74b2dd82865df7e1ea59ae84ee08cb649745a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:21:07 -0300 Subject: [PATCH 027/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/column/ColumnTest.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnTest.java index d8954c600..1f7117724 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/ColumnTest.java @@ -27,26 +27,26 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; -public class ColumnTest { +class ColumnTest { private static final Value DEFAULT_VALUE = Value.of(12); @Test - public void shouldReturnNameWhenNameIsNull() { + void shouldReturnNameWhenNameIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { - Column column = Column.of(null, DEFAULT_VALUE); + Column.of(null, DEFAULT_VALUE); }); } @Test - public void shouldReturnNameWhenValueIsNull() { + void shouldReturnNameWhenValueIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { - Column column = Column.of("Name", null); + Column.of("Name", null); }); } @Test - public void shouldCreateAnColumnInstance() { + void shouldCreateAnColumnInstance() { String name = "name"; Column column = Column.of(name, DEFAULT_VALUE); assertNotNull(column); @@ -55,19 +55,19 @@ public void shouldCreateAnColumnInstance() { } @Test - public void shouldBeEquals() { + void shouldBeEquals() { assertEquals(Column.of("name", DEFAULT_VALUE), Column.of("name", DEFAULT_VALUE)); } @Test - public void shouldReturnGetObject() { + void shouldReturnGetObject() { Value value = Value.of("text"); Column column = Column.of("name", value); assertEquals(value.get(), column.get()); } @Test - public void shouldReturnGetClass() { + void shouldReturnGetClass() { Value value = Value.of("text"); Column column = Column.of("name", value); assertEquals(value.get(String.class), column.get(String.class)); @@ -75,7 +75,7 @@ public void shouldReturnGetClass() { @Test - public void shouldReturnGetType() { + void shouldReturnGetType() { Value value = Value.of("text"); Column column = Column.of("name", value); TypeReference> typeReference = new TypeReference<>() { From 3b87f5a8ee0fc466674e7fbe97976e172f52dd1b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:21:21 -0300 Subject: [PATCH 028/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/metadata/ConstructorBuilderTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/ConstructorBuilderTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/ConstructorBuilderTest.java index 63fd115d4..69948b66f 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/ConstructorBuilderTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/ConstructorBuilderTest.java @@ -25,10 +25,10 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import static org.mockito.Mockito.*; -public class ConstructorBuilderTest { +class ConstructorBuilderTest { @Test - public void shouldReturnValidConstructorBuilder() { + void shouldReturnValidConstructorBuilder() { ConstructorMetadata constructorMetadata = mock(ConstructorMetadata.class); ConstructorBuilderSupplier supplier = mock(ConstructorBuilderSupplier.class); ConstructorBuilder expectedBuilder = mock(ConstructorBuilder.class); @@ -49,7 +49,7 @@ public void shouldReturnValidConstructorBuilder() { } @Test - public void shouldThrowExceptionWhenNoImplementationFound() { + void shouldThrowExceptionWhenNoImplementationFound() { ConstructorMetadata constructorMetadata = mock(ConstructorMetadata.class); // Mock static method to return an empty ServiceLoader From 9b9512a4334bd305e8142faa0441cf890833839c Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:21:29 -0300 Subject: [PATCH 029/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/reflection/ConstructorComparableTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorComparableTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorComparableTest.java index b00f4350c..49a6952ea 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorComparableTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorComparableTest.java @@ -26,14 +26,14 @@ class ConstructorComparableTest { @Test - public void shouldReturnDefaultConstructor(){ + void shouldReturnDefaultConstructor(){ Constructor constructor = Stream.of(Person.class.getDeclaredConstructors()).min(ConstructorComparable.INSTANCE).orElseThrow(); Assertions.assertNotNull(constructor); } @Test - public void shouldReturnDefault() { + void shouldReturnDefault() { Constructor constructor = Stream.of(Animal.class.getDeclaredConstructors()) .min(ConstructorComparable.INSTANCE).orElseThrow(); From 257427bfc3a407f15566988088a349a65f84f382 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:21:56 -0300 Subject: [PATCH 030/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/ConstructorEventTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorEventTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorEventTest.java index b015fe0a6..652f963a2 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorEventTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorEventTest.java @@ -23,10 +23,10 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotEquals; -public class ConstructorEventTest { +class ConstructorEventTest { @Test - public void shouldCreateConstructorEvent() throws NoSuchMethodException { + void shouldCreateConstructorEvent() throws NoSuchMethodException { // Create a sample class to get the constructor Class sampleClass = SampleClass.class; @@ -49,13 +49,13 @@ public void shouldCreateConstructorEvent() throws NoSuchMethodException { } @Test - public void shouldThrowNullPointerException() { + void shouldThrowNullPointerException() { Assertions.assertThrows(NullPointerException.class, () -> ConstructorEvent.of(null, new Object[]{1})); Assertions.assertThrows(NullPointerException.class, () -> ConstructorEvent.of(ConstructorEventTest.class.getDeclaredConstructors()[0], null)); } @Test - public void shouldToString() throws NoSuchMethodException{ + void shouldToString() throws NoSuchMethodException{ Class sampleClass = SampleClass.class; Constructor constructor = sampleClass.getConstructor(int.class, String.class); @@ -68,7 +68,7 @@ public void shouldToString() throws NoSuchMethodException{ } @Test - public void shouldEqualsHasCode() throws NoSuchMethodException { + void shouldEqualsHasCode() throws NoSuchMethodException { Class sampleClass = SampleClass.class; Constructor constructor = sampleClass.getConstructor(int.class, String.class); From e3bead57ec76e490e98a8bc4e1b0e70415b61b0b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:22:03 -0300 Subject: [PATCH 031/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/ConstructorMetadataBuilderTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorMetadataBuilderTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorMetadataBuilderTest.java index a71d7959c..7c37fad38 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorMetadataBuilderTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ConstructorMetadataBuilderTest.java @@ -47,26 +47,26 @@ class ConstructorMetadataBuilderTest { private ConstructorMetadataBuilder builder; @BeforeEach - public void setUp() { + void setUp() { this.builder = new ConstructorMetadataBuilder(reflections); } @Test - public void shouldReturnEmptyMetadata() { + void shouldReturnEmptyMetadata() { ConstructorMetadata metadata = builder.build(Person.class); Assertions.assertNotNull(metadata); Assertions.assertTrue(metadata.parameters().isEmpty()); } @Test - public void shouldReturnEmptyDefaultConstructor() { + void shouldReturnEmptyDefaultConstructor() { ConstructorMetadata metadata = builder.build(Worker.class); Assertions.assertNotNull(metadata); Assertions.assertTrue(metadata.parameters().isEmpty()); } @Test - public void shouldReturnComputerEntityConstructor() { + void shouldReturnComputerEntityConstructor() { ConstructorMetadata metadata = builder.build(Computer.class); List parameters = metadata.parameters(); assertEquals(5, parameters.size()); @@ -78,7 +78,7 @@ public void shouldReturnComputerEntityConstructor() { } @Test - public void shouldReturnBookUserEntityConstructor() { + void shouldReturnBookUserEntityConstructor() { ConstructorMetadata metadata = builder.build(BookUser.class); List parameters = metadata.parameters(); assertEquals(3, parameters.size()); @@ -90,7 +90,7 @@ public void shouldReturnBookUserEntityConstructor() { } @Test - public void shouldReturnSmartphoneEntityConstructor() { + void shouldReturnSmartphoneEntityConstructor() { ConstructorMetadata metadata = builder.build(Smartphone.class); List parameters = metadata.parameters(); assertEquals(2, parameters.size()); @@ -102,7 +102,7 @@ public void shouldReturnSmartphoneEntityConstructor() { } @Test - public void shouldReturnPetOwnerEntityConstructor() { + void shouldReturnPetOwnerEntityConstructor() { ConstructorMetadata metadata = builder.build(PetOwner.class); List parameters = metadata.parameters(); assertEquals(3, parameters.size()); From 8c576f39ad55dec251eb30cb76c885368a521ab1 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:22:08 -0300 Subject: [PATCH 032/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../java/org/eclipse/jnosql/mapping/ConvertersTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/ConvertersTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/ConvertersTest.java index 603e9ca14..4a093eb91 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/ConvertersTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/ConvertersTest.java @@ -37,13 +37,13 @@ class ConvertersTest { @Inject private Converters converters; @Test - public void shouldReturnNPEWhenClassIsNull() { + void shouldReturnNPEWhenClassIsNull() { Assertions.assertThrows(NullPointerException.class, () -> converters.get(null)); } @SuppressWarnings("unchecked") @Test - public void shouldCreateAttributeConverterWithInjections() { + void shouldCreateAttributeConverterWithInjections() { FieldMetadata fieldMetadata = Mockito.mock(FieldMetadata.class); Optional converter = Optional.of(MyConverter.class); Optional newInstance = Optional.of(new MyConverter()); @@ -59,7 +59,7 @@ public void shouldCreateAttributeConverterWithInjections() { @Test @SuppressWarnings("unchecked") - public void shouldCreateNotUsingInjections() { + void shouldCreateNotUsingInjections() { FieldMetadata fieldMetadata = Mockito.mock(FieldMetadata.class); Optional converter = Optional.of(VetedConverter.class); @@ -77,7 +77,7 @@ public void shouldCreateNotUsingInjections() { } @Test - public void shouldGetToString(){ + void shouldGetToString(){ assertThat(this.converters.toString()).isNotNull().isNotBlank().isNotEmpty(); } From 5a9474ccd58581846f9138eb39e7d3171bbf3797 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:22:13 -0300 Subject: [PATCH 033/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/util/ConverterUtilTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/ConverterUtilTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/ConverterUtilTest.java index e8bf1ad58..06e2c3a7d 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/ConverterUtilTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/ConverterUtilTest.java @@ -39,7 +39,7 @@ @AddPackages(value = VetedConverter.class) @AddPackages(value = Reflections.class) @AddExtensions(EntityMetadataExtension.class) -public class ConverterUtilTest { +class ConverterUtilTest { @Inject @@ -49,7 +49,7 @@ public class ConverterUtilTest { private EntitiesMetadata mappings; @Test - public void shouldNotConvert() { + void shouldNotConvert() { EntityMetadata mapping = mappings.get(Person.class); Object value = 10_000L; Object id = ConverterUtil.getValue(value, mapping, "id", converters); @@ -57,7 +57,7 @@ public void shouldNotConvert() { } @Test - public void shouldConvert() { + void shouldConvert() { EntityMetadata mapping = mappings.get(Person.class); String value = "100"; Object id = ConverterUtil.getValue(value, mapping, "id", converters); @@ -65,7 +65,7 @@ public void shouldConvert() { } @Test - public void shouldUseAttributeConvert() { + void shouldUseAttributeConvert() { EntityMetadata mapping = mappings.get(Worker.class); Object value = new Money("BRL", BigDecimal.TEN); Object converted = ConverterUtil.getValue(value, mapping, "salary", converters); From f2200c5c78a18a8cf9d02dfe7eab6dd84e543bfc Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:22:26 -0300 Subject: [PATCH 034/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../org/eclipse/jnosql/mapping/DatabaseMetadataTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseMetadataTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseMetadataTest.java index f61c5c82b..74a365c0c 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseMetadataTest.java @@ -23,12 +23,12 @@ class DatabaseMetadataTest { @Test - public void shouldReturnErrorWhenDatabaseIsNull() { + void shouldReturnErrorWhenDatabaseIsNull() { assertThrows(NullPointerException.class, () -> DatabaseMetadata.of(null)); } @Test - public void shouldReturnMetadata() { + void shouldReturnMetadata() { Database database = Mockito.mock(Database.class); Mockito.when(database.value()).thenReturn(DatabaseType.COLUMN); Mockito.when(database.provider()).thenReturn("column"); @@ -38,7 +38,7 @@ public void shouldReturnMetadata() { } @Test - public void shouldReturnToString() { + void shouldReturnToString() { Database database = Mockito.mock(Database.class); Mockito.when(database.value()).thenReturn(DatabaseType.COLUMN); Mockito.when(database.provider()).thenReturn("column"); @@ -47,7 +47,7 @@ public void shouldReturnToString() { } @Test - public void shouldReturnToString2() { + void shouldReturnToString2() { Database database = Mockito.mock(Database.class); Mockito.when(database.value()).thenReturn(DatabaseType.COLUMN); DatabaseMetadata metadata = DatabaseMetadata.of(database); From fc60a24928cb97fd4da87c650de0a04165f16867 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:22:54 -0300 Subject: [PATCH 035/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../org/eclipse/jnosql/mapping/DatabaseMetadataTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseMetadataTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseMetadataTest.java index f61c5c82b..74a365c0c 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseMetadataTest.java @@ -23,12 +23,12 @@ class DatabaseMetadataTest { @Test - public void shouldReturnErrorWhenDatabaseIsNull() { + void shouldReturnErrorWhenDatabaseIsNull() { assertThrows(NullPointerException.class, () -> DatabaseMetadata.of(null)); } @Test - public void shouldReturnMetadata() { + void shouldReturnMetadata() { Database database = Mockito.mock(Database.class); Mockito.when(database.value()).thenReturn(DatabaseType.COLUMN); Mockito.when(database.provider()).thenReturn("column"); @@ -38,7 +38,7 @@ public void shouldReturnMetadata() { } @Test - public void shouldReturnToString() { + void shouldReturnToString() { Database database = Mockito.mock(Database.class); Mockito.when(database.value()).thenReturn(DatabaseType.COLUMN); Mockito.when(database.provider()).thenReturn("column"); @@ -47,7 +47,7 @@ public void shouldReturnToString() { } @Test - public void shouldReturnToString2() { + void shouldReturnToString2() { Database database = Mockito.mock(Database.class); Mockito.when(database.value()).thenReturn(DatabaseType.COLUMN); DatabaseMetadata metadata = DatabaseMetadata.of(database); From 81f3f6548d3f7f4a817df1705d96d91830f15c65 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:10 -0300 Subject: [PATCH 036/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/DatabaseQualifierTest.java | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseQualifierTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseQualifierTest.java index 057bb401f..202c4a356 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseQualifierTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseQualifierTest.java @@ -24,17 +24,17 @@ import static org.junit.jupiter.api.Assertions.assertEquals; -public class DatabaseQualifierTest { +class DatabaseQualifierTest { @Test - public void shouldReturnDefaultColumn() { + void shouldReturnDefaultColumn() { DatabaseQualifier qualifier = DatabaseQualifier.ofColumn(); assertEquals("", qualifier.provider()); assertEquals(COLUMN, qualifier.value()); } @Test - public void shouldReturnColumnProvider() { + void shouldReturnColumnProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofColumn(provider); assertEquals(provider, qualifier.provider()); @@ -42,19 +42,19 @@ public void shouldReturnColumnProvider() { } @Test - public void shouldReturnErrorWhenColumnNull() { + void shouldReturnErrorWhenColumnNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofColumn(null)); } @Test - public void shouldReturnDefaultDocument() { + void shouldReturnDefaultDocument() { DatabaseQualifier qualifier = DatabaseQualifier.ofDocument(); assertEquals("", qualifier.provider()); assertEquals(DOCUMENT, qualifier.value()); } @Test - public void shouldReturnDocumentProvider() { + void shouldReturnDocumentProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofDocument(provider); assertEquals(provider, qualifier.provider()); @@ -62,17 +62,17 @@ public void shouldReturnDocumentProvider() { } @Test - public void shouldReturnErrorWhenDocumentNull() { + void shouldReturnErrorWhenDocumentNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofDocument(null)); } @Test - public void shouldReturnErrorWhenKeyValueNull() { + void shouldReturnErrorWhenKeyValueNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofKeyValue(null)); } @Test - public void shouldReturnKeyValueProvider() { + void shouldReturnKeyValueProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofKeyValue(provider); assertEquals(provider, qualifier.provider()); @@ -80,7 +80,7 @@ public void shouldReturnKeyValueProvider() { } @Test - public void shouldReturnDefaultKeyValue() { + void shouldReturnDefaultKeyValue() { DatabaseQualifier qualifier = DatabaseQualifier.ofKeyValue(); assertEquals("", qualifier.provider()); assertEquals(KEY_VALUE, qualifier.value()); @@ -88,12 +88,12 @@ public void shouldReturnDefaultKeyValue() { @Test - public void shouldReturnErrorWhenGraphNull() { + void shouldReturnErrorWhenGraphNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofGraph(null)); } @Test - public void shouldReturnGraphProvider() { + void shouldReturnGraphProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofGraph(provider); assertEquals(provider, qualifier.provider()); @@ -101,7 +101,7 @@ public void shouldReturnGraphProvider() { } @Test - public void shouldReturnDefaultGraph() { + void shouldReturnDefaultGraph() { DatabaseQualifier qualifier = DatabaseQualifier.ofGraph(); assertEquals("", qualifier.provider()); assertEquals(GRAPH, qualifier.value()); From 6b6298e6ca4a1942beb2d86f7e0067e69080cd14 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:12 -0300 Subject: [PATCH 037/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/DatabaseQualifierTest.java | 27 +++++++++---------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DatabaseQualifierTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DatabaseQualifierTest.java index 067a37854..d8ed215c7 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DatabaseQualifierTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DatabaseQualifierTest.java @@ -21,18 +21,17 @@ import static org.eclipse.jnosql.mapping.DatabaseType.*; import static org.junit.jupiter.api.Assertions.assertEquals; - -public class DatabaseQualifierTest { +class DatabaseQualifierTest { @Test - public void shouldReturnDefaultColumn() { + void shouldReturnDefaultColumn() { DatabaseQualifier qualifier = DatabaseQualifier.ofColumn(); assertEquals("", qualifier.provider()); assertEquals(COLUMN, qualifier.value()); } @Test - public void shouldReturnColumnProvider() { + void shouldReturnColumnProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofColumn(provider); assertEquals(provider, qualifier.provider()); @@ -40,19 +39,19 @@ public void shouldReturnColumnProvider() { } @Test - public void shouldReturnErrorWhenColumnNull() { + void shouldReturnErrorWhenColumnNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofColumn(null)); } @Test - public void shouldReturnDefaultDocument() { + void shouldReturnDefaultDocument() { DatabaseQualifier qualifier = DatabaseQualifier.ofDocument(); assertEquals("", qualifier.provider()); assertEquals(DOCUMENT, qualifier.value()); } @Test - public void shouldReturnDocumentProvider() { + void shouldReturnDocumentProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofDocument(provider); assertEquals(provider, qualifier.provider()); @@ -60,17 +59,17 @@ public void shouldReturnDocumentProvider() { } @Test - public void shouldReturnErrorWhenDocumentNull() { + void shouldReturnErrorWhenDocumentNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofDocument(null)); } @Test - public void shouldReturnErrorWhenKeyValueNull() { + void shouldReturnErrorWhenKeyValueNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofKeyValue(null)); } @Test - public void shouldReturnKeyValueProvider() { + void shouldReturnKeyValueProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofKeyValue(provider); assertEquals(provider, qualifier.provider()); @@ -78,7 +77,7 @@ public void shouldReturnKeyValueProvider() { } @Test - public void shouldReturnDefaultKeyValue() { + void shouldReturnDefaultKeyValue() { DatabaseQualifier qualifier = DatabaseQualifier.ofKeyValue(); assertEquals("", qualifier.provider()); assertEquals(KEY_VALUE, qualifier.value()); @@ -86,12 +85,12 @@ public void shouldReturnDefaultKeyValue() { @Test - public void shouldReturnErrorWhenGraphNull() { + void shouldReturnErrorWhenGraphNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofGraph(null)); } @Test - public void shouldReturnGraphProvider() { + void shouldReturnGraphProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofGraph(provider); assertEquals(provider, qualifier.provider()); @@ -99,7 +98,7 @@ public void shouldReturnGraphProvider() { } @Test - public void shouldReturnDefaultGraph() { + void shouldReturnDefaultGraph() { DatabaseQualifier qualifier = DatabaseQualifier.ofGraph(); assertEquals("", qualifier.provider()); assertEquals(GRAPH, qualifier.value()); From 1b3c488778f9cb406caedb5e146b1eb6cac6b810 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:17 -0300 Subject: [PATCH 038/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/DatabaseQualifierTest.java | 27 +++++++++---------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseQualifierTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseQualifierTest.java index 057bb401f..dc3960a1f 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseQualifierTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/DatabaseQualifierTest.java @@ -23,18 +23,17 @@ import static org.eclipse.jnosql.mapping.DatabaseType.GRAPH; import static org.junit.jupiter.api.Assertions.assertEquals; - -public class DatabaseQualifierTest { +class DatabaseQualifierTest { @Test - public void shouldReturnDefaultColumn() { + void shouldReturnDefaultColumn() { DatabaseQualifier qualifier = DatabaseQualifier.ofColumn(); assertEquals("", qualifier.provider()); assertEquals(COLUMN, qualifier.value()); } @Test - public void shouldReturnColumnProvider() { + void shouldReturnColumnProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofColumn(provider); assertEquals(provider, qualifier.provider()); @@ -42,19 +41,19 @@ public void shouldReturnColumnProvider() { } @Test - public void shouldReturnErrorWhenColumnNull() { + void shouldReturnErrorWhenColumnNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofColumn(null)); } @Test - public void shouldReturnDefaultDocument() { + void shouldReturnDefaultDocument() { DatabaseQualifier qualifier = DatabaseQualifier.ofDocument(); assertEquals("", qualifier.provider()); assertEquals(DOCUMENT, qualifier.value()); } @Test - public void shouldReturnDocumentProvider() { + void shouldReturnDocumentProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofDocument(provider); assertEquals(provider, qualifier.provider()); @@ -62,17 +61,17 @@ public void shouldReturnDocumentProvider() { } @Test - public void shouldReturnErrorWhenDocumentNull() { + void shouldReturnErrorWhenDocumentNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofDocument(null)); } @Test - public void shouldReturnErrorWhenKeyValueNull() { + void shouldReturnErrorWhenKeyValueNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofKeyValue(null)); } @Test - public void shouldReturnKeyValueProvider() { + void shouldReturnKeyValueProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofKeyValue(provider); assertEquals(provider, qualifier.provider()); @@ -80,7 +79,7 @@ public void shouldReturnKeyValueProvider() { } @Test - public void shouldReturnDefaultKeyValue() { + void shouldReturnDefaultKeyValue() { DatabaseQualifier qualifier = DatabaseQualifier.ofKeyValue(); assertEquals("", qualifier.provider()); assertEquals(KEY_VALUE, qualifier.value()); @@ -88,12 +87,12 @@ public void shouldReturnDefaultKeyValue() { @Test - public void shouldReturnErrorWhenGraphNull() { + void shouldReturnErrorWhenGraphNull() { Assertions.assertThrows(NullPointerException.class, () -> DatabaseQualifier.ofGraph(null)); } @Test - public void shouldReturnGraphProvider() { + void shouldReturnGraphProvider() { String provider = "provider"; DatabaseQualifier qualifier = DatabaseQualifier.ofGraph(provider); assertEquals(provider, qualifier.provider()); @@ -101,7 +100,7 @@ public void shouldReturnGraphProvider() { } @Test - public void shouldReturnDefaultGraph() { + void shouldReturnDefaultGraph() { DatabaseQualifier qualifier = DatabaseQualifier.ofGraph(); assertEquals("", qualifier.provider()); assertEquals(GRAPH, qualifier.value()); From 62288448a00ce13283309aa67e01e4644823bc60 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:18 -0300 Subject: [PATCH 039/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../test/java/org/eclipse/jnosql/mapping/DatabasesTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabasesTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabasesTest.java index b3beed198..cf433d13b 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabasesTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DatabasesTest.java @@ -28,10 +28,10 @@ import static org.junit.jupiter.api.Assertions.*; import static org.mockito.Mockito.*; -public class DatabasesTest { +class DatabasesTest { @Test - public void shouldAddDatabaseValidDatabaseTypeAddsMetadataToSet() { + void shouldAddDatabaseValidDatabaseTypeAddsMetadataToSet() { ProcessProducer processProducer = mock(ProcessProducer.class); AnnotatedMember annotatedMember = mock(AnnotatedMember.class); DatabaseType type = DatabaseType.DOCUMENT; @@ -54,7 +54,7 @@ public void shouldAddDatabaseValidDatabaseTypeAddsMetadataToSet() { } @Test - public void shouldAddDatabase_NoDatabaseAnnotation_NoMetadataAdded() { + void shouldAddDatabase_NoDatabaseAnnotation_NoMetadataAdded() { ProcessProducer processProducer = mock(ProcessProducer.class); DatabaseType type = DatabaseType.DOCUMENT; AnnotatedMember annotatedMember = mock(AnnotatedMember.class); From ecb8303c27003fc5f11e2f7c00396bfc730d0ca0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:19 -0300 Subject: [PATCH 040/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/DefaultColumnConditionTest.java | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnConditionTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnConditionTest.java index 25485a45a..5af59c8c6 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnConditionTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnConditionTest.java @@ -31,17 +31,17 @@ import static org.junit.jupiter.api.Assertions.assertThrows; -public class DefaultColumnConditionTest { +class DefaultColumnConditionTest { private final ColumnCondition lte = ColumnCondition.lte(Column.of("salary", 10.32)); @Test - public void shouldReturnErrorWhenColumnIsNull() { + void shouldReturnErrorWhenColumnIsNull() { assertThrows(NullPointerException.class, () -> ColumnCondition.of(null, Condition.AND)); } @Test - public void shouldCreateAnInstance() { + void shouldCreateAnInstance() { Column name = Column.of("name", "Otavio"); ColumnCondition condition = ColumnCondition.of(name, Condition.EQUALS); assertNotNull(condition); @@ -50,7 +50,7 @@ public void shouldCreateAnInstance() { } @Test - public void shouldCreateNegationCondition() { + void shouldCreateNegationCondition() { Column age = Column.of("age", 26); ColumnCondition condition = ColumnCondition.of(age, Condition.GREATER_THAN); ColumnCondition negate = condition.negate(); @@ -61,7 +61,7 @@ public void shouldCreateNegationCondition() { } @Test - public void shouldReturnValidDoubleNegation() { + void shouldReturnValidDoubleNegation() { Column age = Column.of("age", 26); ColumnCondition condition = ColumnCondition.of(age, Condition.GREATER_THAN); ColumnCondition affirmative = condition.negate().negate(); @@ -69,7 +69,7 @@ public void shouldReturnValidDoubleNegation() { } @Test - public void shouldCreateAndCondition() { + void shouldCreateAndCondition() { Column age = Column.of("age", 26); Column name = Column.of("name", "Otavio"); ColumnCondition condition1 = ColumnCondition.of(name, Condition.EQUALS); @@ -85,7 +85,7 @@ public void shouldCreateAndCondition() { } @Test - public void shouldCreateOrCondition() { + void shouldCreateOrCondition() { Column age = Column.of("age", 26); Column name = Column.of("name", "Otavio"); ColumnCondition condition1 = ColumnCondition.of(name, Condition.EQUALS); @@ -101,19 +101,19 @@ public void shouldCreateOrCondition() { } @Test - public void shouldReturnErrorWhenCreateAndWithNullValues() { + void shouldReturnErrorWhenCreateAndWithNullValues() { assertThrows(NullPointerException.class, () -> ColumnCondition.and((ColumnCondition[]) null)); } @Test - public void shouldReturnErrorWhenCreateOrWithNullValues() { + void shouldReturnErrorWhenCreateOrWithNullValues() { assertThrows(NullPointerException.class, () -> ColumnCondition.or((ColumnCondition[]) null)); } @Test - public void shouldAppendAnd() { + void shouldAppendAnd() { ColumnCondition eq = ColumnCondition.eq(Column.of("name", "otavio")); ColumnCondition gt = ColumnCondition.gt(Column.of("age", 10)); ColumnCondition and = ColumnCondition.and(eq, gt); @@ -124,7 +124,7 @@ public void shouldAppendAnd() { } @Test - public void shouldAppendOr() { + void shouldAppendOr() { ColumnCondition eq = ColumnCondition.eq(Column.of("name", "otavio")); ColumnCondition gt = ColumnCondition.gt(Column.of("age", 10)); ColumnCondition and = ColumnCondition.or(eq, gt); @@ -135,7 +135,7 @@ public void shouldAppendOr() { } @Test - public void shouldAnd() { + void shouldAnd() { ColumnCondition eq = ColumnCondition.eq(Column.of("name", "otavio")); ColumnCondition gt = ColumnCondition.gt(Column.of("age", 10)); ColumnCondition lte = ColumnCondition.lte(Column.of("salary", 10_000.00)); @@ -154,7 +154,7 @@ public void shouldAnd() { } @Test - public void shouldOr() { + void shouldOr() { ColumnCondition eq = ColumnCondition.eq(Column.of("name", "otavio")); ColumnCondition gt = ColumnCondition.gt(Column.of("age", 10)); ColumnCondition lte = ColumnCondition.lte(Column.of("salary", 10_000.00)); @@ -173,7 +173,7 @@ public void shouldOr() { } @Test - public void shouldNegate() { + void shouldNegate() { ColumnCondition eq = ColumnCondition.eq(Column.of("name", "otavio")); ColumnCondition negate = eq.negate(); assertEquals(Condition.NOT, negate.condition()); @@ -182,7 +182,7 @@ public void shouldNegate() { } @Test - public void shouldAffirmDoubleNegate() { + void shouldAffirmDoubleNegate() { ColumnCondition eq = ColumnCondition.eq(Column.of("name", "otavio")); ColumnCondition affirm = eq.negate().negate(); assertEquals(eq.condition(), affirm.condition()); @@ -190,12 +190,12 @@ public void shouldAffirmDoubleNegate() { } @Test - public void shouldReturnErrorWhenBetweenIsNull() { + void shouldReturnErrorWhenBetweenIsNull() { assertThrows(NullPointerException.class, () -> ColumnCondition.between(null)); } @Test - public void shouldReturnErrorWhenBetweenIsNotIterable() { + void shouldReturnErrorWhenBetweenIsNotIterable() { assertThrows(IllegalArgumentException.class, () -> { Column column = Column.of("age", 12); ColumnCondition.between(column); @@ -203,7 +203,7 @@ public void shouldReturnErrorWhenBetweenIsNotIterable() { } @Test - public void shouldReturnErrorWhenIterableHasOneElement() { + void shouldReturnErrorWhenIterableHasOneElement() { assertThrows(IllegalArgumentException.class, () -> { Column column = Column.of("age", Collections.singleton(12)); ColumnCondition.between(column); @@ -211,7 +211,7 @@ public void shouldReturnErrorWhenIterableHasOneElement() { } @Test - public void shouldReturnErrorWhenIterableHasMoreThanTwoElement2() { + void shouldReturnErrorWhenIterableHasMoreThanTwoElement2() { assertThrows(IllegalArgumentException.class, () -> { Column column = Column.of("age", Arrays.asList(12, 12, 12)); ColumnCondition.between(column); @@ -219,7 +219,7 @@ public void shouldReturnErrorWhenIterableHasMoreThanTwoElement2() { } @Test - public void shouldReturnBetween() { + void shouldReturnBetween() { Column column = Column.of("age", Arrays.asList(12, 13)); ColumnCondition between = ColumnCondition.between(column); assertEquals(Condition.BETWEEN, between.condition()); @@ -229,13 +229,13 @@ public void shouldReturnBetween() { } @Test - public void shouldReturnErrorWhenInConditionIsInvalid() { + void shouldReturnErrorWhenInConditionIsInvalid() { assertThrows(NullPointerException.class, () -> ColumnCondition.in(null)); assertThrows(IllegalArgumentException.class, () -> ColumnCondition.in(Column.of("value", 10))); } @Test - public void shouldReturnInClause() { + void shouldReturnInClause() { Column column = Column.of("age", Arrays.asList(12, 13)); ColumnCondition in = ColumnCondition.in(column); assertEquals(Condition.IN, in.condition()); From 4e4ad9f2389a57b896cbeb64c1563da54962b39d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:20 -0300 Subject: [PATCH 041/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/column/DefaultColumnDeleteQueryTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnDeleteQueryTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnDeleteQueryTest.java index 71484974e..c9e132a73 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnDeleteQueryTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnDeleteQueryTest.java @@ -26,13 +26,13 @@ import static org.junit.jupiter.api.Assertions.assertTrue; -public class DefaultColumnDeleteQueryTest { +class DefaultColumnDeleteQueryTest { private ColumnDeleteQuery query; @BeforeEach - public void setUp() { + void setUp() { query = ColumnDeleteQuery.delete().from("columnFamily").build(); } From 070b697a25ec7c5bda5de8bef97417de4df3cef4 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:21 -0300 Subject: [PATCH 042/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/DefaultColumnQueryBuilderTest.java | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryBuilderTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryBuilderTest.java index 3b2c53196..79e25bf3c 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryBuilderTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryBuilderTest.java @@ -37,12 +37,12 @@ class DefaultColumnQueryBuilderTest { @Test - public void shouldReturnErrorWhenHasNullElementInSelect() { + void shouldReturnErrorWhenHasNullElementInSelect() { assertThrows(NullPointerException.class, () -> builder("document", "document'", null)); } @Test - public void shouldBuilder() { + void shouldBuilder() { String documentCollection = "documentCollection"; ColumnQuery query = builder().from(documentCollection).build(); assertTrue(query.columns().isEmpty()); @@ -51,7 +51,7 @@ public void shouldBuilder() { } @Test - public void shouldSelectDocument() { + void shouldSelectDocument() { String documentCollection = "documentCollection"; ColumnQuery query = builder("document", "document2").from(documentCollection).build(); assertThat(query.columns()).contains("document", "document2"); @@ -60,13 +60,13 @@ public void shouldSelectDocument() { } @Test - public void shouldReturnErrorWhenFromIsNull() { + void shouldReturnErrorWhenFromIsNull() { assertThrows(NullPointerException.class, () -> builder().from(null)); } @Test - public void shouldSelectOrderAsc() { + void shouldSelectOrderAsc() { String documentCollection = "documentCollection"; ColumnQuery query = builder().from(documentCollection).sort(Sort.asc("name")).build(); assertTrue(query.columns().isEmpty()); @@ -76,7 +76,7 @@ public void shouldSelectOrderAsc() { } @Test - public void shouldSelectOrderDesc() { + void shouldSelectOrderDesc() { String documentCollection = "documentCollection"; ColumnQuery query = builder().from(documentCollection).sort(Sort.desc("name")).build(); assertTrue(query.columns().isEmpty()); @@ -87,7 +87,7 @@ public void shouldSelectOrderDesc() { @Test - public void shouldReturnErrorSelectWhenOrderIsNull() { + void shouldReturnErrorSelectWhenOrderIsNull() { assertThrows(NullPointerException.class,() -> { String documentCollection = "documentCollection"; builder().from(documentCollection).sort((Sort) null); @@ -95,7 +95,7 @@ public void shouldReturnErrorSelectWhenOrderIsNull() { } @Test - public void shouldSelectLimit() { + void shouldSelectLimit() { String documentCollection = "documentCollection"; ColumnQuery query = builder().from(documentCollection).limit(10).build(); assertTrue(query.columns().isEmpty()); @@ -105,13 +105,13 @@ public void shouldSelectLimit() { } @Test - public void shouldReturnErrorWhenLimitIsNegative() { + void shouldReturnErrorWhenLimitIsNegative() { String documentCollection = "documentCollection"; Assertions.assertThrows(IllegalArgumentException.class, () -> builder().from(documentCollection).limit(-1)); } @Test - public void shouldSelectSkip() { + void shouldSelectSkip() { String documentCollection = "documentCollection"; ColumnQuery query = builder().from(documentCollection).skip(10).build(); assertTrue(query.columns().isEmpty()); @@ -121,13 +121,13 @@ public void shouldSelectSkip() { } @Test - public void shouldReturnErrorWhenSkipIsNegative() { + void shouldReturnErrorWhenSkipIsNegative() { String documentCollection = "documentCollection"; Assertions.assertThrows(IllegalArgumentException.class, () -> builder().from(documentCollection).skip(-1)); } @Test - public void shouldSelectWhereNameEq() { + void shouldSelectWhereNameEq() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; @@ -147,7 +147,7 @@ public void shouldSelectWhereNameEq() { } @Test - public void shouldSelectWhereNameLike() { + void shouldSelectWhereNameLike() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; ColumnQuery query = builder().from(documentCollection) @@ -165,7 +165,7 @@ public void shouldSelectWhereNameLike() { } @Test - public void shouldSelectWhereNameGt() { + void shouldSelectWhereNameGt() { String documentCollection = "documentCollection"; Number value = 10; @@ -184,7 +184,7 @@ public void shouldSelectWhereNameGt() { } @Test - public void shouldSelectWhereNameGte() { + void shouldSelectWhereNameGte() { String documentCollection = "documentCollection"; Number value = 10; ColumnCondition gteName = ColumnCondition.gte("name", value); @@ -201,7 +201,7 @@ public void shouldSelectWhereNameGte() { } @Test - public void shouldSelectWhereNameLt() { + void shouldSelectWhereNameLt() { String documentCollection = "documentCollection"; Number value = 10; @@ -219,7 +219,7 @@ public void shouldSelectWhereNameLt() { } @Test - public void shouldSelectWhereNameLte() { + void shouldSelectWhereNameLte() { String documentCollection = "documentCollection"; Number value = 10; ColumnQuery query = builder().from(documentCollection).where(ColumnCondition.lte("name", value)) @@ -236,7 +236,7 @@ public void shouldSelectWhereNameLte() { } @Test - public void shouldSelectWhereNameBetween() { + void shouldSelectWhereNameBetween() { String documentCollection = "documentCollection"; Number valueA = 10; Number valueB = 20; @@ -257,7 +257,7 @@ public void shouldSelectWhereNameBetween() { } @Test - public void shouldSelectWhereNameNot() { + void shouldSelectWhereNameNot() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; @@ -277,7 +277,7 @@ public void shouldSelectWhereNameNot() { @Test - public void shouldSelectWhereNameAnd() { + void shouldSelectWhereNameAnd() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; ColumnCondition nameEqualsAda = eq("name", name); @@ -296,7 +296,7 @@ public void shouldSelectWhereNameAnd() { } @Test - public void shouldSelectWhereNameOr() { + void shouldSelectWhereNameOr() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; ColumnCondition nameEqualsAda = eq("name", name); @@ -315,7 +315,7 @@ public void shouldSelectWhereNameOr() { @Test - public void shouldSelectNegate() { + void shouldSelectNegate() { String columnFamily = "columnFamily"; ColumnCondition nameNotEqualsLucas = eq("name", "Lucas").negate(); ColumnQuery query = builder().from(columnFamily) @@ -334,7 +334,7 @@ public void shouldSelectNegate() { @Test - public void shouldExecuteManager() { + void shouldExecuteManager() { ColumnManager manager = Mockito.mock(ColumnManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); String collection = "collection"; @@ -344,7 +344,7 @@ public void shouldExecuteManager() { } @Test - public void shouldExecuteSingleResultManager() { + void shouldExecuteSingleResultManager() { ColumnManager manager = Mockito.mock(ColumnManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); String collection = "collection"; From eaca8155c63890c811b2de3480bb59e5adde532a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:22 -0300 Subject: [PATCH 043/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/DefaultColumnQueryParserTest.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryParserTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryParserTest.java index 8407df013..ecac4342b 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryParserTest.java @@ -33,7 +33,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -public class DefaultColumnQueryParserTest { +class DefaultColumnQueryParserTest { private final ColumnQueryParser parser = new ColumnQueryParser(); @@ -41,20 +41,20 @@ public class DefaultColumnQueryParserTest { private final ColumnManager manager = Mockito.mock(ColumnManager.class); @Test - public void shouldReturnNPEWhenThereIsNullParameter() { + void shouldReturnNPEWhenThereIsNullParameter() { assertThrows(NullPointerException.class, () -> parser.query(null, manager, ColumnObserverParser.EMPTY)); assertThrows(NullPointerException.class, () -> parser.query("select * from God", null, ColumnObserverParser.EMPTY)); } @Test - public void shouldReturnErrorWhenHasInvalidQuery() { + void shouldReturnErrorWhenHasInvalidQuery() { assertThrows(QueryException.class, () -> parser.query("inva", manager, ColumnObserverParser.EMPTY)); assertThrows(QueryException.class, () -> parser.query("invalid", manager, ColumnObserverParser.EMPTY)); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, ColumnObserverParser.EMPTY); Mockito.verify(manager).select(captor.capture()); @@ -72,7 +72,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, ColumnObserverParser.EMPTY); Mockito.verify(manager).delete(captor.capture()); @@ -85,7 +85,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\")"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); parser.query(query, manager, ColumnObserverParser.EMPTY); Mockito.verify(manager).insert(captor.capture()); @@ -99,7 +99,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = \"Diana\")"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); parser.query(query, manager, ColumnObserverParser.EMPTY); Mockito.verify(manager).update(captor.capture()); @@ -112,7 +112,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); ColumnPreparedStatement prepare = parser.prepare(query, manager, ColumnObserverParser.EMPTY); @@ -129,7 +129,7 @@ public void shouldExecutePrepareStatement(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = @name)"}) - public void shouldExecutePrepareStatement1(String query) { + void shouldExecutePrepareStatement1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ColumnPreparedStatement prepare = parser.prepare(query, manager, ColumnObserverParser.EMPTY); prepare.bind("name", "Diana"); @@ -143,7 +143,7 @@ public void shouldExecutePrepareStatement1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldExecutePrepareStatement2(String query) { + void shouldExecutePrepareStatement2(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); ColumnPreparedStatement prepare = parser.prepare(query, manager, ColumnObserverParser.EMPTY); @@ -161,7 +161,7 @@ public void shouldExecutePrepareStatement2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = @name)"}) - public void shouldExecutePrepareStatement3(String query) { + void shouldExecutePrepareStatement3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ColumnPreparedStatement prepare = parser.prepare(query, manager, ColumnObserverParser.EMPTY); prepare.bind("name", "Diana"); @@ -174,7 +174,7 @@ public void shouldExecutePrepareStatement3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldSingleResult(String query) { + void shouldSingleResult(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); Mockito.when(manager.select(Mockito.any(ColumnQuery.class))) @@ -195,7 +195,7 @@ public void shouldSingleResult(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldReturnEmptySingleResult(String query) { + void shouldReturnEmptySingleResult(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); Mockito.when(manager.select(Mockito.any(ColumnQuery.class))) @@ -216,7 +216,7 @@ public void shouldReturnEmptySingleResult(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldReturnErrorSingleResult(String query) { + void shouldReturnErrorSingleResult(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); Mockito.when(manager.select(Mockito.any(ColumnQuery.class))) From f002877a8c3928d1bd2ac7ea978e80e75fdca75a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:23 -0300 Subject: [PATCH 044/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/column/DefaultColumnQueryTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryTest.java index 19a4456cd..2021e84ed 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultColumnQueryTest.java @@ -29,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; -public class DefaultColumnQueryTest { +class DefaultColumnQueryTest { private ColumnQuery query; From 8efbd6c7e21363080913efac7fa3bd6a2476aac3 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:24 -0300 Subject: [PATCH 045/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/query/DefaultColumnRepositoryProducerTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/DefaultColumnRepositoryProducerTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/DefaultColumnRepositoryProducerTest.java index dfd4648fa..be9864b05 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/DefaultColumnRepositoryProducerTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/DefaultColumnRepositoryProducerTest.java @@ -44,7 +44,7 @@ class DefaultColumnRepositoryProducerTest { @Test - public void shouldCreateFromManager() { + void shouldCreateFromManager() { ColumnManager manager= Mockito.mock(ColumnManager.class); PersonRepository personRepository = producer.get(PersonRepository.class, manager); assertNotNull(personRepository); @@ -52,7 +52,7 @@ public void shouldCreateFromManager() { @Test - public void shouldCreateFromTemplate() { + void shouldCreateFromTemplate() { JNoSQLColumnTemplate template= Mockito.mock(JNoSQLColumnTemplate.class); PersonRepository personRepository = producer.get(PersonRepository.class, template); assertNotNull(personRepository); From f1962dd454e1a6684b43fa26d3e6b375289df916 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:25 -0300 Subject: [PATCH 046/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/DefaultColumnTemplateProducerTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DefaultColumnTemplateProducerTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DefaultColumnTemplateProducerTest.java index 2e8e53c7d..a83a10cdd 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DefaultColumnTemplateProducerTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DefaultColumnTemplateProducerTest.java @@ -35,18 +35,18 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, ColumnExtension.class}) -public class DefaultColumnTemplateProducerTest { +class DefaultColumnTemplateProducerTest { @Inject private ColumnTemplateProducer producer; @Test - public void shouldReturnErrorWhenColumnManagerNull() { + void shouldReturnErrorWhenColumnManagerNull() { Assertions.assertThrows(NullPointerException.class, () -> producer.apply(null)); } @Test - public void shouldReturn() { + void shouldReturn() { ColumnManager manager = Mockito.mock(ColumnManager.class); ColumnTemplate columnTemplate = producer.apply(manager); assertNotNull(columnTemplate); From 24bd52d4faf8bb698975cc6c1cc31ea1288a4f27 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:26 -0300 Subject: [PATCH 047/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/DefaultColumnTemplateTest.java | 64 +++++++++---------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DefaultColumnTemplateTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DefaultColumnTemplateTest.java index 74162ab76..a65955ad6 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DefaultColumnTemplateTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/DefaultColumnTemplateTest.java @@ -60,7 +60,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, ColumnExtension.class}) -public class DefaultColumnTemplateTest { +class DefaultColumnTemplateTest { private final Person person = Person.builder(). withAge(). @@ -95,7 +95,7 @@ public class DefaultColumnTemplateTest { @SuppressWarnings("unchecked") @BeforeEach - public void setUp() { + void setUp() { managerMock = Mockito.mock(ColumnManager.class); columnEventPersistManager = Mockito.mock(ColumnEventPersistManager.class); captor = ArgumentCaptor.forClass(ColumnEntity.class); @@ -106,7 +106,7 @@ public void setUp() { } @Test - public void shouldInsert() { + void shouldInsert() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -125,7 +125,7 @@ public void shouldInsert() { @Test - public void shouldMergeOnInsert() { + void shouldMergeOnInsert() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -147,7 +147,7 @@ public void shouldMergeOnInsert() { @Test - public void shouldInsertTTL() { + void shouldInsertTTL() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -166,7 +166,7 @@ public void shouldInsertTTL() { } @Test - public void shouldUpdate() { + void shouldUpdate() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -184,7 +184,7 @@ public void shouldUpdate() { } @Test - public void shouldMergeOnUpdate() { + void shouldMergeOnUpdate() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -203,7 +203,7 @@ public void shouldMergeOnUpdate() { } @Test - public void shouldInsertEntitiesTTL() { + void shouldInsertEntitiesTTL() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); Duration duration = Duration.ofHours(2); @@ -217,7 +217,7 @@ public void shouldInsertEntitiesTTL() { } @Test - public void shouldInsertEntities() { + void shouldInsertEntities() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -230,7 +230,7 @@ public void shouldInsertEntities() { } @Test - public void shouldUpdateEntities() { + void shouldUpdateEntities() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -243,7 +243,7 @@ public void shouldUpdateEntities() { } @Test - public void shouldDelete() { + void shouldDelete() { ColumnDeleteQuery query = delete().from("delete").build(); template.delete(query); @@ -251,28 +251,28 @@ public void shouldDelete() { } @Test - public void shouldSelect() { + void shouldSelect() { ColumnQuery query = select().from("person").build(); template.select(query); verify(managerMock).select(query); } @Test - public void shouldCountBy() { + void shouldCountBy() { ColumnQuery query = select().from("person").build(); template.count(query); verify(managerMock).count(query); } @Test - public void shouldExist() { + void shouldExist() { ColumnQuery query = select().from("person").build(); template.exists(query); verify(managerMock).exists(query); } @Test - public void shouldReturnSingleResult() { + void shouldReturnSingleResult() { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -287,7 +287,7 @@ public void shouldReturnSingleResult() { } @Test - public void shouldReturnSingleResultIsEmpty() { + void shouldReturnSingleResultIsEmpty() { Mockito.when(managerMock .select(any(ColumnQuery.class))) .thenReturn(Stream.empty()); @@ -299,7 +299,7 @@ public void shouldReturnSingleResultIsEmpty() { } @Test - public void shouldReturnErrorWhenThereMoreThanASingleResult() { + void shouldReturnErrorWhenThereMoreThanASingleResult() { Assertions.assertThrows(NonUniqueResultException.class, () -> { ColumnEntity columnEntity = ColumnEntity.of("Person"); columnEntity.addAll(Stream.of(columns).collect(Collectors.toList())); @@ -316,22 +316,22 @@ public void shouldReturnErrorWhenThereMoreThanASingleResult() { @Test - public void shouldReturnErrorWhenFindIdHasIdNull() { + void shouldReturnErrorWhenFindIdHasIdNull() { Assertions.assertThrows(NullPointerException.class, () -> template.find(Person.class, null)); } @Test - public void shouldReturnErrorWhenFindIdHasClassNull() { + void shouldReturnErrorWhenFindIdHasClassNull() { Assertions.assertThrows(NullPointerException.class, () -> template.find(null, "10")); } @Test - public void shouldReturnErrorWhenThereIsNotIdInFind() { + void shouldReturnErrorWhenThereIsNotIdInFind() { Assertions.assertThrows(IdNotFoundException.class, () -> template.find(Job.class, "10")); } @Test - public void shouldReturnFind() { + void shouldReturnFind() { template.find(Person.class, "10"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -343,7 +343,7 @@ public void shouldReturnFind() { } @Test - public void shouldDeleteEntity() { + void shouldDeleteEntity() { template.delete(Person.class, "10"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); verify(managerMock).delete(queryCaptor.capture()); @@ -357,7 +357,7 @@ public void shouldDeleteEntity() { } @Test - public void shouldExecuteQuery() { + void shouldExecuteQuery() { template.query("select * from Person"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -366,7 +366,7 @@ public void shouldExecuteQuery() { } @Test - public void shouldConvertEntity() { + void shouldConvertEntity() { template.query("select * from Movie"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -375,7 +375,7 @@ public void shouldConvertEntity() { } @Test - public void shouldConvertEntityName() { + void shouldConvertEntityName() { template.query("select * from download"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -383,7 +383,7 @@ public void shouldConvertEntityName() { assertEquals("download", query.name()); } @Test - public void shouldConvertEntityNameClassName() { + void shouldConvertEntityNameClassName() { template.query("select * from " + Person.class.getName()); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -392,7 +392,7 @@ public void shouldConvertEntityNameClassName() { } @Test - public void shouldConvertConvertFromAnnotationEntity(){ + void shouldConvertConvertFromAnnotationEntity(){ template.query("select * from Vendor" ); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -401,7 +401,7 @@ public void shouldConvertConvertFromAnnotationEntity(){ } @Test - public void shouldPreparedStatement() { + void shouldPreparedStatement() { PreparedStatement preparedStatement = template.prepare("select * from Person where name = @name"); preparedStatement.bind("name", "Ada"); preparedStatement.result(); @@ -412,26 +412,26 @@ public void shouldPreparedStatement() { } @Test - public void shouldCount() { + void shouldCount() { template.count("Person"); verify(managerMock).count("Person"); } @Test - public void shouldCountFromEntityClass() { + void shouldCountFromEntityClass() { template.count(Person.class); verify(managerMock).count("Person"); } @Test - public void shouldFindAll(){ + void shouldFindAll(){ template.findAll(Person.class); verify(managerMock).select(select().from("Person").build()); } @Test - public void shouldDeleteAll(){ + void shouldDeleteAll(){ template.deleteAll(Person.class); verify(managerMock).delete(delete().from("Person").build()); } From 3069837e6bad572de42eec4fba5f2a1179a6f591 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:28 -0300 Subject: [PATCH 048/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../query/DefaultConditionQueryValueTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DefaultConditionQueryValueTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DefaultConditionQueryValueTest.java index 750debcde..bcf5b3d33 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DefaultConditionQueryValueTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DefaultConditionQueryValueTest.java @@ -28,13 +28,13 @@ class DefaultConditionQueryValueTest { private QueryValue queryValue; @BeforeEach - public void setUp() { + void setUp() { this.queryValue = BooleanQueryValue.TRUE; this.condition = new DefaultQueryCondition("active", Condition.EQUALS, queryValue); } @Test - public void shouldReturnType() { + void shouldReturnType() { ConditionQueryValue conditionQueryValue = ConditionQueryValue.of(List.of(condition)); Assertions.assertThat(conditionQueryValue).isNotNull() .extracting(ConditionQueryValue::type) @@ -42,7 +42,7 @@ public void shouldReturnType() { } @Test - public void shouldGet() { + void shouldGet() { ConditionQueryValue conditionQueryValue = ConditionQueryValue.of(List.of(condition)); Assertions.assertThat(conditionQueryValue).isNotNull() .extracting(ConditionQueryValue::get) @@ -50,14 +50,14 @@ public void shouldGet() { } @Test - public void shouldEquals(){ + void shouldEquals(){ ConditionQueryValue conditionQueryValue = ConditionQueryValue.of(List.of(condition)); assertEquals(conditionQueryValue, ConditionQueryValue.of(List.of(condition))); } @Test - public void shouldHashCode(){ + void shouldHashCode(){ ConditionQueryValue conditionQueryValue = ConditionQueryValue.of(List.of(condition)); assertEquals(conditionQueryValue.hashCode(), ConditionQueryValue.of(List.of(condition)).hashCode()); From 7a101fac76313b6eba0115f5fa235fe4b31a8513 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:29 -0300 Subject: [PATCH 049/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/DefaultConstructorBuilderTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultConstructorBuilderTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultConstructorBuilderTest.java index e594dddf8..17e878cdd 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultConstructorBuilderTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultConstructorBuilderTest.java @@ -37,20 +37,20 @@ class DefaultConstructorBuilderTest { private ConstructorMetadata constructor; @BeforeEach - public void setUp(){ + void setUp(){ ClassConverter converter = new ReflectionClassConverter(); EntityMetadata entityMetadata = converter.apply(BookUser.class); this.constructor = entityMetadata.constructor(); } @Test - public void shouldToString(){ + void shouldToString(){ ConstructorBuilder builder = DefaultConstructorBuilder.of(constructor); assertThat(builder.toString()).isNotEmpty().isNotBlank().isNotNull(); } @Test - public void shouldCreateEmpty(){ + void shouldCreateEmpty(){ ConstructorBuilder builder = DefaultConstructorBuilder.of(constructor); builder.addEmptyParameter(); builder.addEmptyParameter(); @@ -66,7 +66,7 @@ public void shouldCreateEmpty(){ @Test - public void shouldCreateWithValues(){ + void shouldCreateWithValues(){ ConstructorBuilder builder = DefaultConstructorBuilder.of(constructor); builder.add("id"); builder.add("name"); @@ -82,7 +82,7 @@ public void shouldCreateWithValues(){ } @Test - public void shouldParameters(){ + void shouldParameters(){ ConstructorBuilder builder = DefaultConstructorBuilder.of(constructor); builder.add("id"); builder.add("name"); @@ -92,7 +92,7 @@ public void shouldParameters(){ } @Test - public void shouldEqualsHashCode(){ + void shouldEqualsHashCode(){ ConstructorBuilder builder = DefaultConstructorBuilder.of(constructor); ConstructorBuilder other = DefaultConstructorBuilder.of(constructor); assertThat(builder).isEqualTo(other); From dd375120b7250d2122a5750f49b06d7257de1a4a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:29 -0300 Subject: [PATCH 050/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/DefaultDeleteQueryBuilderTest.java | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultDeleteQueryBuilderTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultDeleteQueryBuilderTest.java index 5f682268d..6004bbc71 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultDeleteQueryBuilderTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultDeleteQueryBuilderTest.java @@ -34,15 +34,15 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import static org.mockito.Mockito.verify; -public class DefaultDeleteQueryBuilderTest { +class DefaultDeleteQueryBuilderTest { @Test - public void shouldReturnErrorWhenHasNullElementInSelect() { + void shouldReturnErrorWhenHasNullElementInSelect() { Assertions.assertThrows(NullPointerException.class, () -> delete("column", "column", null)); } @Test - public void shouldDelete() { + void shouldDelete() { String columnFamily = "columnFamily"; ColumnDeleteQuery query = delete().from(columnFamily).build(); assertTrue(query.columns().isEmpty()); @@ -51,7 +51,7 @@ public void shouldDelete() { } @Test - public void shouldDeleteColumns() { + void shouldDeleteColumns() { String columnFamily = "columnFamily"; ColumnDeleteQuery query = delete("column", "column2").from(columnFamily).build(); assertThat(query.columns()).contains("column", "column2"); @@ -61,13 +61,13 @@ public void shouldDeleteColumns() { @Test - public void shouldReturnErrorWhenFromIsNull() { + void shouldReturnErrorWhenFromIsNull() { Assertions.assertThrows(NullPointerException.class, () -> delete().from(null)); } @Test - public void shouldSelectWhereNameEq() { + void shouldSelectWhereNameEq() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnDeleteQuery query = delete().from(columnFamily).where("name").eq(name).build(); @@ -84,7 +84,7 @@ public void shouldSelectWhereNameEq() { } @Test - public void shouldSelectWhereNameLike() { + void shouldSelectWhereNameLike() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnDeleteQuery query = delete().from(columnFamily).where("name").like(name).build(); @@ -100,7 +100,7 @@ public void shouldSelectWhereNameLike() { } @Test - public void shouldSelectWhereNameGt() { + void shouldSelectWhereNameGt() { String columnFamily = "columnFamily"; Number value = 10; ColumnDeleteQuery query = delete().from(columnFamily).where("name").gt(value).build(); @@ -116,7 +116,7 @@ public void shouldSelectWhereNameGt() { } @Test - public void shouldSelectWhereNameGte() { + void shouldSelectWhereNameGte() { String columnFamily = "columnFamily"; Number value = 10; ColumnDeleteQuery query = delete().from(columnFamily).where("name").gte(value).build(); @@ -132,7 +132,7 @@ public void shouldSelectWhereNameGte() { } @Test - public void shouldSelectWhereNameLt() { + void shouldSelectWhereNameLt() { String columnFamily = "columnFamily"; Number value = 10; ColumnDeleteQuery query = delete().from(columnFamily).where("name").lt(value).build(); @@ -148,7 +148,7 @@ public void shouldSelectWhereNameLt() { } @Test - public void shouldSelectWhereNameLte() { + void shouldSelectWhereNameLte() { String columnFamily = "columnFamily"; Number value = 10; ColumnDeleteQuery query = delete().from(columnFamily).where("name").lte(value).build(); @@ -164,7 +164,7 @@ public void shouldSelectWhereNameLte() { } @Test - public void shouldSelectWhereNameBetween() { + void shouldSelectWhereNameBetween() { String columnFamily = "columnFamily"; Number valueA = 10; Number valueB = 20; @@ -182,7 +182,7 @@ public void shouldSelectWhereNameBetween() { } @Test - public void shouldSelectWhereNameNot() { + void shouldSelectWhereNameNot() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnDeleteQuery query = delete().from(columnFamily).where("name").not().eq(name).build(); @@ -200,7 +200,7 @@ public void shouldSelectWhereNameNot() { @Test - public void shouldSelectWhereNameAnd() { + void shouldSelectWhereNameAnd() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnDeleteQuery query = delete().from(columnFamily).where("name").eq(name).and("age").gt(10).build(); @@ -215,7 +215,7 @@ public void shouldSelectWhereNameAnd() { } @Test - public void shouldSelectWhereNameOr() { + void shouldSelectWhereNameOr() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnDeleteQuery query = delete().from(columnFamily).where("name").eq(name).or("age").gt(10).build(); @@ -230,7 +230,7 @@ public void shouldSelectWhereNameOr() { } @Test - public void shouldDeleteNegate() { + void shouldDeleteNegate() { String columnFamily = "columnFamily"; ColumnDeleteQuery query = delete().from(columnFamily).where("city").not().eq("Assis") .and("name").not().eq("Lucas").build(); @@ -249,7 +249,7 @@ public void shouldDeleteNegate() { } @Test - public void shouldExecuteDelete() { + void shouldExecuteDelete() { String columnFamily = "columnFamily"; ColumnManager manager = Mockito.mock(ColumnManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); From 97a7791c6cca06ca4928c08e179f6bead2869492 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:30 -0300 Subject: [PATCH 051/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/document/DefaultDocumentDeleteQueryTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultDocumentDeleteQueryTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultDocumentDeleteQueryTest.java index ed508cca5..313bfabc0 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultDocumentDeleteQueryTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultDocumentDeleteQueryTest.java @@ -27,7 +27,7 @@ import static org.eclipse.jnosql.communication.document.DocumentDeleteQuery.delete; import static org.junit.jupiter.api.Assertions.assertTrue; -public class DefaultDocumentDeleteQueryTest { +class DefaultDocumentDeleteQueryTest { private DocumentDeleteQuery query; From 7d7211d10ab02d1007a5e1afae1606baabc36902 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:31 -0300 Subject: [PATCH 052/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/document/DefaultDocumentQueryTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultDocumentQueryTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultDocumentQueryTest.java index 6103b4e97..629681348 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultDocumentQueryTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultDocumentQueryTest.java @@ -30,14 +30,14 @@ import static org.junit.jupiter.api.Assertions.assertTrue; -public class DefaultDocumentQueryTest { +class DefaultDocumentQueryTest { private DocumentQuery query; @BeforeEach - public void setUp() { + void setUp() { query = select().from("columnFamily").build(); } From c5b53165943eb81fe9a337518e13a6fa4381573d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:32 -0300 Subject: [PATCH 053/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DefaultDocumentTemplateProducerTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DefaultDocumentTemplateProducerTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DefaultDocumentTemplateProducerTest.java index bcc414ffb..586b4bc3b 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DefaultDocumentTemplateProducerTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DefaultDocumentTemplateProducerTest.java @@ -36,19 +36,19 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, DocumentExtension.class}) -public class DefaultDocumentTemplateProducerTest { +class DefaultDocumentTemplateProducerTest { @Inject private DocumentTemplateProducer producer; @Test - public void shouldReturnErrorWhenManagerNull() { + void shouldReturnErrorWhenManagerNull() { Assertions.assertThrows(NullPointerException.class, () -> producer.get(null)); } @Test - public void shouldReturn() { + void shouldReturn() { DocumentManager manager = Mockito.mock(DocumentManager.class); DocumentTemplate documentTemplate = producer.get(manager); assertNotNull(documentTemplate); From 0479e01cdcf3d026e4b2b970be1fa3c5d5aeda0c Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:33 -0300 Subject: [PATCH 054/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DefaultDocumentTemplateTest.java | 64 +++++++++---------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DefaultDocumentTemplateTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DefaultDocumentTemplateTest.java index 2a47aeeb7..58fcfac1f 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DefaultDocumentTemplateTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DefaultDocumentTemplateTest.java @@ -59,7 +59,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, DocumentExtension.class}) -public class DefaultDocumentTemplateTest { +class DefaultDocumentTemplateTest { private final Person person = Person.builder(). withAge(). @@ -94,7 +94,7 @@ public class DefaultDocumentTemplateTest { private DocumentEventPersistManager documentEventPersistManager; @BeforeEach - public void setUp() { + void setUp() { managerMock = Mockito.mock(DocumentManager.class); documentEventPersistManager = Mockito.mock(DocumentEventPersistManager.class); captor = ArgumentCaptor.forClass(DocumentEntity.class); @@ -105,7 +105,7 @@ public void setUp() { } @Test - public void shouldInsert() { + void shouldInsert() { DocumentEntity document = DocumentEntity.of("Person"); document.addAll(Stream.of(documents).collect(Collectors.toList())); @@ -123,7 +123,7 @@ public void shouldInsert() { } @Test - public void shouldMergeOnInsert() { + void shouldMergeOnInsert() { DocumentEntity document = DocumentEntity.of("Person"); document.addAll(Stream.of(documents).collect(Collectors.toList())); @@ -143,7 +143,7 @@ public void shouldMergeOnInsert() { @Test - public void shouldSaveTTL() { + void shouldSaveTTL() { Duration twoHours = Duration.ofHours(2L); @@ -165,7 +165,7 @@ public void shouldSaveTTL() { @Test - public void shouldUpdate() { + void shouldUpdate() { DocumentEntity document = DocumentEntity.of("Person"); document.addAll(Stream.of(documents).collect(Collectors.toList())); @@ -183,7 +183,7 @@ public void shouldUpdate() { } @Test - public void shouldMergeOnUpdate() { + void shouldMergeOnUpdate() { DocumentEntity document = DocumentEntity.of("Person"); document.addAll(Stream.of(documents).collect(Collectors.toList())); @@ -205,7 +205,7 @@ public void shouldMergeOnUpdate() { @Test - public void shouldInsertEntitiesTTL() { + void shouldInsertEntitiesTTL() { DocumentEntity documentEntity = DocumentEntity.of("Person"); documentEntity.addAll(Stream.of(documents).collect(Collectors.toList())); Duration duration = Duration.ofHours(2); @@ -219,7 +219,7 @@ public void shouldInsertEntitiesTTL() { } @Test - public void shouldInsertEntities() { + void shouldInsertEntities() { DocumentEntity documentEntity = DocumentEntity.of("Person"); documentEntity.addAll(Stream.of(documents).collect(Collectors.toList())); @@ -232,7 +232,7 @@ public void shouldInsertEntities() { } @Test - public void shouldUpdateEntities() { + void shouldUpdateEntities() { DocumentEntity documentEntity = DocumentEntity.of("Person"); documentEntity.addAll(Stream.of(documents).collect(Collectors.toList())); @@ -246,7 +246,7 @@ public void shouldUpdateEntities() { @Test - public void shouldDelete() { + void shouldDelete() { DocumentDeleteQuery query = delete().from("delete").build(); template.delete(query); @@ -254,21 +254,21 @@ public void shouldDelete() { } @Test - public void shouldSelect() { + void shouldSelect() { DocumentQuery query = select().from("Person").build(); template.select(query); verify(managerMock).select(query); } @Test - public void shouldCountBy() { + void shouldCountBy() { DocumentQuery query = select().from("Person").where("age").gt(10).build(); template.count(query); verify(managerMock).count(query); } @Test - public void shouldGroupBy() { + void shouldGroupBy() { DocumentQuery query = select().from("Person").where("age").gt(10) .limit(1).build(); template.count(query); @@ -276,7 +276,7 @@ public void shouldGroupBy() { } @Test - public void shouldReturnSingleResult() { + void shouldReturnSingleResult() { DocumentEntity documentEntity = DocumentEntity.of("Person"); documentEntity.addAll(Stream.of(documents).collect(Collectors.toList())); @@ -291,7 +291,7 @@ public void shouldReturnSingleResult() { } @Test - public void shouldReturnSingleResultIsEmpty() { + void shouldReturnSingleResultIsEmpty() { Mockito.when(managerMock .select(any(DocumentQuery.class))) .thenReturn(Stream.empty()); @@ -303,7 +303,7 @@ public void shouldReturnSingleResultIsEmpty() { } @Test - public void shouldReturnErrorWhenThereMoreThanASingleResult() { + void shouldReturnErrorWhenThereMoreThanASingleResult() { Assertions.assertThrows(NonUniqueResultException.class, () -> { DocumentEntity documentEntity = DocumentEntity.of("Person"); documentEntity.addAll(Stream.of(documents).collect(Collectors.toList())); @@ -319,22 +319,22 @@ public void shouldReturnErrorWhenThereMoreThanASingleResult() { } @Test - public void shouldReturnErrorWhenFindIdHasIdNull() { + void shouldReturnErrorWhenFindIdHasIdNull() { Assertions.assertThrows(NullPointerException.class, () -> template.find(Person.class, null)); } @Test - public void shouldReturnErrorWhenFindIdHasClassNull() { + void shouldReturnErrorWhenFindIdHasClassNull() { Assertions.assertThrows(NullPointerException.class, () -> template.find(null, "10")); } @Test - public void shouldReturnErrorWhenThereIsNotIdInFind() { + void shouldReturnErrorWhenThereIsNotIdInFind() { Assertions.assertThrows(IdNotFoundException.class, () -> template.find(Job.class, "10")); } @Test - public void shouldReturnFind() { + void shouldReturnFind() { template.find(Person.class, "10"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DocumentQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -347,7 +347,7 @@ public void shouldReturnFind() { } @Test - public void shouldDeleteEntity() { + void shouldDeleteEntity() { template.delete(Person.class, "10"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); verify(managerMock).delete(queryCaptor.capture()); @@ -361,7 +361,7 @@ public void shouldDeleteEntity() { @Test - public void shouldExecuteQuery() { + void shouldExecuteQuery() { template.query("select * from Person"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DocumentQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -370,7 +370,7 @@ public void shouldExecuteQuery() { } @Test - public void shouldConvertEntity() { + void shouldConvertEntity() { template.query("select * from Movie"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DocumentQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -380,7 +380,7 @@ public void shouldConvertEntity() { @Test - public void shouldConvertEntityName() { + void shouldConvertEntityName() { template.query("select * from download"); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DocumentQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -388,7 +388,7 @@ public void shouldConvertEntityName() { assertEquals("download", query.name()); } @Test - public void shouldConvertEntityNameClassName() { + void shouldConvertEntityNameClassName() { template.query("select * from " + Person.class.getName()); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DocumentQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -397,7 +397,7 @@ public void shouldConvertEntityNameClassName() { } @Test - public void shouldConvertConvertFromAnnotationEntity(){ + void shouldConvertConvertFromAnnotationEntity(){ template.query("select * from Vendor" ); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DocumentQuery.class); verify(managerMock).select(queryCaptor.capture()); @@ -406,7 +406,7 @@ public void shouldConvertConvertFromAnnotationEntity(){ } @Test - public void shouldPreparedStatement() { + void shouldPreparedStatement() { PreparedStatement preparedStatement = template.prepare("select * from Person where name = @name"); preparedStatement.bind("name", "Ada"); preparedStatement.result(); @@ -417,25 +417,25 @@ public void shouldPreparedStatement() { } @Test - public void shouldCount() { + void shouldCount() { template.count("Person"); verify(managerMock).count("Person"); } @Test - public void shouldCountFromEntityClass() { + void shouldCountFromEntityClass() { template.count(Person.class); verify(managerMock).count("Person"); } @Test - public void shouldFindAll(){ + void shouldFindAll(){ template.findAll(Person.class); verify(managerMock).select(select().from("Person").build()); } @Test - public void shouldDeleteAll(){ + void shouldDeleteAll(){ template.deleteAll(Person.class); verify(managerMock).delete(delete().from("Person").build()); } From ef66bc1b66b03d9340d78272fa7e38e99342f8b6 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:33 -0300 Subject: [PATCH 055/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../graph/DefaultEdgeTraversalTest.java | 96 +++++++++---------- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultEdgeTraversalTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultEdgeTraversalTest.java index bb28f6116..fb825af9d 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultEdgeTraversalTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultEdgeTraversalTest.java @@ -47,15 +47,15 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class DefaultEdgeTraversalTest extends AbstractTraversalTest { +class DefaultEdgeTraversalTest extends AbstractTraversalTest { @Test - public void shouldReturnErrorWhenEdgeIdIsNull() { + void shouldReturnErrorWhenEdgeIdIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalEdge(null)); } @Test - public void shouldReturnEdgeId() { + void shouldReturnEdgeId() { Optional edgeEntity = graphTemplate.traversalEdge(reads.id()) .next(); @@ -64,7 +64,7 @@ public void shouldReturnEdgeId() { } @Test - public void shouldReturnOutE() { + void shouldReturnOutE() { List edges = graphTemplate.traversalVertex().outE(READS) .stream() .collect(toList()); @@ -74,7 +74,7 @@ public void shouldReturnOutE() { } @Test - public void shouldReturnOutEWithSupplier() { + void shouldReturnOutEWithSupplier() { List edges = graphTemplate.traversalVertex().outE(() -> READS) .stream() .collect(toList()); @@ -84,14 +84,14 @@ public void shouldReturnOutEWithSupplier() { } @Test - public void shouldReturnErrorOutEWhenIsNull() { + void shouldReturnErrorOutEWhenIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().outE((String) null) .stream() .collect(toList())); } @Test - public void shouldReturnInE() { + void shouldReturnInE() { List edges = graphTemplate.traversalVertex().inE(READS) .stream() .collect(toList()); @@ -101,7 +101,7 @@ public void shouldReturnInE() { } @Test - public void shouldReturnInEWitSupplier() { + void shouldReturnInEWitSupplier() { List edges = graphTemplate.traversalVertex().inE(() -> READS) .stream() .collect(toList()); @@ -112,7 +112,7 @@ public void shouldReturnInEWitSupplier() { @Test - public void shouldReturnErrorWhenInEIsNull() { + void shouldReturnErrorWhenInEIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().inE((String) null) .stream() .collect(toList())); @@ -120,7 +120,7 @@ public void shouldReturnErrorWhenInEIsNull() { } @Test - public void shouldReturnBothE() { + void shouldReturnBothE() { List edges = graphTemplate.traversalVertex().bothE(READS) .stream() .toList(); @@ -129,7 +129,7 @@ public void shouldReturnBothE() { } @Test - public void shouldReturnBothEWithSupplier() { + void shouldReturnBothEWithSupplier() { List edges = graphTemplate.traversalVertex().bothE(() -> READS) .stream() .toList(); @@ -138,7 +138,7 @@ public void shouldReturnBothEWithSupplier() { } @Test - public void shouldReturnErrorWhenBothEIsNull() { + void shouldReturnErrorWhenBothEIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().bothE((String) null) .stream() .collect(toList())); @@ -146,14 +146,14 @@ public void shouldReturnErrorWhenBothEIsNull() { @Test - public void shouldReturnOut() { + void shouldReturnOut() { List people = graphTemplate.traversalVertex().outE(READS).outV().result().collect(toList()); assertEquals(3, people.size()); assertThat(people).contains(poliana, otavio, paulo); } @Test - public void shouldReturnIn() { + void shouldReturnIn() { List books = graphTemplate.traversalVertex().outE(READS).inV().result().collect(toList()); assertEquals(3, books.size()); assertThat(books).contains(shack, effectiveJava, license); @@ -161,7 +161,7 @@ public void shouldReturnIn() { @Test - public void shouldReturnBoth() { + void shouldReturnBoth() { List entities = graphTemplate.traversalVertex().outE(READS).bothV().result().collect(toList()); assertEquals(6, entities.size()); assertThat(entities).contains(shack, effectiveJava, license, paulo, otavio, poliana); @@ -169,7 +169,7 @@ public void shouldReturnBoth() { @Test - public void shouldHasPropertyFromAccessor() { + void shouldHasPropertyFromAccessor() { Optional edgeEntity = graphTemplate.traversalVertex() .outE(READS) @@ -180,7 +180,7 @@ public void shouldHasPropertyFromAccessor() { @Test - public void shouldHasProperty() { + void shouldHasProperty() { Optional edgeEntity = graphTemplate.traversalVertex() .outE(READS) .has("motivation", "hobby").next(); @@ -190,7 +190,7 @@ public void shouldHasProperty() { } @Test - public void shouldHasSupplierProperty() { + void shouldHasSupplierProperty() { Optional edgeEntity = graphTemplate.traversalVertex() .outE(READS) .has(() -> "motivation", "hobby").next(); @@ -200,7 +200,7 @@ public void shouldHasSupplierProperty() { } @Test - public void shouldHasPropertyPredicate() { + void shouldHasPropertyPredicate() { Optional edgeEntity = graphTemplate.traversalVertex() .outE(READS) @@ -212,7 +212,7 @@ public void shouldHasPropertyPredicate() { @Test - public void shouldHasPropertyKeySupplierPredicate() { + void shouldHasPropertyKeySupplierPredicate() { Optional edgeEntity = graphTemplate.traversalVertex() .outE(READS) @@ -224,21 +224,21 @@ public void shouldHasPropertyKeySupplierPredicate() { @Test - public void shouldReturnErrorWhenHasPropertyWhenKeyIsNull() { + void shouldReturnErrorWhenHasPropertyWhenKeyIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex() .outE(READS) .has((String) null, "hobby").next()); } @Test - public void shouldReturnErrorWhenHasPropertyWhenValueIsNull() { + void shouldReturnErrorWhenHasPropertyWhenValueIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex() .outE(READS) .has("motivation", null).next()); } @Test - public void shouldHasNot() { + void shouldHasNot() { List edgeEntities = graphTemplate.traversalVertex() .outE(READS).hasNot("language") .stream() @@ -248,39 +248,39 @@ public void shouldHasNot() { } @Test - public void shouldCount() { + void shouldCount() { long count = graphTemplate.traversalVertex().outE(READS).count(); assertEquals(3L, count); } @Test - public void shouldReturnZeroWhenCountIsEmpty() { + void shouldReturnZeroWhenCountIsEmpty() { long count = graphTemplate.traversalVertex().outE("WRITES").count(); assertEquals(0L, count); } @Test - public void shouldReturnErrorWhenHasNotIsNull() { + void shouldReturnErrorWhenHasNotIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().outE(READS).hasNot((String) null)); } @Test - public void shouldDefinesLimit() { + void shouldDefinesLimit() { long count = graphTemplate.traversalEdge().limit(1L).count(); assertEquals(1L, count); assertNotEquals(graphTemplate.traversalEdge().count(), count); } @Test - public void shouldDefinesRange() { + void shouldDefinesRange() { long count = graphTemplate.traversalEdge().range(1, 3).count(); assertEquals(2L, count); assertNotEquals(graphTemplate.traversalEdge().count(), count); } @Test - public void shouldMapValuesAsStream() { + void shouldMapValuesAsStream() { List> maps = graphTemplate.traversalVertex().inE("reads") .valueMap("motivation").stream().toList(); @@ -295,7 +295,7 @@ public void shouldMapValuesAsStream() { } @Test - public void shouldMapValuesAsStreamLimit() { + void shouldMapValuesAsStreamLimit() { List> maps = graphTemplate.traversalVertex().inE("reads") .valueMap("motivation").next(2).toList(); @@ -305,14 +305,14 @@ public void shouldMapValuesAsStreamLimit() { @Test - public void shouldReturnMapValueAsEmptyStream() { + void shouldReturnMapValueAsEmptyStream() { Stream> stream = graphTemplate.traversalVertex().inE("reads") .valueMap("noFoundProperty").stream(); assertTrue(stream.allMatch(m -> Objects.isNull(m.get("noFoundProperty")))); } @Test - public void shouldReturnNext() { + void shouldReturnNext() { Map map = graphTemplate.traversalVertex().inE("reads") .valueMap("motivation").next(); @@ -322,7 +322,7 @@ public void shouldReturnNext() { @Test - public void shouldReturnHas() { + void shouldReturnHas() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -340,7 +340,7 @@ public void shouldReturnHas() { } @Test - public void shouldRepeatTimesTraversal() { + void shouldRepeatTimesTraversal() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -356,7 +356,7 @@ public void shouldRepeatTimesTraversal() { } @Test - public void shouldRepeatUntilTraversal() { + void shouldRepeatUntilTraversal() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -377,7 +377,7 @@ public void shouldRepeatUntilTraversal() { } @Test - public void shouldRepeatUntilHasValueTraversal() { + void shouldRepeatUntilHasValueTraversal() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -398,7 +398,7 @@ public void shouldRepeatUntilHasValueTraversal() { } @Test - public void shouldRepeatUntilHasPredicateTraversal() { + void shouldRepeatUntilHasPredicateTraversal() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -420,18 +420,18 @@ public void shouldRepeatUntilHasPredicateTraversal() { @Test - public void shouldReturnErrorWhenTheOrderIsNull() { + void shouldReturnErrorWhenTheOrderIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalEdge().orderBy(null)); } @Test - public void shouldReturnErrorWhenThePropertyDoesNotExist() { + void shouldReturnErrorWhenThePropertyDoesNotExist() { assertThrows(NoSuchElementException.class, () -> graphTemplate.traversalEdge().orderBy("wrong property").asc().next().get()); } @Test - public void shouldOrderAsc() { + void shouldOrderAsc() { String property = "motivation"; List properties = graphTemplate.traversalEdge() @@ -448,7 +448,7 @@ public void shouldOrderAsc() { } @Test - public void shouldOrderDesc() { + void shouldOrderDesc() { String property = "motivation"; List properties = graphTemplate.traversalEdge() @@ -466,43 +466,43 @@ public void shouldOrderDesc() { @Test - public void shouldReturnResultAsList() { + void shouldReturnResultAsList() { List entities = graphTemplate.traversalEdge().result() .toList(); assertEquals(3, entities.size()); } @Test - public void shouldReturnErrorWhenThereAreMoreThanOneInGetSingleResult() { + void shouldReturnErrorWhenThereAreMoreThanOneInGetSingleResult() { assertThrows(NonUniqueResultException.class, () -> graphTemplate.traversalEdge().singleResult()); } @Test - public void shouldReturnOptionalEmptyWhenThereIsNotResultInSingleResult() { + void shouldReturnOptionalEmptyWhenThereIsNotResultInSingleResult() { Optional entity = graphTemplate.traversalEdge(-1L).singleResult(); assertFalse(entity.isPresent()); } @Test - public void shouldReturnSingleResult() { + void shouldReturnSingleResult() { String name = "Poliana"; Optional entity = graphTemplate.traversalEdge(reads.id()).singleResult(); assertEquals(reads, entity.get()); } @Test - public void shouldReturnErrorWhenPredicateIsNull() { + void shouldReturnErrorWhenPredicateIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalEdge().filter(null)); } @Test - public void shouldReturnFromPredicate() { + void shouldReturnFromPredicate() { long count = graphTemplate.traversalEdge().filter(reads::equals).count(); assertEquals(1L, count); } @Test - public void shouldDedup() { + void shouldDedup() { graphTemplate.edge(otavio, "knows", paulo); graphTemplate.edge(paulo, "knows", otavio); From 12a6344b013621c0f22a5d41ec95530b3c68094e Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:34 -0300 Subject: [PATCH 056/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/DefaultEntitiesMetadataTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultEntitiesMetadataTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultEntitiesMetadataTest.java index e2f8ff836..fb91908a4 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultEntitiesMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultEntitiesMetadataTest.java @@ -47,7 +47,7 @@ class DefaultEntitiesMetadataTest { private DefaultEntitiesMetadata mappings; @Test - public void shouldGet(){ + void shouldGet(){ this.mappings.load(Person.class); this.mappings.load(Vendor.class); @@ -57,7 +57,7 @@ public void shouldGet(){ } @Test - public void shouldFindByName(){ + void shouldFindByName(){ this.mappings.load(Person.class); this.mappings.load(Vendor.class); @@ -66,7 +66,7 @@ public void shouldFindByName(){ Assertions.assertEquals(Vendor.class, mapping.type()); } @Test - public void shouldFindBySimpleName(){ + void shouldFindBySimpleName(){ this.mappings.load(Person.class); this.mappings.load(Vendor.class); @@ -79,7 +79,7 @@ public void shouldFindBySimpleName(){ } @Test - public void shouldFindByClassName(){ + void shouldFindByClassName(){ this.mappings.load(Person.class); this.mappings.load(Vendor.class); @@ -92,7 +92,7 @@ public void shouldFindByClassName(){ } @Test - public void shouldLoadGetPriorityOnParent() { + void shouldLoadGetPriorityOnParent() { this.mappings.load(Notification.class); this.mappings.load(EmailNotification.class); this.mappings.load(SmsNotification.class); @@ -113,7 +113,7 @@ public void shouldLoadGetPriorityOnParent() { } @Test - public void shouldFindByParentGroupByDiscriminatorValue() { + void shouldFindByParentGroupByDiscriminatorValue() { Map group = this.mappings .findByParentGroupByDiscriminatorValue(Notification.class); @@ -124,7 +124,7 @@ public void shouldFindByParentGroupByDiscriminatorValue() { } @Test - public void shouldFindByParentGroupByDiscriminatorValue2() { + void shouldFindByParentGroupByDiscriminatorValue2() { Map group = this.mappings .findByParentGroupByDiscriminatorValue(Project.class); @@ -135,7 +135,7 @@ public void shouldFindByParentGroupByDiscriminatorValue2() { } @Test - public void shouldLoadUsingGet(){ + void shouldLoadUsingGet(){ this.mappings.load(Movie.class); EntityMetadata mapping = mappings.findByName("Movie"); assertThat(mapping).isNotNull(); From 5c990bbd51c183c6b39910623d2af6a1d870926c Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:35 -0300 Subject: [PATCH 057/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/DefaultEntityMetadataTest.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultEntityMetadataTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultEntityMetadataTest.java index 069f89aba..9081b0842 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultEntityMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultEntityMetadataTest.java @@ -36,25 +36,25 @@ class DefaultEntityMetadataTest { @BeforeEach - public void setUp() { + void setUp() { this.converter = new ReflectionClassConverter(); } @Test - public void shouldToString(){ + void shouldToString(){ EntityMetadata entityMetadata = converter.apply(Person.class); assertThat(entityMetadata.toString()).isNotBlank(); } @Test - public void shouldCreateInstance(){ + void shouldCreateInstance(){ EntityMetadata entityMetadata = converter.apply(Person.class); Object person = entityMetadata.newInstance(); assertThat(person).isNotNull().isInstanceOf(Person.class); } @Test - public void shouldGetId(){ + void shouldGetId(){ EntityMetadata entityMetadata = converter.apply(Person.class); Optional id = entityMetadata.id(); assertThat(id).isNotEmpty(); @@ -67,7 +67,7 @@ public void shouldGetId(){ } @Test - public void shouldIsInheritance(){ + void shouldIsInheritance(){ EntityMetadata entityMetadata = converter.apply(Person.class); assertThat(entityMetadata.isInheritance()).isFalse(); @@ -76,7 +76,7 @@ public void shouldIsInheritance(){ } @Test - public void shouldGroupByName(){ + void shouldGroupByName(){ EntityMetadata entityMetadata = converter.apply(Person.class); Map map = entityMetadata.fieldsGroupByName(); @@ -86,38 +86,38 @@ public void shouldGroupByName(){ } @Test - public void shouldGetClass(){ + void shouldGetClass(){ EntityMetadata entityMetadata = converter.apply(Person.class); assertThat(entityMetadata.type()).isEqualTo(Person.class); } @Test - public void shouldName(){ + void shouldName(){ EntityMetadata entityMetadata = converter.apply(Person.class); assertThat(entityMetadata.name()).isEqualTo(Person.class.getSimpleName()); } @Test - public void shouldClassName(){ + void shouldClassName(){ EntityMetadata entityMetadata = converter.apply(Person.class); assertThat(entityMetadata.className()).isEqualTo(Person.class.getName()); } @Test - public void shouldSimpleName(){ + void shouldSimpleName(){ EntityMetadata entityMetadata = converter.apply(Person.class); assertThat(entityMetadata.simpleName()).isEqualTo(Person.class.getSimpleName()); } @Test - public void shouldNewInstance(){ + void shouldNewInstance(){ EntityMetadata entityMetadata = converter.apply(Person.class); Object instance = entityMetadata.newInstance(); assertThat(instance).isNotNull().isInstanceOf(Person.class); } @Test - public void shouldHashCodeEquals(){ + void shouldHashCodeEquals(){ EntityMetadata entityMetadata = converter.apply(Person.class); assertThat(entityMetadata).isEqualTo(converter.apply(Person.class)); assertThat(entityMetadata).hasSameHashCodeAs(entityMetadata); From a46a6aa5dc5a58a63702cb09e52f00016772f7bb Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:36 -0300 Subject: [PATCH 058/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/DefaultEntityTreeTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultEntityTreeTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultEntityTreeTest.java index 13e8978c5..f940a7297 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultEntityTreeTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultEntityTreeTest.java @@ -43,7 +43,7 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class DefaultEntityTreeTest { +class DefaultEntityTreeTest { @Inject protected GraphTemplate graphTemplate; @@ -57,7 +57,7 @@ public class DefaultEntityTreeTest { private Animal grass; @BeforeEach - public void setUp() { + void setUp() { graph.traversal().V().toList().forEach(Vertex::remove); graph.traversal().E().toList().forEach(Edge::remove); lion = graphTemplate.insert(new Animal("lion")); @@ -72,7 +72,7 @@ public void setUp() { } @Test - public void shouldCreateLeaf() { + void shouldCreateLeaf() { EntityTree tree = graphTemplate.traversalVertex() .hasLabel(Animal.class) .in("eats") @@ -91,7 +91,7 @@ public void shouldCreateLeaf() { } @Test - public void shouldGetLeafTrees() { + void shouldGetLeafTrees() { EntityTree tree = graphTemplate.traversalVertex() .hasLabel(Animal.class) .in("eats") @@ -114,7 +114,7 @@ public void shouldGetLeafTrees() { } @Test - public void shouldGetParents() { + void shouldGetParents() { EntityTree tree = graphTemplate.traversalVertex() .hasLabel(Animal.class) .in("eats") @@ -135,7 +135,7 @@ public void shouldGetParents() { } @Test - public void shouldGetParentId() { + void shouldGetParentId() { EntityTree tree = graphTemplate.traversalVertex() .hasLabel(Animal.class) .out("eats") @@ -158,7 +158,7 @@ public void shouldGetParentId() { } @Test - public void shouldIsLeaf() { + void shouldIsLeaf() { EntityTree tree = graphTemplate.traversalVertex() .hasLabel(Animal.class) .out("eats") @@ -171,7 +171,7 @@ public void shouldIsLeaf() { } @Test - public void shouldGetTreesAtDepth() { + void shouldGetTreesAtDepth() { EntityTree tree = graphTemplate.traversalVertex() .hasLabel(Animal.class) .out("eats") @@ -184,7 +184,7 @@ public void shouldGetTreesAtDepth() { } @Test - public void shouldGetLeafsAtDepth() { + void shouldGetLeafsAtDepth() { EntityTree tree = graphTemplate.traversalVertex() .hasLabel(Animal.class) .out("eats") From 458267648d6944674b1142a393c2f938bdf76f6d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:37 -0300 Subject: [PATCH 059/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/DefaultFieldMetadataTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultFieldMetadataTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultFieldMetadataTest.java index 6745f9913..dee611119 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultFieldMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultFieldMetadataTest.java @@ -35,25 +35,25 @@ class DefaultFieldMetadataTest { private DefaultFieldMetadata fieldMetadata; @BeforeEach - public void setUp(){ + void setUp(){ this.converter = new ReflectionClassConverter(); EntityMetadata entityMetadata = converter.apply(Person.class); FieldMetadata name = entityMetadata.fieldMapping("name").orElseThrow(); this.fieldMetadata = (DefaultFieldMetadata) name; } @Test - public void shouldToString() { + void shouldToString() { assertThat(fieldMetadata.toString()).isNotEmpty().isNotNull(); } @Test - public void shouldEqualsHashCode() { + void shouldEqualsHashCode() { assertThat(fieldMetadata).isEqualTo(fieldMetadata); assertThat(fieldMetadata).hasSameHashCodeAs(fieldMetadata); } @Test - public void shouldCreateNewInstanceConverter(){ + void shouldCreateNewInstanceConverter(){ EntityMetadata entityMetadata = converter.apply(Worker.class); FieldMetadata name = entityMetadata.fieldMapping("salary").orElseThrow(); fieldMetadata = (DefaultFieldMetadata) name; From 8d7ff35f38c5dd324548d68e04cac6995e2295da Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:38 -0300 Subject: [PATCH 060/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/metadata/DefaultFieldValueTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/DefaultFieldValueTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/DefaultFieldValueTest.java index 9420ef4d9..7fec71d48 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/DefaultFieldValueTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/DefaultFieldValueTest.java @@ -21,10 +21,10 @@ import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; -public class DefaultFieldValueTest { +class DefaultFieldValueTest { @Test - public void shouldConstructWithValidArguments() { + void shouldConstructWithValidArguments() { FieldMetadata fieldMetadata = mock(FieldMetadata.class); when(fieldMetadata.name()).thenReturn("fieldName"); @@ -37,13 +37,13 @@ public void shouldConstructWithValidArguments() { } @Test - public void shouldThrowExceptionForNullFieldMetadataInConstructor() { + void shouldThrowExceptionForNullFieldMetadataInConstructor() { Object value = "testValue"; assertThrows(NullPointerException.class, () -> new DefaultFieldValue(value, null)); } @Test - public void shouldReturnTrueForIsNotEmptyWithValue() { + void shouldReturnTrueForIsNotEmptyWithValue() { FieldMetadata fieldMetadata = mock(FieldMetadata.class); when(fieldMetadata.name()).thenReturn("fieldName"); DefaultFieldValue fieldValue = new DefaultFieldValue("testValue", fieldMetadata); @@ -51,7 +51,7 @@ public void shouldReturnTrueForIsNotEmptyWithValue() { } @Test - public void shouldReturnFalseForIsNotEmptyWithNullValue() { + void shouldReturnFalseForIsNotEmptyWithNullValue() { FieldMetadata fieldMetadata = mock(FieldMetadata.class); when(fieldMetadata.name()).thenReturn("fieldName"); DefaultFieldValue fieldValue = new DefaultFieldValue(null, fieldMetadata); @@ -59,7 +59,7 @@ public void shouldReturnFalseForIsNotEmptyWithNullValue() { } @Test - public void shouldReturnCorrectStringRepresentation() { + void shouldReturnCorrectStringRepresentation() { FieldMetadata fieldMetadata = mock(FieldMetadata.class); when(fieldMetadata.name()).thenReturn("fieldName"); DefaultFieldValue fieldValue = new DefaultFieldValue("testValue", fieldMetadata); From 125d75748a7b31ae6ff4a0637cb87e87b56c03c2 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:40 -0300 Subject: [PATCH 061/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../DefaultFluentDeleteQueryBuilderTest.java | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultFluentDeleteQueryBuilderTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultFluentDeleteQueryBuilderTest.java index aa6d3c562..6c21d843c 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultFluentDeleteQueryBuilderTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultFluentDeleteQueryBuilderTest.java @@ -34,15 +34,15 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import static org.mockito.Mockito.verify; -public class DefaultFluentDeleteQueryBuilderTest { +class DefaultFluentDeleteQueryBuilderTest { @Test - public void shouldReturnErrorWhenHasNullElementInSelect() { + void shouldReturnErrorWhenHasNullElementInSelect() { Assertions.assertThrows(NullPointerException.class,() -> delete("document", "document", null)); } @Test - public void shouldDelete() { + void shouldDelete() { String documentCollection = "documentCollection"; DocumentDeleteQuery query = delete().from(documentCollection).build(); assertTrue(query.documents().isEmpty()); @@ -51,7 +51,7 @@ public void shouldDelete() { } @Test - public void shouldDeleteDocuments() { + void shouldDeleteDocuments() { String documentCollection = "documentCollection"; DocumentDeleteQuery query = delete("document", "document2").from(documentCollection).build(); assertThat(query.documents()).contains("document", "document2"); @@ -61,12 +61,12 @@ public void shouldDeleteDocuments() { @Test - public void shouldReturnErrorWhenFromIsNull() { + void shouldReturnErrorWhenFromIsNull() { Assertions.assertThrows(NullPointerException.class,() -> delete().from(null)); } @Test - public void shouldSelectWhereNameEq() { + void shouldSelectWhereNameEq() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentDeleteQuery query = delete().from(documentCollection).where("name").eq(name).build(); @@ -83,7 +83,7 @@ public void shouldSelectWhereNameEq() { } @Test - public void shouldSelectWhereNameLike() { + void shouldSelectWhereNameLike() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentDeleteQuery query = delete().from(documentCollection).where("name").like(name).build(); @@ -99,7 +99,7 @@ public void shouldSelectWhereNameLike() { } @Test - public void shouldSelectWhereNameGt() { + void shouldSelectWhereNameGt() { String documentCollection = "documentCollection"; Number value = 10; DocumentDeleteQuery query = delete().from(documentCollection).where("name").gt(value).build(); @@ -115,7 +115,7 @@ public void shouldSelectWhereNameGt() { } @Test - public void shouldSelectWhereNameGte() { + void shouldSelectWhereNameGte() { String documentCollection = "documentCollection"; Number value = 10; DocumentDeleteQuery query = delete().from(documentCollection).where("name").gte(value).build(); @@ -131,7 +131,7 @@ public void shouldSelectWhereNameGte() { } @Test - public void shouldSelectWhereNameLt() { + void shouldSelectWhereNameLt() { String documentCollection = "documentCollection"; Number value = 10; DocumentDeleteQuery query = delete().from(documentCollection).where("name").lt(value).build(); @@ -147,7 +147,7 @@ public void shouldSelectWhereNameLt() { } @Test - public void shouldSelectWhereNameLte() { + void shouldSelectWhereNameLte() { String documentCollection = "documentCollection"; Number value = 10; DocumentDeleteQuery query = delete().from(documentCollection).where("name").lte(value).build(); @@ -163,7 +163,7 @@ public void shouldSelectWhereNameLte() { } @Test - public void shouldSelectWhereNameBetween() { + void shouldSelectWhereNameBetween() { String documentCollection = "documentCollection"; Number valueA = 10; Number valueB = 20; @@ -180,7 +180,7 @@ public void shouldSelectWhereNameBetween() { } @Test - public void shouldSelectWhereNameNot() { + void shouldSelectWhereNameNot() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentDeleteQuery query = delete().from(documentCollection).where("name").not().eq(name).build(); @@ -198,7 +198,7 @@ public void shouldSelectWhereNameNot() { @Test - public void shouldSelectWhereNameAnd() { + void shouldSelectWhereNameAnd() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentDeleteQuery query = delete().from(documentCollection).where("name").eq(name).and("age") @@ -214,7 +214,7 @@ public void shouldSelectWhereNameAnd() { } @Test - public void shouldSelectWhereNameOr() { + void shouldSelectWhereNameOr() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentDeleteQuery query = delete().from(documentCollection).where("name").eq(name) @@ -232,7 +232,7 @@ public void shouldSelectWhereNameOr() { @Test - public void shouldDeleteNegate() { + void shouldDeleteNegate() { String columnFamily = "columnFamily"; DocumentDeleteQuery query = delete().from(columnFamily).where("city").not().eq("Assis") .and("name").not().eq("Lucas").build(); @@ -251,7 +251,7 @@ public void shouldDeleteNegate() { } @Test - public void shouldExecuteDelete() { + void shouldExecuteDelete() { String collection = "collection"; DocumentManager manager = Mockito.mock(DocumentManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); From cfc2eb41d9388943c461943968dd3959080308cc Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:41 -0300 Subject: [PATCH 062/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- ...DefaultFluentDocumentQueryBuilderTest.java | 50 +++++++++---------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultFluentDocumentQueryBuilderTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultFluentDocumentQueryBuilderTest.java index cfd19d644..2e605fcb4 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultFluentDocumentQueryBuilderTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DefaultFluentDocumentQueryBuilderTest.java @@ -37,16 +37,16 @@ import static org.junit.jupiter.api.Assertions.assertTrue; -public class DefaultFluentDocumentQueryBuilderTest { +class DefaultFluentDocumentQueryBuilderTest { @Test - public void shouldReturnErrorWhenHasNullElementInSelect() { + void shouldReturnErrorWhenHasNullElementInSelect() { assertThrows(NullPointerException.class, () -> select("document", "document'", null)); } @Test - public void shouldSelect() { + void shouldSelect() { String documentCollection = "documentCollection"; DocumentQuery query = select().from(documentCollection).build(); assertTrue(query.documents().isEmpty()); @@ -55,7 +55,7 @@ public void shouldSelect() { } @Test - public void shouldSelectDocument() { + void shouldSelectDocument() { String documentCollection = "documentCollection"; DocumentQuery query = select("document", "document2").from(documentCollection).build(); assertThat(query.documents()).contains("document", "document2"); @@ -64,13 +64,13 @@ public void shouldSelectDocument() { } @Test - public void shouldReturnErrorWhenFromIsNull() { + void shouldReturnErrorWhenFromIsNull() { assertThrows(NullPointerException.class, () -> select().from(null)); } @Test - public void shouldSelectOrderAsc() { + void shouldSelectOrderAsc() { String documentCollection = "documentCollection"; DocumentQuery query = select().from(documentCollection).orderBy("name").asc().build(); assertTrue(query.documents().isEmpty()); @@ -80,7 +80,7 @@ public void shouldSelectOrderAsc() { } @Test - public void shouldSelectOrderDesc() { + void shouldSelectOrderDesc() { String documentCollection = "documentCollection"; DocumentQuery query = select().from(documentCollection).orderBy("name").desc().build(); assertTrue(query.documents().isEmpty()); @@ -91,7 +91,7 @@ public void shouldSelectOrderDesc() { @Test - public void shouldReturnErrorSelectWhenOrderIsNull() { + void shouldReturnErrorSelectWhenOrderIsNull() { assertThrows(NullPointerException.class,() -> { String documentCollection = "documentCollection"; select().from(documentCollection).orderBy(null); @@ -99,7 +99,7 @@ public void shouldReturnErrorSelectWhenOrderIsNull() { } @Test - public void shouldSelectLimit() { + void shouldSelectLimit() { String documentCollection = "documentCollection"; DocumentQuery query = select().from(documentCollection).limit(10).build(); assertTrue(query.documents().isEmpty()); @@ -109,13 +109,13 @@ public void shouldSelectLimit() { } @Test - public void shouldReturnErrorWhenLimitIsNegative() { + void shouldReturnErrorWhenLimitIsNegative() { String documentCollection = "documentCollection"; assertThrows(IllegalArgumentException.class, () -> select().from(documentCollection).limit(-1)); } @Test - public void shouldSelectSkip() { + void shouldSelectSkip() { String documentCollection = "documentCollection"; DocumentQuery query = select().from(documentCollection).skip(10).build(); assertTrue(query.documents().isEmpty()); @@ -125,13 +125,13 @@ public void shouldSelectSkip() { } @Test - public void shouldReturnErrorWhenSkipIsNegative() { + void shouldReturnErrorWhenSkipIsNegative() { String documentCollection = "documentCollection"; assertThrows(IllegalArgumentException.class, () -> select().from(documentCollection).skip(-1)); } @Test - public void shouldSelectWhereNameEq() { + void shouldSelectWhereNameEq() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentQuery query = select().from(documentCollection).where("name").eq(name).build(); @@ -148,7 +148,7 @@ public void shouldSelectWhereNameEq() { } @Test - public void shouldSelectWhereNameLike() { + void shouldSelectWhereNameLike() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentQuery query = select().from(documentCollection).where("name").like(name).build(); @@ -164,7 +164,7 @@ public void shouldSelectWhereNameLike() { } @Test - public void shouldSelectWhereNameGt() { + void shouldSelectWhereNameGt() { String documentCollection = "documentCollection"; Number value = 10; DocumentQuery query = select().from(documentCollection).where("name").gt(value).build(); @@ -180,7 +180,7 @@ public void shouldSelectWhereNameGt() { } @Test - public void shouldSelectWhereNameGte() { + void shouldSelectWhereNameGte() { String documentCollection = "documentCollection"; Number value = 10; DocumentQuery query = select().from(documentCollection).where("name").gte(value).build(); @@ -196,7 +196,7 @@ public void shouldSelectWhereNameGte() { } @Test - public void shouldSelectWhereNameLt() { + void shouldSelectWhereNameLt() { String documentCollection = "documentCollection"; Number value = 10; DocumentQuery query = select().from(documentCollection).where("name").lt(value).build(); @@ -212,7 +212,7 @@ public void shouldSelectWhereNameLt() { } @Test - public void shouldSelectWhereNameLte() { + void shouldSelectWhereNameLte() { String documentCollection = "documentCollection"; Number value = 10; DocumentQuery query = select().from(documentCollection).where("name").lte(value).build(); @@ -228,7 +228,7 @@ public void shouldSelectWhereNameLte() { } @Test - public void shouldSelectWhereNameBetween() { + void shouldSelectWhereNameBetween() { String documentCollection = "documentCollection"; Number valueA = 10; Number valueB = 20; @@ -246,7 +246,7 @@ public void shouldSelectWhereNameBetween() { } @Test - public void shouldSelectWhereNameNot() { + void shouldSelectWhereNameNot() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentQuery query = select().from(documentCollection).where("name").not().eq(name).build(); @@ -264,7 +264,7 @@ public void shouldSelectWhereNameNot() { @Test - public void shouldSelectWhereNameAnd() { + void shouldSelectWhereNameAnd() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentQuery query = select().from(documentCollection).where("name").eq(name).and("age") @@ -280,7 +280,7 @@ public void shouldSelectWhereNameAnd() { } @Test - public void shouldSelectWhereNameOr() { + void shouldSelectWhereNameOr() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentQuery query = select().from(documentCollection).where("name").eq(name).or("age").gt(10).build(); @@ -296,7 +296,7 @@ public void shouldSelectWhereNameOr() { @Test - public void shouldSelectNegate() { + void shouldSelectNegate() { String columnFamily = "columnFamily"; DocumentQuery query = select().from(columnFamily).where("city").not().eq("Assis") .and("name").not().eq("Lucas").build(); @@ -315,7 +315,7 @@ public void shouldSelectNegate() { @Test - public void shouldExecuteManager() { + void shouldExecuteManager() { DocumentManager manager = Mockito.mock(DocumentManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); String collection = "collection"; @@ -325,7 +325,7 @@ public void shouldExecuteManager() { } @Test - public void shouldExecuteSingleResultManager() { + void shouldExecuteSingleResultManager() { DocumentManager manager = Mockito.mock(DocumentManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); String collection = "collection"; From 4b01f62986a5fe2c90d61204901bf4e50166384d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:42 -0300 Subject: [PATCH 063/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../DefaultGenericFieldMetaDataTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultGenericFieldMetaDataTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultGenericFieldMetaDataTest.java index 532ad9e89..25def057c 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultGenericFieldMetaDataTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultGenericFieldMetaDataTest.java @@ -35,48 +35,48 @@ class DefaultGenericFieldMetaDataTest { private GenericFieldMetadata fieldMetadata; @BeforeEach - public void setUp(){ + void setUp(){ ClassConverter converter = new ReflectionClassConverter(); EntityMetadata entityMetadata = converter.apply(Person.class); FieldMetadata phones = entityMetadata.fieldMapping("phones").orElseThrow(); this.fieldMetadata = (GenericFieldMetadata) phones; } @Test - public void shouldToString() { + void shouldToString() { assertThat(fieldMetadata.toString()).isNotEmpty().isNotNull(); } @Test - public void shouldGetElementType(){ + void shouldGetElementType(){ assertThat(fieldMetadata.elementType()).isEqualTo(String.class); } @Test - public void shouldCollectionInstance(){ + void shouldCollectionInstance(){ Collection collection = this.fieldMetadata.collectionInstance(); assertThat(collection).isInstanceOf(List.class); } @Test - public void shouldEqualsHashCode(){ + void shouldEqualsHashCode(){ Assertions.assertThat(fieldMetadata).isEqualTo(fieldMetadata); Assertions.assertThat(fieldMetadata).hasSameHashCodeAs(fieldMetadata); } @Test - public void shouldValue(){ + void shouldValue(){ List phones = List.of("Ada", "Lovelace"); Object value = fieldMetadata.value(Value.of(phones)); assertThat(value).isNotNull().isInstanceOf(List.class); } @Test - public void shouldConverter(){ + void shouldConverter(){ assertThat(fieldMetadata.converter()).isNotNull().isEmpty(); } @Test - public void shouldNewConverter(){ + void shouldNewConverter(){ assertThat(fieldMetadata.newConverter()).isNotNull().isEmpty(); } } From c000f633c591754fea0a89a24fc6cfd5fed135a6 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:43 -0300 Subject: [PATCH 064/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/DefaultGenericParameterMetaDataTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultGenericParameterMetaDataTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultGenericParameterMetaDataTest.java index 27c251a88..44f84c1fa 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultGenericParameterMetaDataTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultGenericParameterMetaDataTest.java @@ -34,7 +34,7 @@ class DefaultGenericParameterMetaDataTest { private GenericParameterMetaData fieldMetadata; @BeforeEach - public void setUp(){ + void setUp(){ ClassConverter converter = new ReflectionClassConverter(); EntityMetadata entityMetadata = converter.apply(BookUser.class); ConstructorMetadata constructor = entityMetadata.constructor(); @@ -43,17 +43,17 @@ public void setUp(){ .findFirst().orElseThrow(); } @Test - public void shouldToString() { + void shouldToString() { assertThat(fieldMetadata.toString()).isNotEmpty().isNotNull(); } @Test - public void shouldGetElementType(){ + void shouldGetElementType(){ assertThat(fieldMetadata.elementType()).isEqualTo(Book.class); } @Test - public void shouldCollectionInstance(){ + void shouldCollectionInstance(){ Collection collection = this.fieldMetadata.collectionInstance(); assertThat(collection).isInstanceOf(List.class); } From 3048b88987bf159a605c579c5b1b4f961446808e Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:45 -0300 Subject: [PATCH 065/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../DefaultKeyValueEntityConverterTest.java | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/DefaultKeyValueEntityConverterTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/DefaultKeyValueEntityConverterTest.java index 4af4b6bb0..ed30f45fd 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/DefaultKeyValueEntityConverterTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/DefaultKeyValueEntityConverterTest.java @@ -40,23 +40,23 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, KeyValueExtension.class}) -public class DefaultKeyValueEntityConverterTest { +class DefaultKeyValueEntityConverterTest { @Inject private KeyValueEntityConverter converter; @Test - public void shouldReturnNPEWhenEntityIsNull() { + void shouldReturnNPEWhenEntityIsNull() { Assertions.assertThrows(NullPointerException.class, () -> converter.toKeyValue(null)); } @Test - public void shouldReturnErrorWhenThereIsNotKeyAnnotation() { + void shouldReturnErrorWhenThereIsNotKeyAnnotation() { Assertions.assertThrows(IdNotFoundException.class, () -> converter.toKeyValue(new Worker())); } @Test - public void shouldReturnErrorWhenTheKeyIsNull() { + void shouldReturnErrorWhenTheKeyIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { User user = new User(null, "name", 24); converter.toKeyValue(user); @@ -64,7 +64,7 @@ public void shouldReturnErrorWhenTheKeyIsNull() { } @Test - public void shouldConvertToKeyValue() { + void shouldConvertToKeyValue() { User user = new User("nickname", "name", 24); KeyValueEntity keyValueEntity = converter.toKeyValue(user); assertEquals("nickname", keyValueEntity.key()); @@ -72,24 +72,24 @@ public void shouldConvertToKeyValue() { } @Test - public void shouldReturnNPEWhenKeyValueIsNull() { + void shouldReturnNPEWhenKeyValueIsNull() { Assertions.assertThrows(NullPointerException.class, () -> converter.toEntity(User.class, null)); } @Test - public void shouldReturnNPEWhenClassIsNull() { + void shouldReturnNPEWhenClassIsNull() { Assertions.assertThrows(NullPointerException.class, () -> converter.toEntity(null, KeyValueEntity.of("user", new User("nickname", "name", 21)))); } @Test - public void shouldReturnErrorWhenTheKeyIsMissing() { + void shouldReturnErrorWhenTheKeyIsMissing() { Assertions.assertThrows(IdNotFoundException.class, () -> converter.toEntity(Worker.class, KeyValueEntity.of("worker", new Worker()))); } @Test - public void shouldConvertToEntity() { + void shouldConvertToEntity() { User expectedUser = new User("nickname", "name", 21); User user = converter.toEntity(User.class, KeyValueEntity.of("user", expectedUser)); @@ -97,7 +97,7 @@ public void shouldConvertToEntity() { } @Test - public void shouldConvertAndFeedTheKeyValue() { + void shouldConvertAndFeedTheKeyValue() { User expectedUser = new User("nickname", "name", 21); User user = converter.toEntity(User.class, KeyValueEntity.of("nickname", new User(null, "name", 21))); @@ -105,7 +105,7 @@ public void shouldConvertAndFeedTheKeyValue() { } @Test - public void shouldConvertAndFeedTheKeyValueIfKeyAndFieldAreDifferent() { + void shouldConvertAndFeedTheKeyValueIfKeyAndFieldAreDifferent() { User expectedUser = new User("nickname", "name", 21); User user = converter.toEntity(User.class, KeyValueEntity.of("nickname", new User("newName", "name", 21))); @@ -113,14 +113,14 @@ public void shouldConvertAndFeedTheKeyValueIfKeyAndFieldAreDifferent() { } @Test - public void shouldConvertValueToEntity() { + void shouldConvertValueToEntity() { User expectedUser = new User("nickname", "name", 21); User user = converter.toEntity(User.class, KeyValueEntity.of("nickname", Value.of(expectedUser))); assertEquals(expectedUser, user); } @Test - public void shouldConvertToEntityKeyWhenThereIsConverterAnnotation() { + void shouldConvertToEntityKeyWhenThereIsConverterAnnotation() { Car car = new Car(); car.setName("Ferrari"); @@ -130,7 +130,7 @@ public void shouldConvertToEntityKeyWhenThereIsConverterAnnotation() { } @Test - public void shouldConvertToKeyWhenThereIsConverterAnnotation() { + void shouldConvertToKeyWhenThereIsConverterAnnotation() { Car car = new Car(); car.setPlate(Plate.of("123-BRL")); car.setName("Ferrari"); @@ -141,7 +141,7 @@ public void shouldConvertToKeyWhenThereIsConverterAnnotation() { } @Test - public void shouldConvertToEntityKeyWhenKeyTypeIsDifferent() { + void shouldConvertToEntityKeyWhenKeyTypeIsDifferent() { Person person = Person.builder().withName("Ada").build(); Person ada = converter.toEntity(Person.class, KeyValueEntity.of("123", person)); @@ -151,7 +151,7 @@ public void shouldConvertToEntityKeyWhenKeyTypeIsDifferent() { } @Test - public void shouldConvertToKeyWhenKeyTypeIsDifferent() { + void shouldConvertToKeyWhenKeyTypeIsDifferent() { Person person = Person.builder().withId(123L).withName("Ada").build(); KeyValueEntity entity = converter.toKeyValue(person); Assertions.assertEquals(123L, entity.key()); From fae311d4b1d02d2aeab9cdff0b19c2346a611264 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:46 -0300 Subject: [PATCH 066/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../keyvalue/DefaultKeyValueTemplateTest.java | 60 +++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/DefaultKeyValueTemplateTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/DefaultKeyValueTemplateTest.java index ef0d055ac..444367a32 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/DefaultKeyValueTemplateTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/DefaultKeyValueTemplateTest.java @@ -62,7 +62,7 @@ @AddExtensions({EntityMetadataExtension.class, KeyValueExtension.class}) @ExtendWith(MockitoExtension.class) @MockitoSettings(strictness = Strictness.LENIENT) -public class DefaultKeyValueTemplateTest { +class DefaultKeyValueTemplateTest { private static final String KEY = "otaviojava"; @Inject @@ -81,14 +81,14 @@ public class DefaultKeyValueTemplateTest { @BeforeEach - public void setUp() { + void setUp() { Instance instance = Mockito.mock(Instance.class); when(instance.get()).thenReturn(manager); this.template = new DefaultKeyValueTemplate(converter, instance, eventManager); } @Test - public void shouldPut() { + void shouldPut() { User user = new User(KEY, "otavio", 27); template.put(user); Mockito.verify(manager).put(captor.capture()); @@ -99,14 +99,14 @@ public void shouldPut() { @Test - public void shouldMergeOnPut() { + void shouldMergeOnPut() { User user = new User(KEY, "otavio", 27); User result = template.put(user); assertSame(user, result); } @Test - public void shouldPutIterable() { + void shouldPutIterable() { User user = new User(KEY, "otavio", 27); template.put(singletonList(user)); Mockito.verify(manager).put(captor.capture()); @@ -116,7 +116,7 @@ public void shouldPutIterable() { } @Test - public void shouldPutTTL() { + void shouldPutTTL() { Duration duration = Duration.ofSeconds(2L); User user = new User(KEY, "otavio", 27); @@ -129,7 +129,7 @@ public void shouldPutTTL() { } @Test - public void shouldPutTTLIterable() { + void shouldPutTTLIterable() { Duration duration = Duration.ofSeconds(2L); User user = new User(KEY, "otavio", 27); @@ -142,7 +142,7 @@ public void shouldPutTTLIterable() { } @Test - public void shouldInsert() { + void shouldInsert() { User user = new User(KEY, "otavio", 27); template.insert(user); Mockito.verify(manager).put(captor.capture()); @@ -152,7 +152,7 @@ public void shouldInsert() { } @Test - public void shouldInsertIterable() { + void shouldInsertIterable() { User user = new User(KEY, "otavio", 27); template.insert(singletonList(user)); Mockito.verify(manager).put(captor.capture()); @@ -162,7 +162,7 @@ public void shouldInsertIterable() { } @Test - public void shouldInsertTTL() { + void shouldInsertTTL() { Duration duration = Duration.ofSeconds(2L); User user = new User(KEY, "otavio", 27); @@ -175,7 +175,7 @@ public void shouldInsertTTL() { } @Test - public void shouldInsertTTLIterable() { + void shouldInsertTTLIterable() { Duration duration = Duration.ofSeconds(2L); User user = new User(KEY, "otavio", 27); @@ -188,7 +188,7 @@ public void shouldInsertTTLIterable() { } @Test - public void shouldUpdate() { + void shouldUpdate() { User user = new User(KEY, "otavio", 27); template.update(user); Mockito.verify(manager).put(captor.capture()); @@ -198,7 +198,7 @@ public void shouldUpdate() { } @Test - public void shouldUpdateIterable() { + void shouldUpdateIterable() { User user = new User(KEY, "otavio", 27); template.update(singletonList(user)); Mockito.verify(manager).put(captor.capture()); @@ -208,7 +208,7 @@ public void shouldUpdateIterable() { } @Test - public void shouldGet() { + void shouldGet() { User user = new User(KEY, "otavio", 27); when(manager.get(KEY)).thenReturn(Optional.of(Value.of(user))); @@ -219,7 +219,7 @@ public void shouldGet() { } @Test - public void shouldFindById() { + void shouldFindById() { User user = new User(KEY, "otavio", 27); when(manager.get(KEY)).thenReturn(Optional.of(Value.of(user))); Optional userOptional = template.find(User.class, KEY); @@ -229,7 +229,7 @@ public void shouldFindById() { } @Test - public void shouldGetIterable() { + void shouldGetIterable() { User user = new User(KEY, "otavio", 27); when(manager.get(KEY)).thenReturn(Optional.of(Value.of(user))); @@ -241,7 +241,7 @@ public void shouldGetIterable() { } @Test - public void shouldReturnEmptyIterable() { + void shouldReturnEmptyIterable() { User user = new User(KEY, "otavio", 27); when(manager.get(KEY)).thenReturn(Optional.empty()); @@ -252,45 +252,45 @@ public void shouldReturnEmptyIterable() { } @Test - public void shouldRemove() { + void shouldRemove() { template.delete(KEY); Mockito.verify(manager).delete(KEY); } @Test - public void shouldRemoveById() { + void shouldRemoveById() { template.delete(User.class, KEY); Mockito.verify(manager).delete(KEY); } @Test - public void shouldRemoveIterable() { + void shouldRemoveIterable() { template.delete(singletonList(KEY)); Mockito.verify(manager).delete(singletonList(KEY)); } @Test - public void shouldExecuteClass() { + void shouldExecuteClass() { template.query("remove id"); Mockito.verify(manager).query("remove id"); } @Test @MockitoSettings(strictness = Strictness.LENIENT) - public void shouldReturnErrorWhenQueryIsNull() { + void shouldReturnErrorWhenQueryIsNull() { assertThrows(NullPointerException.class, () -> template.query(null)); assertThrows(NullPointerException.class, () -> template.query(null, String.class)); } @Test - public void shouldExecuteClassNotClass() { + void shouldExecuteClassNotClass() { template.query("remove id"); Mockito.verify(manager).query("remove id"); } @Test - public void shouldExecuteQuery() { + void shouldExecuteQuery() { when(manager.query("get id")) .thenReturn(Stream.of(Value.of("12"))); @@ -299,7 +299,7 @@ public void shouldExecuteQuery() { } @Test - public void shouldReturnSingleResult() { + void shouldReturnSingleResult() { when(manager.query("get id")) .thenReturn(Stream.of(Value.of("12"))); @@ -308,7 +308,7 @@ public void shouldReturnSingleResult() { } @Test - public void shouldReturnSingleResult2() { + void shouldReturnSingleResult2() { when(manager.query("get id2")) .thenReturn(Stream.empty()); @@ -317,14 +317,14 @@ public void shouldReturnSingleResult2() { } @Test - public void shouldReturnSingleResult3() { + void shouldReturnSingleResult3() { when(manager.query("get id3")) .thenReturn(Stream.of(Value.of("12"), Value.of("15"))); assertThrows(NonUniqueResultException.class, () -> template.getSingleResult("get id3", Integer.class)); } @Test - public void shouldExecutePrepare() { + void shouldExecutePrepare() { org.eclipse.jnosql.communication.keyvalue.KeyValuePreparedStatement prepare = Mockito.mock(KeyValuePreparedStatement.class); when(prepare.result()).thenReturn(Stream.of(Value.of("12"))); when(prepare.singleResult()).thenReturn(Optional.of(Value.of("12"))); @@ -340,12 +340,12 @@ public void shouldExecutePrepare() { } @Test - public void shouldUnsupportedExceptionOnSelect() { + void shouldUnsupportedExceptionOnSelect() { assertThrows(UnsupportedOperationException.class, ()-> template.select(Person.class)); } @Test - public void shouldUnsupportedExceptionOnDelete() { + void shouldUnsupportedExceptionOnDelete() { assertThrows(UnsupportedOperationException.class, ()-> template.delete(Person.class)); } } From e37d4542c32556cc5d5edb2959624c6d32b421a0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:47 -0300 Subject: [PATCH 067/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/DefaultParameterMetaDataTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultParameterMetaDataTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultParameterMetaDataTest.java index 5bb31263e..eb31e91e7 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultParameterMetaDataTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/DefaultParameterMetaDataTest.java @@ -37,7 +37,7 @@ class DefaultParameterMetaDataTest { @BeforeEach - public void setUp(){ + void setUp(){ ClassConverter converter = new ReflectionClassConverter(); EntityMetadata entityMetadata = converter.apply(BookUser.class); ConstructorMetadata constructor = entityMetadata.constructor(); @@ -48,33 +48,33 @@ public void setUp(){ @Test - public void shouldParamType() { + void shouldParamType() { assertEquals(MappingType.DEFAULT, parameterMetaData.mappingType()); } @Test - public void shouldName() { + void shouldName() { assertEquals("native_name", parameterMetaData.name()); } @Test - public void shouldType() { + void shouldType() { assertEquals(String.class, parameterMetaData.type()); } @Test - public void shouldIsId() { + void shouldIsId() { assertFalse(parameterMetaData.isId()); } @Test - public void shouldConverter() { + void shouldConverter() { Optional>> converter = parameterMetaData.converter(); assertFalse(converter.isPresent()); } @Test - public void testNewConverter() { + void testNewConverter() { Assertions.assertThat(parameterMetaData.newConverter()).isEmpty(); } } \ No newline at end of file From 5357e3f60bc9c205d89dd40ea59a7748e2c4428f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:48 -0300 Subject: [PATCH 068/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/DefaultPropertyTest.java | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultPropertyTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultPropertyTest.java index cbf173deb..15e7414c2 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultPropertyTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultPropertyTest.java @@ -23,33 +23,33 @@ import static org.junit.jupiter.api.Assertions.assertThrows; -public class DefaultPropertyTest { +class DefaultPropertyTest { @Test - public void shouldReturnErrorWhenKeyINull() { + void shouldReturnErrorWhenKeyINull() { assertThrows(NullPointerException.class, () -> DefaultProperty.of(null, 10L)); } @Test - public void shouldReturnErrorWhenValueINull() { + void shouldReturnErrorWhenValueINull() { assertThrows(NullPointerException.class, () -> DefaultProperty.of("key", null)); } @Test - public void shouldReturnKey() { + void shouldReturnKey() { Property element = DefaultProperty.of("key", 10L); assertEquals("key", element.key()); } @Test - public void shouldReturnValue() { + void shouldReturnValue() { Property element = DefaultProperty.of("key", 10L); assertEquals(10L, element.value()); } @Test - public void shouldReturnValueAsObject() { + void shouldReturnValueAsObject() { long value = 10L; Property element = DefaultProperty.of("key", value); assertEquals(value, element.value()); @@ -57,7 +57,7 @@ public void shouldReturnValueAsObject() { @Test - public void shouldCreateInstanceValue() { + void shouldCreateInstanceValue() { Property element = DefaultProperty.of("key", Value.of(10L)); assertEquals(Value.of(10L), element.value()); assertEquals("key", element.key()); @@ -65,20 +65,20 @@ public void shouldCreateInstanceValue() { } @Test - public void shouldToString() { + void shouldToString() { Property element = DefaultProperty.of("key", 10L); assertEquals("DefaultProperty{key='key', value=10}", element.toString()); } @Test - public void shouldUnsupportedOperationException() { + void shouldUnsupportedOperationException() { Property element = DefaultProperty.of("key", 10L); assertThrows(UnsupportedOperationException.class, element::remove); assertThrows(UnsupportedOperationException.class, element::element); } @Test - public void shouldEqualsHashCode() { + void shouldEqualsHashCode() { Property element = DefaultProperty.of("key", 10L); assertEquals(element, element); assertEquals(element, DefaultProperty.of("key", 10L)); @@ -86,7 +86,7 @@ public void shouldEqualsHashCode() { } @Test - public void shouldIsPresent(){ + void shouldIsPresent(){ Property element = DefaultProperty.of("key", 10L); Assertions.assertThat(element.isPresent()).isTrue(); } From bcde6a8b8ccb6b9e36c5622f76c3b537a222b5db Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:52 -0300 Subject: [PATCH 069/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/query/DefaultQueryValueTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DefaultQueryValueTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DefaultQueryValueTest.java index 580e4796d..2d0ab685f 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DefaultQueryValueTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DefaultQueryValueTest.java @@ -19,7 +19,7 @@ class DefaultQueryValueTest { @Test - public void shouldCreateInstance(){ + void shouldCreateInstance(){ ParamQueryValue param = new DefaultQueryValue("name"); assertThat(param).isNotNull() .extracting(ParamQueryValue::type) @@ -27,7 +27,7 @@ public void shouldCreateInstance(){ } @Test - public void shouldReturnType(){ + void shouldReturnType(){ ParamQueryValue param = new DefaultQueryValue("name"); assertThat(param).isNotNull() .extracting(ParamQueryValue::type) @@ -35,7 +35,7 @@ public void shouldReturnType(){ } @Test - public void shouldReturnValue(){ + void shouldReturnValue(){ ParamQueryValue param = new DefaultQueryValue("name"); assertThat(param).isNotNull() .extracting(ParamQueryValue::get) @@ -43,14 +43,14 @@ public void shouldReturnValue(){ } @Test - public void shouldEquals(){ + void shouldEquals(){ ParamQueryValue param = new DefaultQueryValue("name"); ParamQueryValue paramB = new DefaultQueryValue("name"); Assertions.assertThat(param).isEqualTo(paramB); } @Test - public void shouldHashCode(){ + void shouldHashCode(){ ParamQueryValue param = new DefaultQueryValue("name"); ParamQueryValue paramB = new DefaultQueryValue("name"); Assertions.assertThat(param).hasSameHashCodeAs(paramB); From fd8bcca69ced68fef9fcf2d224d4852ea05a4441 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:53 -0300 Subject: [PATCH 070/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/repository/DefaultRepositoryReturnTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DefaultRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DefaultRepositoryReturnTest.java index a71b3b0b0..cee3b7815 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DefaultRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DefaultRepositoryReturnTest.java @@ -36,7 +36,7 @@ class DefaultRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Optional.class)); Assertions.assertTrue(repositoryReturn.isCompatible(Object.class, Person.class)); Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Object.class)); @@ -44,7 +44,7 @@ public void shouldReturnIsCompatible() { @Test - public void shouldReturnDefaultPage() { + void shouldReturnDefaultPage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Person.class) @@ -61,7 +61,7 @@ public void shouldReturnDefaultPage() { } @Test - public void shouldReturnDefault() { + void shouldReturnDefault() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withSingleResult(Optional::empty) From bc83676c004e9bec2f38f88632164fcf4b3e9a34 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:33:54 -0300 Subject: [PATCH 071/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/DefaultSelectQueryBuilderTest.java | 50 +++++++++---------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultSelectQueryBuilderTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultSelectQueryBuilderTest.java index cc5687fad..4a9bf49b2 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultSelectQueryBuilderTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DefaultSelectQueryBuilderTest.java @@ -38,16 +38,16 @@ import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; -public class DefaultSelectQueryBuilderTest { +class DefaultSelectQueryBuilderTest { @Test - public void shouldReturnErrorWhenHasNullElementInSelect() { + void shouldReturnErrorWhenHasNullElementInSelect() { Assertions.assertThrows(NullPointerException.class, () -> select("column", "column", null)); } @Test - public void shouldSelect() { + void shouldSelect() { String columnFamily = "columnFamily"; ColumnQuery query = select().from(columnFamily).build(); assertTrue(query.columns().isEmpty()); @@ -56,7 +56,7 @@ public void shouldSelect() { } @Test - public void shouldSelectColumns() { + void shouldSelectColumns() { String columnFamily = "columnFamily"; ColumnQuery query = select("column", "column2").from(columnFamily).build(); assertThat(query.columns()).contains("column", "column2"); @@ -65,13 +65,13 @@ public void shouldSelectColumns() { } @Test - public void shouldReturnErrorWhenFromIsNull() { + void shouldReturnErrorWhenFromIsNull() { Assertions.assertThrows(NullPointerException.class, () -> select().from(null)); } @Test - public void shouldSelectOrderAsc() { + void shouldSelectOrderAsc() { String columnFamily = "columnFamily"; ColumnQuery query = select().from(columnFamily).orderBy("name").asc().build(); assertTrue(query.columns().isEmpty()); @@ -81,7 +81,7 @@ public void shouldSelectOrderAsc() { } @Test - public void shouldSelectOrderDesc() { + void shouldSelectOrderDesc() { String columnFamily = "columnFamily"; ColumnQuery query = select().from(columnFamily).orderBy("name").desc().build(); assertTrue(query.columns().isEmpty()); @@ -91,7 +91,7 @@ public void shouldSelectOrderDesc() { } @Test - public void shouldReturnErrorSelectWhenOrderIsNull() { + void shouldReturnErrorSelectWhenOrderIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { String columnFamily = "columnFamily"; select().from(columnFamily).orderBy(null); @@ -99,7 +99,7 @@ public void shouldReturnErrorSelectWhenOrderIsNull() { } @Test - public void shouldSelectLimit() { + void shouldSelectLimit() { String columnFamily = "columnFamily"; ColumnQuery query = select().from(columnFamily).limit(10).build(); assertTrue(query.columns().isEmpty()); @@ -109,13 +109,13 @@ public void shouldSelectLimit() { } @Test - public void shouldReturnErrorWhenLimitIsNegative() { + void shouldReturnErrorWhenLimitIsNegative() { String columnFamily = "columnFamily"; Assertions.assertThrows(IllegalArgumentException.class, () -> builder().from(columnFamily).limit(-1)); } @Test - public void shouldSelectSkip() { + void shouldSelectSkip() { String columnFamily = "columnFamily"; ColumnQuery query = select().from(columnFamily).skip(10).build(); assertTrue(query.columns().isEmpty()); @@ -125,13 +125,13 @@ public void shouldSelectSkip() { } @Test - public void shouldReturnErrorWhenSkipIsNegative() { + void shouldReturnErrorWhenSkipIsNegative() { String columnFamily = "columnFamily"; Assertions.assertThrows(IllegalArgumentException.class, () -> builder().from(columnFamily).skip(-1)); } @Test - public void shouldSelectWhereNameEq() { + void shouldSelectWhereNameEq() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnQuery query = select().from(columnFamily).where("name").eq(name).build(); @@ -148,7 +148,7 @@ public void shouldSelectWhereNameEq() { } @Test - public void shouldSelectWhereNameLike() { + void shouldSelectWhereNameLike() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnQuery query = select().from(columnFamily).where("name").like(name).build(); @@ -164,7 +164,7 @@ public void shouldSelectWhereNameLike() { } @Test - public void shouldSelectWhereNameGt() { + void shouldSelectWhereNameGt() { String columnFamily = "columnFamily"; Number value = 10; ColumnQuery query = select().from(columnFamily).where("name").gt(value).build(); @@ -180,7 +180,7 @@ public void shouldSelectWhereNameGt() { } @Test - public void shouldSelectWhereNameGte() { + void shouldSelectWhereNameGte() { String columnFamily = "columnFamily"; Number value = 10; ColumnQuery query = select().from(columnFamily).where("name").gte(value).build(); @@ -196,7 +196,7 @@ public void shouldSelectWhereNameGte() { } @Test - public void shouldSelectWhereNameLt() { + void shouldSelectWhereNameLt() { String columnFamily = "columnFamily"; Number value = 10; ColumnQuery query = select().from(columnFamily).where("name").lt(value).build(); @@ -212,7 +212,7 @@ public void shouldSelectWhereNameLt() { } @Test - public void shouldSelectWhereNameLte() { + void shouldSelectWhereNameLte() { String columnFamily = "columnFamily"; Number value = 10; ColumnQuery query = select().from(columnFamily).where("name").lte(value).build(); @@ -228,7 +228,7 @@ public void shouldSelectWhereNameLte() { } @Test - public void shouldSelectWhereNameBetween() { + void shouldSelectWhereNameBetween() { String columnFamily = "columnFamily"; Number valueA = 10; Number valueB = 20; @@ -246,7 +246,7 @@ public void shouldSelectWhereNameBetween() { } @Test - public void shouldSelectWhereNameNot() { + void shouldSelectWhereNameNot() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnQuery query = select().from(columnFamily).where("name").not().eq(name).build(); @@ -264,7 +264,7 @@ public void shouldSelectWhereNameNot() { @Test - public void shouldSelectWhereNameAnd() { + void shouldSelectWhereNameAnd() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnQuery query = select().from(columnFamily).where("name").eq(name).and("age").gt(10).build(); @@ -279,7 +279,7 @@ public void shouldSelectWhereNameAnd() { } @Test - public void shouldSelectWhereNameOr() { + void shouldSelectWhereNameOr() { String columnFamily = "columnFamily"; String name = "Ada Lovelace"; ColumnQuery query = select().from(columnFamily).where("name").eq(name).or("age").gt(10).build(); @@ -294,7 +294,7 @@ public void shouldSelectWhereNameOr() { } @Test - public void shouldSelectNegate() { + void shouldSelectNegate() { String columnFamily = "columnFamily"; ColumnQuery query = select().from(columnFamily).where("city").not().eq("Assis") .and("name").not().eq("Lucas").build(); @@ -313,7 +313,7 @@ public void shouldSelectNegate() { } @Test - public void shouldExecuteManager() { + void shouldExecuteManager() { ColumnManager manager = Mockito.mock(ColumnManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); String columnFamily = "columnFamily"; @@ -324,7 +324,7 @@ public void shouldExecuteManager() { } @Test - public void shouldExecuteSingleResultManager() { + void shouldExecuteSingleResultManager() { ColumnManager manager = Mockito.mock(ColumnManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(ColumnQuery.class); String columnFamily = "columnFamily"; From c446475d4e59954995debe28de2efa976fbb2ac3 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:13 -0300 Subject: [PATCH 072/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../graph/DefaultValueMapTraversalTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultValueMapTraversalTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultValueMapTraversalTest.java index 173558940..98ece4b6a 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultValueMapTraversalTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultValueMapTraversalTest.java @@ -43,7 +43,7 @@ class DefaultValueMapTraversalTest extends AbstractTraversalTest { @Test - public void shouldCount() { + void shouldCount() { long count = graphTemplate.traversalVertex() .hasLabel(Person.class).valueMap("name").count(); assertEquals(3L, count); @@ -51,7 +51,7 @@ public void shouldCount() { @Test - public void shouldReturnMapValues() { + void shouldReturnMapValues() { List names = graphTemplate.traversalVertex() .hasLabel(Person.class).valueMap("name") .stream() @@ -62,7 +62,7 @@ public void shouldReturnMapValues() { } @Test - public void shouldReturnStream() { + void shouldReturnStream() { Stream> stream = graphTemplate.traversalVertex() .hasLabel(Person.class).valueMap("name") .stream(); @@ -72,7 +72,7 @@ public void shouldReturnStream() { @Test - public void shouldReturnResultAsList() { + void shouldReturnResultAsList() { List> maps = graphTemplate.traversalVertex() .hasLabel(Person.class).valueMap("name") .resultList(); @@ -80,21 +80,21 @@ public void shouldReturnResultAsList() { } @Test - public void shouldReturnErrorWhenThereAreMoreThanOneInGetSingleResult() { + void shouldReturnErrorWhenThereAreMoreThanOneInGetSingleResult() { assertThrows(NonUniqueResultException.class, () -> graphTemplate.traversalVertex() .hasLabel(Person.class).valueMap("name") .singleResult()); } @Test - public void shouldReturnOptionalEmptyWhenThereIsNotResultInSingleResult() { + void shouldReturnOptionalEmptyWhenThereIsNotResultInSingleResult() { Optional> entity = graphTemplate.traversalVertex() .hasLabel("not_found").valueMap("name").singleResult(); assertFalse(entity.isPresent()); } @Test - public void shouldReturnSingleResult() { + void shouldReturnSingleResult() { String name = "Poliana"; Optional> poliana = graphTemplate.traversalVertex().hasLabel("Person"). has("name", name).valueMap("name").singleResult(); From 9c33aceb45d62eaae11ecfd2754e1ee3a4e33aa6 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:14 -0300 Subject: [PATCH 073/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../java/org/eclipse/jnosql/communication/DefaultValueTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/DefaultValueTest.java b/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/DefaultValueTest.java index 633f1c7bc..85c8e6584 100644 --- a/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/DefaultValueTest.java +++ b/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/DefaultValueTest.java @@ -183,7 +183,7 @@ void shouldEquals(){ } @Test - public void shouldInstanceOf(){ + void shouldInstanceOf(){ var value = Value.of(10); Assertions.assertThat(value.isInstanceOf(Integer.class)).isTrue(); Assertions.assertThat(value.isInstanceOf(boolean.class)).isFalse(); From 43885a6c19e3fe19cccbf2d543e2eee759e8d1f1 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:15 -0300 Subject: [PATCH 074/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../graph/DefaultVertexTraversalTest.java | 110 +++++++++--------- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultVertexTraversalTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultVertexTraversalTest.java index 30448c087..028b44ee8 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultVertexTraversalTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/DefaultVertexTraversalTest.java @@ -49,16 +49,16 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class DefaultVertexTraversalTest extends AbstractTraversalTest { +class DefaultVertexTraversalTest extends AbstractTraversalTest { @Test - public void shouldReturnErrorWhenVertexIdIsNull() { + void shouldReturnErrorWhenVertexIdIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex(null)); } @Test - public void shouldGetVertexFromId() { + void shouldGetVertexFromId() { List people = graphTemplate.traversalVertex(otavio.getId(), poliana.getId()).result() .collect(toList()); @@ -66,7 +66,7 @@ public void shouldGetVertexFromId() { } @Test - public void shouldDefineLimit() { + void shouldDefineLimit() { List people = graphTemplate.traversalVertex(otavio.getId(), poliana.getId(), paulo.getId()).limit(1) .result() @@ -77,7 +77,7 @@ public void shouldDefineLimit() { } @Test - public void shouldDefineLimit2() { + void shouldDefineLimit2() { List people = graphTemplate.traversalVertex(otavio.getId(), poliana.getId(), paulo.getId()). next(2) .collect(toList()); @@ -87,27 +87,27 @@ public void shouldDefineLimit2() { } @Test - public void shouldNext() { + void shouldNext() { Optional next = graphTemplate.traversalVertex().next(); assertTrue(next.isPresent()); } @Test - public void shouldEmptyNext() { + void shouldEmptyNext() { Optional next = graphTemplate.traversalVertex(-12).next(); assertFalse(next.isPresent()); } @Test - public void shouldHave() { + void shouldHave() { Optional person = graphTemplate.traversalVertex().has("name", "Poliana").next(); assertTrue(person.isPresent()); assertEquals(person.get(), poliana); } @Test - public void shouldReturnErrorWhenHasNullKey() { + void shouldReturnErrorWhenHasNullKey() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex() .has((String) null, "Poliana") .next()); @@ -115,25 +115,25 @@ public void shouldReturnErrorWhenHasNullKey() { @Test - public void shouldReturnErrorWhenHasNullValue() { + void shouldReturnErrorWhenHasNullValue() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().has("name", null) .next()); } @Test - public void shouldHaveId() { + void shouldHaveId() { Optional person = graphTemplate.traversalVertex().has(T.id, poliana.getId()).next(); assertTrue(person.isPresent()); assertEquals(person.get(), poliana); } @Test - public void shouldReturnErrorWhenHasIdHasNullValue() { + void shouldReturnErrorWhenHasIdHasNullValue() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().has(T.id, null).next()); } @Test - public void shouldReturnErrorWhenHasIdHasNullAccessor() { + void shouldReturnErrorWhenHasIdHasNullAccessor() { assertThrows(NullPointerException.class, () -> { T id = null; graphTemplate.traversalVertex().has(id, poliana.getId()).next(); @@ -142,7 +142,7 @@ public void shouldReturnErrorWhenHasIdHasNullAccessor() { @Test - public void shouldHavePredicate() { + void shouldHavePredicate() { List result = graphTemplate.traversalVertex().has("age", P.gt(26)) .result() .toList(); @@ -150,7 +150,7 @@ public void shouldHavePredicate() { } @Test - public void shouldReturnErrorWhenHasPredicateIsNull() { + void shouldReturnErrorWhenHasPredicateIsNull() { assertThrows(NullPointerException.class, () -> { P gt = null; graphTemplate.traversalVertex().has("age", gt) @@ -160,7 +160,7 @@ public void shouldReturnErrorWhenHasPredicateIsNull() { } @Test - public void shouldReturnErrorWhenHasKeyIsNull() { + void shouldReturnErrorWhenHasKeyIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().has((String) null, P.gt(26)) .result() @@ -168,14 +168,14 @@ public void shouldReturnErrorWhenHasKeyIsNull() { } @Test - public void shouldHaveLabel() { + void shouldHaveLabel() { List books = graphTemplate.traversalVertex().hasLabel("Book").result().collect(toList()); assertEquals(3, books.size()); assertThat(books).contains(shack, license, effectiveJava); } @Test - public void shouldHaveLabel2() { + void shouldHaveLabel2() { List entities = graphTemplate.traversalVertex() .hasLabel(P.eq("Book").or(P.eq("Person"))) @@ -184,88 +184,88 @@ public void shouldHaveLabel2() { } @Test - public void shouldReturnErrorWhenHasLabelHasNull() { + void shouldReturnErrorWhenHasLabelHasNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().hasLabel((String) null) .result().collect(toList())); } @Test - public void shouldIn() { + void shouldIn() { List books = graphTemplate.traversalVertex().out(READS).result().collect(toList()); assertEquals(3, books.size()); assertThat(books).contains(shack, license, effectiveJava); } @Test - public void shouldReturnErrorWhenInIsNull() { + void shouldReturnErrorWhenInIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().out((String) null).result().collect(toList())); } @Test - public void shouldOut() { + void shouldOut() { List people = graphTemplate.traversalVertex().in(READS).result().collect(toList()); assertEquals(3, people.size()); assertThat(people).contains(otavio, poliana, paulo); } @Test - public void shouldReturnErrorWhenOutIsNull() { + void shouldReturnErrorWhenOutIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().in((String) null).result().collect(toList())); } @Test - public void shouldBoth() { + void shouldBoth() { List entities = graphTemplate.traversalVertex().both(READS) .result().toList(); assertEquals(6, entities.size()); } @Test - public void shouldReturnErrorWhenBothIsNull() { + void shouldReturnErrorWhenBothIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().both((String) null) .result().collect(toList())); } @Test - public void shouldNot() { + void shouldNot() { List result = graphTemplate.traversalVertex().hasNot("year").result().toList(); assertEquals(6, result.size()); } @Test - public void shouldReturnErrorWhenHasNotIsNull() { + void shouldReturnErrorWhenHasNotIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().hasNot((String) null) .result().collect(toList())); } @Test - public void shouldCount() { + void shouldCount() { long count = graphTemplate.traversalVertex().both(READS).count(); assertEquals(6L, count); } @Test - public void shouldReturnZeroWhenCountIsEmpty() { + void shouldReturnZeroWhenCountIsEmpty() { long count = graphTemplate.traversalVertex().both("WRITES").count(); assertEquals(0L, count); } @Test - public void shouldDefinesLimit() { + void shouldDefinesLimit() { long count = graphTemplate.traversalVertex().limit(1L).count(); assertEquals(1L, count); assertNotEquals(graphTemplate.traversalVertex().count(), count); } @Test - public void shouldDefinesRange() { + void shouldDefinesRange() { long count = graphTemplate.traversalVertex().range(1, 3).count(); assertEquals(2L, count); assertNotEquals(graphTemplate.traversalVertex().count(), count); } @Test - public void shouldMapValuesAsStream() { + void shouldMapValuesAsStream() { List> maps = graphTemplate.traversalVertex().hasLabel("Person") .valueMap("name").stream().toList(); @@ -280,7 +280,7 @@ public void shouldMapValuesAsStream() { } @Test - public void shouldMapValuesAsStreamLimit() { + void shouldMapValuesAsStreamLimit() { List> maps = graphTemplate.traversalVertex().hasLabel("Person") .valueMap("name").next(2).toList(); @@ -290,14 +290,14 @@ public void shouldMapValuesAsStreamLimit() { @Test - public void shouldReturnMapValueAsEmptyStream() { + void shouldReturnMapValueAsEmptyStream() { Stream> stream = graphTemplate.traversalVertex().hasLabel("Person") .valueMap("noField").stream(); assertTrue(stream.allMatch(m -> Objects.isNull(m.get("noFoundProperty")))); } @Test - public void shouldReturnNext() { + void shouldReturnNext() { Map map = graphTemplate.traversalVertex().hasLabel("Person") .valueMap("name").next(); @@ -307,7 +307,7 @@ public void shouldReturnNext() { @Test - public void shouldRepeatTimesTraversal() { + void shouldRepeatTimesTraversal() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -323,7 +323,7 @@ public void shouldRepeatTimesTraversal() { } @Test - public void shouldRepeatTimesTraversal2() { + void shouldRepeatTimesTraversal2() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -339,7 +339,7 @@ public void shouldRepeatTimesTraversal2() { } @Test - public void shouldRepeatUntilTraversal() { + void shouldRepeatUntilTraversal() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -360,7 +360,7 @@ public void shouldRepeatUntilTraversal() { } @Test - public void shouldRepeatUntilTraversal2() { + void shouldRepeatUntilTraversal2() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal snake = graphTemplate.insert(new Animal("snake")); Animal mouse = graphTemplate.insert(new Animal("mouse")); @@ -382,18 +382,18 @@ public void shouldRepeatUntilTraversal2() { @Test - public void shouldReturnErrorWhenTheOrderIsNull() { + void shouldReturnErrorWhenTheOrderIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().orderBy(null)); } @Test - public void shouldReturnErrorWhenThePropertyDoesNotExist() { + void shouldReturnErrorWhenThePropertyDoesNotExist() { assertThrows(NoSuchElementException.class, () -> graphTemplate.traversalVertex().orderBy("wrong property").asc().next().get()); } @Test - public void shouldOrderAsc() { + void shouldOrderAsc() { String property = "name"; List properties = graphTemplate.traversalVertex() @@ -408,7 +408,7 @@ public void shouldOrderAsc() { } @Test - public void shouldOrderDesc() { + void shouldOrderDesc() { String property = "name"; List properties = graphTemplate.traversalVertex() @@ -423,29 +423,29 @@ public void shouldOrderDesc() { } @Test - public void shouldReturnErrorWhenHasLabelStringNull() { + void shouldReturnErrorWhenHasLabelStringNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().hasLabel((String) null)); } @Test - public void shouldReturnErrorWhenHasLabelSupplierNull() { + void shouldReturnErrorWhenHasLabelSupplierNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().hasLabel((Supplier) null)); } @Test - public void shouldReturnErrorWhenHasLabelEntityClassNull() { + void shouldReturnErrorWhenHasLabelEntityClassNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().hasLabel((Class) null)); } @Test - public void shouldReturnHasLabel() { + void shouldReturnHasLabel() { assertTrue(graphTemplate.traversalVertex().hasLabel("Person").result().allMatch(Person.class::isInstance)); assertTrue(graphTemplate.traversalVertex().hasLabel(() -> "Book").result().allMatch(Book.class::isInstance)); assertTrue(graphTemplate.traversalVertex().hasLabel(Animal.class).result().allMatch(Animal.class::isInstance)); } @Test - public void shouldReturnResultAsList() { + void shouldReturnResultAsList() { List people = graphTemplate.traversalVertex().hasLabel("Person") .result() .toList(); @@ -453,18 +453,18 @@ public void shouldReturnResultAsList() { } @Test - public void shouldReturnErrorWhenThereAreMoreThanOneInGetSingleResult() { + void shouldReturnErrorWhenThereAreMoreThanOneInGetSingleResult() { assertThrows(NonUniqueResultException.class, () -> graphTemplate.traversalVertex().hasLabel("Person").singleResult()); } @Test - public void shouldReturnOptionalEmptyWhenThereIsNotResultInSingleResult() { + void shouldReturnOptionalEmptyWhenThereIsNotResultInSingleResult() { Optional entity = graphTemplate.traversalVertex().hasLabel("NoEntity").singleResult(); assertFalse(entity.isPresent()); } @Test - public void shouldReturnSingleResult() { + void shouldReturnSingleResult() { String name = "Poliana"; Optional poliana = graphTemplate.traversalVertex().hasLabel("Person"). has("name", name).singleResult(); @@ -472,12 +472,12 @@ public void shouldReturnSingleResult() { } @Test - public void shouldReturnErrorWhenPredicateIsNull() { + void shouldReturnErrorWhenPredicateIsNull() { assertThrows(NullPointerException.class, () -> graphTemplate.traversalVertex().filter(null)); } @Test - public void shouldPredicate() { + void shouldPredicate() { long count = graphTemplate.traversalVertex() .hasLabel(Person.class) .filter(Person::isAdult).count(); @@ -485,7 +485,7 @@ public void shouldPredicate() { } @Test - public void shouldDedup() { + void shouldDedup() { graphTemplate.edge(otavio, "knows", paulo); graphTemplate.edge(paulo, "knows", otavio); @@ -510,7 +510,7 @@ public void shouldDedup() { } @Test - public void shouldCreateTree() { + void shouldCreateTree() { Animal lion = graphTemplate.insert(new Animal("lion")); Animal zebra = graphTemplate.insert(new Animal("zebra")); Animal giraffe = graphTemplate.insert(new Animal("giraffe")); From e36e66b8b26adc9032f0f6bb0ceaf9f6087ca640 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:16 -0300 Subject: [PATCH 075/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../DeleteByMethodQueryProviderTest.java | 54 +++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/DeleteByMethodQueryProviderTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/DeleteByMethodQueryProviderTest.java index a2eb94e0e..1a0f96c19 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/DeleteByMethodQueryProviderTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/DeleteByMethodQueryProviderTest.java @@ -38,7 +38,7 @@ class DeleteByMethodQueryProviderTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteBy"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { String entity = "entity"; DeleteQuery deleteQuery = queryProvider.apply(query, entity); assertNotNull(deleteQuery); @@ -51,27 +51,27 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByName"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { String entity = "entity"; checkEqualsQuery(query, entity); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByNameEquals"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { String entity = "entity"; checkEqualsQuery(query, entity); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByNameNotEquals"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { checkNotCondition(query, Condition.EQUALS, "name"); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeGreaterThan"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { Condition operator = Condition.GREATER_THAN; String variable = "age"; @@ -80,7 +80,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeNotGreaterThan"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { Condition operator = Condition.GREATER_THAN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -88,7 +88,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeGreaterThanEqual"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { Condition operator = Condition.GREATER_EQUALS_THAN; String variable = "age"; @@ -97,7 +97,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeNotGreaterThanEqual"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { Condition operator = Condition.GREATER_EQUALS_THAN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -105,7 +105,7 @@ public void shouldReturnParserQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeLessThan"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { Condition operator = Condition.LESSER_THAN; String variable = "age"; @@ -114,7 +114,7 @@ public void shouldReturnParserQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeNotLessThan"}) - public void shouldReturnParserQuery9(String query) { + void shouldReturnParserQuery9(String query) { Condition operator = Condition.LESSER_THAN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -122,7 +122,7 @@ public void shouldReturnParserQuery9(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeLessThanEqual"}) - public void shouldReturnParserQuery10(String query) { + void shouldReturnParserQuery10(String query) { Condition operator = Condition.LESSER_EQUALS_THAN; String variable = "age"; @@ -131,7 +131,7 @@ public void shouldReturnParserQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeNotLessThanEqual"}) - public void shouldReturnParserQuery11(String query) { + void shouldReturnParserQuery11(String query) { Condition operator = Condition.LESSER_EQUALS_THAN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -139,7 +139,7 @@ public void shouldReturnParserQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeLike"}) - public void shouldReturnParserQuery12(String query) { + void shouldReturnParserQuery12(String query) { Condition operator = Condition.LIKE; String variable = "age"; @@ -148,7 +148,7 @@ public void shouldReturnParserQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeNotLike"}) - public void shouldReturnParserQuery13(String query) { + void shouldReturnParserQuery13(String query) { Condition operator = Condition.LIKE; String variable = "age"; checkNotCondition(query, operator, variable); @@ -157,7 +157,7 @@ public void shouldReturnParserQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeIn"}) - public void shouldReturnParserQuery14(String query) { + void shouldReturnParserQuery14(String query) { Condition operator = Condition.IN; String variable = "age"; @@ -166,7 +166,7 @@ public void shouldReturnParserQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeNotIn"}) - public void shouldReturnParserQuery15(String query) { + void shouldReturnParserQuery15(String query) { Condition operator = Condition.IN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -174,7 +174,7 @@ public void shouldReturnParserQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeAndName"}) - public void shouldReturnParserQuery16(String query) { + void shouldReturnParserQuery16(String query) { Condition operator = Condition.EQUALS; Condition operator2 = Condition.EQUALS; @@ -186,7 +186,7 @@ public void shouldReturnParserQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeOrName"}) - public void shouldReturnParserQuery17(String query) { + void shouldReturnParserQuery17(String query) { Condition operator = Condition.EQUALS; Condition operator2 = Condition.EQUALS; @@ -199,7 +199,7 @@ public void shouldReturnParserQuery17(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeOrNameLessThan"}) - public void shouldReturnParserQuery18(String query) { + void shouldReturnParserQuery18(String query) { Condition operator = Condition.EQUALS; Condition operator2 = Condition.LESSER_THAN; @@ -211,7 +211,7 @@ public void shouldReturnParserQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeGreaterThanOrNameIn"}) - public void shouldReturnParserQuery19(String query) { + void shouldReturnParserQuery19(String query) { Condition operator = Condition.GREATER_THAN; Condition operator2 = Condition.IN; @@ -223,7 +223,7 @@ public void shouldReturnParserQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeBetween"}) - public void shouldReturnParserQuery27(String query) { + void shouldReturnParserQuery27(String query) { Condition operator = Condition.BETWEEN; String entity = "entity"; @@ -244,7 +244,7 @@ public void shouldReturnParserQuery27(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeNotBetween"}) - public void shouldReturnParserQuery28(String query) { + void shouldReturnParserQuery28(String query) { String entity = "entity"; DeleteQuery deleteQuery = queryProvider.apply(query, entity); @@ -267,7 +267,7 @@ public void shouldReturnParserQuery28(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteBySalary_Currency"}) - public void shouldRunQuery29(String query) { + void shouldRunQuery29(String query) { String entity = "entity"; DeleteQuery deleteQuery = queryProvider.apply(query, entity); assertNotNull(deleteQuery); @@ -281,7 +281,7 @@ public void shouldRunQuery29(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteBySalary_CurrencyAndCredential_Role"}) - public void shouldRunQuery30(String query) { + void shouldRunQuery30(String query) { String entity = "entity"; DeleteQuery deleteQuery = queryProvider.apply(query, entity); assertNotNull(deleteQuery); @@ -300,7 +300,7 @@ public void shouldRunQuery30(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteBySalary_CurrencyAndName"}) - public void shouldRunQuery31(String query) { + void shouldRunQuery31(String query) { String entity = "entity"; DeleteQuery deleteQuery = queryProvider.apply(query, entity); assertNotNull(deleteQuery); @@ -319,7 +319,7 @@ public void shouldRunQuery31(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByActiveTrue"}) - public void shouldRunQuery32(String query) { + void shouldRunQuery32(String query) { String entity = "entity"; DeleteQuery deleteQuery = queryProvider.apply(query, entity); assertNotNull(deleteQuery); @@ -335,7 +335,7 @@ public void shouldRunQuery32(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByActiveFalse"}) - public void shouldRunQuery33(String query) { + void shouldRunQuery33(String query) { String entity = "entity"; DeleteQuery deleteQuery = queryProvider.apply(query, entity); assertNotNull(deleteQuery); From 341daca0869fb1fff7ee6ce3d1158940090463e7 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:17 -0300 Subject: [PATCH 076/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/query/method/DeleteMethodProviderTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/DeleteMethodProviderTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/DeleteMethodProviderTest.java index ab8f57556..ee952adda 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/DeleteMethodProviderTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/DeleteMethodProviderTest.java @@ -20,7 +20,7 @@ class DeleteMethodProviderTest { @Test - public void shouldCreate() { + void shouldCreate() { Method method = PersonRepository.class.getDeclaredMethods()[0]; DeleteQuery query = DeleteMethodProvider.INSTANCE.apply(method, "Person"); Assertions.assertNotNull(query); From 56a21ddc263a80925c36b415c8e149efdc9c2e6f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:18 -0300 Subject: [PATCH 077/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../query/DeleteQueryConverterTest.java | 46 +++++++++---------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DeleteQueryConverterTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DeleteQueryConverterTest.java index 822f3f610..7b0a817d6 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DeleteQueryConverterTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DeleteQueryConverterTest.java @@ -34,20 +34,20 @@ class DeleteQueryConverterTest { private final DeleteQueryConverter selectProvider = new DeleteQueryConverter(); @Test - public void shouldReturnErrorWhenStringIsNull() { + void shouldReturnErrorWhenStringIsNull() { Assertions.assertThrows(NullPointerException.class, () -> selectProvider.apply(null)); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertFalse(deleteQuery.where().isPresent()); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete name, address from God"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { DeleteQuery deleteQuery = selectProvider.apply(query); assertEquals("God", deleteQuery.entity()); assertFalse(deleteQuery.fields().isEmpty()); @@ -59,7 +59,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = 10"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -74,7 +74,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina > 10.23"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -89,7 +89,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina >= 10.23"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -104,7 +104,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina <= 10.23"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -119,7 +119,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina < 10.23"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -135,7 +135,7 @@ public void shouldReturnParserQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age between 10 and 30"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -153,7 +153,7 @@ public void shouldReturnParserQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"diana\""}) - public void shouldReturnParserQuery9(String query) { + void shouldReturnParserQuery9(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -168,7 +168,7 @@ public void shouldReturnParserQuery9(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = {\"diana\"}"}) - public void shouldReturnParserQuery10(String query) { + void shouldReturnParserQuery10(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -185,7 +185,7 @@ public void shouldReturnParserQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = {\"diana\", 17, 20.21}"}) - public void shouldReturnParserQuery11(String query) { + void shouldReturnParserQuery11(String query) { DeleteQuery selectQuery = checkDeleteFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -202,7 +202,7 @@ public void shouldReturnParserQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery12(String query) { + void shouldReturnParserQuery12(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -219,7 +219,7 @@ public void shouldReturnParserQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = @name"}) - public void shouldReturnParserQuery13(String query) { + void shouldReturnParserQuery13(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -235,7 +235,7 @@ public void shouldReturnParserQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = convert(12, java.lang.Integer)"}) - public void shouldReturnParserQuery14(String query) { + void shouldReturnParserQuery14(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -254,7 +254,7 @@ public void shouldReturnParserQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name in (\"Ada\", \"Apollo\")"}) - public void shouldReturnParserQuery15(String query) { + void shouldReturnParserQuery15(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -272,7 +272,7 @@ public void shouldReturnParserQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name like \"Ada\""}) - public void shouldReturnParserQuery16(String query) { + void shouldReturnParserQuery16(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -287,7 +287,7 @@ public void shouldReturnParserQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name not like \"Ada\""}) - public void shouldReturnParserQuery17(String query) { + void shouldReturnParserQuery17(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -310,7 +310,7 @@ public void shouldReturnParserQuery17(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20 and" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery18(String query) { + void shouldReturnParserQuery18(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -349,7 +349,7 @@ public void shouldReturnParserQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" or age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery19(String query) { + void shouldReturnParserQuery19(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -389,7 +389,7 @@ public void shouldReturnParserQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery20(String query) { + void shouldReturnParserQuery20(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -439,7 +439,7 @@ public void shouldReturnParserQuery20(String query) { @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"} or birthday =" + " convert(\"2007-12-03\", java.time.LocalDate)"}) - public void shouldReturnParserQuery21(String query) { + void shouldReturnParserQuery21(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); @@ -502,7 +502,7 @@ public void shouldReturnParserQuery21(String query) { @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"} and birthday =" + " convert(\"2007-12-03\", java.time.LocalDate)"}) - public void shouldReturnParserQuery22(String query) { + void shouldReturnParserQuery22(String query) { DeleteQuery deleteQuery = checkDeleteFromStart(query); assertTrue(deleteQuery.where().isPresent()); From 80e8e407c3284f9d1bee60f40e4704dc07fd869b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:19 -0300 Subject: [PATCH 078/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../graph/query/DeleteQueryConverterTest.java | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/DeleteQueryConverterTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/DeleteQueryConverterTest.java index 3ae8eddb9..52f52c40f 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/DeleteQueryConverterTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/DeleteQueryConverterTest.java @@ -66,26 +66,26 @@ class DeleteQueryConverterTest { private Graph graph; @BeforeEach - public void setUp() { + void setUp() { graph.traversal().E().toList().forEach(Edge::remove); graph.traversal().V().toList().forEach(Vertex::remove); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByName"}) - public void shouldRunQuery(String methodName) { + void shouldRunQuery(String methodName) { checkEquals(methodName); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByNameEquals"}) - public void shouldRunQuery1(String methodName) { + void shouldRunQuery1(String methodName) { checkEquals(methodName); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByNameNotEquals"}) - public void shouldRunQuery2(String methodName) { + void shouldRunQuery2(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -104,7 +104,7 @@ public void shouldRunQuery2(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeLessThan"}) - public void shouldRunQuery3(String methodName) { + void shouldRunQuery3(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -122,7 +122,7 @@ public void shouldRunQuery3(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeLessThanEqual"}) - public void shouldRunQuery4(String methodName) { + void shouldRunQuery4(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -142,7 +142,7 @@ public void shouldRunQuery4(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeGreaterThan"}) - public void shouldRunQuery5(String methodName) { + void shouldRunQuery5(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -160,7 +160,7 @@ public void shouldRunQuery5(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeGreaterThanEqual"}) - public void shouldRunQuery6(String methodName) { + void shouldRunQuery6(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -179,7 +179,7 @@ public void shouldRunQuery6(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeBetween"}) - public void shouldRunQuery7(String methodName) { + void shouldRunQuery7(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -199,7 +199,7 @@ public void shouldRunQuery7(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeIn"}) - public void shouldRunQuery11(String methodName) { + void shouldRunQuery11(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -220,7 +220,7 @@ public void shouldRunQuery11(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByNameIn"}) - public void shouldRunQuery12(String methodName) { + void shouldRunQuery12(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); From 46d6112b3232a84556e46cfb6d58516d2d720ee0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:20 -0300 Subject: [PATCH 079/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/DeleteQueryParserTest.java | 42 +++++++++---------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DeleteQueryParserTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DeleteQueryParserTest.java index dbfbe53f6..58afb284a 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DeleteQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/DeleteQueryParserTest.java @@ -48,7 +48,7 @@ class DeleteQueryParserTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -61,7 +61,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete name, address from God"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -74,7 +74,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina > 10.23"}) - public void shouldReturnParserQuery11(String query) { + void shouldReturnParserQuery11(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -90,7 +90,7 @@ public void shouldReturnParserQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina >= -10.23"}) - public void shouldReturnParserQuery12(String query) { + void shouldReturnParserQuery12(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -106,7 +106,7 @@ public void shouldReturnParserQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina <= -10.23"}) - public void shouldReturnParserQuery13(String query) { + void shouldReturnParserQuery13(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -122,7 +122,7 @@ public void shouldReturnParserQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina < -10.23"}) - public void shouldReturnParserQuery14(String query) { + void shouldReturnParserQuery14(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -138,7 +138,7 @@ public void shouldReturnParserQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age between 10 and 30"}) - public void shouldReturnParserQuery15(String query) { + void shouldReturnParserQuery15(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -154,7 +154,7 @@ public void shouldReturnParserQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"diana\""}) - public void shouldReturnParserQuery16(String query) { + void shouldReturnParserQuery16(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -170,7 +170,7 @@ public void shouldReturnParserQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery18(String query) { + void shouldReturnParserQuery18(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -191,7 +191,7 @@ public void shouldReturnParserQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = convert(12, java.lang.Integer)"}) - public void shouldReturnParserQuery19(String query) { + void shouldReturnParserQuery19(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -210,7 +210,7 @@ public void shouldReturnParserQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name in (\"Ada\", \"Apollo\")"}) - public void shouldReturnParserQuery20(String query) { + void shouldReturnParserQuery20(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -229,7 +229,7 @@ public void shouldReturnParserQuery20(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name like \"Ada\""}) - public void shouldReturnParserQuery21(String query) { + void shouldReturnParserQuery21(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -246,7 +246,7 @@ public void shouldReturnParserQuery21(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name not like \"Ada\""}) - public void shouldReturnParserQuery22(String query) { + void shouldReturnParserQuery22(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -266,7 +266,7 @@ public void shouldReturnParserQuery22(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20"}) - public void shouldReturnParserQuery23(String query) { + void shouldReturnParserQuery23(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -285,7 +285,7 @@ public void shouldReturnParserQuery23(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" or age = 20"}) - public void shouldReturnParserQuery24(String query) { + void shouldReturnParserQuery24(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -305,7 +305,7 @@ public void shouldReturnParserQuery24(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery25(String query) { + void shouldReturnParserQuery25(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); @@ -329,7 +329,7 @@ public void shouldReturnParserQuery25(String query) { @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"} and birthday =" + " convert(\"2007-12-03\", java.time.LocalDate)"}) - public void shouldReturnParserQuery26(String query) { + void shouldReturnParserQuery26(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).delete(captor.capture()); @@ -350,7 +350,7 @@ public void shouldReturnParserQuery26(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldReturnErrorWhenNeedPrepareStatement(String query) { + void shouldReturnErrorWhenNeedPrepareStatement(String query) { assertThrows(QueryException.class, () -> parser.query(query, manager, observer)); @@ -359,7 +359,7 @@ public void shouldReturnErrorWhenNeedPrepareStatement(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldReturnErrorWhenIsQueryWithParam(String query) { + void shouldReturnErrorWhenIsQueryWithParam(String query) { assertThrows(QueryException.class, () -> parser.query(query, manager, observer)); @@ -367,7 +367,7 @@ public void shouldReturnErrorWhenIsQueryWithParam(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldReturnErrorWhenDontBindParameters(String query) { + void shouldReturnErrorWhenDontBindParameters(String query) { ColumnPreparedStatement prepare = parser.prepare(query, manager, observer); assertThrows(QueryException.class, prepare::result); @@ -375,7 +375,7 @@ public void shouldReturnErrorWhenDontBindParameters(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnDeleteQuery.class); ColumnPreparedStatement prepare = parser.prepare(query, manager, observer); From eef7c3ddb348bf51de7e985ff15987cb7f97db2d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:20 -0300 Subject: [PATCH 080/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DeleteQueryParserTest.java | 42 +++++++++---------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DeleteQueryParserTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DeleteQueryParserTest.java index dbc4603fb..96eca23d9 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DeleteQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DeleteQueryParserTest.java @@ -48,7 +48,7 @@ class DeleteQueryParserTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -61,7 +61,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete name, address from God"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -74,7 +74,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina > 10.23"}) - public void shouldReturnParserQuery11(String query) { + void shouldReturnParserQuery11(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -90,7 +90,7 @@ public void shouldReturnParserQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina >= -10.23"}) - public void shouldReturnParserQuery12(String query) { + void shouldReturnParserQuery12(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -106,7 +106,7 @@ public void shouldReturnParserQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina <= -10.23"}) - public void shouldReturnParserQuery13(String query) { + void shouldReturnParserQuery13(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -122,7 +122,7 @@ public void shouldReturnParserQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where stamina < -10.23"}) - public void shouldReturnParserQuery14(String query) { + void shouldReturnParserQuery14(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -138,7 +138,7 @@ public void shouldReturnParserQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age between 10 and 30"}) - public void shouldReturnParserQuery15(String query) { + void shouldReturnParserQuery15(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -154,7 +154,7 @@ public void shouldReturnParserQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"diana\""}) - public void shouldReturnParserQuery16(String query) { + void shouldReturnParserQuery16(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -170,7 +170,7 @@ public void shouldReturnParserQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery18(String query) { + void shouldReturnParserQuery18(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -191,7 +191,7 @@ public void shouldReturnParserQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = convert(12, java.lang.Integer)"}) - public void shouldReturnParserQuery19(String query) { + void shouldReturnParserQuery19(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -210,7 +210,7 @@ public void shouldReturnParserQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name in (\"Ada\", \"Apollo\")"}) - public void shouldReturnParserQuery20(String query) { + void shouldReturnParserQuery20(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -229,7 +229,7 @@ public void shouldReturnParserQuery20(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name like \"Ada\""}) - public void shouldReturnParserQuery21(String query) { + void shouldReturnParserQuery21(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -246,7 +246,7 @@ public void shouldReturnParserQuery21(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name not like \"Ada\""}) - public void shouldReturnParserQuery22(String query) { + void shouldReturnParserQuery22(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -266,7 +266,7 @@ public void shouldReturnParserQuery22(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20"}) - public void shouldReturnParserQuery23(String query) { + void shouldReturnParserQuery23(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -285,7 +285,7 @@ public void shouldReturnParserQuery23(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" or age = 20"}) - public void shouldReturnParserQuery24(String query) { + void shouldReturnParserQuery24(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -305,7 +305,7 @@ public void shouldReturnParserQuery24(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery25(String query) { + void shouldReturnParserQuery25(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); @@ -329,7 +329,7 @@ public void shouldReturnParserQuery25(String query) { @ValueSource(strings = {"delete from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"} and birthday =" + " convert(\"2007-12-03\", java.time.LocalDate)"}) - public void shouldReturnParserQuery26(String query) { + void shouldReturnParserQuery26(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).delete(captor.capture()); @@ -350,7 +350,7 @@ public void shouldReturnParserQuery26(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldReturnErrorWhenNeedPrepareStatement(String query) { + void shouldReturnErrorWhenNeedPrepareStatement(String query) { assertThrows(QueryException.class, () -> parser.query(query, documentCollection, observer)); @@ -358,7 +358,7 @@ public void shouldReturnErrorWhenNeedPrepareStatement(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldReturnErrorWhenIsQueryWithParam(String query) { + void shouldReturnErrorWhenIsQueryWithParam(String query) { assertThrows(QueryException.class, () -> parser.query(query, documentCollection, observer)); @@ -366,7 +366,7 @@ public void shouldReturnErrorWhenIsQueryWithParam(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldReturnErrorWhenDontBindParameters(String query) { + void shouldReturnErrorWhenDontBindParameters(String query) { DocumentPreparedStatement prepare = parser.prepare(query, documentCollection, observer); assertThrows(QueryException.class, prepare::result); @@ -374,7 +374,7 @@ public void shouldReturnErrorWhenDontBindParameters(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); DocumentPreparedStatement prepare = parser.prepare(query, documentCollection, observer); From d8e386e51f0ab8bf6aa29046f45c57f3fadfcaf1 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:21 -0300 Subject: [PATCH 081/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/query/DelQueryTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DelQueryTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DelQueryTest.java index 167e44c31..ed964841f 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DelQueryTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/DelQueryTest.java @@ -26,39 +26,39 @@ import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.ArgumentsSource; -public class DelQueryTest { +class DelQueryTest { @ParameterizedTest @ArgumentsSource(DelQueryArgumentProvider.class) - public void shouldExecuteQuery(String query) { + void shouldExecuteQuery(String query) { testQuery(query); } @Test - public void shouldIgnoreComments() { + void shouldIgnoreComments() { testQuery("//ignore this line \n del 12"); } @ParameterizedTest @ArgumentsSource(WrongDelQueryArgumentProvider.class) - public void shouldNotExecute(String query) { + void shouldNotExecute(String query) { Assertions.assertThrows(QueryException.class, () -> testQuery(query)); } @Test - public void shouldCreateFromMethodFactory(){ + void shouldCreateFromMethodFactory(){ DelQuery query = DelQuery.parse("del \"Ada Lovelace\""); Assertions.assertNotNull(query); } @Test - public void shouldEquals(){ + void shouldEquals(){ String text = "del \"Ada Lovelace\""; Assertions.assertEquals(DelQuery.parse(text), DelQuery.parse(text)); } @Test - public void shouldHashCode(){ + void shouldHashCode(){ String text = "del \"Ada Lovelace\""; Assertions.assertEquals(DelQuery.parse(text).hashCode(), DelQuery.parse(text).hashCode()); } From 9fc216a761fdb2e70674107fc109fce14fce94e9 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:23 -0300 Subject: [PATCH 082/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/collection/DequeSupplierTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/DequeSupplierTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/DequeSupplierTest.java index 5d1a4ca1a..5b92d49d2 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/DequeSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/DequeSupplierTest.java @@ -31,19 +31,19 @@ class DequeSupplierTest { private CollectionSupplier supplier; @BeforeEach - public void setUp() { + void setUp() { this.supplier = new DequeSupplier(); } @Test - public void shouldTest() { + void shouldTest() { Assertions.assertTrue(supplier.test(Deque.class)); Assertions.assertTrue(supplier.test(Queue.class)); Assertions.assertFalse(supplier.test(List.class)); } @Test - public void shouldGet() { + void shouldGet() { final Collection collection = this.supplier.get(); Assertions.assertNotNull(collection); Assertions.assertTrue(collection instanceof LinkedList); From 533fa033fda2fb5f52ebee7df0f145e8720f4578 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:24 -0300 Subject: [PATCH 083/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DocumentConditionTest.java | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentConditionTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentConditionTest.java index 97bed1891..ebe4ea649 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentConditionTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentConditionTest.java @@ -32,16 +32,16 @@ import static org.junit.jupiter.api.Assertions.assertThrows; -public class DocumentConditionTest { +class DocumentConditionTest { @Test - public void shouldReturnErrorWhenDocumentIsNull() { + void shouldReturnErrorWhenDocumentIsNull() { assertThrows(NullPointerException.class, () -> DocumentCondition.of(null, Condition.AND)); } @Test - public void shouldCreateAnInstance() { + void shouldCreateAnInstance() { Document name = Document.of("name", "Otavio"); DocumentCondition condition = DocumentCondition.of(name, Condition.EQUALS); assertNotNull(condition); @@ -50,7 +50,7 @@ public void shouldCreateAnInstance() { } @Test - public void shouldCreateNegationCondition() { + void shouldCreateNegationCondition() { Document age = Document.of("age", 26); DocumentCondition condition = DocumentCondition.of(age, Condition.GREATER_THAN); DocumentCondition negate = condition.negate(); @@ -61,7 +61,7 @@ public void shouldCreateNegationCondition() { } @Test - public void shouldReturnValidDoubleNegation() { + void shouldReturnValidDoubleNegation() { Document age = Document.of("age", 26); DocumentCondition condition = DocumentCondition.of(age, Condition.GREATER_THAN); DocumentCondition affirmative = condition.negate().negate(); @@ -69,7 +69,7 @@ public void shouldReturnValidDoubleNegation() { } @Test - public void shouldCreateAndCondition() { + void shouldCreateAndCondition() { Document age = Document.of("age", 26); Document name = Document.of("name", "Otavio"); DocumentCondition condition1 = DocumentCondition.of(name, Condition.EQUALS); @@ -85,7 +85,7 @@ public void shouldCreateAndCondition() { } @Test - public void shouldCreateOrCondition() { + void shouldCreateOrCondition() { Document age = Document.of("age", 26); Document name = Document.of("name", "Otavio"); DocumentCondition condition1 = DocumentCondition.of(name, Condition.EQUALS); @@ -101,19 +101,19 @@ public void shouldCreateOrCondition() { } @Test - public void shouldReturnErrorWhenCreateAndWithNullValues() { + void shouldReturnErrorWhenCreateAndWithNullValues() { assertThrows(NullPointerException.class, () -> DocumentCondition.and((DocumentCondition[]) null)); } @Test - public void shouldReturnErrorWhenCreateOrWithNullValues() { + void shouldReturnErrorWhenCreateOrWithNullValues() { assertThrows(NullPointerException.class, () -> DocumentCondition.or((DocumentCondition[]) null)); } @Test - public void shouldAppendAnd() { + void shouldAppendAnd() { DocumentCondition eq = DocumentCondition.eq(Document.of("name", "otavio")); DocumentCondition gt = DocumentCondition.gt(Document.of("age", 10)); DocumentCondition and = DocumentCondition.and(eq, gt); @@ -124,7 +124,7 @@ public void shouldAppendAnd() { } @Test - public void shouldAppendOr() { + void shouldAppendOr() { DocumentCondition eq = DocumentCondition.eq(Document.of("name", "otavio")); DocumentCondition gt = DocumentCondition.gt(Document.of("age", 10)); DocumentCondition and = DocumentCondition.or(eq, gt); @@ -135,7 +135,7 @@ public void shouldAppendOr() { } @Test - public void shouldAnd() { + void shouldAnd() { DocumentCondition eq = DocumentCondition.eq(Document.of("name", "otavio")); DocumentCondition gt = DocumentCondition.gt(Document.of("age", 10)); DocumentCondition lte = DocumentCondition.lte(Document.of("salary", 10_000.00)); @@ -154,7 +154,7 @@ public void shouldAnd() { } @Test - public void shouldOr() { + void shouldOr() { DocumentCondition eq = DocumentCondition.eq(Document.of("name", "otavio")); DocumentCondition gt = DocumentCondition.gt(Document.of("age", 10)); DocumentCondition lte = DocumentCondition.lte(Document.of("salary", 10_000.00)); @@ -173,7 +173,7 @@ public void shouldOr() { } @Test - public void shouldNegate() { + void shouldNegate() { DocumentCondition eq = DocumentCondition.eq(Document.of("name", "otavio")); DocumentCondition negate = eq.negate(); assertEquals(Condition.NOT, negate.condition()); @@ -182,7 +182,7 @@ public void shouldNegate() { } @Test - public void shouldAffirmDoubleNegate() { + void shouldAffirmDoubleNegate() { DocumentCondition eq = DocumentCondition.eq(Document.of("name", "otavio")); DocumentCondition affirm = eq.negate().negate(); assertEquals(eq.condition(), affirm.condition()); @@ -190,12 +190,12 @@ public void shouldAffirmDoubleNegate() { } @Test - public void shouldReturnErrorWhenBetweenIsNull() { + void shouldReturnErrorWhenBetweenIsNull() { assertThrows(NullPointerException.class, () -> DocumentCondition.between(null)); } @Test - public void shouldReturnErrorWhenBetweenIsNotIterable() { + void shouldReturnErrorWhenBetweenIsNotIterable() { assertThrows(IllegalArgumentException.class, () -> { Document document = Document.of("age", 12); DocumentCondition.between(document); @@ -203,7 +203,7 @@ public void shouldReturnErrorWhenBetweenIsNotIterable() { } @Test - public void shouldReturnErrorWhenIterableHasOneElement() { + void shouldReturnErrorWhenIterableHasOneElement() { assertThrows(IllegalArgumentException.class, () -> { Document document = Document.of("age", Collections.singleton(12)); DocumentCondition.between(document); @@ -211,7 +211,7 @@ public void shouldReturnErrorWhenIterableHasOneElement() { } @Test - public void shouldReturnErrorWhenIterableHasMoreThanTwoElement2() { + void shouldReturnErrorWhenIterableHasMoreThanTwoElement2() { assertThrows(IllegalArgumentException.class, () -> { Document document = Document.of("age", Arrays.asList(12, 12, 12)); DocumentCondition.between(document); @@ -219,7 +219,7 @@ public void shouldReturnErrorWhenIterableHasMoreThanTwoElement2() { } @Test - public void shouldReturnBetween() { + void shouldReturnBetween() { Document document = Document.of("age", Arrays.asList(12, 13)); DocumentCondition between = DocumentCondition.between(document); assertEquals(Condition.BETWEEN, between.condition()); @@ -229,13 +229,13 @@ public void shouldReturnBetween() { } @Test - public void shouldReturnErrorWhenInConditionIsInvalid() { + void shouldReturnErrorWhenInConditionIsInvalid() { assertThrows(NullPointerException.class, () -> DocumentCondition.in(null)); assertThrows(IllegalArgumentException.class, () -> DocumentCondition.in(Document.of("value", 10))); } @Test - public void shouldReturnInClause() { + void shouldReturnInClause() { Document column = Document.of("age", Arrays.asList(12, 13)); DocumentCondition in = DocumentCondition.in(column); assertEquals(Condition.IN, in.condition()); From 749d7e559e6093d0afed7c1aa7e4abb59636eea6 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:24 -0300 Subject: [PATCH 084/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- ...DocumentEntityConverterConstructorTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterConstructorTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterConstructorTest.java index e6c029440..8ac487a37 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterConstructorTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterConstructorTest.java @@ -47,13 +47,13 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, DocumentExtension.class}) -public class DocumentEntityConverterConstructorTest { +class DocumentEntityConverterConstructorTest { @Inject private DocumentEntityConverter converter; @Test - public void shouldConverterEntityComputer() { + void shouldConverterEntityComputer() { DocumentEntity communication = DocumentEntity.of("Computer"); communication.add("_id", 10L); communication.add("name", "Dell"); @@ -70,7 +70,7 @@ public void shouldConverterEntityComputer() { } @Test - public void shouldConvertComputerToCommunication() { + void shouldConvertComputerToCommunication() { Computer computer = new Computer(10L, "Dell", 2020, "Dell 2020", Money.parse("USD 20")); DocumentEntity communication = this.converter.toDocument(computer); @@ -84,7 +84,7 @@ public void shouldConvertComputerToCommunication() { } @Test - public void shouldConvertPetOwner() { + void shouldConvertPetOwner() { DocumentEntity communication = DocumentEntity.of("PetOwner"); communication.add("_id", 10L); communication.add("name", "Otavio"); @@ -101,7 +101,7 @@ public void shouldConvertPetOwner() { } @Test - public void shouldConvertPetOwnerCommunication() { + void shouldConvertPetOwnerCommunication() { Animal ada = new Animal("Ada"); PetOwner petOwner = new PetOwner(10L, "Poliana", ada); DocumentEntity communication = this.converter.toDocument(petOwner); @@ -115,7 +115,7 @@ public void shouldConvertPetOwnerCommunication() { } @Test - public void shouldConvertBookUser() { + void shouldConvertBookUser() { DocumentEntity communication = DocumentEntity.of("BookUser"); communication.add("_id", "otaviojava"); communication.add("native_name", "Otavio Santana"); @@ -133,7 +133,7 @@ public void shouldConvertBookUser() { } @Test - public void shouldConverterFieldsOnEntityComputer() { + void shouldConverterFieldsOnEntityComputer() { DocumentEntity communication = DocumentEntity.of("Computer"); communication.add("_id", "10"); communication.add("name", "Dell"); @@ -150,7 +150,7 @@ public void shouldConverterFieldsOnEntityComputer() { } @Test - public void shouldConverterEntityBookRelease() { + void shouldConverterEntityBookRelease() { DocumentEntity communication = DocumentEntity.of("BookRelease"); communication.add("isbn", "9780132345286"); communication.add("title", "Effective Java"); @@ -165,7 +165,7 @@ public void shouldConverterEntityBookRelease() { } @Test - public void shouldConverterEntityBookReleaseOnStringYear() { + void shouldConverterEntityBookReleaseOnStringYear() { DocumentEntity communication = DocumentEntity.of("BookRelease"); communication.add("isbn", "9780132345286"); communication.add("title", "Effective Java"); From 183ea7a893614797685773be4b758b0b1eb73acc Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:25 -0300 Subject: [PATCH 085/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- ...ocumentEntityConverterInheritanceTest.java | 40 +++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterInheritanceTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterInheritanceTest.java index 08f3c1c76..75ce3c34a 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterInheritanceTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterInheritanceTest.java @@ -60,7 +60,7 @@ class DocumentEntityConverterInheritanceTest { private DocumentEntityConverter converter; @Test - public void shouldConvertProjectToSmallProject() { + void shouldConvertProjectToSmallProject() { DocumentEntity entity = DocumentEntity.of("Project"); entity.add("_id", "Small Project"); entity.add("investor", "Otavio Santana"); @@ -73,7 +73,7 @@ public void shouldConvertProjectToSmallProject() { } @Test - public void shouldConvertProjectToLargeProject() { + void shouldConvertProjectToLargeProject() { DocumentEntity entity = DocumentEntity.of("Project"); entity.add("_id", "Large Project"); entity.add("budget", BigDecimal.TEN); @@ -86,7 +86,7 @@ public void shouldConvertProjectToLargeProject() { } @Test - public void shouldConvertProject() { + void shouldConvertProject() { DocumentEntity entity = DocumentEntity.of("Project"); entity.add("_id", "Project"); entity.add("size", "Project"); @@ -95,7 +95,7 @@ public void shouldConvertProject() { } @Test - public void shouldConvertProjectToCommunicationEntity() { + void shouldConvertProjectToCommunicationEntity() { Project project = new Project(); project.setName("Large Project"); DocumentEntity entity = this.converter.toDocument(project); @@ -106,7 +106,7 @@ public void shouldConvertProjectToCommunicationEntity() { } @Test - public void shouldConvertLargeProjectToCommunicationEntity() { + void shouldConvertLargeProjectToCommunicationEntity() { LargeProject project = new LargeProject(); project.setName("Large Project"); project.setBudget(BigDecimal.TEN); @@ -119,7 +119,7 @@ public void shouldConvertLargeProjectToCommunicationEntity() { } @Test - public void shouldConvertSmallProjectToCommunicationEntity() { + void shouldConvertSmallProjectToCommunicationEntity() { SmallProject project = new SmallProject(); project.setName("Small Project"); project.setInvestor("Otavio Santana"); @@ -132,7 +132,7 @@ public void shouldConvertSmallProjectToCommunicationEntity() { } @Test - public void shouldConvertDocumentEntityToSocialMedia(){ + void shouldConvertDocumentEntityToSocialMedia(){ LocalDate date = LocalDate.now(); DocumentEntity entity = DocumentEntity.of("Notification"); entity.add("_id", 100L); @@ -148,7 +148,7 @@ public void shouldConvertDocumentEntityToSocialMedia(){ } @Test - public void shouldConvertDocumentEntityToSms(){ + void shouldConvertDocumentEntityToSms(){ LocalDate date = LocalDate.now(); DocumentEntity entity = DocumentEntity.of("Notification"); entity.add("_id", 100L); @@ -164,7 +164,7 @@ public void shouldConvertDocumentEntityToSms(){ } @Test - public void shouldConvertDocumentEntityToEmail(){ + void shouldConvertDocumentEntityToEmail(){ LocalDate date = LocalDate.now(); DocumentEntity entity = DocumentEntity.of("Notification"); entity.add("_id", 100L); @@ -180,7 +180,7 @@ public void shouldConvertDocumentEntityToEmail(){ } @Test - public void shouldConvertSocialMediaToCommunicationEntity(){ + void shouldConvertSocialMediaToCommunicationEntity(){ SocialMediaNotification notification = new SocialMediaNotification(); notification.setId(100L); notification.setName("Social Media"); @@ -196,7 +196,7 @@ public void shouldConvertSocialMediaToCommunicationEntity(){ } @Test - public void shouldConvertSmsToCommunicationEntity(){ + void shouldConvertSmsToCommunicationEntity(){ SmsNotification notification = new SmsNotification(); notification.setId(100L); notification.setName("SMS"); @@ -212,7 +212,7 @@ public void shouldConvertSmsToCommunicationEntity(){ } @Test - public void shouldConvertEmailToCommunicationEntity(){ + void shouldConvertEmailToCommunicationEntity(){ EmailNotification notification = new EmailNotification(); notification.setId(100L); notification.setName("Email Media"); @@ -228,7 +228,7 @@ public void shouldConvertEmailToCommunicationEntity(){ } @Test - public void shouldReturnErrorWhenConvertMissingColumn(){ + void shouldReturnErrorWhenConvertMissingColumn(){ LocalDate date = LocalDate.now(); DocumentEntity entity = DocumentEntity.of("Notification"); entity.add("_id", 100L); @@ -239,7 +239,7 @@ public void shouldReturnErrorWhenConvertMissingColumn(){ } @Test - public void shouldReturnErrorWhenMismatchField() { + void shouldReturnErrorWhenMismatchField() { LocalDate date = LocalDate.now(); DocumentEntity entity = DocumentEntity.of("Notification"); entity.add("_id", 100L); @@ -251,7 +251,7 @@ public void shouldReturnErrorWhenMismatchField() { } @Test - public void shouldConvertCommunicationNotificationReaderEmail() { + void shouldConvertCommunicationNotificationReaderEmail() { DocumentEntity entity = DocumentEntity.of("NotificationReader"); entity.add("_id", "poli"); entity.add("name", "Poliana Santana"); @@ -277,7 +277,7 @@ public void shouldConvertCommunicationNotificationReaderEmail() { } @Test - public void shouldConvertCommunicationNotificationReaderSms() { + void shouldConvertCommunicationNotificationReaderSms() { DocumentEntity entity = DocumentEntity.of("NotificationReader"); entity.add("_id", "poli"); entity.add("name", "Poliana Santana"); @@ -303,7 +303,7 @@ public void shouldConvertCommunicationNotificationReaderSms() { } @Test - public void shouldConvertCommunicationNotificationReaderSocial() { + void shouldConvertCommunicationNotificationReaderSocial() { DocumentEntity entity = DocumentEntity.of("NotificationReader"); entity.add("_id", "poli"); entity.add("name", "Poliana Santana"); @@ -329,7 +329,7 @@ public void shouldConvertCommunicationNotificationReaderSocial() { } @Test - public void shouldConvertSocialCommunication() { + void shouldConvertSocialCommunication() { SocialMediaNotification notification = new SocialMediaNotification(); notification.setId(10L); notification.setName("Ada"); @@ -352,7 +352,7 @@ public void shouldConvertSocialCommunication() { } @Test - public void shouldConvertConvertProjectManagerCommunication() { + void shouldConvertConvertProjectManagerCommunication() { LargeProject large = new LargeProject(); large.setBudget(BigDecimal.TEN); large.setName("large"); @@ -391,7 +391,7 @@ public void shouldConvertConvertProjectManagerCommunication() { } @Test - public void shouldConvertConvertCommunicationProjectManager() { + void shouldConvertConvertCommunicationProjectManager() { DocumentEntity communication = DocumentEntity.of("ProjectManager"); communication.add("_id", 10L); communication.add("name", "manager"); From 47441c0f94ce972182f9d7d288ca04cef933f17d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:26 -0300 Subject: [PATCH 086/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DocumentEntityConverterTest.java | 52 +++++++++---------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterTest.java index e43d9cb64..42a4ec450 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityConverterTest.java @@ -66,7 +66,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, DocumentExtension.class}) -public class DocumentEntityConverterTest { +class DocumentEntityConverterTest { @Inject private DefaultDocumentEntityConverter converter; @@ -82,7 +82,7 @@ public class DocumentEntityConverterTest { .build(); @BeforeEach - public void init() { + void init() { documents = new Document[]{Document.of("_id", 12L), Document.of("age", 10), Document.of("name", "Otavio"), Document.of("phones", Arrays.asList("234", "2342")) @@ -91,7 +91,7 @@ public void init() { } @Test - public void shouldConvertDocumentEntityFromEntity() { + void shouldConvertDocumentEntityFromEntity() { Person person = Person.builder().withAge() .withId(12) @@ -108,7 +108,7 @@ public void shouldConvertDocumentEntityFromEntity() { } @Test - public void shouldConvertEntityFromDocumentEntity() { + void shouldConvertEntityFromDocumentEntity() { DocumentEntity entity = converter.toDocument(actor); @@ -120,7 +120,7 @@ public void shouldConvertEntityFromDocumentEntity() { } @Test - public void shouldConvertDocumentEntityFromEntity2() { + void shouldConvertDocumentEntityFromEntity2() { DocumentEntity entity = DocumentEntity.of("Actor"); Stream.of(documents).forEach(entity::add); @@ -135,7 +135,7 @@ public void shouldConvertDocumentEntityFromEntity2() { @Test - public void shouldConvertColumnEntityToExistEntity() { + void shouldConvertColumnEntityToExistEntity() { DocumentEntity entity = DocumentEntity.of("Actor"); Stream.of(documents).forEach(entity::add); Actor actor = Actor.actorBuilder().build(); @@ -150,7 +150,7 @@ public void shouldConvertColumnEntityToExistEntity() { } @Test - public void shouldReturnErrorWhenToEntityIsNull() { + void shouldReturnErrorWhenToEntityIsNull() { DocumentEntity entity = DocumentEntity.of("Actor"); Stream.of(documents).forEach(entity::add); Actor actor = Actor.actorBuilder().build(); @@ -161,7 +161,7 @@ public void shouldReturnErrorWhenToEntityIsNull() { } @Test - public void shouldConvertDocumentEntityFromEntity3() { + void shouldConvertDocumentEntityFromEntity3() { DocumentEntity entity = DocumentEntity.of("Actor"); Stream.of(documents).forEach(entity::add); @@ -175,7 +175,7 @@ public void shouldConvertDocumentEntityFromEntity3() { } @Test - public void shouldConvertEntityFromDocumentEntity2() { + void shouldConvertEntityFromDocumentEntity2() { Movie movie = new Movie("Matrix", 2012, singleton("Actor")); Director director = Director.builderDirector().withAge(12) @@ -206,7 +206,7 @@ public void shouldConvertEntityFromDocumentEntity2() { @Test - public void shouldConvertToEmbeddedClassWhenHasSubDocument() { + void shouldConvertToEmbeddedClassWhenHasSubDocument() { Movie movie = new Movie("Matrix", 2012, singleton("Actor")); Director director = Director.builderDirector().withAge(12) .withId(12) @@ -223,7 +223,7 @@ public void shouldConvertToEmbeddedClassWhenHasSubDocument() { } @Test - public void shouldConvertToEmbeddedClassWhenHasSubDocument2() { + void shouldConvertToEmbeddedClassWhenHasSubDocument2() { Movie movie = new Movie("Matrix", 2012, singleton("Actor")); Director director = Director.builderDirector().withAge(12) .withId(12) @@ -245,7 +245,7 @@ public void shouldConvertToEmbeddedClassWhenHasSubDocument2() { @Test - public void shouldConvertToEmbeddedClassWhenHasSubDocument3() { + void shouldConvertToEmbeddedClassWhenHasSubDocument3() { Movie movie = new Movie("Matrix", 2012, singleton("Actor")); Director director = Director.builderDirector().withAge(12) .withId(12) @@ -270,7 +270,7 @@ public void shouldConvertToEmbeddedClassWhenHasSubDocument3() { } @Test - public void shouldConvertToDocumentWhenHaConverter() { + void shouldConvertToDocumentWhenHaConverter() { Worker worker = new Worker(); Job job = new Job(); job.setCity("Sao Paulo"); @@ -287,7 +287,7 @@ public void shouldConvertToDocumentWhenHaConverter() { } @Test - public void shouldConvertToEntityWhenHasConverter() { + void shouldConvertToEntityWhenHasConverter() { Worker worker = new Worker(); Job job = new Job(); job.setCity("Sao Paulo"); @@ -303,7 +303,7 @@ public void shouldConvertToEntityWhenHasConverter() { } @Test - public void shouldConvertEmbeddableLazily() { + void shouldConvertEmbeddableLazily() { DocumentEntity entity = DocumentEntity.of("Worker"); entity.add("name", "Otavio"); entity.add("money", "BRL 10"); @@ -316,7 +316,7 @@ public void shouldConvertEmbeddableLazily() { } @Test - public void shouldConvertToListEmbeddable() { + void shouldConvertToListEmbeddable() { AppointmentBook appointmentBook = new AppointmentBook("ids"); appointmentBook.add(Contact.builder().withType(ContactType.EMAIL) .withName("Ada").withInformation("ada@lovelace.com").build()); @@ -336,7 +336,7 @@ public void shouldConvertToListEmbeddable() { } @Test - public void shouldConvertFromListEmbeddable() { + void shouldConvertFromListEmbeddable() { DocumentEntity entity = DocumentEntity.of("AppointmentBook"); entity.add(Document.of("_id", "ids")); List> documents = new ArrayList<>(); @@ -362,7 +362,7 @@ public void shouldConvertFromListEmbeddable() { @Test - public void shouldConvertSubEntity() { + void shouldConvertSubEntity() { ZipCode zipcode = new ZipCode(); zipcode.setZip("12321"); zipcode.setPlusFour("1234"); @@ -387,7 +387,7 @@ public void shouldConvertSubEntity() { } @Test - public void shouldConvertDocumentInSubEntity() { + void shouldConvertDocumentInSubEntity() { DocumentEntity entity = DocumentEntity.of("Address"); @@ -409,7 +409,7 @@ public void shouldConvertDocumentInSubEntity() { } @Test - public void shouldReturnNullWhenThereIsNotSubEntity() { + void shouldReturnNullWhenThereIsNotSubEntity() { DocumentEntity entity = DocumentEntity.of("Address"); @@ -430,7 +430,7 @@ public void shouldReturnNullWhenThereIsNotSubEntity() { @Test - public void shouldConvertAndDoNotUseUnmodifiableCollection() { + void shouldConvertAndDoNotUseUnmodifiableCollection() { DocumentEntity entity = DocumentEntity.of("vendors"); entity.add("name", "name"); entity.add("prefixes", Arrays.asList("value", "value2")); @@ -443,7 +443,7 @@ public void shouldConvertAndDoNotUseUnmodifiableCollection() { } @Test - public void shouldConvertEntityToDocumentWithArray() { + void shouldConvertEntityToDocumentWithArray() { byte[] contents = {1, 2, 3, 4, 5, 6}; DocumentEntity entity = DocumentEntity.of("download"); @@ -456,7 +456,7 @@ public void shouldConvertEntityToDocumentWithArray() { } @Test - public void shouldConvertDocumentToEntityWithArray() { + void shouldConvertDocumentToEntityWithArray() { byte[] contents = {1, 2, 3, 4, 5, 6}; Download download = new Download(); @@ -472,7 +472,7 @@ public void shouldConvertDocumentToEntityWithArray() { } @Test - public void shouldCreateUserScope() { + void shouldCreateUserScope() { DocumentEntity entity = DocumentEntity.of("UserScope"); entity.add("_id", "userName"); entity.add("scope", "scope"); @@ -487,7 +487,7 @@ public void shouldCreateUserScope() { } @Test - public void shouldCreateUserScope2() { + void shouldCreateUserScope2() { DocumentEntity entity = DocumentEntity.of("UserScope"); entity.add("_id", "userName"); entity.add("scope", "scope"); @@ -506,7 +506,7 @@ private Object getValue(Optional document) { } @Test - public void shouldCreateLazilyEntity() { + void shouldCreateLazilyEntity() { DocumentEntity entity = DocumentEntity.of("Citizen"); entity.add("id", "10"); entity.add("name", "Salvador"); From 13fcd029046dcfddb09b67e97120cf51459acf1d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:27 -0300 Subject: [PATCH 087/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DocumentEntityImmutableTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityImmutableTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityImmutableTest.java index bcfd678a4..7433aad17 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityImmutableTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEntityImmutableTest.java @@ -41,7 +41,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, DocumentExtension.class}) -public class DocumentEntityImmutableTest { +class DocumentEntityImmutableTest { @Inject @@ -52,7 +52,7 @@ public class DocumentEntityImmutableTest { private Car car; @BeforeEach - public void init() { + void init() { this.car = new Car("123456789", "SF90", "Ferrari", Year.now()); @@ -64,7 +64,7 @@ public void init() { } @Test - public void shouldConvertCommunicationEntity() { + void shouldConvertCommunicationEntity() { DocumentEntity entity = converter.toDocument(car); assertEquals("Car", entity.name()); @@ -76,7 +76,7 @@ public void shouldConvertCommunicationEntity() { } @Test - public void shouldConvertCommunicationEntity2() { + void shouldConvertCommunicationEntity2() { DocumentEntity entity = converter.toDocument(car); assertEquals("Car", entity.name()); @@ -86,7 +86,7 @@ public void shouldConvertCommunicationEntity2() { } @Test - public void shouldConvertEntity() { + void shouldConvertEntity() { DocumentEntity entity = DocumentEntity.of("Car"); Stream.of(columns).forEach(entity::add); @@ -100,7 +100,7 @@ public void shouldConvertEntity() { } @Test - public void shouldConvertExistRecord() { + void shouldConvertExistRecord() { DocumentEntity entity = DocumentEntity.of("Car"); Stream.of(columns).forEach(entity::add); Car ferrari = new Car(null, null, null, null); @@ -125,7 +125,7 @@ public void shouldConvertExistRecord() { } @Test - public void shouldConvertExist() { + void shouldConvertExist() { DocumentEntity entity = DocumentEntity.of("Hero"); entity.add("_id", "2342"); entity.add("name", "Iron man"); From 006e0e5643c9736514cc711f1c18301ad7447b5b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:28 -0300 Subject: [PATCH 088/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/document/DocumentEntityTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentEntityTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentEntityTest.java index 8a6cb279d..ae0cc5c00 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentEntityTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentEntityTest.java @@ -38,7 +38,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; -public class DocumentEntityTest { +class DocumentEntityTest { @Test void shouldReturnErrorWhenNameIsNull() { From de3b09581be6381d54e60d97d782c0b9a8179376 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:29 -0300 Subject: [PATCH 089/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/document/DocumentEventPersistManagerTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEventPersistManagerTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEventPersistManagerTest.java index 26d125602..91ebfe88f 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEventPersistManagerTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentEventPersistManagerTest.java @@ -28,7 +28,7 @@ import static org.mockito.Mockito.verify; @ExtendWith(MockitoExtension.class) -public class DocumentEventPersistManagerTest { +class DocumentEventPersistManagerTest { @InjectMocks private DocumentEventPersistManager subject; @@ -45,7 +45,7 @@ public class DocumentEventPersistManagerTest { @Test - public void shouldFirePreEntity() { + void shouldFirePreEntity() { Jedi jedi = new Jedi(); jedi.name = "Luke"; subject.firePreEntity(jedi); @@ -56,7 +56,7 @@ public void shouldFirePreEntity() { } @Test - public void shouldFirePostEntity() { + void shouldFirePostEntity() { Jedi jedi = new Jedi(); jedi.name = "Luke"; subject.firePostEntity(jedi); From 3cadd9781fc4877a4a5279385b3df14128133d76 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:29 -0300 Subject: [PATCH 090/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/document/spi/DocumentExtensionTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/spi/DocumentExtensionTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/spi/DocumentExtensionTest.java index ac863da5a..0c396e3a8 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/spi/DocumentExtensionTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/spi/DocumentExtensionTest.java @@ -39,7 +39,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, DocumentExtension.class}) -public class DocumentExtensionTest { +class DocumentExtensionTest { @Inject @@ -59,27 +59,27 @@ public class DocumentExtensionTest { @Test - public void shouldInitiate() { + void shouldInitiate() { assertNotNull(repository); Person person = repository.save(Person.builder().build()); assertEquals("Default", person.getName()); } @Test - public void shouldUseMock(){ + void shouldUseMock(){ assertNotNull(repositoryMock); Person person = repositoryMock.save(Person.builder().build()); assertEquals("documentRepositoryMock", person.getName()); } @Test - public void shouldInjectTemplate() { + void shouldInjectTemplate() { assertNotNull(templateMock); assertNotNull(template); } @Test - public void shouldInjectRepository() { + void shouldInjectRepository() { assertNotNull(repository); assertNotNull(repositoryMock); } From 6e1d4ab2434fd306ed30a1370f5593c108a50e0a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:30 -0300 Subject: [PATCH 091/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../configuration/DocumentManagerSupplierTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/configuration/DocumentManagerSupplierTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/configuration/DocumentManagerSupplierTest.java index 4171ed95c..150fee800 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/configuration/DocumentManagerSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/configuration/DocumentManagerSupplierTest.java @@ -46,13 +46,13 @@ class DocumentManagerSupplierTest { private DocumentManagerSupplier supplier; @BeforeEach - public void beforeEach(){ + void beforeEach(){ System.clearProperty(DOCUMENT_PROVIDER.get()); System.clearProperty(DOCUMENT_DATABASE.get()); } @Test - public void shouldGetManager() { + void shouldGetManager() { System.setProperty(DOCUMENT_PROVIDER.get(), DocumentConfigurationMock.class.getName()); System.setProperty(DOCUMENT_DATABASE.get(), "database"); DocumentManager manager = supplier.get(); @@ -62,7 +62,7 @@ public void shouldGetManager() { @Test - public void shouldUseDefaultConfigurationWhenProviderIsWrong() { + void shouldUseDefaultConfigurationWhenProviderIsWrong() { System.setProperty(DOCUMENT_PROVIDER.get(), Integer.class.getName()); System.setProperty(DOCUMENT_DATABASE.get(), "database"); DocumentManager manager = supplier.get(); @@ -71,7 +71,7 @@ public void shouldUseDefaultConfigurationWhenProviderIsWrong() { } @Test - public void shouldUseDefaultConfiguration() { + void shouldUseDefaultConfiguration() { System.setProperty(DOCUMENT_DATABASE.get(), "database"); DocumentManager manager = supplier.get(); Assertions.assertNotNull(manager); @@ -79,12 +79,12 @@ public void shouldUseDefaultConfiguration() { } @Test - public void shouldReturnErrorWhenThereIsNotDatabase() { + void shouldReturnErrorWhenThereIsNotDatabase() { Assertions.assertThrows(MappingException.class, () -> supplier.get()); } @Test - public void shouldClose(){ + void shouldClose(){ DocumentManager manager = Mockito.mock(DocumentManager.class); supplier.close(manager); Mockito.verify(manager).close(); From 9b6b926a27c154b16d165967ab50f8879c14e46c Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:32 -0300 Subject: [PATCH 092/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DocumentMapperObserverTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentMapperObserverTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentMapperObserverTest.java index 22adc53cb..d525eb706 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentMapperObserverTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentMapperObserverTest.java @@ -45,48 +45,48 @@ class DocumentMapperObserverTest { private DocumentObserverParser parser; @BeforeEach - public void setUp() { + void setUp() { this.parser = new DocumentMapperObserver(mappings); } @Test - public void shouldFireEntity(){ + void shouldFireEntity(){ var entity = parser.fireEntity("Vendor"); Assertions.assertEquals("vendors", entity); } @Test - public void shouldFireFromClass(){ + void shouldFireFromClass(){ var entity = parser.fireEntity(Car.class.getSimpleName()); Assertions.assertEquals("Car", entity); } @Test - public void shouldFireFromClassName(){ + void shouldFireFromClassName(){ var entity = parser.fireEntity(Car.class.getSimpleName()); Assertions.assertEquals("Car", entity); } @Test - public void shouldFireField(){ + void shouldFireField(){ var field = parser.fireField("Worker", "salary"); Assertions.assertEquals("money", field); } @Test - public void shouldFireFieldFromClassName(){ + void shouldFireFieldFromClassName(){ var field = parser.fireField(Worker.class.getName(), "salary"); Assertions.assertEquals("money", field); } @Test - public void shouldFireFieldFromSimplesName(){ + void shouldFireFieldFromSimplesName(){ var field = parser.fireField(Worker.class.getSimpleName(), "salary"); Assertions.assertEquals("money", field); } @Test - public void shouldFireFieldFromEntity(){ + void shouldFireFieldFromEntity(){ var field = parser.fireField(Vendor.class.getSimpleName(), "name"); Assertions.assertEquals("_id", field); } From c85527cd70fb6273fa3d2438f04e7aea82107c29 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:33 -0300 Subject: [PATCH 093/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/document/DocumentParamsTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentParamsTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentParamsTest.java index cece8fcb4..d641a1dc5 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentParamsTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentParamsTest.java @@ -26,7 +26,7 @@ class DocumentParamsTest { @Test - public void shouldSetParameter() { + void shouldSetParameter() { Params params = Params.newParams(); Value name = params.add("name"); Document document = Document.of("name", name); From b3aadb65a115da0cc3fe681e26eaa1993517c443 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:34 -0300 Subject: [PATCH 094/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DocumentQueryBuilderTest.java | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentQueryBuilderTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentQueryBuilderTest.java index 2efc78394..40f53d433 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentQueryBuilderTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentQueryBuilderTest.java @@ -37,12 +37,12 @@ class DocumentQueryBuilderTest { @Test - public void shouldReturnErrorWhenHasNullElementInSelect() { + void shouldReturnErrorWhenHasNullElementInSelect() { assertThrows(NullPointerException.class, () -> builder("document", "document'", null)); } @Test - public void shouldBuilder() { + void shouldBuilder() { String documentCollection = "documentCollection"; DocumentQuery query = builder().from(documentCollection).build(); assertTrue(query.documents().isEmpty()); @@ -51,7 +51,7 @@ public void shouldBuilder() { } @Test - public void shouldSelectDocument() { + void shouldSelectDocument() { String documentCollection = "documentCollection"; DocumentQuery query = builder("document", "document2").from(documentCollection).build(); assertThat(query.documents()).contains("document", "document2"); @@ -60,13 +60,13 @@ public void shouldSelectDocument() { } @Test - public void shouldReturnErrorWhenFromIsNull() { + void shouldReturnErrorWhenFromIsNull() { assertThrows(NullPointerException.class, () -> builder().from(null)); } @Test - public void shouldSelectOrderAsc() { + void shouldSelectOrderAsc() { String documentCollection = "documentCollection"; DocumentQuery query = builder().from(documentCollection).sort(Sort.asc("name")).build(); assertTrue(query.documents().isEmpty()); @@ -76,7 +76,7 @@ public void shouldSelectOrderAsc() { } @Test - public void shouldSelectOrderDesc() { + void shouldSelectOrderDesc() { String documentCollection = "documentCollection"; DocumentQuery query = builder().from(documentCollection).sort(Sort.desc("name")).build(); assertTrue(query.documents().isEmpty()); @@ -87,7 +87,7 @@ public void shouldSelectOrderDesc() { @Test - public void shouldReturnErrorSelectWhenOrderIsNull() { + void shouldReturnErrorSelectWhenOrderIsNull() { assertThrows(NullPointerException.class,() -> { String documentCollection = "documentCollection"; builder().from(documentCollection).sort((Sort) null); @@ -95,7 +95,7 @@ public void shouldReturnErrorSelectWhenOrderIsNull() { } @Test - public void shouldSelectLimit() { + void shouldSelectLimit() { String documentCollection = "documentCollection"; DocumentQuery query = builder().from(documentCollection).limit(10).build(); assertTrue(query.documents().isEmpty()); @@ -105,13 +105,13 @@ public void shouldSelectLimit() { } @Test - public void shouldReturnErrorWhenLimitIsNegative() { + void shouldReturnErrorWhenLimitIsNegative() { String documentCollection = "documentCollection"; Assertions.assertThrows(IllegalArgumentException.class, () -> builder().from(documentCollection).limit(-1)); } @Test - public void shouldSelectSkip() { + void shouldSelectSkip() { String documentCollection = "documentCollection"; DocumentQuery query = builder().from(documentCollection).skip(10).build(); assertTrue(query.documents().isEmpty()); @@ -121,13 +121,13 @@ public void shouldSelectSkip() { } @Test - public void shouldReturnErrorWhenSkipIsNegative() { + void shouldReturnErrorWhenSkipIsNegative() { String documentCollection = "documentCollection"; Assertions.assertThrows(IllegalArgumentException.class, () -> builder().from(documentCollection).skip(-1)); } @Test - public void shouldSelectWhereNameEq() { + void shouldSelectWhereNameEq() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; @@ -147,7 +147,7 @@ public void shouldSelectWhereNameEq() { } @Test - public void shouldSelectWhereNameLike() { + void shouldSelectWhereNameLike() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentQuery query = builder().from(documentCollection) @@ -165,7 +165,7 @@ public void shouldSelectWhereNameLike() { } @Test - public void shouldSelectWhereNameGt() { + void shouldSelectWhereNameGt() { String documentCollection = "documentCollection"; Number value = 10; @@ -184,7 +184,7 @@ public void shouldSelectWhereNameGt() { } @Test - public void shouldSelectWhereNameGte() { + void shouldSelectWhereNameGte() { String documentCollection = "documentCollection"; Number value = 10; DocumentCondition gteName = DocumentCondition.gte("name", value); @@ -201,7 +201,7 @@ public void shouldSelectWhereNameGte() { } @Test - public void shouldSelectWhereNameLt() { + void shouldSelectWhereNameLt() { String documentCollection = "documentCollection"; Number value = 10; @@ -219,7 +219,7 @@ public void shouldSelectWhereNameLt() { } @Test - public void shouldSelectWhereNameLte() { + void shouldSelectWhereNameLte() { String documentCollection = "documentCollection"; Number value = 10; DocumentQuery query = builder().from(documentCollection).where(DocumentCondition.lte("name", value)) @@ -236,7 +236,7 @@ public void shouldSelectWhereNameLte() { } @Test - public void shouldSelectWhereNameBetween() { + void shouldSelectWhereNameBetween() { String documentCollection = "documentCollection"; Number valueA = 10; Number valueB = 20; @@ -257,7 +257,7 @@ public void shouldSelectWhereNameBetween() { } @Test - public void shouldSelectWhereNameNot() { + void shouldSelectWhereNameNot() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; @@ -277,7 +277,7 @@ public void shouldSelectWhereNameNot() { @Test - public void shouldSelectWhereNameAnd() { + void shouldSelectWhereNameAnd() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentCondition nameEqualsAda = eq("name", name); @@ -296,7 +296,7 @@ public void shouldSelectWhereNameAnd() { } @Test - public void shouldSelectWhereNameOr() { + void shouldSelectWhereNameOr() { String documentCollection = "documentCollection"; String name = "Ada Lovelace"; DocumentCondition nameEqualsAda = eq("name", name); @@ -315,7 +315,7 @@ public void shouldSelectWhereNameOr() { @Test - public void shouldSelectNegate() { + void shouldSelectNegate() { String collection = "collection"; DocumentCondition nameNotEqualsLucas = eq("name", "Lucas").negate(); DocumentQuery query = builder().from(collection) @@ -334,7 +334,7 @@ public void shouldSelectNegate() { @Test - public void shouldExecuteManager() { + void shouldExecuteManager() { DocumentManager manager = Mockito.mock(DocumentManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); String collection = "collection"; @@ -344,7 +344,7 @@ public void shouldExecuteManager() { } @Test - public void shouldExecuteSingleResultManager() { + void shouldExecuteSingleResultManager() { DocumentManager manager = Mockito.mock(DocumentManager.class); ArgumentCaptor queryCaptor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); String collection = "collection"; From dcf2e3590d4edef4852c9c6be5d99138fe9344df Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:34 -0300 Subject: [PATCH 095/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/DocumentQueryParserTest.java | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentQueryParserTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentQueryParserTest.java index 3b16b6186..eeaa6a88f 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentQueryParserTest.java @@ -41,14 +41,14 @@ class DocumentQueryParserTest { private final DocumentManager manager = Mockito.mock(DocumentManager.class); @Test - public void shouldReturnNPEWhenThereIsNullParameter() { + void shouldReturnNPEWhenThereIsNullParameter() { assertThrows(NullPointerException.class, () -> parser.query(null, manager, DocumentObserverParser.EMPTY)); assertThrows(NullPointerException.class, () -> parser.query("select * from God", null, DocumentObserverParser.EMPTY)); } @Test - public void shouldReturnErrorWhenHasInvalidQuery() { + void shouldReturnErrorWhenHasInvalidQuery() { assertThrows(QueryException.class, () -> parser.query("inva", manager, DocumentObserverParser.EMPTY)); assertThrows(QueryException.class, () -> parser.query("invalid", manager, DocumentObserverParser.EMPTY)); @@ -56,7 +56,7 @@ public void shouldReturnErrorWhenHasInvalidQuery() { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, manager, DocumentObserverParser.EMPTY); Mockito.verify(manager).select(captor.capture()); @@ -74,7 +74,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); parser.query(query, manager, DocumentObserverParser.EMPTY); Mockito.verify(manager).delete(captor.capture()); @@ -87,7 +87,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\")"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); parser.query(query, manager, DocumentObserverParser.EMPTY); Mockito.verify(manager).insert(captor.capture()); @@ -101,7 +101,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = \"Diana\")"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); parser.query(query, manager, DocumentObserverParser.EMPTY); Mockito.verify(manager).update(captor.capture()); @@ -114,7 +114,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"delete from God where age = @age"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentDeleteQuery.class); DocumentPreparedStatement prepare = parser.prepare(query, manager, DocumentObserverParser.EMPTY); @@ -131,7 +131,7 @@ public void shouldExecutePrepareStatement(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = @name)"}) - public void shouldExecutePrepareStatement1(String query) { + void shouldExecutePrepareStatement1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); DocumentPreparedStatement prepare = parser.prepare(query, manager, DocumentObserverParser.EMPTY); prepare.bind("name", "Diana"); @@ -145,7 +145,7 @@ public void shouldExecutePrepareStatement1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldExecutePrepareStatement2(String query) { + void shouldExecutePrepareStatement2(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); DocumentPreparedStatement prepare = parser.prepare(query, manager, DocumentObserverParser.EMPTY); @@ -162,7 +162,7 @@ public void shouldExecutePrepareStatement2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = @name)"}) - public void shouldExecutePrepareStatement3(String query) { + void shouldExecutePrepareStatement3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); DocumentPreparedStatement prepare = parser.prepare(query, manager, DocumentObserverParser.EMPTY); prepare.bind("name", "Diana"); @@ -176,7 +176,7 @@ public void shouldExecutePrepareStatement3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldSingleResult(String query) { + void shouldSingleResult(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); Mockito.when(manager.select(Mockito.any(DefaultDocumentQuery.class))) @@ -197,7 +197,7 @@ public void shouldSingleResult(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldReturnEmptySingleResult(String query) { + void shouldReturnEmptySingleResult(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); Mockito.when(manager.select(Mockito.any(DefaultDocumentQuery.class))) @@ -218,7 +218,7 @@ public void shouldReturnEmptySingleResult(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldReturnErrorSingleResult(String query) { + void shouldReturnErrorSingleResult(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentQuery.class); Mockito.when(manager.select(Mockito.any(DefaultDocumentQuery.class))) From 272eb37bf00bb1d974e7f32b2f794593589da043 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:35 -0300 Subject: [PATCH 096/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/query/DocumentRepositoryProducerTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProducerTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProducerTest.java index d4e28ee83..78b9f8f49 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProducerTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProducerTest.java @@ -44,7 +44,7 @@ class DocumentRepositoryProducerTest { @Test - public void shouldCreateFromManager() { + void shouldCreateFromManager() { DocumentManager manager= Mockito.mock(DocumentManager.class); PersonRepository personRepository = producer.get(PersonRepository.class, manager); assertNotNull(personRepository); @@ -52,7 +52,7 @@ public void shouldCreateFromManager() { @Test - public void shouldCreateFromTemplate() { + void shouldCreateFromTemplate() { JNoSQLDocumentTemplate template= Mockito.mock(JNoSQLDocumentTemplate.class); PersonRepository personRepository = producer.get(PersonRepository.class, template); assertNotNull(personRepository); From 04d4bd976bcc2bd63cabc3e61c7ea52c022532f0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:35 -0300 Subject: [PATCH 097/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../DocumentRepositoryProxyPageableTest.java | 46 +++++++++---------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProxyPageableTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProxyPageableTest.java index a67e182ee..9754cfd43 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProxyPageableTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProxyPageableTest.java @@ -86,7 +86,7 @@ class DocumentRepositoryProxyPageableTest { private VendorRepository vendorRepository; @BeforeEach - public void setUp() { + void setUp() { this.template = Mockito.mock(JNoSQLDocumentTemplate.class); DocumentRepositoryProxy personHandler = new DocumentRepositoryProxy(template, @@ -110,7 +110,7 @@ public void setUp() { @Test - public void shouldFindByNameInstance() { + void shouldFindByNameInstance() { when(template.singleResult(any(DocumentQuery.class))).thenReturn(Optional .of(Person.builder().build())); @@ -139,7 +139,7 @@ public void shouldFindByNameInstance() { } @Test - public void shouldFindByNameANDAge() { + void shouldFindByNameANDAge() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -160,7 +160,7 @@ public void shouldFindByNameANDAge() { } @Test - public void shouldFindByAgeANDName() { + void shouldFindByAgeANDName() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -180,7 +180,7 @@ public void shouldFindByAgeANDName() { } @Test - public void shouldFindByNameANDAgeOrderByName() { + void shouldFindByNameANDAgeOrderByName() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -201,7 +201,7 @@ public void shouldFindByNameANDAgeOrderByName() { } @Test - public void shouldFindByNameANDAgeOrderByAge() { + void shouldFindByNameANDAgeOrderByAge() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -223,7 +223,7 @@ public void shouldFindByNameANDAgeOrderByAge() { @Test - public void shouldFindAll() { + void shouldFindAll() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -244,7 +244,7 @@ public void shouldFindAll() { @Test - public void shouldFindByNameAndAgeGreaterEqualThan() { + void shouldFindByNameAndAgeGreaterEqualThan() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -276,7 +276,7 @@ public void shouldFindByNameAndAgeGreaterEqualThan() { } @Test - public void shouldFindByGreaterThan() { + void shouldFindByGreaterThan() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -298,7 +298,7 @@ public void shouldFindByGreaterThan() { } @Test - public void shouldFindByAgeLessThanEqual() { + void shouldFindByAgeLessThanEqual() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -320,7 +320,7 @@ public void shouldFindByAgeLessThanEqual() { } @Test - public void shouldFindByAgeLessEqual() { + void shouldFindByAgeLessEqual() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -342,7 +342,7 @@ public void shouldFindByAgeLessEqual() { } @Test - public void shouldFindByAgeBetween() { + void shouldFindByAgeBetween() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -367,7 +367,7 @@ public void shouldFindByAgeBetween() { @Test - public void shouldFindByNameLike() { + void shouldFindByNameLike() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -390,7 +390,7 @@ public void shouldFindByNameLike() { @Test - public void shouldFindByStringWhenFieldIsSet() { + void shouldFindByStringWhenFieldIsSet() { Vendor vendor = new Vendor("vendor"); vendor.setPrefixes(Collections.singleton("prefix")); @@ -413,7 +413,7 @@ public void shouldFindByStringWhenFieldIsSet() { } @Test - public void shouldFindByIn() { + void shouldFindByIn() { Vendor vendor = new Vendor("vendor"); vendor.setPrefixes(Collections.singleton("prefix")); @@ -436,7 +436,7 @@ public void shouldFindByIn() { @Test - public void shouldConvertFieldToTheType() { + void shouldConvertFieldToTheType() { Person ada = Person.builder() .withAge(20).withName("Ada").build(); @@ -459,7 +459,7 @@ public void shouldConvertFieldToTheType() { } @Test - public void shouldFindByNameOrderName() { + void shouldFindByNameOrderName() { when(template.singleResult(any(DocumentQuery.class))).thenReturn(Optional .of(Person.builder().build())); @@ -487,7 +487,7 @@ public void shouldFindByNameOrderName() { } @Test - public void shouldFindByNameOrderName2() { + void shouldFindByNameOrderName2() { when(template.singleResult(any(DocumentQuery.class))).thenReturn(Optional .of(Person.builder().build())); @@ -517,7 +517,7 @@ public void shouldFindByNameOrderName2() { } @Test - public void shouldFindByNameSort() { + void shouldFindByNameSort() { when(template.singleResult(any(DocumentQuery.class))).thenReturn(Optional .of(Person.builder().build())); @@ -536,7 +536,7 @@ public void shouldFindByNameSort() { } @Test - public void shouldFindByNameSortPagination() { + void shouldFindByNameSortPagination() { when(template.singleResult(any(DocumentQuery.class))).thenReturn(Optional .of(Person.builder().build())); @@ -555,7 +555,7 @@ public void shouldFindByNameSortPagination() { @Test - public void shouldFindByNameLimit() { + void shouldFindByNameLimit() { when(template.singleResult(any(DocumentQuery.class))).thenReturn(Optional .of(Person.builder().build())); @@ -574,7 +574,7 @@ public void shouldFindByNameLimit() { } @Test - public void shouldFindByNameLimit2() { + void shouldFindByNameLimit2() { when(template.singleResult(any(DocumentQuery.class))).thenReturn(Optional .of(Person.builder().build())); @@ -593,7 +593,7 @@ public void shouldFindByNameLimit2() { } @Test - public void shouldFindByNameLimit3() { + void shouldFindByNameLimit3() { when(template.singleResult(any(DocumentQuery.class))).thenReturn(Optional .of(Person.builder().build())); From dcc5b19291e8ccc9c43967643d69cd3d6a3a8cc9 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:36 -0300 Subject: [PATCH 098/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/query/DocumentRepositoryProxyTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProxyTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProxyTest.java index 469c89ac6..f650d0531 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProxyTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DocumentRepositoryProxyTest.java @@ -89,7 +89,7 @@ class DocumentRepositoryProxyTest { @BeforeEach - public void setUp() { + void setUp() { this.template = Mockito.mock(JNoSQLDocumentTemplate.class); DocumentRepositoryProxy personHandler = new DocumentRepositoryProxy(template, @@ -335,14 +335,14 @@ void shouldDeleteAll() { } @Test - public void shouldDeleteEntity(){ + void shouldDeleteEntity(){ Person person = Person.builder().withId(1L).withAge(20).withName("Ada").build(); personRepository.delete(person); verify(template).delete(Person.class, 1L); } @Test - public void shouldDeleteEntities(){ + void shouldDeleteEntities(){ Person person = Person.builder().withId(1L).withAge(20).withName("Ada").build(); personRepository.deleteAll(List.of(person)); verify(template).delete(Person.class, 1L); @@ -698,7 +698,7 @@ void shouldExistsByName() { } @Test - public void shouldExecuteCustomRepository(){ + void shouldExecuteCustomRepository(){ PersonStatisticRepository.PersonStatistic statistics = personRepository.statistics("Salvador"); assertThat(statistics).isNotNull(); SoftAssertions.assertSoftly(softly -> { From ecf3873ce3329d82ca569f13678d4ebadb9c936b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:37 -0300 Subject: [PATCH 099/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/document/DocumentsTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentsTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentsTest.java index 0b5e34c6e..8a8a0db89 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentsTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/DocumentsTest.java @@ -31,14 +31,14 @@ public class DocumentsTest { @Test - public void shouldCreateDocument() { + void shouldCreateDocument() { Document column = Documents.of("name", "Ada"); assertEquals("name", column.name()); assertEquals("Ada", column.get()); } @Test - public void shouldCreateColumnsFromMap() { + void shouldCreateColumnsFromMap() { Map map = singletonMap("name", "Ada"); List documents = Documents.of(map); assertFalse(documents.isEmpty()); @@ -46,7 +46,7 @@ public void shouldCreateColumnsFromMap() { } @Test - public void shouldCreateRecursiveMap() { + void shouldCreateRecursiveMap() { List>> list = new ArrayList<>(); Map map = singletonMap("mobile", "55 1234-4567"); list.add(singletonList(map)); From 0e5a104353968de62839b3698596a58fe9ce1802 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:37 -0300 Subject: [PATCH 100/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/document/DocumentTemplateTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentTemplateTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentTemplateTest.java index c3c25fc02..df9677a48 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentTemplateTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/DocumentTemplateTest.java @@ -45,12 +45,12 @@ class DocumentTemplateTest { @Test - public void shouldInjectTemplate() { + void shouldInjectTemplate() { Assertions.assertNotNull(template); } @Test - public void shouldInjectQualifier() { + void shouldInjectQualifier() { Assertions.assertNotNull(qualifier); } } From a5bb3c593b1905cd3d5a283650173161c5e8d6dc Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:38 -0300 Subject: [PATCH 101/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/DynamicQueryExceptionTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DynamicQueryExceptionTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DynamicQueryExceptionTest.java index dfb545b77..e8ae7f54e 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DynamicQueryExceptionTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/DynamicQueryExceptionTest.java @@ -17,17 +17,17 @@ import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; -public class DynamicQueryExceptionTest { +class DynamicQueryExceptionTest { @Test - public void testConstructorWithMessage() { + void testConstructorWithMessage() { String errorMessage = "Test error message"; DynamicQueryException exception = new DynamicQueryException(errorMessage); assertEquals(errorMessage, exception.getMessage()); } @Test - public void testEmptyMessage() { + void testEmptyMessage() { String emptyMessage = ""; DynamicQueryException exception = new DynamicQueryException(emptyMessage); assertEquals(emptyMessage, exception.getMessage()); From 06d96fef750170b14797c2c6ee62986bb8121729 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:40 -0300 Subject: [PATCH 102/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../DynamicQueryMethodReturnTest.java | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicQueryMethodReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicQueryMethodReturnTest.java index aa106558a..56a6499cd 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicQueryMethodReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicQueryMethodReturnTest.java @@ -35,7 +35,7 @@ class DynamicQueryMethodReturnTest { @Test - public void shouldReturnEmptyOptional() throws NoSuchMethodException { + void shouldReturnEmptyOptional() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getOptional"); @@ -54,7 +54,7 @@ public void shouldReturnEmptyOptional() throws NoSuchMethodException { } @Test - public void shouldReturnOptional() throws NoSuchMethodException { + void shouldReturnOptional() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getOptional"); @@ -74,7 +74,7 @@ public void shouldReturnOptional() throws NoSuchMethodException { } @Test - public void shouldReturnOptionalError() throws NoSuchMethodException { + void shouldReturnOptionalError() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getOptional"); @@ -92,7 +92,7 @@ public void shouldReturnOptionalError() throws NoSuchMethodException { } @Test - public void shouldReturnAnInstance() throws NoSuchMethodException { + void shouldReturnAnInstance() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getInstance"); @@ -111,7 +111,7 @@ public void shouldReturnAnInstance() throws NoSuchMethodException { } @Test - public void shouldReturnNull() throws NoSuchMethodException { + void shouldReturnNull() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getInstance"); @@ -128,7 +128,7 @@ public void shouldReturnNull() throws NoSuchMethodException { } @Test - public void shouldReturnList() throws NoSuchMethodException { + void shouldReturnList() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getList"); @@ -149,7 +149,7 @@ public void shouldReturnList() throws NoSuchMethodException { @Test - public void shouldReturnIterable() throws NoSuchMethodException { + void shouldReturnIterable() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getIterable"); @@ -168,7 +168,7 @@ public void shouldReturnIterable() throws NoSuchMethodException { } @Test - public void shouldReturnCollection() throws NoSuchMethodException { + void shouldReturnCollection() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getCollection"); @@ -188,7 +188,7 @@ public void shouldReturnCollection() throws NoSuchMethodException { @Test - public void shouldReturnQueue() throws NoSuchMethodException { + void shouldReturnQueue() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getQueue"); @@ -207,7 +207,7 @@ public void shouldReturnQueue() throws NoSuchMethodException { } @Test - public void shouldReturnStream() throws NoSuchMethodException { + void shouldReturnStream() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Method method = getMethod(PersonRepository.class, "getStream"); @@ -225,7 +225,7 @@ public void shouldReturnStream() throws NoSuchMethodException { } @Test - public void shouldReturnFromPrepareStatement() throws NoSuchMethodException { + void shouldReturnFromPrepareStatement() throws NoSuchMethodException { PreparedStatement preparedStatement = Mockito.mock(PreparedStatement.class); Mockito.when(preparedStatement.result()) .thenReturn(Stream.of(new Person("Ada"))); From c7aef7f1792951563124c2cc46066e251fd119fd Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:40 -0300 Subject: [PATCH 103/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/query/DynamicQueryTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/DynamicQueryTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/DynamicQueryTest.java index d9d8067a8..11a8e96f0 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/DynamicQueryTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/DynamicQueryTest.java @@ -45,12 +45,12 @@ class DynamicQueryTest { private Limit limit; @BeforeEach - public void setUp() { + void setUp() { MockitoAnnotations.openMocks(this); } @Test - public void shouldCreateDynamicQuery() { + void shouldCreateDynamicQuery() { when(special.isEmpty()).thenReturn(true); when(query.condition()).thenReturn(Optional.empty()); when(query.name()).thenReturn("sampleQuery"); @@ -61,7 +61,7 @@ public void shouldCreateDynamicQuery() { } @Test - public void shouldCreateDynamicQueryWithSortsAndLimit() { + void shouldCreateDynamicQueryWithSortsAndLimit() { when(special.isEmpty()).thenReturn(false); when(special.hasOnlySort()).thenReturn(true); when(special.sorts()).thenReturn(List.of(mock(Sort.class))); @@ -82,7 +82,7 @@ public void shouldCreateDynamicQueryWithSortsAndLimit() { } @Test - public void shouldCreateDynamicQueryWithLimit() { + void shouldCreateDynamicQueryWithLimit() { when(special.isEmpty()).thenReturn(false); when(special.hasOnlySort()).thenReturn(false); when(limit.startAt()).thenReturn(1L); @@ -102,7 +102,7 @@ public void shouldCreateDynamicQueryWithLimit() { } @Test - public void shouldCreateDynamicQueryWithPageable() { + void shouldCreateDynamicQueryWithPageable() { when(special.isEmpty()).thenReturn(false); when(special.pageable()).thenReturn(Optional.of(mock(Pageable.class))); when(special.sorts()).thenReturn(List.of(mock(Sort.class))); @@ -121,7 +121,7 @@ public void shouldCreateDynamicQueryWithPageable() { } @Test - public void shouldReturnWhenThereIsLimitAndSort(){ + void shouldReturnWhenThereIsLimitAndSort(){ when(special.isEmpty()).thenReturn(false); when(special.pageable()).thenReturn(Optional.of(mock(Pageable.class))); when(query.condition()).thenReturn(Optional.empty()); From dac4b0f9eb4ca8cc5713ed8658d60b2cf2a17938 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:41 -0300 Subject: [PATCH 104/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/document/query/DynamicQueryTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DynamicQueryTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DynamicQueryTest.java index 7e5f6f022..fd7ccec9e 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DynamicQueryTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/DynamicQueryTest.java @@ -44,12 +44,12 @@ class DynamicQueryTest { private Limit limit; @BeforeEach - public void setUp() { + void setUp() { MockitoAnnotations.openMocks(this); } @Test - public void shouldCreateDynamicQuery() { + void shouldCreateDynamicQuery() { when(special.isEmpty()).thenReturn(true); when(query.condition()).thenReturn(Optional.empty()); when(query.name()).thenReturn("sampleQuery"); @@ -60,7 +60,7 @@ public void shouldCreateDynamicQuery() { } @Test - public void shouldCreateDynamicQueryWithSortsAndLimit() { + void shouldCreateDynamicQueryWithSortsAndLimit() { when(special.isEmpty()).thenReturn(false); when(special.hasOnlySort()).thenReturn(true); when(special.sorts()).thenReturn(List.of(mock(Sort.class))); @@ -81,7 +81,7 @@ public void shouldCreateDynamicQueryWithSortsAndLimit() { } @Test - public void shouldCreateDynamicQueryWithLimit() { + void shouldCreateDynamicQueryWithLimit() { when(special.isEmpty()).thenReturn(false); when(special.hasOnlySort()).thenReturn(false); when(limit.startAt()).thenReturn(1L); @@ -101,7 +101,7 @@ public void shouldCreateDynamicQueryWithLimit() { } @Test - public void shouldCreateDynamicQueryWithPageable() { + void shouldCreateDynamicQueryWithPageable() { when(special.isEmpty()).thenReturn(false); when(special.pageable()).thenReturn(Optional.of(mock(Pageable.class))); when(special.sorts()).thenReturn(List.of(mock(Sort.class))); @@ -120,7 +120,7 @@ public void shouldCreateDynamicQueryWithPageable() { } @Test - public void shouldReturnWhenThereIsLimitAndSort(){ + void shouldReturnWhenThereIsLimitAndSort(){ when(special.isEmpty()).thenReturn(false); when(special.pageable()).thenReturn(Optional.of(mock(Pageable.class))); when(query.condition()).thenReturn(Optional.empty()); From c7f73ffa5564cb241e5c77f4b6a67cb6e014cfc9 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:42 -0300 Subject: [PATCH 105/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../DynamicReturnPaginationTest.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicReturnPaginationTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicReturnPaginationTest.java index 4547df784..ded7d7845 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicReturnPaginationTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicReturnPaginationTest.java @@ -53,7 +53,7 @@ class DynamicReturnPaginationTest { private Function> page; @Test - public void shouldReturnEmptyOptional() throws NoSuchMethodException { + void shouldReturnEmptyOptional() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = Stream::empty; @@ -83,7 +83,7 @@ public void shouldReturnEmptyOptional() throws NoSuchMethodException { @Test - public void shouldReturnOptional() throws NoSuchMethodException { + void shouldReturnOptional() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = Stream::empty; @@ -112,7 +112,7 @@ public void shouldReturnOptional() throws NoSuchMethodException { @Test - public void shouldReturnAnInstance() throws NoSuchMethodException { + void shouldReturnAnInstance() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getInstance"); Supplier> stream = Stream::empty; Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); @@ -138,7 +138,7 @@ public void shouldReturnAnInstance() throws NoSuchMethodException { } @Test - public void shouldReturnNull() throws NoSuchMethodException { + void shouldReturnNull() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getInstance"); Supplier> stream = Stream::empty; @@ -165,7 +165,7 @@ public void shouldReturnNull() throws NoSuchMethodException { } @Test - public void shouldReturnList() throws NoSuchMethodException { + void shouldReturnList() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getList"); Supplier> stream = Stream::empty; @@ -193,7 +193,7 @@ public void shouldReturnList() throws NoSuchMethodException { } @Test - public void shouldReturnIterable() throws NoSuchMethodException { + void shouldReturnIterable() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getIterable"); Supplier> stream = Stream::empty; @@ -220,7 +220,7 @@ public void shouldReturnIterable() throws NoSuchMethodException { } @Test - public void shouldReturnCollection() throws NoSuchMethodException { + void shouldReturnCollection() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getCollection"); Supplier> stream = Stream::empty; @@ -247,7 +247,7 @@ public void shouldReturnCollection() throws NoSuchMethodException { } @Test - public void shouldReturnSet() throws NoSuchMethodException { + void shouldReturnSet() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getSet"); Supplier> stream = Stream::empty; @@ -274,7 +274,7 @@ public void shouldReturnSet() throws NoSuchMethodException { } @Test - public void shouldReturnQueue() throws NoSuchMethodException { + void shouldReturnQueue() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getQueue"); Supplier> stream = Stream::empty; @@ -302,7 +302,7 @@ public void shouldReturnQueue() throws NoSuchMethodException { @Test - public void shouldReturnStream() throws NoSuchMethodException { + void shouldReturnStream() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getStream"); Supplier> stream = Stream::empty; @@ -328,7 +328,7 @@ public void shouldReturnStream() throws NoSuchMethodException { } @Test - public void shouldReturnSortedSet() throws NoSuchMethodException { + void shouldReturnSortedSet() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getSortedSet"); Supplier> stream = Stream::empty; @@ -355,7 +355,7 @@ public void shouldReturnSortedSet() throws NoSuchMethodException { } @Test - public void shouldReturnNavigableSet() throws NoSuchMethodException { + void shouldReturnNavigableSet() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getNavigableSet"); Supplier> stream = Stream::empty; @@ -383,7 +383,7 @@ public void shouldReturnNavigableSet() throws NoSuchMethodException { @Test - public void shouldReturnDeque() throws NoSuchMethodException { + void shouldReturnDeque() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getDeque"); Supplier> stream = Stream::empty; @@ -410,7 +410,7 @@ public void shouldReturnDeque() throws NoSuchMethodException { } @Test - public void shouldReturnErrorWhenExecutePage() throws NoSuchMethodException { + void shouldReturnErrorWhenExecutePage() throws NoSuchMethodException { Method method = getMethod(PersonRepository.class, "getPage"); Supplier> stream = Stream::empty; Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); From c99a0253f56b82b0457292fee3c3bfc1d5d14d3a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:43 -0300 Subject: [PATCH 106/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/repository/DynamicReturnTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicReturnTest.java index 025e810fb..534e48be3 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/DynamicReturnTest.java @@ -1 +1 @@ -/* * Copyright (c) 2022 Contributors to the Eclipse Foundation * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * and Apache License v2.0 which accompanies this distribution. * The Eclipse Public License is available at http://www.eclipse.org/legal/epl-v10.html * and the Apache License v2.0 is available at http://www.opensource.org/licenses/apache2.0.php. * * You may elect to redistribute this code under either of these licenses. * * Contributors: * * Otavio Santana */ package org.eclipse.jnosql.mapping.repository; import jakarta.data.exceptions.NonUniqueResultException; import jakarta.data.repository.CrudRepository; import jakarta.data.repository.Page; import jakarta.data.repository.Pageable; import org.eclipse.jnosql.mapping.DynamicQueryException; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Test; import java.lang.reflect.Method; import java.math.BigDecimal; import java.util.Collection; import java.util.Deque; import java.util.List; import java.util.NavigableSet; import java.util.Optional; import java.util.Queue; import java.util.Set; import java.util.SortedSet; import java.util.function.Supplier; import java.util.stream.Stream; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; class DynamicReturnTest { @Test public void shouldReturnNPEWhenThereIsPagination() { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = Stream::empty; Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); assertThrows(NullPointerException.class, () -> DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult) .withPagination(Pageable.ofPage(1L).size(2)).build()); } @Test public void shouldReturnEmptyOptional() { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = Stream::empty; Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Optional); Optional optional = (Optional) execute; Assertions.assertFalse(optional.isPresent()); } @Test public void shouldReturnOptional() { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Optional); Optional optional = (Optional) execute; assertTrue(optional.isPresent()); Assertions.assertEquals(new Person("Ada"), optional.get()); } @Test public void shouldReturnOptionalError() { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = () -> Stream.of(new Person("Poliana"), new Person("Otavio")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); assertThrows(NonUniqueResultException.class, dynamicReturn::execute); } @Test public void shouldReturnAnInstance() { Method method = getMethod(PersonRepository.class, "getInstance"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Person); Person person = (Person) execute; Assertions.assertEquals(new Person("Ada"), person); } @Test public void shouldReturnNull() { Method method = getMethod(PersonRepository.class, "getInstance"); Supplier> stream = Stream::empty; Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertNull(execute); } @Test public void shouldReturnList() { Method method = getMethod(PersonRepository.class, "getList"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof List); List persons = (List) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.get(0)); } @Test public void shouldReturnIterable() { Method method = getMethod(PersonRepository.class, "getIterable"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Iterable); Iterable persons = (List) execute; Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test public void shouldReturnCollection() { Method method = getMethod(PersonRepository.class, "getCollection"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Collection); Collection persons = (Collection) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test public void shouldReturnSet() { Method method = getMethod(PersonRepository.class, "getSet"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Set); Set persons = (Set) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test public void shouldReturnQueue() { Method method = getMethod(PersonRepository.class, "getQueue"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Queue); Queue persons = (Queue) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test public void shouldReturnStream() { Method method = getMethod(PersonRepository.class, "getStream"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Stream); Stream persons = (Stream) execute; Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test public void shouldReturnSortedSet() { Method method = getMethod(PersonRepository.class, "getSortedSet"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof SortedSet); SortedSet persons = (SortedSet) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test public void shouldReturnNavigableSet() { Method method = getMethod(PersonRepository.class, "getNavigableSet"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof NavigableSet); NavigableSet persons = (NavigableSet) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test public void shouldReturnDeque() { Method method = getMethod(PersonRepository.class, "getDeque"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Deque); Deque persons = (Deque) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test public void shouldReturnErrorWhenExecutePage() { Method method = getMethod(PersonRepository.class, "getPage"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); assertThrows(DynamicQueryException.class, dynamicReturn::execute); } @Test public void shouldReturnErrorNavigableSetEntityIsNotComparable() { Method method = getMethod(AnimalRepository.class, "getSortedSet"); Supplier> stream = () -> Stream.of(new Animal("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Animal.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); assertThrows(DynamicQueryException.class, dynamicReturn::execute); } @Test public void shouldReturnNullWhenParamIsEmptyOnFindSpecial() { assertTrue(DynamicReturn.findSpecialParameters(null).isEmpty()); assertTrue(DynamicReturn.findSpecialParameters(new Object[0]).isEmpty()); } @Test public void shouldFindSpecial() { Pageable pagination = Pageable.ofPage(1L).size(2); SpecialParameters specialParameters = DynamicReturn.findSpecialParameters(new Object[]{"value", 23, pagination}); Assertions.assertEquals(pagination, specialParameters.pageable().orElseThrow()); } @Test public void shouldReturnNullWhenThereIsNotSpecial() { SpecialParameters pagination = DynamicReturn.findSpecialParameters(new Object[]{"value", 23, BigDecimal.TEN}); assertTrue(pagination.isEmpty()); } // @Test public void shouldReturnNullWhenParamIsEmptyOnFindPagination() { assertNull(DynamicReturn.findPageable(null)); assertNull(DynamicReturn.findPageable(new Object[0])); } @Test public void shouldFindPagination() { Pageable pagination = Pageable.ofPage(1L).size(2); Pageable pageable = DynamicReturn.findPageable(new Object[]{"value", 23, pagination}); Assertions.assertEquals(pagination, pageable); } @Test public void shouldReturnNullWhenThereIsNotPagination() { Pageable pagination = DynamicReturn.findPageable(new Object[]{"value", 23, BigDecimal.TEN}); assertNull(pagination); } private Method getMethod(Class repository, String methodName) { return Stream.of(repository.getDeclaredMethods()) .filter(m -> m.getName().equals(methodName)) .findFirst().get(); } private record Animal(String name) { } private record Person(String name) implements Comparable { @Override public int compareTo(Person o) { return name.compareTo(o.name); } } private interface AnimalRepository extends CrudRepository { SortedSet getSortedSet(); } private interface PersonRepository extends CrudRepository { Optional getOptional(); Person getInstance(); List getList(); Iterable getIterable(); Collection getCollection(); Set getSet(); Queue getQueue(); Stream getStream(); SortedSet getSortedSet(); NavigableSet getNavigableSet(); Deque getDeque(); Page getPage(); } } \ No newline at end of file +/* * Copyright (c) 2022 Contributors to the Eclipse Foundation * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * and Apache License v2.0 which accompanies this distribution. * The Eclipse Public License is available at http://www.eclipse.org/legal/epl-v10.html * and the Apache License v2.0 is available at http://www.opensource.org/licenses/apache2.0.php. * * You may elect to redistribute this code under either of these licenses. * * Contributors: * * Otavio Santana */ package org.eclipse.jnosql.mapping.repository; import jakarta.data.exceptions.NonUniqueResultException; import jakarta.data.repository.CrudRepository; import jakarta.data.repository.Page; import jakarta.data.repository.Pageable; import org.eclipse.jnosql.mapping.DynamicQueryException; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Test; import java.lang.reflect.Method; import java.math.BigDecimal; import java.util.Collection; import java.util.Deque; import java.util.List; import java.util.NavigableSet; import java.util.Optional; import java.util.Queue; import java.util.Set; import java.util.SortedSet; import java.util.function.Supplier; import java.util.stream.Stream; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; class DynamicReturnTest { @Test void shouldReturnNPEWhenThereIsPagination() { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = Stream::empty; Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); assertThrows(NullPointerException.class, () -> DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult) .withPagination(Pageable.ofPage(1L).size(2)).build()); } @Test void shouldReturnEmptyOptional() { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = Stream::empty; Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Optional); Optional optional = (Optional) execute; Assertions.assertFalse(optional.isPresent()); } @Test void shouldReturnOptional() { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Optional); Optional optional = (Optional) execute; assertTrue(optional.isPresent()); Assertions.assertEquals(new Person("Ada"), optional.get()); } @Test void shouldReturnOptionalError() { Method method = getMethod(PersonRepository.class, "getOptional"); Supplier> stream = () -> Stream.of(new Person("Poliana"), new Person("Otavio")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); assertThrows(NonUniqueResultException.class, dynamicReturn::execute); } @Test void shouldReturnAnInstance() { Method method = getMethod(PersonRepository.class, "getInstance"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Person); Person person = (Person) execute; Assertions.assertEquals(new Person("Ada"), person); } @Test void shouldReturnNull() { Method method = getMethod(PersonRepository.class, "getInstance"); Supplier> stream = Stream::empty; Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertNull(execute); } @Test void shouldReturnList() { Method method = getMethod(PersonRepository.class, "getList"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof List); List persons = (List) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.get(0)); } @Test void shouldReturnIterable() { Method method = getMethod(PersonRepository.class, "getIterable"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Iterable); Iterable persons = (List) execute; Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test void shouldReturnCollection() { Method method = getMethod(PersonRepository.class, "getCollection"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Collection); Collection persons = (Collection) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test void shouldReturnSet() { Method method = getMethod(PersonRepository.class, "getSet"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Set); Set persons = (Set) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test void shouldReturnQueue() { Method method = getMethod(PersonRepository.class, "getQueue"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Queue); Queue persons = (Queue) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test void shouldReturnStream() { Method method = getMethod(PersonRepository.class, "getStream"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Stream); Stream persons = (Stream) execute; Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test void shouldReturnSortedSet() { Method method = getMethod(PersonRepository.class, "getSortedSet"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof SortedSet); SortedSet persons = (SortedSet) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test void shouldReturnNavigableSet() { Method method = getMethod(PersonRepository.class, "getNavigableSet"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof NavigableSet); NavigableSet persons = (NavigableSet) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test void shouldReturnDeque() { Method method = getMethod(PersonRepository.class, "getDeque"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); Object execute = dynamicReturn.execute(); assertTrue(execute instanceof Deque); Deque persons = (Deque) execute; Assertions.assertFalse(persons.isEmpty()); Assertions.assertEquals(new Person("Ada"), persons.iterator().next()); } @Test void shouldReturnErrorWhenExecutePage() { Method method = getMethod(PersonRepository.class, "getPage"); Supplier> stream = () -> Stream.of(new Person("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Person.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); assertThrows(DynamicQueryException.class, dynamicReturn::execute); } @Test void shouldReturnErrorNavigableSetEntityIsNotComparable() { Method method = getMethod(AnimalRepository.class, "getSortedSet"); Supplier> stream = () -> Stream.of(new Animal("Ada")); Supplier> singleResult = DynamicReturn.toSingleResult(method).apply(stream); DynamicReturn dynamicReturn = DynamicReturn.builder() .withClassSource(Animal.class) .withMethodSource(method).withResult(stream) .withSingleResult(singleResult).build(); assertThrows(DynamicQueryException.class, dynamicReturn::execute); } @Test void shouldReturnNullWhenParamIsEmptyOnFindSpecial() { assertTrue(DynamicReturn.findSpecialParameters(null).isEmpty()); assertTrue(DynamicReturn.findSpecialParameters(new Object[0]).isEmpty()); } @Test void shouldFindSpecial() { Pageable pagination = Pageable.ofPage(1L).size(2); SpecialParameters specialParameters = DynamicReturn.findSpecialParameters(new Object[]{"value", 23, pagination}); Assertions.assertEquals(pagination, specialParameters.pageable().orElseThrow()); } @Test void shouldReturnNullWhenThereIsNotSpecial() { SpecialParameters pagination = DynamicReturn.findSpecialParameters(new Object[]{"value", 23, BigDecimal.TEN}); assertTrue(pagination.isEmpty()); } // @Test void shouldReturnNullWhenParamIsEmptyOnFindPagination() { assertNull(DynamicReturn.findPageable(null)); assertNull(DynamicReturn.findPageable(new Object[0])); } @Test void shouldFindPagination() { Pageable pagination = Pageable.ofPage(1L).size(2); Pageable pageable = DynamicReturn.findPageable(new Object[]{"value", 23, pagination}); Assertions.assertEquals(pagination, pageable); } @Test void shouldReturnNullWhenThereIsNotPagination() { Pageable pagination = DynamicReturn.findPageable(new Object[]{"value", 23, BigDecimal.TEN}); assertNull(pagination); } private Method getMethod(Class repository, String methodName) { return Stream.of(repository.getDeclaredMethods()) .filter(m -> m.getName().equals(methodName)) .findFirst().get(); } private record Animal(String name) { } private record Person(String name) implements Comparable { @Override public int compareTo(Person o) { return name.compareTo(o.name); } } private interface AnimalRepository extends CrudRepository { SortedSet getSortedSet(); } private interface PersonRepository extends CrudRepository { Optional getOptional(); Person getInstance(); List getList(); Iterable getIterable(); Collection getCollection(); Set getSet(); Queue getQueue(); Stream getStream(); SortedSet getSortedSet(); NavigableSet getNavigableSet(); Deque getDeque(); Page getPage(); } } \ No newline at end of file From 4382e9639c6b144bebc15cf573874014a5d74e7f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:44 -0300 Subject: [PATCH 107/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/graph/EdgeEntityTest.java | 54 +++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/EdgeEntityTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/EdgeEntityTest.java index f4e1b7f03..0920e3fcc 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/EdgeEntityTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/EdgeEntityTest.java @@ -39,7 +39,7 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class EdgeEntityTest { +class EdgeEntityTest { @Inject @@ -47,7 +47,7 @@ public class EdgeEntityTest { @Test - public void shouldReturnErrorWhenInboundIsNull() { + void shouldReturnErrorWhenInboundIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { Person person = Person.builder().withName("Poliana").withAge().build(); Book book = null; @@ -56,7 +56,7 @@ public void shouldReturnErrorWhenInboundIsNull() { } @Test - public void shouldReturnErrorWhenOutboundIsNull() { + void shouldReturnErrorWhenOutboundIsNull() { Assertions.assertThrows(IllegalStateException.class, () -> { Person person = Person.builder().withName("Poliana").withAge().build(); Book book = Book.builder().withAge(2007).withName("The Shack").build(); @@ -65,7 +65,7 @@ public void shouldReturnErrorWhenOutboundIsNull() { } @Test - public void shouldReturnErrorWhenLabelIsNull() { + void shouldReturnErrorWhenLabelIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { Person person = Person.builder().withName("Poliana").withAge().build(); Book book = Book.builder().withAge(2007).withName("The Shack").build(); @@ -74,7 +74,7 @@ public void shouldReturnErrorWhenLabelIsNull() { } @Test - public void shouldReturnNullWhenInboundIdIsNull() { + void shouldReturnNullWhenInboundIdIsNull() { Assertions.assertThrows(IllegalStateException.class, () -> { Person person = Person.builder().withName("Poliana").withAge().build(); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); @@ -84,7 +84,7 @@ public void shouldReturnNullWhenInboundIdIsNull() { } @Test - public void shouldReturnNullWhenOutboundIdIsNull() { + void shouldReturnNullWhenOutboundIdIsNull() { Assertions.assertThrows(IllegalStateException.class, () -> { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = Book.builder().withAge(2007).withName("The Shack").build(); @@ -93,7 +93,7 @@ public void shouldReturnNullWhenOutboundIdIsNull() { } @Test - public void shouldReturnEntityNotFoundWhenOutBoundDidNotFound() { + void shouldReturnEntityNotFoundWhenOutBoundDidNotFound() { Assertions.assertThrows( EmptyResultException.class, () -> { Person person = Person.builder().withId(-10L).withName("Poliana").withAge().build(); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); @@ -102,7 +102,7 @@ public void shouldReturnEntityNotFoundWhenOutBoundDidNotFound() { } @Test - public void shouldReturnEntityNotFoundWhenInBoundDidNotFound() { + void shouldReturnEntityNotFoundWhenInBoundDidNotFound() { Assertions.assertThrows( EmptyResultException.class, () -> { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = Book.builder().withId(10L).withAge(2007).withName("The Shack").build(); @@ -111,7 +111,7 @@ public void shouldReturnEntityNotFoundWhenInBoundDidNotFound() { } @Test - public void shouldCreateAnEdge() { + void shouldCreateAnEdge() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -124,7 +124,7 @@ public void shouldCreateAnEdge() { } @Test - public void shouldGetId() { + void shouldGetId() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -142,7 +142,7 @@ public void shouldGetId() { } @Test - public void shouldCreateAnEdgeWithSupplier() { + void shouldCreateAnEdgeWithSupplier() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, () -> "reads", book); @@ -155,7 +155,7 @@ public void shouldCreateAnEdgeWithSupplier() { } @Test - public void shouldUseAnEdge() { + void shouldUseAnEdge() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -167,7 +167,7 @@ public void shouldUseAnEdge() { } @Test - public void shouldUseAnEdge2() { + void shouldUseAnEdge2() { Person poliana = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Person nilzete = graphTemplate.insert(Person.builder().withName("Nilzete").withAge().build()); @@ -187,7 +187,7 @@ public void shouldUseAnEdge2() { } @Test - public void shouldUseADifferentEdge() { + void shouldUseADifferentEdge() { Person poliana = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Person nilzete = graphTemplate.insert(Person.builder().withName("Nilzete").withAge().build()); @@ -205,7 +205,7 @@ public void shouldUseADifferentEdge() { } @Test - public void shouldReturnErrorWhenAddKeyIsNull() { + void shouldReturnErrorWhenAddKeyIsNull() { assertThrows(NullPointerException.class, () -> { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); @@ -215,7 +215,7 @@ public void shouldReturnErrorWhenAddKeyIsNull() { } @Test - public void shouldReturnErrorWhenAddValueIsNull() { + void shouldReturnErrorWhenAddValueIsNull() { assertThrows(NullPointerException.class, () -> { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); @@ -226,7 +226,7 @@ public void shouldReturnErrorWhenAddValueIsNull() { } @Test - public void shouldAddProperty() { + void shouldAddProperty() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -238,7 +238,7 @@ public void shouldAddProperty() { } @Test - public void shouldAddPropertyWithValue() { + void shouldAddPropertyWithValue() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -251,7 +251,7 @@ public void shouldAddPropertyWithValue() { @Test - public void shouldReturnErrorWhenRemoveNullKeyProperty() { + void shouldReturnErrorWhenRemoveNullKeyProperty() { assertThrows(NullPointerException.class, () -> { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); @@ -265,7 +265,7 @@ public void shouldReturnErrorWhenRemoveNullKeyProperty() { } @Test - public void shouldRemoveProperty() { + void shouldRemoveProperty() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -278,7 +278,7 @@ public void shouldRemoveProperty() { } @Test - public void shouldFindProperty() { + void shouldFindProperty() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -292,7 +292,7 @@ public void shouldFindProperty() { } @Test - public void shouldDeleteAnEdge() { + void shouldDeleteAnEdge() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -305,12 +305,12 @@ public void shouldDeleteAnEdge() { } @Test - public void shouldReturnErrorWhenDeleteAnEdgeWithNull() { + void shouldReturnErrorWhenDeleteAnEdgeWithNull() { assertThrows(NullPointerException.class, () -> graphTemplate.delete((Iterable) null)); } @Test - public void shouldDeleteAnEdge2() { + void shouldDeleteAnEdge2() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); @@ -324,13 +324,13 @@ public void shouldDeleteAnEdge2() { @Test - public void shouldReturnErrorWhenFindEdgeWithNull() { + void shouldReturnErrorWhenFindEdgeWithNull() { assertThrows(NullPointerException.class, () -> graphTemplate.edge(null)); } @Test - public void shouldFindAnEdge() { + void shouldFindAnEdge() { Person person = graphTemplate.insert(Person.builder().withName("Poliana").withAge().build()); Book book = graphTemplate.insert(Book.builder().withAge(2007).withName("The Shack").build()); EdgeEntity edge = graphTemplate.edge(person, "reads", book); @@ -344,7 +344,7 @@ public void shouldFindAnEdge() { } @Test - public void shouldNotFindAnEdge() { + void shouldNotFindAnEdge() { Optional edgeEntity = graphTemplate.edge(-12L); assertFalse(edgeEntity.isPresent()); From 1f995cb5e96db436ed04d153c24bc3b118210b27 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:44 -0300 Subject: [PATCH 108/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/EmbeddedFieldMetadataTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/EmbeddedFieldMetadataTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/EmbeddedFieldMetadataTest.java index 5c35f967e..79e67fc68 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/EmbeddedFieldMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/EmbeddedFieldMetadataTest.java @@ -29,24 +29,24 @@ class EmbeddedFieldMetadataTest { private EmbeddedFieldMetadata metadata; @BeforeEach - public void setUp() { + void setUp() { ClassConverter converter = new ReflectionClassConverter(); EntityMetadata entity = converter.apply(Worker.class); metadata = (EmbeddedFieldMetadata) entity.fieldsGroupByName().get("job"); } @Test - public void shouldId(){ + void shouldId(){ Assertions.assertThat(metadata.isId()).isFalse(); } @Test - public void shouldToString(){ + void shouldToString(){ Assertions.assertThat(metadata.toString()).isNotEmpty(); } @Test - public void shouldEqualsHasCode(){ + void shouldEqualsHasCode(){ Assertions.assertThat(metadata).isEqualTo(metadata); Assertions.assertThat(metadata).hasSameHashCodeAs(metadata); } From 26d62ade50196f2c51d288ddcaf87f73424c9172 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:45 -0300 Subject: [PATCH 109/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/EntityConverterByConstructorTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/EntityConverterByConstructorTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/EntityConverterByConstructorTest.java index ea7957ca1..80aae0ff8 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/EntityConverterByConstructorTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/EntityConverterByConstructorTest.java @@ -50,7 +50,7 @@ class EntityConverterByConstructorTest { private EntitiesMetadata entities; @Test - public void shouldCreateRecordEntity() { + void shouldCreateRecordEntity() { Vertex vertex = graph.addVertex("Car"); vertex.property("model", "500"); vertex.property("manufacturer", "Fiat"); @@ -68,7 +68,7 @@ public void shouldCreateRecordEntity() { } @Test - public void shouldCreateRecordClass() { + void shouldCreateRecordClass() { Vertex vertex = graph.addVertex("Hero"); vertex.property("name", "Super man"); EntityMetadata metadata = entities.get(Hero.class); From 8b741b8a1f65051af4e890e95b5b7cf04be53fbf Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:46 -0300 Subject: [PATCH 110/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/EntityPostPersistTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/EntityPostPersistTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/EntityPostPersistTest.java index 33baa94fd..92c240084 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/EntityPostPersistTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/EntityPostPersistTest.java @@ -18,17 +18,17 @@ import static org.junit.jupiter.api.Assertions.*; -public class EntityPostPersistTest { +class EntityPostPersistTest { @Test - public void shouldGet() { + void shouldGet() { Object value = new Object(); EntityPostPersist entity = new EntityPostPersist(value); assertEquals(value, entity.get()); } @Test - public void shouldEqualsAndHashCode() { + void shouldEqualsAndHashCode() { Object value1 = new Object(); Object value2 = new Object(); @@ -44,7 +44,7 @@ public void shouldEqualsAndHashCode() { } @Test - public void shouldToString() { + void shouldToString() { Object value = new Object(); EntityPostPersist entity = new EntityPostPersist(value); String expected = "EntityPostPersist{value=" + value + "}"; @@ -52,14 +52,14 @@ public void shouldToString() { } @Test - public void shouldOf() { + void shouldOf() { Object value = new Object(); EntityPostPersist entity = EntityPostPersist.of(value); assertEquals(value, entity.get()); } @Test - public void shouldOfWithNullValue() { + void shouldOfWithNullValue() { assertThrows(NullPointerException.class, () -> EntityPostPersist.of(null)); } } From f8281692c6c8c31decdddad3e16834582c763550 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:46 -0300 Subject: [PATCH 111/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/EntityPrePersistTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/EntityPrePersistTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/EntityPrePersistTest.java index 8e203e0f1..b6e15e811 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/EntityPrePersistTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/EntityPrePersistTest.java @@ -17,17 +17,17 @@ import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.*; -public class EntityPrePersistTest { +class EntityPrePersistTest { @Test - public void shouldGet() { + void shouldGet() { Object value = new Object(); EntityPrePersist entity = new EntityPrePersist(value); assertEquals(value, entity.get()); } @Test - public void shouldEqualsAndHashCode() { + void shouldEqualsAndHashCode() { Object value1 = new Object(); Object value2 = new Object(); @@ -43,7 +43,7 @@ public void shouldEqualsAndHashCode() { } @Test - public void shouldToString() { + void shouldToString() { Object value = new Object(); EntityPrePersist entity = new EntityPrePersist(value); String expected = "DefaultEntityPrePersist{value=" + value + "}"; @@ -51,14 +51,14 @@ public void shouldToString() { } @Test - public void shouldOf() { + void shouldOf() { Object value = new Object(); EntityPrePersist entity = EntityPrePersist.of(value); assertEquals(value, entity.get()); } @Test - public void shouldOfWithNullValue() { + void shouldOfWithNullValue() { assertThrows(NullPointerException.class, () -> EntityPrePersist.of(null)); } } From da69964dabc40266c28b2ead80ab0dd3e1cb03b4 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:47 -0300 Subject: [PATCH 112/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/FieldMetadataTest.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/FieldMetadataTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/FieldMetadataTest.java index c7dd47cc9..9a6250c8e 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/FieldMetadataTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/FieldMetadataTest.java @@ -37,19 +37,19 @@ import static org.junit.jupiter.api.Assertions.assertEquals; -public class FieldMetadataTest { +class FieldMetadataTest { private ClassConverter converter; @BeforeEach - public void setUp() { + void setUp() { this.converter = new ReflectionClassConverter(); } @Test - public void shouldReadDefaultField() { + void shouldReadDefaultField() { EntityMetadata entityMetadata = converter.apply(ForClass.class); List fields = entityMetadata.fields(); @@ -63,7 +63,7 @@ public void shouldReadDefaultField() { } @Test - public void shouldReadCollectionField() { + void shouldReadCollectionField() { EntityMetadata entityMetadata = converter.apply(ForClass.class); List fields = entityMetadata.fields(); FieldMetadata field = fields.stream() @@ -75,7 +75,7 @@ public void shouldReadCollectionField() { } @Test - public void shouldReadMapField() { + void shouldReadMapField() { EntityMetadata entityMetadata = converter.apply(ForClass.class); List fields = entityMetadata.fields(); FieldMetadata field = fields.stream() @@ -88,7 +88,7 @@ public void shouldReadMapField() { } @Test - public void shouldReadEmbeddableField() { + void shouldReadEmbeddableField() { EntityMetadata entityMetadata = converter.apply(ForClass.class); List fields = entityMetadata.fields(); FieldMetadata field = fields.stream() @@ -100,7 +100,7 @@ public void shouldReadEmbeddableField() { } @Test - public void shouldUserFieldReader() { + void shouldUserFieldReader() { ForClass forClass = new ForClass(); forClass.string = "text"; forClass.list = Collections.singletonList("text"); @@ -123,7 +123,7 @@ public void shouldUserFieldReader() { } @Test - public void shouldUserFieldWriter() { + void shouldUserFieldWriter() { ForClass forClass = new ForClass(); BarClass value = new BarClass(); value.integer = 10; @@ -147,7 +147,7 @@ public void shouldUserFieldWriter() { } @Test - public void shouldReadFromAnnotation(){ + void shouldReadFromAnnotation(){ EntityMetadata entityMetadata = converter.apply(ForClass.class); List fields = entityMetadata.fields(); @@ -161,7 +161,7 @@ public void shouldReadFromAnnotation(){ } @Test - public void shouldReturnEmptyWhenThereIsNotAnnotation(){ + void shouldReturnEmptyWhenThereIsNotAnnotation(){ EntityMetadata entityMetadata = converter.apply(ForClass.class); List fields = entityMetadata.fields(); @@ -174,7 +174,7 @@ public void shouldReturnEmptyWhenThereIsNotAnnotation(){ } @Test - public void shouldReturnEmptyWhenThereIsValueMethod(){ + void shouldReturnEmptyWhenThereIsValueMethod(){ EntityMetadata entityMetadata = converter.apply(ForClass.class); List fields = entityMetadata.fields(); @@ -188,7 +188,7 @@ public void shouldReturnEmptyWhenThereIsValueMethod(){ @Test - public void shouldReturnEmptyWhenThereIsValueMethod2(){ + void shouldReturnEmptyWhenThereIsValueMethod2(){ EntityMetadata entityMetadata = converter.apply(ForClass.class); List fields = entityMetadata.fields(); From 5fd0b36302fd66c89adbdd81d1122d3d7ba860d3 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:48 -0300 Subject: [PATCH 113/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/query/GetProviderTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/GetProviderTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/GetProviderTest.java index 35528f7f1..bf1d867eb 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/GetProviderTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/GetProviderTest.java @@ -30,14 +30,14 @@ class GetProviderTest { private final GetQueryConverter queryProvider = new GetQueryConverter(); @Test - public void shouldReturnErrorWhenStringIsNull() { + void shouldReturnErrorWhenStringIsNull() { Assertions.assertThrows(NullPointerException.class, () -> queryProvider.apply(null)); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"get \"Diana\""}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { GetQuery getQuery = queryProvider.apply(query); List> keys = getQuery.keys(); assertEquals(1, keys.size()); @@ -48,7 +48,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"get 12"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { GetQuery getQuery = queryProvider.apply(query); List> keys = getQuery.keys(); assertEquals(1, keys.size()); @@ -59,7 +59,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"get 12.12"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { GetQuery getQuery = queryProvider.apply(query); List> keys = getQuery.keys(); assertEquals(1, keys.size()); @@ -70,7 +70,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"get -12"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { GetQuery getQuery = queryProvider.apply(query); List> keys = getQuery.keys(); assertEquals(1, keys.size()); @@ -81,7 +81,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"get -12.12"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { GetQuery getQuery = queryProvider.apply(query); List> keys = getQuery.keys(); assertEquals(1, keys.size()); @@ -93,7 +93,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"get {1,12}"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { GetQuery getQuery = queryProvider.apply(query); List> keys = getQuery.keys(); assertEquals(1, keys.size()); From f36e4d8f69674dcfe093a45c296b5d8c107653f0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:48 -0300 Subject: [PATCH 114/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/communication/query/GetQueryTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/GetQueryTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/GetQueryTest.java index b8b9fead4..b941463e7 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/GetQueryTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/GetQueryTest.java @@ -28,22 +28,22 @@ import static org.assertj.core.api.Assertions.assertThat; -public class GetQueryTest { +class GetQueryTest { @ParameterizedTest @ArgumentsSource(GetQueryArgumentProvider.class) - public void shouldExecuteQuery(String query) { + void shouldExecuteQuery(String query) { testQuery(query); } @Test - public void shouldIgnoreComments() { + void shouldIgnoreComments() { testQuery("//ignore this line \n get 12"); } @ParameterizedTest @ArgumentsSource(WrongGetQueryArgumentProvider.class) - public void shouldNotExecute(String query) { + void shouldNotExecute(String query) { Assertions.assertThrows(QueryException.class, () -> testQuery(query)); } From a1132dbf0dd1d2a398287e5095ddaa3020be8f30 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:48 -0300 Subject: [PATCH 115/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../spi/GraphConfigurationProducerExtensionTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/spi/GraphConfigurationProducerExtensionTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/spi/GraphConfigurationProducerExtensionTest.java index 874fd2843..8203707ca 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/spi/GraphConfigurationProducerExtensionTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/spi/GraphConfigurationProducerExtensionTest.java @@ -38,7 +38,7 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class GraphConfigurationProducerExtensionTest { +class GraphConfigurationProducerExtensionTest { @Inject @Database(value = GRAPH, provider = "graphRepositoryMock") @@ -57,20 +57,20 @@ public class GraphConfigurationProducerExtensionTest { @Test - public void shouldInstance() { + void shouldInstance() { assertNotNull(manager); assertNotNull(managerMock); } @Test - public void shouldSave() { + void shouldSave() { Person personMock = managerMock.insert(Person.builder().withId(10L).build()); assertEquals(Long.valueOf(10L), personMock.getId()); } @Test - public void shouldInjectRepository() { + void shouldInjectRepository() { repositoryMock.save(Book.builder().withName("book").build()); assertNotNull(repository.findById("10")); } From 6c27de702b8b9616b49992dc7839b02a1a6bba54 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:49 -0300 Subject: [PATCH 116/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/graph/GraphEventPersistManagerTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphEventPersistManagerTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphEventPersistManagerTest.java index 23beda30e..fb1ecd532 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphEventPersistManagerTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphEventPersistManagerTest.java @@ -29,7 +29,7 @@ import static org.mockito.Mockito.verify; @ExtendWith(MockitoExtension.class) -public class GraphEventPersistManagerTest { +class GraphEventPersistManagerTest { @InjectMocks private GraphEventPersistManager subject; @@ -44,7 +44,7 @@ public class GraphEventPersistManagerTest { private Vertex vertex; @Test - public void shouldFirePreEntity() { + void shouldFirePreEntity() { Jedi jedi = new Jedi(); jedi.name = "Luke"; subject.firePreEntity(jedi); @@ -55,7 +55,7 @@ public void shouldFirePreEntity() { } @Test - public void shouldFirePostEntity() { + void shouldFirePostEntity() { Jedi jedi = new Jedi(); jedi.name = "Luke"; subject.firePostEntity(jedi); From c5137ae607a519d86e26fe08804143e80906dfae Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:49 -0300 Subject: [PATCH 117/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/GraphImmutableConveterTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphImmutableConveterTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphImmutableConveterTest.java index 90640c687..5e4be942d 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphImmutableConveterTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphImmutableConveterTest.java @@ -50,13 +50,13 @@ class GraphImmutableConveterTest { private Graph graph; @BeforeEach - public void setUp() { + void setUp() { this.graph.traversal().V().toList().forEach(Vertex::remove); this.graph.traversal().E().toList().forEach(Edge::remove); } @Test - public void shouldConvertEntity() { + void shouldConvertEntity() { Car car = new Car(null, "SF90", "Ferrari", 2023); Vertex vertex = this.converter.toVertex(car); SoftAssertions.assertSoftly(soft -> { @@ -73,7 +73,7 @@ public void shouldConvertEntity() { } @Test - public void shouldConvertVertex() { + void shouldConvertVertex() { Vertex vertex = graph.addVertex("Car"); vertex.property("model", "SF90"); vertex.property("manufacturer", "Ferrari"); @@ -89,7 +89,7 @@ public void shouldConvertVertex() { } @Test - public void shouldConvertToExistRecordEntity() { + void shouldConvertToExistRecordEntity() { Vertex vertex = graph.addVertex("Car"); vertex.property("model", "SF90"); vertex.property("manufacturer", "Ferrari"); @@ -112,7 +112,7 @@ public void shouldConvertToExistRecordEntity() { } @Test - public void shouldConvertToExistEntity() { + void shouldConvertToExistEntity() { Vertex vertex = graph.addVertex("Hero"); vertex.property("name", "Iron Man"); Hero hero = new Hero(null, null); From ee71f1f0e1305f1fd29e8113ef89aa08ef83af06 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:50 -0300 Subject: [PATCH 118/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/graph/query/GraphRepositoryProducerTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProducerTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProducerTest.java index 1923c1e01..287e90df8 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProducerTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProducerTest.java @@ -43,7 +43,7 @@ class GraphRepositoryProducerTest { @Test - public void shouldCreateFromManager() { + void shouldCreateFromManager() { Graph manager= Mockito.mock(Graph.class); GraphRepositoryProxyTest.PersonRepository personRepository = producer.get(GraphRepositoryProxyTest.PersonRepository.class, manager); assertNotNull(personRepository); From 05f426b510cdb01cf88ce9da70c0dbb259fa0ca2 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:52 -0300 Subject: [PATCH 119/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../GraphRepositoryProxyPageableTest.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProxyPageableTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProxyPageableTest.java index 71b247c27..b2f481a7e 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProxyPageableTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProxyPageableTest.java @@ -58,7 +58,7 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class GraphRepositoryProxyPageableTest { +class GraphRepositoryProxyPageableTest { private GraphTemplate template; @@ -79,7 +79,7 @@ public class GraphRepositoryProxyPageableTest { private PersonRepository personRepository; @BeforeEach - public void setUp() { + void setUp() { graph.traversal().V().toList().forEach(Vertex::remove); graph.traversal().E().toList().forEach(Edge::remove); @@ -101,14 +101,14 @@ public void setUp() { } @AfterEach - public void after() { + void after() { graph.traversal().V().toList().forEach(Vertex::remove); graph.traversal().E().toList().forEach(Edge::remove); } @Test - public void shouldFindByNameAndAge() { + void shouldFindByNameAndAge() { graph.addVertex(T.label, "Person", "name", "name", "age", 20); graph.addVertex(T.label, "Person", "name", "name", "age", 20); @@ -123,7 +123,7 @@ public void shouldFindByNameAndAge() { } @Test - public void shouldFindByAgeAndName() { + void shouldFindByAgeAndName() { graph.addVertex(T.label, "Person", "name", "name", "age", 20); graph.addVertex(T.label, "Person", "name", "name", "age", 20); @@ -136,7 +136,7 @@ public void shouldFindByAgeAndName() { } @Test - public void shouldFindByAge() { + void shouldFindByAge() { graph.addVertex(T.label, "Person", "name", "name", "age", 20); Optional person = personRepository.findByAge(20, Pageable.ofPage(1).size(2)); @@ -145,7 +145,7 @@ public void shouldFindByAge() { @Test - public void shouldFindAll() { + void shouldFindAll() { graph.addVertex(T.label, "Person", "name", "name", "age", 20); graph.addVertex(T.label, "Person", "name", "name", "age", 20); List people = personRepository.findAll(Pageable.ofPage(2).size(1)).content(); @@ -154,13 +154,13 @@ public void shouldFindAll() { } @Test - public void shouldReturnEmptyAtFindAll() { + void shouldReturnEmptyAtFindAll() { List people = personRepository.findAll(Pageable.ofPage(1).size(2)).content(); assertTrue(people.isEmpty()); } @Test - public void shouldFindByName() { + void shouldFindByName() { graph.addVertex(T.label, "Person", "name", "Otavio", "age", 30); graph.addVertex(T.label, "Person", "name", "Otavio", "age", 20); List people = personRepository.findByName("Otavio", Pageable.ofPage(2).size(1) @@ -172,7 +172,7 @@ public void shouldFindByName() { } @Test - public void shouldFindByNameOrderByAge() { + void shouldFindByNameOrderByAge() { graph.addVertex(T.label, "Person", "name", "Otavio", "age", 30); graph.addVertex(T.label, "Person", "name", "Otavio", "age", 20); Page page = personRepository.findByNameOrderByAge("Otavio", Pageable.ofPage(1).size(1)); @@ -187,7 +187,7 @@ public void shouldFindByNameOrderByAge() { } @Test - public void shouldFindByAgeOrderByName() { + void shouldFindByAgeOrderByName() { graph.addVertex(T.label, "Person", "name", "Otavio", "age", 30); graph.addVertex(T.label, "Person", "name", "Otavio", "age", 20); Slice slice = personRepository.findByAgeOrderByName(20, Pageable.ofPage(1).size(1)); @@ -198,7 +198,7 @@ public void shouldFindByAgeOrderByName() { } @Test - public void shouldFindByNameSort() { + void shouldFindByNameSort() { graph.addVertex(T.label, "Person", "name", "Otavio", "age", 30); graph.addVertex(T.label, "Person", "name", "Otavio", "age", 20); List people = personRepository.findByName("Otavio", Sort.desc("age")); @@ -207,7 +207,7 @@ public void shouldFindByNameSort() { } @Test - public void shouldFindNameSortPageable() { + void shouldFindNameSortPageable() { graph.addVertex(T.label, "Person", "name", "Otavio", "age", 30); graph.addVertex(T.label, "Person", "name", "Poliana", "age", 20); graph.addVertex(T.label, "Person", "name", "Ada", "age", 30); @@ -220,7 +220,7 @@ public void shouldFindNameSortPageable() { } @Test - public void shouldFindNameLimit() { + void shouldFindNameLimit() { graph.addVertex(T.label, "Person", "name", "Ada", "age", 30); graph.addVertex(T.label, "Person", "name", "Otavio", "age", 30); graph.addVertex(T.label, "Person", "name", "Poliana", "age", 20); From d3b3fdef97df5bd6f35fb88e9fc22fbc6825c4a8 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:53 -0300 Subject: [PATCH 120/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/graph/query/GraphRepositoryProxyTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProxyTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProxyTest.java index d03b56dfa..3b1f8379a 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProxyTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/GraphRepositoryProxyTest.java @@ -528,7 +528,7 @@ void shouldUseDefaultMethodFromOtherInterface() { } @Test - public void shouldExecuteCustomRepository(){ + void shouldExecuteCustomRepository(){ PersonStatisticRepository.PersonStatistic statistics = personRepository.statistics("Salvador"); assertThat(statistics).isNotNull(); SoftAssertions.assertSoftly(softly -> { From fc9f698d25d2d2b7c8ada4930ed278bce0ec93a4 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:53 -0300 Subject: [PATCH 121/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/configuration/GraphSupplierTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/configuration/GraphSupplierTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/configuration/GraphSupplierTest.java index e2d6632f6..45a08daec 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/configuration/GraphSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/configuration/GraphSupplierTest.java @@ -49,7 +49,7 @@ public void beforeEach(){ } @Test - public void shouldGetGraph() { + void shouldGetGraph() { System.setProperty(GRAPH_PROVIDER.get(), GraphConfigurationMock.class.getName()); Graph graph = supplier.get(); Assertions.assertNotNull(graph); @@ -58,7 +58,7 @@ public void shouldGetGraph() { @Test - public void shouldUseDefaultConfigurationWhenProviderIsWrong() { + void shouldUseDefaultConfigurationWhenProviderIsWrong() { System.setProperty(GRAPH_PROVIDER.get(), Integer.class.getName()); Graph graph = supplier.get(); Assertions.assertNotNull(graph); @@ -66,14 +66,14 @@ public void shouldUseDefaultConfigurationWhenProviderIsWrong() { } @Test - public void shouldUseDefaultConfiguration() { + void shouldUseDefaultConfiguration() { Graph graph = supplier.get(); Assertions.assertNotNull(graph); assertThat(graph).isInstanceOf(GraphConfigurationMock2.GraphMock.class); } @Test - public void shouldClose() throws Exception { + void shouldClose() throws Exception { Graph graph = Mockito.mock(Graph.class); supplier.close(graph); Mockito.verify(graph).close(); From 1ecd8e56753f3ee555bf3abf4c5c963b1878af2a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:54 -0300 Subject: [PATCH 122/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/graph/GraphTemplateProducerTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphTemplateProducerTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphTemplateProducerTest.java index dac0bfba1..176d7fc12 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphTemplateProducerTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphTemplateProducerTest.java @@ -34,19 +34,19 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class GraphTemplateProducerTest { +class GraphTemplateProducerTest { @Inject private GraphTemplateProducer producer; @Test - public void shouldReturnErrorWhenManagerNull() { + void shouldReturnErrorWhenManagerNull() { assertThrows(NullPointerException.class, () -> producer.get((Graph) null)); assertThrows(NullPointerException.class, () -> producer.get((GraphTraversalSourceSupplier) null)); } @Test - public void shouldReturnGraphTemplateWhenGetGraph() { + void shouldReturnGraphTemplateWhenGetGraph() { Graph graph = Mockito.mock(Graph.class); GraphTemplate template = producer.get(graph); assertNotNull(template); @@ -54,7 +54,7 @@ public void shouldReturnGraphTemplateWhenGetGraph() { @Test - public void shouldReturnGraphTemplateWhenGetGraphTraversalSourceSupplier() { + void shouldReturnGraphTemplateWhenGetGraphTraversalSourceSupplier() { GraphTraversalSourceSupplier supplier = Mockito.mock(GraphTraversalSourceSupplier.class); GraphTemplate template = producer.get(supplier); assertNotNull(template); From 34f9dcb40f88b2568bd0fc6bdf42f35a3a0982a1 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:55 -0300 Subject: [PATCH 123/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/graph/GraphTransactionUtilTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphTransactionUtilTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphTransactionUtilTest.java index 52cb36ddd..0582f76cb 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphTransactionUtilTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GraphTransactionUtilTest.java @@ -22,12 +22,12 @@ class GraphTransactionUtilTest { @Test - public void shouldReturnTrue() { + void shouldReturnTrue() { Assertions.assertTrue(GraphTransactionUtil.isAutomatic()); } @Test - public void shouldReturnFalse() { + void shouldReturnFalse() { synchronized (GraphTransactionUtil.class) { System.setProperty(GRAPH_TRANSACTION_AUTOMATIC.get(), Boolean.FALSE.toString()); Assertions.assertFalse(GraphTransactionUtil.isAutomatic()); From e6af82f7212a2d01862d4564b0733120bfc0cc0d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:56 -0300 Subject: [PATCH 124/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/GremlinExecutorTest.java | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GremlinExecutorTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GremlinExecutorTest.java index 5ccb83c21..c81dc83d6 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GremlinExecutorTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GremlinExecutorTest.java @@ -56,7 +56,7 @@ class GremlinExecutorTest { private GremlinExecutor executor; @BeforeEach - public void before() { + void before() { executor = new GremlinExecutor(converter); graph.traversal().V().toList().forEach(Vertex::remove); graph.traversal().E().toList().forEach(Edge::remove); @@ -67,7 +67,7 @@ public void before() { } @Test - public void shouldExecuteQueryEdges() { + void shouldExecuteQueryEdges() { List edges = executor. executeGremlin(graph.traversal(), "g.E()") .toList(); @@ -82,7 +82,7 @@ public void shouldExecuteQueryEdges() { } @Test - public void shouldExecuteQueryEdges2() { + void shouldExecuteQueryEdges2() { List edges = executor. executeGremlin(graph.traversal(), "g.E().toList()") .toList(); @@ -97,7 +97,7 @@ public void shouldExecuteQueryEdges2() { } @Test - public void shouldExecuteQueryVertex() { + void shouldExecuteQueryVertex() { List people = executor.executeGremlin(graph.traversal(), "g.V()") .toList(); assertFalse(people.isEmpty()); @@ -107,7 +107,7 @@ public void shouldExecuteQueryVertex() { } @Test - public void shouldExecuteQueryVertex2() { + void shouldExecuteQueryVertex2() { List people = executor.executeGremlin(graph.traversal(), "g.V().toList()") .toList(); assertFalse(people.isEmpty()); @@ -117,7 +117,7 @@ public void shouldExecuteQueryVertex2() { } @Test - public void shouldExecuteQueryVertex3() { + void shouldExecuteQueryVertex3() { List people = executor.executeGremlin(graph.traversal(), "g.V().in('loves').toList()") .toList(); List names = people.stream().map(Person::getName).collect(toList()); @@ -126,7 +126,7 @@ public void shouldExecuteQueryVertex3() { } @Test - public void shouldExecuteQueryVertex4() { + void shouldExecuteQueryVertex4() { List people = executor.executeGremlin(graph.traversal(), "g.V().in('loves').toSet()") .toList(); List names = people.stream().map(Person::getName).collect(toList()); @@ -135,7 +135,7 @@ public void shouldExecuteQueryVertex4() { } @Test - public void shouldExecuteQueryVertex5() { + void shouldExecuteQueryVertex5() { List people = executor.executeGremlin(graph.traversal(), "g.V().in('loves').toList()") .toList(); List names = people.stream().map(Person::getName).collect(toList()); @@ -144,7 +144,7 @@ public void shouldExecuteQueryVertex5() { } @Test - public void shouldExecuteQueryCount() { + void shouldExecuteQueryCount() { List count = executor.executeGremlin(graph.traversal(), "g.V().count().toList()") .collect(toList()); assertFalse(count.isEmpty()); @@ -152,7 +152,7 @@ public void shouldExecuteQueryCount() { } @Test - public void shouldExecuteQueryCount2() { + void shouldExecuteQueryCount2() { List count = executor.executeGremlin(graph.traversal(), "g.V().count()") .collect(toList()); assertFalse(count.isEmpty()); @@ -160,7 +160,7 @@ public void shouldExecuteQueryCount2() { } @Test - public void shouldExecuteQueryProperties() { + void shouldExecuteQueryProperties() { List properties = executor.executeGremlin(graph.traversal(), "g.V().values()") .collect(toList()); assertFalse(properties.isEmpty()); @@ -169,7 +169,7 @@ public void shouldExecuteQueryProperties() { } @Test - public void shouldExecuteQueryProperties2() { + void shouldExecuteQueryProperties2() { List properties = executor.executeGremlin(graph.traversal(), "g.V().values().toList()") .collect(toList()); assertFalse(properties.isEmpty()); @@ -178,7 +178,7 @@ public void shouldExecuteQueryProperties2() { } @Test - public void shouldExecuteQueryPropertiesMap() { + void shouldExecuteQueryPropertiesMap() { List>> properties = executor.>> executeGremlin(graph.traversal(), "g.V().valueMap('name')") .toList(); @@ -189,7 +189,7 @@ public void shouldExecuteQueryPropertiesMap() { } @Test - public void shouldExecuteQueryPropertiesMap2() { + void shouldExecuteQueryPropertiesMap2() { List>> properties = executor.>> executeGremlin(graph.traversal(), "g.V().valueMap('name').toList()") .toList(); @@ -199,7 +199,7 @@ public void shouldExecuteQueryPropertiesMap2() { } @Test - public void shouldExecuteWithParams() { + void shouldExecuteWithParams() { List people = executor.executeGremlin(graph.traversal(), "g.V().in(@param).toList()",singletonMap("param", "loves")) From 255c69c83de86a8d864c1e64cf2928119b9bd76a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:57 -0300 Subject: [PATCH 125/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/GremlinParamParserTest.java | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GremlinParamParserTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GremlinParamParserTest.java index b132815b8..00af378df 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GremlinParamParserTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/GremlinParamParserTest.java @@ -27,7 +27,7 @@ class GremlinParamParserTest { private final GremlinParamParser parser = GremlinParamParser.INSTANCE; @Test - public void shouldGotErrorWhenNull() { + void shouldGotErrorWhenNull() { assertNotNull(NullPointerException.class, () -> parser.apply(null, null)); assertNotNull(NullPointerException.class, () -> @@ -38,7 +38,7 @@ public void shouldGotErrorWhenNull() { } @Test - public void shouldParserParamString() { + void shouldParserParamString() { String query = "g.V().hasLabel(@param)"; String expected = "g.V().hasLabel('Otavio')"; Map params = Map.of("param", "Otavio"); @@ -48,7 +48,7 @@ public void shouldParserParamString() { } @Test - public void shouldParserBoolean() { + void shouldParserBoolean() { String query = "g.V().hasLabel(@label).has('active', @active)"; String expected = "g.V().hasLabel('Otavio').has('active', 'true')"; Map params = Map.of("label", "Otavio", "active", Boolean.TRUE); @@ -58,7 +58,7 @@ public void shouldParserBoolean() { } @Test - public void shouldParserPrimitiveBoolean() { + void shouldParserPrimitiveBoolean() { String query = "g.V().hasLabel(@label).has('active', @active)"; String expected = "g.V().hasLabel('Otavio').has('active', 'true')"; Map params = Map.of("label", "Otavio", "active", true); @@ -67,7 +67,7 @@ public void shouldParserPrimitiveBoolean() { Assertions.assertEquals(expected, gremlin); } @Test - public void shouldParserBooleanFalse() { + void shouldParserBooleanFalse() { String query = "g.V().hasLabel(@label).has('active', @active)"; String expected = "g.V().hasLabel('Otavio').has('active', 'false')"; Map params = Map.of("label", "Otavio", "active", Boolean.FALSE); @@ -77,7 +77,7 @@ public void shouldParserBooleanFalse() { } @Test - public void shouldParserPrimitiveBooleanFalse() { + void shouldParserPrimitiveBooleanFalse() { String query = "g.V().hasLabel(@label).has('active', @active)"; String expected = "g.V().hasLabel('Otavio').has('active', 'false')"; Map params = Map.of("label", "Otavio", "active", false); @@ -87,7 +87,7 @@ public void shouldParserPrimitiveBooleanFalse() { } @Test - public void shouldParserNumber() { + void shouldParserNumber() { String query = "g.V().hasLabel(@label).has('age', @age)"; String expected = "g.V().hasLabel('Otavio').has('age', 15)"; Map params = Map.of("label", "Otavio", "age", 15); @@ -98,7 +98,7 @@ public void shouldParserNumber() { } @Test - public void shouldParserNegativeNumber() { + void shouldParserNegativeNumber() { String query = "g.V().hasLabel(@label).has('age', @age)"; String expected = "g.V().hasLabel('Otavio').has('age', -15)"; Map params = Map.of("label", "Otavio", "age", -15); @@ -108,7 +108,7 @@ public void shouldParserNegativeNumber() { } @Test - public void shouldReplaceAll() { + void shouldReplaceAll() { String query = "g.V().hasLabel(@label).has('name', @label)"; String expected = "g.V().hasLabel('Otavio').has('name', 'Otavio')"; Map params = Map.of("label", "Otavio"); @@ -118,7 +118,7 @@ public void shouldReplaceAll() { } @Test - public void shouldGetAnExceptionWhenThereIsMoreParamsLeft() { + void shouldGetAnExceptionWhenThereIsMoreParamsLeft() { String query = "g.V().hasLabel(@label).has('age', @age)"; Map params = Map.of("label", "Otavio"); @@ -127,7 +127,7 @@ public void shouldGetAnExceptionWhenThereIsMoreParamsLeft() { } @Test - public void shouldReturnErrorWhenMissingParameter(){ + void shouldReturnErrorWhenMissingParameter(){ String query = "g.V().hasLabel(@label)"; Map params = Map.of("label", "Otavio", "age", 15); From 624876effb9d1cc43e0ae87eda89aefbc84cdd06 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:34:59 -0300 Subject: [PATCH 126/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../org/eclipse/jnosql/mapping/IdNotFoundExceptionTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/IdNotFoundExceptionTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/IdNotFoundExceptionTest.java index 8b9bf5513..982c6355e 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/IdNotFoundExceptionTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/IdNotFoundExceptionTest.java @@ -23,14 +23,14 @@ class IdNotFoundExceptionTest { @Test - public void testConstructorWithMessage() { + void testConstructorWithMessage() { String errorMessage = "Test error message"; IdNotFoundException exception = new IdNotFoundException(errorMessage); assertEquals(errorMessage, exception.getMessage()); } @Test - public void testNewInstance() { + void testNewInstance() { Class entityType = MyClass.class; String expectedMessage = "The entity " + entityType.getName() + " must have a field annotated with @Id"; IdNotFoundException exception = IdNotFoundException.newInstance(entityType); @@ -38,7 +38,7 @@ public void testNewInstance() { } @Test - public void testKeyNotFoundExceptionSupplier() { + void testKeyNotFoundExceptionSupplier() { Supplier supplier = IdNotFoundException.KEY_NOT_FOUND_EXCEPTION_SUPPLIER; assertNotNull(supplier); IdNotFoundException exception = supplier.get(); From 4b12c1f4f9b7852fd03409a4f3689bd784b05576 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:01 -0300 Subject: [PATCH 127/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/query/InsertQueryConverterTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/InsertQueryConverterTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/InsertQueryConverterTest.java index 29a154880..ebcfb4726 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/InsertQueryConverterTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/InsertQueryConverterTest.java @@ -30,7 +30,7 @@ import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; -public class InsertQueryConverterTest { +class InsertQueryConverterTest { private final InsertQueryConverter insertQueryConverter = new InsertQueryConverter(); From e878bd2c46fb4409752ff53a71bdac23375bff9c Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:03 -0300 Subject: [PATCH 128/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/InsertQueryParserTest.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/InsertQueryParserTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/InsertQueryParserTest.java index 6a5d828c5..522dcfe21 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/InsertQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/InsertQueryParserTest.java @@ -44,7 +44,7 @@ class InsertQueryParserTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\")"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); parser.query(query, manager, observer); Mockito.verify(manager).insert(captor.capture()); @@ -57,7 +57,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (age = 30, name = \"Artemis\")"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); parser.query(query, manager, observer); Mockito.verify(manager).insert(captor.capture()); @@ -70,7 +70,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 day"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -87,7 +87,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 hour"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -104,7 +104,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 minute"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -121,7 +121,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 second"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -139,7 +139,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 millisecond"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -156,7 +156,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 nanosecond"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -173,7 +173,7 @@ public void shouldReturnParserQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert Person {\"name\":\"Ada Lovelace\"}"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); @@ -187,7 +187,7 @@ public void shouldReturnParserQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert Person {\"name\":\"Ada Lovelace\"} 10 nanosecond"}) - public void shouldReturnParserQuery9(String query) { + void shouldReturnParserQuery9(String query) { ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); @@ -205,7 +205,7 @@ public void shouldReturnParserQuery9(String query) { @ValueSource(strings = {"insert Person {\"name\": \"Ada Lovelace\", \"age\": 12, \"sibling\":" + " [\"Ana\" ,\"Maria\"]," + " \"address\":{\"country\": \"United Kingdom\", \"city\": \"London\"}}"}) - public void shouldReturnParserQuery10(String query) { + void shouldReturnParserQuery10(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); @@ -227,7 +227,7 @@ public void shouldReturnParserQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = @name)"}) - public void shouldReturnErrorWhenShouldUsePrepareStatement(String query) { + void shouldReturnErrorWhenShouldUsePrepareStatement(String query) { assertThrows(QueryException.class, () -> parser.query(query, manager, observer)); } @@ -235,7 +235,7 @@ public void shouldReturnErrorWhenShouldUsePrepareStatement(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = @name)"}) - public void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { + void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { ColumnPreparedStatement prepare = parser.prepare(query, manager, observer); assertThrows(QueryException.class, prepare::result); @@ -244,7 +244,7 @@ public void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = @name)"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ColumnPreparedStatement prepare = parser.prepare(query, manager, observer); prepare.bind("name", "Diana"); From 6b22885df926ce84c1851fb17b78fe553ce712c0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:04 -0300 Subject: [PATCH 129/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/InsertQueryParserTest.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/InsertQueryParserTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/InsertQueryParserTest.java index fd722e1cf..7f3b9acc2 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/InsertQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/InsertQueryParserTest.java @@ -44,7 +44,7 @@ class InsertQueryParserTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\")"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); parser.query(query, manager, observer); Mockito.verify(manager).insert(captor.capture()); @@ -57,7 +57,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (age = 30, name = \"Artemis\")"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); parser.query(query, manager, observer); Mockito.verify(manager).insert(captor.capture()); @@ -70,7 +70,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 day"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -87,7 +87,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 hour"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -104,7 +104,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 minute"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -121,7 +121,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 second"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -139,7 +139,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 millisecond"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -156,7 +156,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = \"Diana\") 10 nanosecond"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); @@ -174,7 +174,7 @@ public void shouldReturnParserQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert Person {\"name\":\"Ada Lovelace\"}"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); @@ -188,7 +188,7 @@ public void shouldReturnParserQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert Person {\"name\":\"Ada Lovelace\"} 10 nanosecond"}) - public void shouldReturnParserQuery9(String query) { + void shouldReturnParserQuery9(String query) { ArgumentCaptor durationCaptor = ArgumentCaptor.forClass(Duration.class); ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); @@ -206,7 +206,7 @@ public void shouldReturnParserQuery9(String query) { @ValueSource(strings = {"insert Person {\"name\": \"Ada Lovelace\", \"age\": 12, \"sibling\":" + " [\"Ana\" ,\"Maria\"]," + " \"address\":{\"country\": \"United Kingdom\", \"city\": \"London\"}}"}) - public void shouldReturnParserQuery10(String query) { + void shouldReturnParserQuery10(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); @@ -228,7 +228,7 @@ public void shouldReturnParserQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = @name)"}) - public void shouldReturnErrorWhenShouldUsePrepareStatement(String query) { + void shouldReturnErrorWhenShouldUsePrepareStatement(String query) { assertThrows(QueryException.class, () -> parser.query(query, manager, observer)); } @@ -236,7 +236,7 @@ public void shouldReturnErrorWhenShouldUsePrepareStatement(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = @name)"}) - public void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { + void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { DocumentPreparedStatement prepare = parser.prepare(query, manager, observer); assertThrows(QueryException.class, prepare::result); @@ -245,7 +245,7 @@ public void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"insert God (name = @name)"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); DocumentPreparedStatement prepare = parser.prepare(query, manager, observer); prepare.bind("name", "Diana"); From 10873a044392bb59a7b1dcd8533690ec9111e8f0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:05 -0300 Subject: [PATCH 130/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../returns/InstanceRepositoryReturnTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/InstanceRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/InstanceRepositoryReturnTest.java index 32620473c..06c6b99f2 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/InstanceRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/InstanceRepositoryReturnTest.java @@ -40,14 +40,14 @@ class InstanceRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Person.class)); Assertions.assertFalse(repositoryReturn.isCompatible(Object.class, Person.class)); Assertions.assertFalse(repositoryReturn.isCompatible(Person.class, Object.class)); } @Test - public void shouldReturnInstancePage() { + void shouldReturnInstancePage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() @@ -66,7 +66,7 @@ public void shouldReturnInstancePage() { } @Test - public void shouldReturnNullAsInstancePage() { + void shouldReturnNullAsInstancePage() { DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Person.class) .withSingleResult(Optional::empty) @@ -82,7 +82,7 @@ public void shouldReturnNullAsInstancePage() { } @Test - public void shouldReturnInstance() { + void shouldReturnInstance() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() @@ -97,7 +97,7 @@ public void shouldReturnInstance() { } @Test - public void shouldReturnNullAsInstance() { + void shouldReturnNullAsInstance() { DynamicReturn dynamic = DynamicReturn.builder() .withSingleResult(Optional::empty) .withClassSource(Person.class) From 014a641ff002372e4df86e83e27db6b281b0334f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:07 -0300 Subject: [PATCH 131/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/query/JSONQueryValueTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/JSONQueryValueTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/JSONQueryValueTest.java index 1ca135236..388bfc763 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/JSONQueryValueTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/JSONQueryValueTest.java @@ -23,13 +23,13 @@ class JSONQueryValueTest { private JsonObject json; @BeforeEach - public void setUp() { + void setUp() { this.json = JsonObject.EMPTY_JSON_OBJECT.asJsonObject(); } @Test - public void shouldGetType() { + void shouldGetType() { JSONQueryValue queryValue = new JSONQueryValue(json); assertThat(queryValue).isNotNull() .extracting(JSONQueryValue::type) @@ -37,7 +37,7 @@ public void shouldGetType() { } @Test - public void shouldGet() { + void shouldGet() { JSONQueryValue queryValue = new JSONQueryValue(json); assertThat(queryValue).isNotNull() .extracting(JSONQueryValue::get) @@ -45,13 +45,13 @@ public void shouldGet() { } @Test - public void shouldEquals(){ + void shouldEquals(){ JSONQueryValue queryValue = new JSONQueryValue(json); assertEquals(queryValue, new JSONQueryValue(json)); } @Test - public void shouldHashCode() { + void shouldHashCode() { JSONQueryValue queryValue = new JSONQueryValue(json); assertEquals(queryValue.hashCode(), new JSONQueryValue(json).hashCode()); } From 9a1169b9bc0be301e453874d17b0208f2d7e371a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:10 -0300 Subject: [PATCH 132/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/keyvalue/KeyValueEventPersistManagerTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueEventPersistManagerTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueEventPersistManagerTest.java index 3189ca443..fc474cda3 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueEventPersistManagerTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueEventPersistManagerTest.java @@ -29,7 +29,7 @@ @ExtendWith(MockitoExtension.class) -public class KeyValueEventPersistManagerTest { +class KeyValueEventPersistManagerTest { @InjectMocks private KeyValueEventPersistManager subject; @@ -43,7 +43,7 @@ public class KeyValueEventPersistManagerTest { @Test - public void shouldFirePreEntity() { + void shouldFirePreEntity() { Actor actor = new Actor(); actor.name = "Luke"; subject.firePreEntity(actor); @@ -54,7 +54,7 @@ public void shouldFirePreEntity() { } @Test - public void shouldFirePostEntity() { + void shouldFirePostEntity() { Actor actor = new Actor(); actor.name = "Luke"; subject.firePostEntity(actor); From f54e50fedd48e8d28b59e4ed097dd807662bc31b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:12 -0300 Subject: [PATCH 133/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/keyvalue/spi/KeyValueExtensionTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/spi/KeyValueExtensionTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/spi/KeyValueExtensionTest.java index f016fa056..468bd8d99 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/spi/KeyValueExtensionTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/spi/KeyValueExtensionTest.java @@ -37,7 +37,7 @@ @AddPackages(MockProducer.class) @AddExtensions({EntityMetadataExtension.class, KeyValueExtension.class}) @AddPackages(Reflections.class) -public class KeyValueExtensionTest { +class KeyValueExtensionTest { @Inject private KeyValueTemplate template; @@ -58,7 +58,7 @@ public class KeyValueExtensionTest { private UserRepository userRepositoryMock; @Test - public void shouldUseMock() { + void shouldUseMock() { Person person = template.get(10L, Person.class).get(); Person personMock = templateMock.get(10L, Person.class).get(); @@ -70,7 +70,7 @@ public void shouldUseMock() { @Test - public void shouldUseRepository() { + void shouldUseRepository() { User user = userRepository.findById("user").get(); User userDefault = userRepositoryDefault.findById("user").get(); User userMock = userRepositoryMock.findById("user").get(); From 10c8cbe80b0b2be4d230a03295e921db906d471f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:13 -0300 Subject: [PATCH 134/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../keyvalue/query/KeyValueRepositoryProducerTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/query/KeyValueRepositoryProducerTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/query/KeyValueRepositoryProducerTest.java index 32201f90c..6b50237da 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/query/KeyValueRepositoryProducerTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/query/KeyValueRepositoryProducerTest.java @@ -43,14 +43,14 @@ class KeyValueRepositoryProducerTest { private KeyValueRepositoryProducer producer; @Test - public void shouldCreateFromManager() { + void shouldCreateFromManager() { BucketManager manager = Mockito.mock(BucketManager.class); PersonRepository personRepository = producer.get(PersonRepository.class, manager); assertNotNull(personRepository); } @Test - public void shouldCreateFromTemplate() { + void shouldCreateFromTemplate() { KeyValueTemplate template = Mockito.mock(KeyValueTemplate.class); PersonRepository personRepository = producer.get(PersonRepository.class, template); assertNotNull(personRepository); From 8c6818d20a173aad75b6563d58791b95f0225b50 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:14 -0300 Subject: [PATCH 135/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../query/KeyValueRepositoryProxyTest.java | 42 +++++++++---------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/query/KeyValueRepositoryProxyTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/query/KeyValueRepositoryProxyTest.java index f0e4fed3f..cbd92361c 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/query/KeyValueRepositoryProxyTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/query/KeyValueRepositoryProxyTest.java @@ -60,7 +60,7 @@ @AddPackages(PersonStatisticRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, KeyValueExtension.class}) -public class KeyValueRepositoryProxyTest { +class KeyValueRepositoryProxyTest { private KeyValueTemplate template; @@ -70,7 +70,7 @@ public class KeyValueRepositoryProxyTest { @Inject private EntitiesMetadata entitiesMetadata; @BeforeEach - public void setUp() { + void setUp() { this.template = Mockito.mock(KeyValueTemplate.class); KeyValueRepositoryProxy handler = new KeyValueRepositoryProxy(UserRepository.class, entitiesMetadata, template); userRepository = (UserRepository) Proxy.newProxyInstance(UserRepository.class.getClassLoader(), @@ -79,7 +79,7 @@ public void setUp() { } @Test - public void shouldSave() { + void shouldSave() { ArgumentCaptor captor = ArgumentCaptor.forClass(User.class); User user = new User("ada", "Ada", 10); @@ -91,7 +91,7 @@ public void shouldSave() { @Test - public void shouldSaveIterable() { + void shouldSaveIterable() { ArgumentCaptor captor = ArgumentCaptor.forClass(Iterable.class); User user = new User("ada", "Ada", 10); @@ -103,7 +103,7 @@ public void shouldSaveIterable() { @Test - public void shouldDelete() { + void shouldDelete() { userRepository.deleteById("key"); ArgumentCaptor captor = ArgumentCaptor.forClass(String.class); Mockito.verify(template).delete(captor.capture()); @@ -111,7 +111,7 @@ public void shouldDelete() { } @Test - public void shouldDeleteIterable() { + void shouldDeleteIterable() { userRepository.deleteAllById(Collections.singletonList("key")); ArgumentCaptor captor = ArgumentCaptor.forClass(Iterable.class); Mockito.verify(template).delete(captor.capture()); @@ -119,7 +119,7 @@ public void shouldDeleteIterable() { } @Test - public void shouldDeleteEntity() { + void shouldDeleteEntity() { User user = new User("ada", "Ada", 10); userRepository.delete(user); ArgumentCaptor captor = ArgumentCaptor.forClass(String.class); @@ -128,7 +128,7 @@ public void shouldDeleteEntity() { } @Test - public void shouldDeleteEntities() { + void shouldDeleteEntities() { User user = new User("ada", "Ada", 10); userRepository.deleteAll(Collections.singletonList(user)); ArgumentCaptor captor = ArgumentCaptor.forClass(Iterable.class); @@ -138,7 +138,7 @@ public void shouldDeleteEntities() { @Test - public void shouldFindById() { + void shouldFindById() { User user = new User("ada", "Ada", 10); when(template.get("key", User.class)).thenReturn( Optional.of(user)); @@ -147,7 +147,7 @@ public void shouldFindById() { } @Test - public void shouldExistsById() { + void shouldExistsById() { User user = new User("ada", "Ada", 10); when(template.get("key", User.class)).thenReturn( Optional.of(user)); @@ -157,7 +157,7 @@ public void shouldExistsById() { } @Test - public void shouldFindByIdIterable() { + void shouldFindByIdIterable() { User user = new User("ada", "Ada", 10); User user2 = new User("ada", "Ada", 10); List keys = Arrays.asList("key", "key2"); @@ -168,7 +168,7 @@ public void shouldFindByIdIterable() { } @Test - public void shouldFindByQuery() { + void shouldFindByQuery() { User user = new User("12", "Ada", 10); when(template.query("get \"12\"", User.class)).thenReturn(Stream.of(user)); @@ -178,7 +178,7 @@ public void shouldFindByQuery() { } @Test - public void shouldFindByQueryWithParameter() { + void shouldFindByQueryWithParameter() { User user = new User("12", "Ada", 10); List keys = Arrays.asList("key", "key2"); PreparedStatement prepare = Mockito.mock(PreparedStatement.class); @@ -190,7 +190,7 @@ public void shouldFindByQueryWithParameter() { } @Test - public void shouldExecuteDefaultMethod() { + void shouldExecuteDefaultMethod() { User user = new User("12", "Otavio", 30); PreparedStatement prepare = Mockito.mock(PreparedStatement.class); Mockito.when(template.prepare("get @id", User.class)) @@ -202,7 +202,7 @@ public void shouldExecuteDefaultMethod() { } @Test - public void shouldUseQueriesFromOtherInterface() { + void shouldUseQueriesFromOtherInterface() { User user = new User("12", "Ada", 30); PreparedStatement prepare = Mockito.mock(PreparedStatement.class); Mockito.when(template.prepare("get @key", User.class)) @@ -214,7 +214,7 @@ public void shouldUseQueriesFromOtherInterface() { } @Test - public void shouldUseDefaultMethodFromOtherInterface() { + void shouldUseDefaultMethodFromOtherInterface() { User user = new User("12", "Poliana", 30); PreparedStatement prepare = Mockito.mock(PreparedStatement.class); Mockito.when(template.prepare("get @key", User.class)) @@ -226,22 +226,22 @@ public void shouldUseDefaultMethodFromOtherInterface() { } @Test - public void shouldReturnErrorWhenExecuteMethodQuery() { + void shouldReturnErrorWhenExecuteMethodQuery() { Assertions.assertThrows(DynamicQueryException.class, () -> userRepository.findByName("name")); } @Test - public void shouldReturnToString() { + void shouldReturnToString() { assertNotNull(userRepository.toString()); } @Test - public void shouldReturnHasCode() { + void shouldReturnHasCode() { assertEquals(userRepository.hashCode(), userRepository.hashCode()); } @Test - public void shouldReturnUnsupportedOperationException() { + void shouldReturnUnsupportedOperationException() { Assertions.assertThrows(UnsupportedOperationException.class, () -> userRepository.findAll()); Assertions.assertThrows(UnsupportedOperationException.class, () -> userRepository.count()); Assertions.assertThrows(UnsupportedOperationException.class, () -> userRepository.findAll(null)); @@ -250,7 +250,7 @@ public void shouldReturnUnsupportedOperationException() { @Test - public void shouldExecuteCustomRepository(){ + void shouldExecuteCustomRepository(){ PersonStatisticRepository.PersonStatistic statistics = userRepository .statistics("Salvador"); assertThat(statistics).isNotNull(); From 6a9e1f942b2be1f80ccafb4a2fde8a782618b1b0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:14 -0300 Subject: [PATCH 136/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/keyvalue/KeyValueTemplateProducerTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueTemplateProducerTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueTemplateProducerTest.java index 8f2d9506d..c84281fd4 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueTemplateProducerTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueTemplateProducerTest.java @@ -35,7 +35,7 @@ @AddPackages(MockProducer.class) @AddExtensions({EntityMetadataExtension.class, KeyValueExtension.class}) @AddPackages(Reflections.class) -public class KeyValueTemplateProducerTest { +class KeyValueTemplateProducerTest { @Inject @@ -43,12 +43,12 @@ public class KeyValueTemplateProducerTest { @Test - public void shouldReturnErrorWhenManagerNull() { + void shouldReturnErrorWhenManagerNull() { assertThrows(NullPointerException.class, () -> producer.apply(null)); } @Test - public void shouldReturn() { + void shouldReturn() { BucketManager manager = Mockito.mock(BucketManager.class); KeyValueTemplate repository = producer.apply(manager); assertNotNull(repository); From 1a62d1825c1cabf010dc28e6e96b62cb58bc499c Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:15 -0300 Subject: [PATCH 137/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/keyvalue/KeyValueTemplateTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueTemplateTest.java b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueTemplateTest.java index be405ab37..c13bb5436 100644 --- a/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueTemplateTest.java +++ b/jnosql-mapping/jnosql-mapping-key-value/src/test/java/org/eclipse/jnosql/mapping/keyvalue/KeyValueTemplateTest.java @@ -44,12 +44,12 @@ class KeyValueTemplateTest { private Template qualifier; @Test - public void shouldInjectTemplate() { + void shouldInjectTemplate() { Assertions.assertNotNull(template); } @Test - public void shouldInjectQualifier() { + void shouldInjectQualifier() { Assertions.assertNotNull(qualifier); } From c66fccef14ca0ca438bed0e1d4b7e7f03fa4a7b2 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:16 -0300 Subject: [PATCH 138/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../repository/returns/ListRepositoryReturnTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/ListRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/ListRepositoryReturnTest.java index f07cc4147..53230959b 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/ListRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/ListRepositoryReturnTest.java @@ -43,7 +43,7 @@ class ListRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, List.class)); Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Iterable.class)); Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Collection.class)); @@ -52,7 +52,7 @@ public void shouldReturnIsCompatible() { } @Test - public void shouldReturnList() { + void shouldReturnList() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withSingleResult(Optional::empty) @@ -67,7 +67,7 @@ public void shouldReturnList() { } @Test - public void shouldReturnListPage() { + void shouldReturnListPage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Person.class) From 582089cf97dc701eab3410d9f5467df0d3cbf602 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:17 -0300 Subject: [PATCH 139/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/collection/ListSupplierTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/ListSupplierTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/ListSupplierTest.java index 9f92ad1c7..f5e0c52a8 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/ListSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/ListSupplierTest.java @@ -29,12 +29,12 @@ class ListSupplierTest { private CollectionSupplier supplier; @BeforeEach - public void setUp() { + void setUp() { this.supplier = new ListSupplier(); } @Test - public void shouldTest() { + void shouldTest() { Assertions.assertTrue(supplier.test(List.class)); Assertions.assertTrue(supplier.test(Iterable.class)); Assertions.assertTrue(supplier.test(Collection.class)); @@ -42,7 +42,7 @@ public void shouldTest() { } @Test - public void shouldGet() { + void shouldGet() { final Collection collection = this.supplier.get(); Assertions.assertNotNull(collection); Assertions.assertTrue(collection instanceof ArrayList); From d51fba2822c19ced006964ca3d60677af688e373 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:17 -0300 Subject: [PATCH 140/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/column/MapperDeleteTest.java | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/MapperDeleteTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/MapperDeleteTest.java index 23852e8d2..14f4e1b91 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/MapperDeleteTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/MapperDeleteTest.java @@ -46,7 +46,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, ColumnExtension.class}) -public class MapperDeleteTest { +class MapperDeleteTest { @Inject private ColumnEntityConverter converter; @@ -65,7 +65,7 @@ public class MapperDeleteTest { private ArgumentCaptor captor; @BeforeEach - public void setUp() { + void setUp() { managerMock = Mockito.mock(ColumnManager.class); ColumnEventPersistManager persistManager = Mockito.mock(ColumnEventPersistManager.class); Instance instance = Mockito.mock(Instance.class); @@ -76,7 +76,7 @@ public void setUp() { } @Test - public void shouldReturnDeleteFrom() { + void shouldReturnDeleteFrom() { template.delete(Person.class).execute(); Mockito.verify(managerMock).delete(captor.capture()); ColumnDeleteQuery query = captor.getValue(); @@ -86,7 +86,7 @@ public void shouldReturnDeleteFrom() { @Test - public void shouldDeleteWhereEq() { + void shouldDeleteWhereEq() { template.delete(Person.class).where("name").eq("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); ColumnDeleteQuery query = captor.getValue(); @@ -97,7 +97,7 @@ public void shouldDeleteWhereEq() { } @Test - public void shouldDeleteWhereLike() { + void shouldDeleteWhereLike() { template.delete(Person.class).where("name").like("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); ColumnDeleteQuery query = captor.getValue(); @@ -107,7 +107,7 @@ public void shouldDeleteWhereLike() { } @Test - public void shouldDeleteWhereGt() { + void shouldDeleteWhereGt() { template.delete(Person.class).where("id").gt(10).execute(); Mockito.verify(managerMock).delete(captor.capture()); ColumnDeleteQuery query = captor.getValue(); @@ -116,7 +116,7 @@ public void shouldDeleteWhereGt() { } @Test - public void shouldDeleteWhereGte() { + void shouldDeleteWhereGte() { template.delete(Person.class).where("id").gte(10).execute(); Mockito.verify(managerMock).delete(captor.capture()); ColumnDeleteQuery query = captor.getValue(); @@ -126,7 +126,7 @@ public void shouldDeleteWhereGte() { } @Test - public void shouldDeleteWhereLt() { + void shouldDeleteWhereLt() { template.delete(Person.class).where("id").lt(10).execute(); Mockito.verify(managerMock).delete(captor.capture()); ColumnDeleteQuery query = captor.getValue(); @@ -135,7 +135,7 @@ public void shouldDeleteWhereLt() { } @Test - public void shouldDeleteWhereLte() { + void shouldDeleteWhereLte() { template.delete(Person.class).where("id").lte(10).execute(); Mockito.verify(managerMock).delete(captor.capture()); ColumnDeleteQuery query = captor.getValue(); @@ -144,7 +144,7 @@ public void shouldDeleteWhereLte() { } @Test - public void shouldDeleteWhereBetween() { + void shouldDeleteWhereBetween() { template.delete(Person.class).where("id") .between(10, 20).execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -155,7 +155,7 @@ public void shouldDeleteWhereBetween() { } @Test - public void shouldDeleteWhereNot() { + void shouldDeleteWhereNot() { template.delete(Person.class).where("name").not().like("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); ColumnDeleteQuery query = captor.getValue(); @@ -165,7 +165,7 @@ public void shouldDeleteWhereNot() { @Test - public void shouldDeleteWhereAnd() { + void shouldDeleteWhereAnd() { template.delete(Person.class).where("age").between(10, 20) .and("name").eq("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -178,7 +178,7 @@ public void shouldDeleteWhereAnd() { } @Test - public void shouldDeleteWhereOr() { + void shouldDeleteWhereOr() { template.delete(Person.class).where("id").between(10, 20) .or("name").eq("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -191,7 +191,7 @@ public void shouldDeleteWhereOr() { } @Test - public void shouldConvertField() { + void shouldConvertField() { template.delete(Person.class).where("id").eq("20") .execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -203,7 +203,7 @@ public void shouldConvertField() { } @Test - public void shouldUseAttributeConverter() { + void shouldUseAttributeConverter() { template.delete(Worker.class).where("salary") .eq(new Money("USD", BigDecimal.TEN)).execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -214,7 +214,7 @@ public void shouldUseAttributeConverter() { } @Test - public void shouldQueryByEmbeddable() { + void shouldQueryByEmbeddable() { template.delete(Worker.class).where("job.city").eq("Salvador") .execute(); @@ -227,7 +227,7 @@ public void shouldQueryByEmbeddable() { } @Test - public void shouldQueryBySubEntity() { + void shouldQueryBySubEntity() { template.delete(Address.class).where("zipCode.zip").eq("01312321") .execute(); From 643d98800b46ab02cfdf8200e14b9e2b2b8bd97b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:18 -0300 Subject: [PATCH 141/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/document/MapperDeleteTest.java | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/MapperDeleteTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/MapperDeleteTest.java index 6ab1692e4..b0916cb5f 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/MapperDeleteTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/MapperDeleteTest.java @@ -46,7 +46,7 @@ @AddPackages(MockProducer.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, DocumentExtension.class}) -public class MapperDeleteTest { +class MapperDeleteTest { @Inject private DocumentEntityConverter converter; @@ -65,7 +65,7 @@ public class MapperDeleteTest { private ArgumentCaptor captor; @BeforeEach - public void setUp() { + void setUp() { managerMock = Mockito.mock(DocumentManager.class); DocumentEventPersistManager persistManager = Mockito.mock(DocumentEventPersistManager.class); Instance instance = Mockito.mock(Instance.class); @@ -76,7 +76,7 @@ public void setUp() { } @Test - public void shouldReturnDeleteFrom() { + void shouldReturnDeleteFrom() { template.delete(Person.class).execute(); Mockito.verify(managerMock).delete(captor.capture()); DocumentDeleteQuery query = captor.getValue(); @@ -86,7 +86,7 @@ public void shouldReturnDeleteFrom() { @Test - public void shouldDeleteWhereEq() { + void shouldDeleteWhereEq() { template.delete(Person.class).where("name").eq("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); DocumentDeleteQuery query = captor.getValue(); @@ -95,7 +95,7 @@ public void shouldDeleteWhereEq() { } @Test - public void shouldDeleteWhereLike() { + void shouldDeleteWhereLike() { template.delete(Person.class).where("name").like("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); DocumentDeleteQuery query = captor.getValue(); @@ -104,7 +104,7 @@ public void shouldDeleteWhereLike() { } @Test - public void shouldDeleteWhereGt() { + void shouldDeleteWhereGt() { template.delete(Person.class).where("id").gt(10).execute(); Mockito.verify(managerMock).delete(captor.capture()); DocumentDeleteQuery query = captor.getValue(); @@ -113,7 +113,7 @@ public void shouldDeleteWhereGt() { } @Test - public void shouldDeleteWhereGte() { + void shouldDeleteWhereGte() { template.delete(Person.class).where("id").gte(10).execute(); Mockito.verify(managerMock).delete(captor.capture()); DocumentDeleteQuery query = captor.getValue(); @@ -122,7 +122,7 @@ public void shouldDeleteWhereGte() { } @Test - public void shouldDeleteWhereLt() { + void shouldDeleteWhereLt() { template.delete(Person.class).where("id").lt(10).execute(); Mockito.verify(managerMock).delete(captor.capture()); DocumentDeleteQuery query = captor.getValue(); @@ -131,7 +131,7 @@ public void shouldDeleteWhereLt() { } @Test - public void shouldDeleteWhereLte() { + void shouldDeleteWhereLte() { template.delete(Person.class).where("id").lte(10).execute(); Mockito.verify(managerMock).delete(captor.capture()); DocumentDeleteQuery query = captor.getValue(); @@ -140,7 +140,7 @@ public void shouldDeleteWhereLte() { } @Test - public void shouldDeleteWhereBetween() { + void shouldDeleteWhereBetween() { template.delete(Person.class).where("id") .between(10, 20).execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -151,7 +151,7 @@ public void shouldDeleteWhereBetween() { } @Test - public void shouldDeleteWhereNot() { + void shouldDeleteWhereNot() { template.delete(Person.class).where("name").not().like("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); DocumentDeleteQuery query = captor.getValue(); @@ -161,7 +161,7 @@ public void shouldDeleteWhereNot() { @Test - public void shouldDeleteWhereAnd() { + void shouldDeleteWhereAnd() { template.delete(Person.class).where("age").between(10, 20) .and("name").eq("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -174,7 +174,7 @@ public void shouldDeleteWhereAnd() { } @Test - public void shouldDeleteWhereOr() { + void shouldDeleteWhereOr() { template.delete(Person.class).where("id").between(10, 20) .or("name").eq("Ada").execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -187,7 +187,7 @@ public void shouldDeleteWhereOr() { } @Test - public void shouldConvertField() { + void shouldConvertField() { template.delete(Person.class).where("id").eq("20") .execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -199,7 +199,7 @@ public void shouldConvertField() { } @Test - public void shouldUseAttributeConverter() { + void shouldUseAttributeConverter() { template.delete(Worker.class).where("salary") .eq(new Money("USD", BigDecimal.TEN)).execute(); Mockito.verify(managerMock).delete(captor.capture()); @@ -210,7 +210,7 @@ public void shouldUseAttributeConverter() { } @Test - public void shouldQueryByEmbeddable() { + void shouldQueryByEmbeddable() { template.delete(Worker.class).where("job.city").eq("Salvador") .execute(); @@ -223,7 +223,7 @@ public void shouldQueryByEmbeddable() { } @Test - public void shouldQueryBySubEntity() { + void shouldQueryBySubEntity() { template.delete(Address.class).where("zipCode.zip").eq("01312321") .execute(); From fcfcbba010d7b61e29b1b7a732d1104403aadd1f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:20 -0300 Subject: [PATCH 142/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/MapperDeleteTest.java | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/MapperDeleteTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/MapperDeleteTest.java index b75404eed..d13b43d3f 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/MapperDeleteTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/MapperDeleteTest.java @@ -44,7 +44,7 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class MapperDeleteTest { +class MapperDeleteTest { @Inject private GraphTemplate template; @@ -57,13 +57,13 @@ public class MapperDeleteTest { private Person poliana; @AfterEach - public void after() { + void after() { graph.traversal().V().toList().forEach(Vertex::remove); graph.traversal().E().toList().forEach(Edge::remove); } @BeforeEach - public void before() { + void before() { otavio = template.insert(Person.builder().withName("Otavio") .withAge(35).build()); ada = template.insert(Person.builder().withName("Ada") @@ -73,14 +73,14 @@ public void before() { } @Test - public void shouldReturnDeleteFrom() { + void shouldReturnDeleteFrom() { template.delete(Person.class).execute(); List people = template.select(Person.class).result(); assertThat(people).isEmpty(); } @Test - public void shouldDeleteWhereNameEq() { + void shouldDeleteWhereNameEq() { template.delete(Person.class).where("name").eq(otavio.getName()).execute(); List people = template.select(Person.class).result(); assertThat(people).hasSize(2).map(Person::getName) @@ -88,7 +88,7 @@ public void shouldDeleteWhereNameEq() { } @Test - public void shouldThrownAnExceptionWhenDeleteWhereNameLike() { + void shouldThrownAnExceptionWhenDeleteWhereNameLike() { assertThrows(UnsupportedOperationException.class, () -> template.delete(Person.class).where("name").like("test")); List people = template.select(Person.class).result(); @@ -97,7 +97,7 @@ public void shouldThrownAnExceptionWhenDeleteWhereNameLike() { } @Test - public void shouldDeleteWhereGt() { + void shouldDeleteWhereGt() { template.delete(Person.class).where("age").gt(30).execute(); List people = template.select(Person.class).result(); @@ -106,7 +106,7 @@ public void shouldDeleteWhereGt() { } @Test - public void shouldDeleteWhereGte() { + void shouldDeleteWhereGte() { template.delete(Person.class).where("age").gte(30).execute(); List people = template.select(Person.class).result(); @@ -116,7 +116,7 @@ public void shouldDeleteWhereGte() { } @Test - public void shouldDeleteWhereLt() { + void shouldDeleteWhereLt() { template.delete(Person.class).where("age").lt(30).execute(); List people = template.select(Person.class).result(); @@ -125,7 +125,7 @@ public void shouldDeleteWhereLt() { } @Test - public void shouldDeleteWhereLte() { + void shouldDeleteWhereLte() { template.delete(Person.class).where("age").lte(30).execute(); @@ -135,7 +135,7 @@ public void shouldDeleteWhereLte() { } @Test - public void shouldDeleteWhereBetween() { + void shouldDeleteWhereBetween() { template.delete(Person.class).where("age").between(29, 40).execute(); List people = template.select(Person.class).result(); assertThat(people).hasSize(1).map(Person::getName) @@ -143,7 +143,7 @@ public void shouldDeleteWhereBetween() { } @Test - public void shouldDeleteWhereNot() { + void shouldDeleteWhereNot() { template.delete(Person.class).where("name").not().eq(otavio.getName()).execute(); List people = template.select(Person.class).result(); assertThat(people).hasSize(1).map(Person::getName) @@ -152,7 +152,7 @@ public void shouldDeleteWhereNot() { @Test - public void shouldDeleteWhereAnd() { + void shouldDeleteWhereAnd() { template.delete(Person.class).where("name").eq(otavio.getName()) .and("age").gte(20).execute(); List people = template.select(Person.class).result(); @@ -161,7 +161,7 @@ public void shouldDeleteWhereAnd() { } @Test - public void shouldDeleteWhereOr() { + void shouldDeleteWhereOr() { template.delete(Person.class).where("name").eq(otavio.getName()) .or("age").gte(20).execute(); List people = template.select(Person.class).result(); @@ -170,7 +170,7 @@ public void shouldDeleteWhereOr() { } @Test - public void shouldConvertField() { + void shouldConvertField() { template.delete(Person.class).where("name") .not().eq("Otavio").or("age").lt("30").execute(); @@ -180,7 +180,7 @@ public void shouldConvertField() { } @Test - public void shouldUseAttributeConverter() { + void shouldUseAttributeConverter() { Job job = new Job(); job.setCity("Salvador"); job.setDescription("Java Developer"); From 9fc87509a77b9b9ab599f3f36819d290d63f636f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:21 -0300 Subject: [PATCH 143/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/graph/MapperSelectTest.java | 46 +++++++++---------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/MapperSelectTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/MapperSelectTest.java index be3e694ff..3eaad9ab3 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/MapperSelectTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/MapperSelectTest.java @@ -49,7 +49,7 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class MapperSelectTest { +class MapperSelectTest { @Inject @@ -63,13 +63,13 @@ public class MapperSelectTest { private Person poliana; @AfterEach - public void after() { + void after() { graph.traversal().V().toList().forEach(Vertex::remove); graph.traversal().E().toList().forEach(Edge::remove); } @BeforeEach - public void before() { + void before() { otavio = template.insert(Person.builder().withName("Otavio") .withAge(35).build()); ada = template.insert(Person.builder().withName("Ada") @@ -79,7 +79,7 @@ public void before() { } @Test - public void shouldExecuteSelectFrom() { + void shouldExecuteSelectFrom() { List people = template.select(Person.class).result(); @@ -91,7 +91,7 @@ public void shouldExecuteSelectFrom() { @Test - public void shouldSelectOrderAsc() { + void shouldSelectOrderAsc() { List people = template.select(Person.class).orderBy("name").asc().result(); assertThat(people).hasSize(3).map(Person::getName) @@ -99,7 +99,7 @@ public void shouldSelectOrderAsc() { } @Test - public void shouldSelectOrderDesc() { + void shouldSelectOrderDesc() { List people = template.select(Person.class).orderBy("name").desc().result(); assertThat(people).hasSize(3).map(Person::getName) @@ -107,7 +107,7 @@ public void shouldSelectOrderDesc() { } @Test - public void shouldSelectLimit() { + void shouldSelectLimit() { List people = template.select(Person.class).orderBy("name").desc().limit(2).result(); assertThat(people).hasSize(2).map(Person::getName) @@ -115,7 +115,7 @@ public void shouldSelectLimit() { } @Test - public void shouldSelectStart() { + void shouldSelectStart() { List people = template.select(Person.class).orderBy("name").desc().skip(1).result(); assertThat(people).hasSize(2).map(Person::getName) @@ -123,7 +123,7 @@ public void shouldSelectStart() { } @Test - public void shouldSelectWhereEq() { + void shouldSelectWhereEq() { Optional person = template.select(Person.class) .where("name").eq("Otavio").singleResult(); @@ -133,7 +133,7 @@ public void shouldSelectWhereEq() { } @Test - public void shouldSelectWhereGt() { + void shouldSelectWhereGt() { List people = template.select(Person.class).where("age") .gt(30).result(); assertThat(people).hasSize(1).map(Person::getName) @@ -141,7 +141,7 @@ public void shouldSelectWhereGt() { } @Test - public void shouldSelectWhereGte() { + void shouldSelectWhereGte() { List people = template.select(Person.class).where("age") .gte(30).result(); assertThat(people).hasSize(2).map(Person::getName) @@ -149,7 +149,7 @@ public void shouldSelectWhereGte() { } @Test - public void shouldSelectWhereLt() { + void shouldSelectWhereLt() { List people = template.select(Person.class).where("age") .lt(30).result(); assertThat(people).hasSize(1).map(Person::getName) @@ -157,7 +157,7 @@ public void shouldSelectWhereLt() { } @Test - public void shouldSelectWhereLte() { + void shouldSelectWhereLte() { List people = template.select(Person.class).where("age") .lte(30).result(); assertThat(people).hasSize(2).map(Person::getName) @@ -165,7 +165,7 @@ public void shouldSelectWhereLte() { } @Test - public void shouldSelectWhereBetween() { + void shouldSelectWhereBetween() { List people = template.select(Person.class).where("age") .between(30, 40).result(); assertThat(people).hasSize(2).map(Person::getName) @@ -173,7 +173,7 @@ public void shouldSelectWhereBetween() { } @Test - public void shouldSelectWhereNot() { + void shouldSelectWhereNot() { List people = template.select(Person.class).where("name") .not().eq("Otavio").result(); assertThat(people).hasSize(2).map(Person::getName) @@ -181,7 +181,7 @@ public void shouldSelectWhereNot() { } @Test - public void shouldSelectWhereAnd() { + void shouldSelectWhereAnd() { List people = template.select(Person.class).where("name") .not().eq("Otavio").and("age").lt(30).result(); assertThat(people).hasSize(1).map(Person::getName) @@ -189,7 +189,7 @@ public void shouldSelectWhereAnd() { } @Test - public void shouldSelectWhereOr() { + void shouldSelectWhereOr() { List people = template.select(Person.class).where("name") .not().eq("Otavio").or("age").lt(30).result(); assertThat(people).hasSize(2).map(Person::getName) @@ -197,7 +197,7 @@ public void shouldSelectWhereOr() { } @Test - public void shouldConvertField() { + void shouldConvertField() { List people = template.select(Person.class).where("name") .not().eq("Otavio").or("age").lt("30").result(); assertThat(people).hasSize(2).map(Person::getName) @@ -205,7 +205,7 @@ public void shouldConvertField() { } @Test - public void shouldUseAttributeConverter() { + void shouldUseAttributeConverter() { Job job = new Job(); job.setCity("Salvador"); job.setDescription("Java Developer"); @@ -224,7 +224,7 @@ public void shouldUseAttributeConverter() { } @Test - public void shouldFindByIdUsingQuery() { + void shouldFindByIdUsingQuery() { Optional person = template.select(Person.class).where("id").eq(poliana.getId()).singleResult(); Assertions.assertNotNull(person); @@ -233,7 +233,7 @@ public void shouldFindByIdUsingQuery() { } @Test - public void shouldResult() { + void shouldResult() { List people = template.select(Person.class).result(); Assertions.assertNotNull(people); assertThat(people).hasSize(3).map(Person::getName) @@ -241,7 +241,7 @@ public void shouldResult() { } @Test - public void shouldStream() { + void shouldStream() { Stream people = template.select(Person.class).stream(); Assertions.assertNotNull(people); @@ -251,7 +251,7 @@ public void shouldStream() { } @Test - public void shouldSingleResult() { + void shouldSingleResult() { Assertions.assertThrows(NonUniqueResultException.class, () -> template.select(Person.class).singleResult()); Optional person = template.select(Person.class).where("name").eq("Jono").singleResult(); From 6e234b617d42bcd708403a160456b4636996f8cc Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:21 -0300 Subject: [PATCH 144/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../config/MappingConfigurationsTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/config/MappingConfigurationsTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/config/MappingConfigurationsTest.java index 4735b0485..96eefcb74 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/config/MappingConfigurationsTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/config/MappingConfigurationsTest.java @@ -20,52 +20,52 @@ import static org.junit.jupiter.api.Assertions.assertEquals; -public class MappingConfigurationsTest { +class MappingConfigurationsTest { @Test - public void shouldReturnValueForKeyValueProvider() { + void shouldReturnValueForKeyValueProvider() { String expectedValue = "jnosql.keyvalue.provider"; assertEquals(expectedValue, MappingConfigurations.KEY_VALUE_PROVIDER.get()); } @Test - public void shouldReturnValueForKeyValueDatabase() { + void shouldReturnValueForKeyValueDatabase() { String expectedValue = "jnosql.keyvalue.database"; assertEquals(expectedValue, MappingConfigurations.KEY_VALUE_DATABASE.get()); } @Test - public void shouldReturnValueForDocumentProvider() { + void shouldReturnValueForDocumentProvider() { String expectedValue = "jnosql.document.provider"; assertEquals(expectedValue, MappingConfigurations.DOCUMENT_PROVIDER.get()); } @Test - public void shouldReturnValueForDocumentDatabase() { + void shouldReturnValueForDocumentDatabase() { String expectedValue = "jnosql.document.database"; assertEquals(expectedValue, MappingConfigurations.DOCUMENT_DATABASE.get()); } @Test - public void shouldReturnValueForColumnProvider() { + void shouldReturnValueForColumnProvider() { String expectedValue = "jnosql.column.provider"; assertEquals(expectedValue, MappingConfigurations.COLUMN_PROVIDER.get()); } @Test - public void shouldReturnValueForColumnDatabase() { + void shouldReturnValueForColumnDatabase() { String expectedValue = "jnosql.column.database"; assertEquals(expectedValue, MappingConfigurations.COLUMN_DATABASE.get()); } @Test - public void shouldReturnValueForGraphProvider() { + void shouldReturnValueForGraphProvider() { String expectedValue = "jnosql.graph.provider"; assertEquals(expectedValue, MappingConfigurations.GRAPH_PROVIDER.get()); } @Test - public void shouldReturnValueForGraphTransactionAutomatic() { + void shouldReturnValueForGraphTransactionAutomatic() { String expectedValue = "jnosql.graph.transaction.automatic"; assertEquals(expectedValue, MappingConfigurations.GRAPH_TRANSACTION_AUTOMATIC.get()); } From 0a3c71402edee9b204d5a8b08c1a081aa986bd56 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:22 -0300 Subject: [PATCH 145/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/metadata/MappingTypeTest.java | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/MappingTypeTest.java b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/MappingTypeTest.java index 829bcaad2..78fe4e8b7 100644 --- a/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/MappingTypeTest.java +++ b/jnosql-mapping/jnosql-mapping-api-core/src/test/java/org/eclipse/jnosql/mapping/metadata/MappingTypeTest.java @@ -37,44 +37,44 @@ class MappingTypeTest { @Test - public void shouldReturnList() throws NoSuchFieldException { + void shouldReturnList() throws NoSuchFieldException { Field field = Person.class.getDeclaredField("phones"); assertEquals(MappingType.COLLECTION, MappingType.of(field.getType())); } @Test - public void shouldReturnSet() throws NoSuchFieldException { + void shouldReturnSet() throws NoSuchFieldException { Field field = Movie.class.getDeclaredField("actors"); assertEquals(MappingType.COLLECTION, MappingType.of(field.getType())); } @Test - public void shouldReturnMap() throws NoSuchFieldException { + void shouldReturnMap() throws NoSuchFieldException { Field field = Actor.class.getDeclaredField("movieCharacter"); assertEquals(MappingType.MAP, MappingType.of(field.getType())); } @Test - public void shouldReturnDefault() throws NoSuchFieldException { + void shouldReturnDefault() throws NoSuchFieldException { Field field = Person.class.getDeclaredField("name"); assertEquals(MappingType.DEFAULT, MappingType.of(field.getType())); } @Test - public void shouldReturnEmbedded() throws NoSuchFieldException { + void shouldReturnEmbedded() throws NoSuchFieldException { Field field = Worker.class.getDeclaredField("job"); assertEquals(MappingType.EMBEDDED, MappingType.of(field.getType())); } @Test - public void shouldReturnEntity() throws NoSuchFieldException { + void shouldReturnEntity() throws NoSuchFieldException { Field field = Address.class.getDeclaredField("zipCode"); assertEquals(MappingType.ENTITY, MappingType.of(field.getType())); } @Test - public void shouldReturnParameterDefault() throws NoSuchMethodException { + void shouldReturnParameterDefault() throws NoSuchMethodException { Constructor constructor = (Constructor) BookUser.class.getDeclaredConstructors()[0]; Parameter id = constructor.getParameters()[0]; Parameter name = constructor.getParameters()[1]; @@ -83,28 +83,28 @@ public void shouldReturnParameterDefault() throws NoSuchMethodException { } @Test - public void shouldReturnParameterCollection() { + void shouldReturnParameterCollection() { Constructor constructor = (Constructor) BookUser.class.getDeclaredConstructors()[0]; Parameter books = constructor.getParameters()[2]; assertEquals(MappingType.COLLECTION, MappingType.of(books.getType())); } @Test - public void shouldReturnParameterEntity() { + void shouldReturnParameterEntity() { Constructor constructor = (Constructor) PetOwner.class.getDeclaredConstructors()[0]; Parameter animal = constructor.getParameters()[2]; assertEquals(MappingType.ENTITY, MappingType.of(animal.getType())); } @Test - public void shouldReturnParameterMap() { + void shouldReturnParameterMap() { Constructor constructor = (Constructor) ForClass.class.getDeclaredConstructors()[0]; Parameter map = constructor.getParameters()[0]; assertEquals(MappingType.MAP, MappingType.of(map.getType())); } @Test - public void shouldReturnParameterEmbedded() { + void shouldReturnParameterEmbedded() { Constructor constructor = (Constructor) ForClass.class.getDeclaredConstructors()[0]; Parameter map = constructor.getParameters()[1]; assertEquals(MappingType.EMBEDDED, MappingType.of(map.getType())); From 808617fc1b8a102b90244a2b69f35cd81586e0da Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:23 -0300 Subject: [PATCH 146/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../query/method/MethodParamQueryValueTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/MethodParamQueryValueTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/MethodParamQueryValueTest.java index f44caa070..940a4ddd1 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/MethodParamQueryValueTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/MethodParamQueryValueTest.java @@ -20,14 +20,14 @@ class MethodParamQueryValueTest { @Test - public void shouldReturnType() { + void shouldReturnType() { MethodParamQueryValue param = new MethodParamQueryValue("name"); Assertions.assertThat(param).isNotNull() .extracting(MethodParamQueryValue::type) .isNotNull().isEqualTo(ValueType.PARAMETER); } @Test - public void shouldCreateInstance() { + void shouldCreateInstance() { MethodParamQueryValue param = new MethodParamQueryValue("name"); Assertions.assertThat(param).isNotNull() .extracting(MethodParamQueryValue::get) @@ -36,13 +36,13 @@ public void shouldCreateInstance() { } @Test - public void shouldEquals() { + void shouldEquals() { MethodParamQueryValue param = new MethodParamQueryValue("name"); assertEquals(param, param); } @Test - public void shouldHashCode() { + void shouldHashCode() { MethodParamQueryValue param = new MethodParamQueryValue("name"); assertEquals(param.hashCode(), param.hashCode()); } From c904f9e4ce95c5e48ee19ae1877bf0746ceaf27b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:24 -0300 Subject: [PATCH 147/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../query/method/MethodQueryTest.java | 76 +++++++++---------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/MethodQueryTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/MethodQueryTest.java index 9215016b3..4468accfb 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/MethodQueryTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/MethodQueryTest.java @@ -22,25 +22,25 @@ class MethodQueryTest { @Test - public void shouldReturnNullWhenQueryIsNull() { + void shouldReturnNullWhenQueryIsNull() { Assertions.assertThrows(NullPointerException.class, () -> MethodQuery.of(null)); } @Test - public void shouldEquals() { + void shouldEquals() { MethodQuery query = MethodQuery.of("findByAge"); Assertions.assertEquals(query, MethodQuery.of("findByAge")); } @Test - public void shouldHashCode() { + void shouldHashCode() { MethodQuery query = MethodQuery.of("findByAge"); Assertions.assertEquals(query.hashCode(), MethodQuery.of("findByAge").hashCode()); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAge"}) - public void shouldRunQuery(String query) { + void shouldRunQuery(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Age", methodQuery.get()); @@ -49,7 +49,7 @@ public void shouldRunQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameAndAge"}) - public void shouldRunQuery1(String query) { + void shouldRunQuery1(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Name And Age", methodQuery.get()); @@ -57,7 +57,7 @@ public void shouldRunQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameOrAge"}) - public void shouldRunQuery2(String query) { + void shouldRunQuery2(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Name Or Age", methodQuery.get()); @@ -65,7 +65,7 @@ public void shouldRunQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameOrAgeOrderByName"}) - public void shouldRunQuery3(String query) { + void shouldRunQuery3(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Name Or Age OrderBy Name", methodQuery.get()); @@ -73,7 +73,7 @@ public void shouldRunQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameOrAgeOrderByNameAsc"}) - public void shouldRunQuery4(String query) { + void shouldRunQuery4(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Name Or Age OrderBy Name Asc", methodQuery.get()); @@ -81,7 +81,7 @@ public void shouldRunQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameOrAgeOrderByNameDesc"}) - public void shouldRunQuery5(String query) { + void shouldRunQuery5(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Name Or Age OrderBy Name Desc", methodQuery.get()); @@ -90,7 +90,7 @@ public void shouldRunQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByLastNameAndFirstName"}) - public void shouldRunQuery6(String query) { + void shouldRunQuery6(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy LastName And FirstName", methodQuery.get()); @@ -99,7 +99,7 @@ public void shouldRunQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByLastNameOrFirstName"}) - public void shouldRunQuery7(String query) { + void shouldRunQuery7(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy LastName Or FirstName", methodQuery.get()); @@ -107,7 +107,7 @@ public void shouldRunQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByStartDateBetween"}) - public void shouldRunQuery8(String query) { + void shouldRunQuery8(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy StartDate Between", methodQuery.get()); @@ -115,7 +115,7 @@ public void shouldRunQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThan"}) - public void shouldRunQuery9(String query) { + void shouldRunQuery9(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Age LessThan", methodQuery.get()); @@ -123,7 +123,7 @@ public void shouldRunQuery9(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThanEqual"}) - public void shouldRunQuery10(String query) { + void shouldRunQuery10(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Age LessThanEqual", methodQuery.get()); @@ -131,7 +131,7 @@ public void shouldRunQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeGreaterThan"}) - public void shouldRunQuery11(String query) { + void shouldRunQuery11(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Age GreaterThan", methodQuery.get()); @@ -139,7 +139,7 @@ public void shouldRunQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeGreaterThanEqual"}) - public void shouldRunQuery12(String query) { + void shouldRunQuery12(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Age GreaterThanEqual", methodQuery.get()); @@ -147,7 +147,7 @@ public void shouldRunQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByFirstNameLike"}) - public void shouldRunQuery13(String query) { + void shouldRunQuery13(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy FirstName Like", methodQuery.get()); @@ -155,7 +155,7 @@ public void shouldRunQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByFirstNameNotLike"}) - public void shouldRunQuery14(String query) { + void shouldRunQuery14(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy FirstName Not Like", methodQuery.get()); @@ -163,7 +163,7 @@ public void shouldRunQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByFirstNameLikeOrderByNameAscAgeDesc"}) - public void shouldRunQuery15(String query) { + void shouldRunQuery15(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy FirstName Like OrderBy Name Asc Age Desc", methodQuery.get()); @@ -171,7 +171,7 @@ public void shouldRunQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByFirstNameLikeOrderByNameAscAge"}) - public void shouldRunQuery16(String query) { + void shouldRunQuery16(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy FirstName Like OrderBy Name Asc Age", methodQuery.get()); @@ -180,7 +180,7 @@ public void shouldRunQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAge"}) - public void shouldRunQuery17(String query) { + void shouldRunQuery17(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Age", methodQuery.get()); @@ -189,7 +189,7 @@ public void shouldRunQuery17(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByNameAndAge"}) - public void shouldRunQuery18(String query) { + void shouldRunQuery18(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Name And Age", methodQuery.get()); @@ -197,7 +197,7 @@ public void shouldRunQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByNameOrAge"}) - public void shouldRunQuery19(String query) { + void shouldRunQuery19(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Name Or Age", methodQuery.get()); @@ -206,7 +206,7 @@ public void shouldRunQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByLastNameAndFirstName"}) - public void shouldRunQuery20(String query) { + void shouldRunQuery20(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy LastName And FirstName", methodQuery.get()); @@ -215,7 +215,7 @@ public void shouldRunQuery20(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByLastNameOrFirstName"}) - public void shouldRunQuery21(String query) { + void shouldRunQuery21(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy LastName Or FirstName", methodQuery.get()); @@ -223,7 +223,7 @@ public void shouldRunQuery21(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByStartDateBetween"}) - public void shouldRunQuery22(String query) { + void shouldRunQuery22(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy StartDate Between", methodQuery.get()); @@ -231,7 +231,7 @@ public void shouldRunQuery22(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeLessThan"}) - public void shouldRunQuery23(String query) { + void shouldRunQuery23(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Age LessThan", methodQuery.get()); @@ -239,7 +239,7 @@ public void shouldRunQuery23(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThanEqual"}) - public void shouldRunQuery24(String query) { + void shouldRunQuery24(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Age LessThanEqual", methodQuery.get()); @@ -247,7 +247,7 @@ public void shouldRunQuery24(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeGreaterThan"}) - public void shouldRunQuery25(String query) { + void shouldRunQuery25(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Age GreaterThan", methodQuery.get()); @@ -255,7 +255,7 @@ public void shouldRunQuery25(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByAgeGreaterThanEqual"}) - public void shouldRunQuery26(String query) { + void shouldRunQuery26(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Age GreaterThanEqual", methodQuery.get()); @@ -263,7 +263,7 @@ public void shouldRunQuery26(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByFirstNameLike"}) - public void shouldRunQuery27(String query) { + void shouldRunQuery27(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy FirstName Like", methodQuery.get()); @@ -271,7 +271,7 @@ public void shouldRunQuery27(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteByFirstNameNotLike"}) - public void shouldRunQuery28(String query) { + void shouldRunQuery28(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy FirstName Not Like", methodQuery.get()); @@ -279,7 +279,7 @@ public void shouldRunQuery28(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteBySalary_Currency"}) - public void shouldRunQuery29(String query) { + void shouldRunQuery29(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Salary_Currency", methodQuery.get()); @@ -287,7 +287,7 @@ public void shouldRunQuery29(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteBySalary_CurrencyAndCredential_Role"}) - public void shouldRunQuery30(String query) { + void shouldRunQuery30(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Salary_Currency And Credential_Role", methodQuery.get()); @@ -295,7 +295,7 @@ public void shouldRunQuery30(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"deleteBySalary_CurrencyAndName"}) - public void shouldRunQuery31(String query) { + void shouldRunQuery31(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("deleteBy Salary_Currency And Name", methodQuery.get()); @@ -303,7 +303,7 @@ public void shouldRunQuery31(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findBySalary_Currency"}) - public void shouldRunQuery32(String query) { + void shouldRunQuery32(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Salary_Currency", methodQuery.get()); @@ -311,7 +311,7 @@ public void shouldRunQuery32(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findBySalary_CurrencyAndCredential_Role"}) - public void shouldRunQuery33(String query) { + void shouldRunQuery33(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Salary_Currency And Credential_Role", methodQuery.get()); @@ -319,7 +319,7 @@ public void shouldRunQuery33(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findBySalary_CurrencyAndName"}) - public void shouldRunQuery34(String query) { + void shouldRunQuery34(String query) { MethodQuery methodQuery = MethodQuery.of(query); assertNotNull(methodQuery); assertEquals("findBy Salary_Currency And Name", methodQuery.get()); From 83309b0c29d8b3b1b6bb28f31710acb1dc2f9888 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:24 -0300 Subject: [PATCH 148/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../config/MicroProfileSettingsTest.java | 50 +++++++++---------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/config/MicroProfileSettingsTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/config/MicroProfileSettingsTest.java index d9f6a3ccf..f607465cf 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/config/MicroProfileSettingsTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/config/MicroProfileSettingsTest.java @@ -69,25 +69,25 @@ public static void beforeAll() { @Test - public void shouldReturnNPEWhenInstanceIsNull() { + void shouldReturnNPEWhenInstanceIsNull() { assertThrows(NullPointerException.class, () -> Settings.of((Map) null)); } @Test - public void shouldReturnNewInstance() { + void shouldReturnNewInstance() { Settings settings = MicroProfileSettings.INSTANCE; Assertions.assertNotNull(settings); } @Test - public void shouldCreateFromMap() { + void shouldCreateFromMap() { Settings settings = MicroProfileSettings.INSTANCE; assertFalse(settings.isEmpty()); } @Test - public void shouldContainsKeys() { + void shouldContainsKeys() { Settings settings = MicroProfileSettings.INSTANCE; assertTrue(settings.containsKey("jnosql.key")); assertFalse(settings.containsKey("key2")); @@ -95,27 +95,27 @@ public void shouldContainsKeys() { @Test - public void shouldGetKeys() { + void shouldGetKeys() { Settings settings = MicroProfileSettings.INSTANCE; assertThat(settings.keySet()).contains("jnosql.key"); } @Test - public void shouldSize() { + void shouldSize() { Settings settings = Settings.of(singletonMap("jnosql.key", "value")); assertTrue(settings.size() >= 1); } @Test - public void shouldIsEmpty() { + void shouldIsEmpty() { Settings settings = MicroProfileSettings.INSTANCE; assertFalse(settings.isEmpty()); } @Test - public void shouldGet() { + void shouldGet() { Settings settings = MicroProfileSettings.INSTANCE; Optional value = settings.get("jnosql.key-number"); Assertions.assertNotNull(value); @@ -123,7 +123,7 @@ public void shouldGet() { } @Test - public void shouldGetSupplier() { + void shouldGetSupplier() { Settings settings = MicroProfileSettings.INSTANCE; Optional value = settings.get(() -> "jnosql.key-number"); Assertions.assertNotNull(value); @@ -131,14 +131,14 @@ public void shouldGetSupplier() { } @Test - public void shouldNPEGet() { + void shouldNPEGet() { Settings settings = MicroProfileSettings.INSTANCE; Assertions.assertThrows(NullPointerException.class, () -> settings.get((String) null)); Assertions.assertThrows(NullPointerException.class, () -> settings.get((Supplier) null)); } @Test - public void shouldGetIterable() { + void shouldGetIterable() { Settings settings = MicroProfileSettings.INSTANCE; Optional value = settings.get(Collections.singleton("jnosql.key-number")); Assertions.assertNotNull(value); @@ -146,7 +146,7 @@ public void shouldGetIterable() { } @Test - public void shouldGetIterableSupplier() { + void shouldGetIterableSupplier() { Settings settings = MicroProfileSettings.INSTANCE; Optional value = settings.getSupplier(Collections.singleton(() -> "jnosql.key-number")); Assertions.assertNotNull(value); @@ -154,14 +154,14 @@ public void shouldGetIterableSupplier() { } @Test - public void shouldNPEGetIterable() { + void shouldNPEGetIterable() { Settings settings = MicroProfileSettings.INSTANCE; Assertions.assertThrows(NullPointerException.class, () -> settings.get((Iterable) null)); Assertions.assertThrows(NullPointerException.class, () -> settings.getSupplier(null)); } @Test - public void shouldGetValueClass() { + void shouldGetValueClass() { Settings settings = MicroProfileSettings.INSTANCE; Integer value = settings.get("jnosql.key-number", Integer.class).get(); @@ -170,7 +170,7 @@ public void shouldGetValueClass() { } @Test - public void shouldGetValueClassSupplier() { + void shouldGetValueClassSupplier() { Settings settings = MicroProfileSettings.INSTANCE; Integer value = settings.get(() -> "jnosql.key-number", Integer.class).get(); @@ -179,21 +179,21 @@ public void shouldGetValueClassSupplier() { } @Test - public void shouldGetOrDefault() { + void shouldGetOrDefault() { Settings settings = MicroProfileSettings.INSTANCE; assertEquals("12", settings.getOrDefault("jnosql.key-number", "13")); assertEquals("13", settings.getOrDefault("key-1", "13")); } @Test - public void shouldGetOrDefaultSupplier() { + void shouldGetOrDefaultSupplier() { Settings settings = MicroProfileSettings.INSTANCE; assertEquals("12", settings.getOrDefault(() -> "jnosql.key-number", "13")); assertEquals("13", settings.getOrDefault(() -> "key-1", "13")); } @Test - public void shouldReturnErrorWhenPrefixIsNull() { + void shouldReturnErrorWhenPrefixIsNull() { Settings settings = MicroProfileSettings.INSTANCE; @@ -201,7 +201,7 @@ public void shouldReturnErrorWhenPrefixIsNull() { } @Test - public void shouldFindPrefix() { + void shouldFindPrefix() { Settings settings = MicroProfileSettings.INSTANCE; List hosts = settings.prefix("jnosql.host"); @@ -211,7 +211,7 @@ public void shouldFindPrefix() { } @Test - public void shouldFindPrefixSupplier() { + void shouldFindPrefixSupplier() { Settings settings = MicroProfileSettings.INSTANCE; List hosts = settings.prefix(() -> "jnosql.host"); @@ -221,7 +221,7 @@ public void shouldFindPrefixSupplier() { } @Test - public void shouldFindPrefixWithOrder() { + void shouldFindPrefixWithOrder() { Settings settings = MicroProfileSettings.INSTANCE; List hosts = settings.prefix("jnosql.host"); assertThat(hosts).hasSize(4).contains("host", "host-1", "host-2", "host-3"); @@ -229,14 +229,14 @@ public void shouldFindPrefixWithOrder() { @Test - public void shouldReturnErrorWhenPrefixesIsNull() { + void shouldReturnErrorWhenPrefixesIsNull() { Settings settings = MicroProfileSettings.INSTANCE; assertThrows(NullPointerException.class, () -> settings.prefix((Collection) null)); } @Test - public void shouldFindPrefixes() { + void shouldFindPrefixes() { Settings settings = MicroProfileSettings.INSTANCE; @@ -245,7 +245,7 @@ public void shouldFindPrefixes() { } @Test - public void shouldFindPrefixesSupplier() { + void shouldFindPrefixesSupplier() { Settings settings = MicroProfileSettings.INSTANCE; List hosts = settings.prefixSupplier(Arrays.asList(() -> "jnosql.host", () -> "jnosql.server")); @@ -253,7 +253,7 @@ public void shouldFindPrefixesSupplier() { } @Test - public void shouldFindPrefixesSort() { + void shouldFindPrefixesSort() { Settings settings = MicroProfileSettings.INSTANCE; From f32d454ee2b55feceee82734d3c55cc25af78963 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:25 -0300 Subject: [PATCH 149/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/NoSQLPageTest.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/NoSQLPageTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/NoSQLPageTest.java index bac337b22..568c16c5f 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/NoSQLPageTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/NoSQLPageTest.java @@ -30,7 +30,7 @@ class NoSQLPageTest { @Test - public void shouldReturnErrorWhenNull() { + void shouldReturnErrorWhenNull() { assertThrows(NullPointerException.class, ()-> NoSQLPage.of(Collections.emptyList(), null)); @@ -40,7 +40,7 @@ public void shouldReturnErrorWhenNull() { @Test - public void shouldReturnUnsupportedOperation() { + void shouldReturnUnsupportedOperation() { Page page = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), Pageable.ofPage(2)); @@ -50,7 +50,7 @@ public void shouldReturnUnsupportedOperation() { } @Test - public void shouldReturnHasContent() { + void shouldReturnHasContent() { Page page = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), Pageable.ofPage(2)); @@ -62,7 +62,7 @@ public void shouldReturnHasContent() { } @Test - public void shouldNumberOfElements() { + void shouldNumberOfElements() { Page page = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), Pageable.ofPage(2)); @@ -71,14 +71,14 @@ public void shouldNumberOfElements() { } @Test - public void shouldIterator() { + void shouldIterator() { Page page = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), Pageable.ofPage(2)); Assertions.assertNotNull(page.iterator()); } @Test - public void shouldPageable() { + void shouldPageable() { Page page = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), Pageable.ofPage(2)); Pageable pageable = page.pageable(); @@ -87,7 +87,7 @@ public void shouldPageable() { } @Test - public void shouldNextPageable() { + void shouldNextPageable() { Page page = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), Pageable.ofPage(2)); Pageable pageable = page.nextPageable(); @@ -95,25 +95,25 @@ public void shouldNextPageable() { } @Test - public void shouldThrowNullPointerExceptionWhenPageableIsNull() { + void shouldThrowNullPointerExceptionWhenPageableIsNull() { assertThrows(NullPointerException.class, () -> NoSQLPage.skip(null)); } @Test - public void shouldCalculateSkip() { + void shouldCalculateSkip() { long skipValue = NoSQLPage.skip(Pageable.ofPage(2).size(10)); assertEquals(10, skipValue); } @Test - public void shouldCalculateSkipForFirstPage() { + void shouldCalculateSkipForFirstPage() { // Create a pageable with page=1 and size=5 long skipValue = NoSQLPage.skip(Pageable.ofPage(1).size(5)); assertEquals(0, skipValue); } @Test - public void shouldToString(){ + void shouldToString(){ Page page = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), Pageable.ofPage(2)); @@ -121,7 +121,7 @@ public void shouldToString(){ } @Test - public void shouldEqualsHasCode(){ + void shouldEqualsHasCode(){ Page page = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), Pageable.ofPage(2)); Page page2 = NoSQLPage.of(Collections.singletonList(Person.builder().withName("Otavio").build()), From 069a586c667f7cee78b4c1bd57807b90fe30d252 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:26 -0300 Subject: [PATCH 150/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../returns/OptionalRepositoryReturnTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/OptionalRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/OptionalRepositoryReturnTest.java index 01f351c91..ed1605c52 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/OptionalRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/OptionalRepositoryReturnTest.java @@ -40,14 +40,14 @@ class OptionalRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Optional.class)); Assertions.assertFalse(repositoryReturn.isCompatible(Object.class, Person.class)); Assertions.assertFalse(repositoryReturn.isCompatible(Person.class, Object.class)); } @Test - public void shouldReturnOptional() { + void shouldReturnOptional() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() @@ -63,7 +63,7 @@ public void shouldReturnOptional() { } @Test - public void shouldReturnEmptyOptional() { + void shouldReturnEmptyOptional() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() @@ -79,7 +79,7 @@ public void shouldReturnEmptyOptional() { @Test - public void shouldReturnOptionalPage() { + void shouldReturnOptionalPage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() @@ -99,7 +99,7 @@ public void shouldReturnOptionalPage() { } @Test - public void shouldReturnOptionalEmptyPage() { + void shouldReturnOptionalEmptyPage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() From bf65d8ca25fa7f0dbad9d5ed3b6ffaf666be7581 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:27 -0300 Subject: [PATCH 151/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../repository/returns/PageRepositoryReturnTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/PageRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/PageRepositoryReturnTest.java index 706137dc3..749d875dd 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/PageRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/PageRepositoryReturnTest.java @@ -45,7 +45,7 @@ class PageRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Page.class)); Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Slice.class)); assertFalse(repositoryReturn.isCompatible(Object.class, Person.class)); @@ -53,7 +53,7 @@ public void shouldReturnIsCompatible() { } @Test - public void shouldReturnPage() { + void shouldReturnPage() { Person ada = new Person("Ada"); @@ -78,7 +78,7 @@ public void shouldReturnPage() { } @Test - public void shouldReturnSlice() { + void shouldReturnSlice() { Person ada = new Person("Ada"); @@ -103,7 +103,7 @@ public void shouldReturnSlice() { } @Test - public void shouldReturnErrorWhenUsePage() { + void shouldReturnErrorWhenUsePage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() From 1f183171f8035443c0d6051e2bc061995888913d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:29 -0300 Subject: [PATCH 152/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/ParameterMetaDataBuilderTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ParameterMetaDataBuilderTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ParameterMetaDataBuilderTest.java index d694f4ca1..78141c697 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ParameterMetaDataBuilderTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ParameterMetaDataBuilderTest.java @@ -37,7 +37,7 @@ class ParameterMetaDataBuilderTest { @Test - public void shouldConvertIdParameter() { + void shouldConvertIdParameter() { Constructor constructor = (Constructor) Computer.class.getDeclaredConstructors()[0]; ParameterMetaData id = ParameterMetaDataBuilder.of(constructor.getParameters()[0]); Assertions.assertNotNull(id); @@ -49,7 +49,7 @@ public void shouldConvertIdParameter() { } @Test - public void shouldConvertDefaultParameterWithoutDefinedName() { + void shouldConvertDefaultParameterWithoutDefinedName() { Constructor constructor = (Constructor) Smartphone.class.getDeclaredConstructors()[0]; ParameterMetaData name = ParameterMetaDataBuilder.of(constructor.getParameters()[1]); Assertions.assertNotNull(name); @@ -61,7 +61,7 @@ public void shouldConvertDefaultParameterWithoutDefinedName() { } @Test - public void shouldConvertDefaultParameter() { + void shouldConvertDefaultParameter() { Constructor constructor = (Constructor) Computer.class.getDeclaredConstructors()[0]; ParameterMetaData name = ParameterMetaDataBuilder.of(constructor.getParameters()[1]); Assertions.assertNotNull(name); @@ -73,7 +73,7 @@ public void shouldConvertDefaultParameter() { } @Test - public void shouldConvertConverterParameter() { + void shouldConvertConverterParameter() { Constructor constructor = (Constructor) Computer.class.getDeclaredConstructors()[0]; ParameterMetaData price = ParameterMetaDataBuilder.of(constructor.getParameters()[4]); Assertions.assertNotNull(price); @@ -90,7 +90,7 @@ public void shouldConvertConverterParameter() { //parameter with map @Test - public void shouldConvertEntityParameter() { + void shouldConvertEntityParameter() { Constructor constructor = (Constructor) PetOwner.class.getDeclaredConstructors()[0]; ParameterMetaData animal = ParameterMetaDataBuilder.of(constructor.getParameters()[2]); Assertions.assertNotNull(animal); @@ -102,7 +102,7 @@ public void shouldConvertEntityParameter() { } @Test - public void shouldConvertCollectionParameter() { + void shouldConvertCollectionParameter() { Constructor constructor = (Constructor) BookUser.class.getDeclaredConstructors()[0]; ParameterMetaData books = ParameterMetaDataBuilder.of(constructor.getParameters()[2]); Assertions.assertNotNull(books); @@ -116,7 +116,7 @@ public void shouldConvertCollectionParameter() { } @Test - public void shouldConvertMapParameter() { + void shouldConvertMapParameter() { Constructor constructor = (Constructor) Foo.class.getDeclaredConstructors()[0]; ParameterMetaData map = ParameterMetaDataBuilder.of(constructor.getParameters()[0]); Assertions.assertNotNull(map); From a90196c5cacb4c2e1d97ab795d30c9aaec7670f5 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:30 -0300 Subject: [PATCH 153/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/mapping/column/query/ParamsBinderTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ParamsBinderTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ParamsBinderTest.java index b797c6cb1..06d88c779 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ParamsBinderTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/ParamsBinderTest.java @@ -63,7 +63,7 @@ class ParamsBinderTest { private ParamsBinder paramsBinder; @Test - public void shouldConvert() { + void shouldConvert() { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals("findByAge")).findFirst().get(); @@ -86,7 +86,7 @@ public void shouldConvert() { } @Test - public void shouldConvert2() { + void shouldConvert2() { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals("findByAgeAndName")).findFirst().get(); From 4553d7204412b00acdc6b6bb81dd4b569f1a0677 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:32 -0300 Subject: [PATCH 154/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/util/ParamsBinderTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/ParamsBinderTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/ParamsBinderTest.java index 8a41d40b6..0f03a8b80 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/ParamsBinderTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/util/ParamsBinderTest.java @@ -56,13 +56,13 @@ class ParamsBinderTest { private ParamsBinder binder; @BeforeEach - public void setUp() { + void setUp() { this.metadata = entities.get(Person.class); this.binder = new ParamsBinder(metadata, converters); } @Test - public void shouldReturnNPEWhenThereIsNullParameter() { + void shouldReturnNPEWhenThereIsNullParameter() { Params params = Params.newParams(); Assertions.assertThrows(NullPointerException.class, () -> binder.bind(params, null, null) @@ -74,7 +74,7 @@ public void shouldReturnNPEWhenThereIsNullParameter() { } @Test - public void shouldReturnErrorWhenParamsIsBiggerThanArgs() { + void shouldReturnErrorWhenParamsIsBiggerThanArgs() { Method method = PersonRepository.class.getDeclaredMethods()[0]; Params params = Params.newParams(); params.add("name"); @@ -84,7 +84,7 @@ public void shouldReturnErrorWhenParamsIsBiggerThanArgs() { } @Test - public void shouldBindParameterFindById() { + void shouldBindParameterFindById() { Method method = PersonRepository.class.getDeclaredMethods()[0]; Params params = Params.newParams(); Value value = params.add("name"); @@ -96,7 +96,7 @@ public void shouldBindParameterFindById() { } @Test - public void shouldBindParameterFindByUnderLineParameter() { + void shouldBindParameterFindByUnderLineParameter() { Method method = PersonRepository.class.getDeclaredMethods()[0]; Params params = Params.newParams(); Value value = params.add("name_1212"); @@ -108,7 +108,7 @@ public void shouldBindParameterFindByUnderLineParameter() { } @Test - public void shouldBindParameterInSingleParameter() { + void shouldBindParameterInSingleParameter() { Method method = PersonRepository.class.getDeclaredMethods()[1]; Params params = Params.newParams(); Value value = params.add("name_1212"); @@ -120,7 +120,7 @@ public void shouldBindParameterInSingleParameter() { } @Test - public void shouldBindParameterInIterableParameter() { + void shouldBindParameterInIterableParameter() { Method method = PersonRepository.class.getDeclaredMethods()[1]; Params params = Params.newParams(); Value value = params.add("name_1212"); @@ -133,7 +133,7 @@ public void shouldBindParameterInIterableParameter() { } @Test - public void shouldConvertParamBinder() { + void shouldConvertParamBinder() { Method method = PersonRepository.class.getDeclaredMethods()[2]; Params params = Params.newParams(); Value value = params.add("age_1212"); @@ -145,7 +145,7 @@ public void shouldConvertParamBinder() { } @Test - public void shouldConvertIterable() { + void shouldConvertIterable() { Method method = PersonRepository.class.getDeclaredMethods()[1]; Params params = Params.newParams(); Value value = params.add("age"); From 5c572cf4ab4df36e7329f6b03476c73b368d9ee3 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:33 -0300 Subject: [PATCH 155/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/document/query/ParamsBinderTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/ParamsBinderTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/ParamsBinderTest.java index 4c5de65b0..d456c653d 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/ParamsBinderTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/ParamsBinderTest.java @@ -64,7 +64,7 @@ class ParamsBinderTest { private ParamsBinder paramsBinder; @Test - public void shouldConvert() { + void shouldConvert() { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals("findByAge")).findFirst().get(); @@ -87,7 +87,7 @@ public void shouldConvert() { } @Test - public void shouldConvert2() { + void shouldConvert2() { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals("findByAgeAndName")).findFirst().get(); From bee75f56511b642eda130aba3ec9e3c6bb31e5f4 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:34 -0300 Subject: [PATCH 156/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../java/org/eclipse/jnosql/communication/ParamsTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/ParamsTest.java b/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/ParamsTest.java index 13eea3d34..f3dd2734a 100644 --- a/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/ParamsTest.java +++ b/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/ParamsTest.java @@ -34,7 +34,7 @@ void shouldNewParams() { @Test @DisplayName("Should not use Value when is invalid") - public void shouldNotUseValueWhenIsInvalid() { + void shouldNotUseValueWhenIsInvalid() { String paramValue = UUID.randomUUID().toString(); Params params = Params.newParams(); @@ -50,7 +50,7 @@ public void shouldNotUseValueWhenIsInvalid() { } @Test - public void shouldPrefix(){ + void shouldPrefix(){ Params params = Params.newParams(); Value value = params.add("name_2342342"); params.prefix("name", "Ada"); From e6cbb5802b521b4092798d1728757832f3d0257f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:36 -0300 Subject: [PATCH 157/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/query/PutProviderTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/PutProviderTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/PutProviderTest.java index a8a8a526a..ac61575f0 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/PutProviderTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/PutProviderTest.java @@ -29,14 +29,14 @@ class PutProviderTest { private final PutQueryConverter provider = new PutQueryConverter(); @Test - public void shouldReturnErrorWhenStringIsNull() { + void shouldReturnErrorWhenStringIsNull() { Assertions.assertThrows(NullPointerException.class, () -> provider.apply(null)); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"put {\"Ada\", \"Hunt\"}\n"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { PutQuery putQuery = provider.apply(query); QueryValue key = putQuery.key(); QueryValue value = putQuery.value(); @@ -54,7 +54,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"put {12, \"Hunt\"}\n"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { PutQuery putQuery = provider.apply(query); QueryValue key = putQuery.key(); QueryValue value = putQuery.value(); @@ -70,7 +70,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"put {12, 12.12}\n"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { PutQuery putQuery = provider.apply(query); QueryValue key = putQuery.key(); QueryValue value = putQuery.value(); @@ -87,7 +87,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"put {@name, @value, 10 hour}\n"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { PutQuery putQuery = provider.apply(query); QueryValue key = putQuery.key(); QueryValue value = putQuery.value(); @@ -104,7 +104,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"put {@name, @value, 10 minute}\n"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { PutQuery putQuery = provider.apply(query); QueryValue key = putQuery.key(); QueryValue value = putQuery.value(); @@ -121,7 +121,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"put {@name, @value, 10 second}\n"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { PutQuery putQuery = provider.apply(query); QueryValue key = putQuery.key(); QueryValue value = putQuery.value(); @@ -138,7 +138,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"put {@name, @value, 10 millisecond}\n"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { PutQuery putQuery = provider.apply(query); QueryValue key = putQuery.key(); QueryValue value = putQuery.value(); @@ -155,7 +155,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"put {@name, @value, 10 nanosecond}\n"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { PutQuery putQuery = provider.apply(query); QueryValue key = putQuery.key(); QueryValue value = putQuery.value(); From 1a4569b2e351ec9c5dec1a77f8b8f9acc66e16aa Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:38 -0300 Subject: [PATCH 158/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/communication/query/PutQueryTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/PutQueryTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/PutQueryTest.java index b58750915..09dbc87ca 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/PutQueryTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/PutQueryTest.java @@ -26,22 +26,22 @@ import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.ArgumentsSource; -public class PutQueryTest { +class PutQueryTest { @ParameterizedTest @ArgumentsSource(PutQueryArgumentProvider.class) - public void shouldExecuteQuery(String query) { + void shouldExecuteQuery(String query) { testQuery(query); } @Test - public void shouldIgnoreComments() { + void shouldIgnoreComments() { testQuery("//ignore this line \n put {\"Ada\", \"Ada Lovelace\"}"); } @ParameterizedTest @ArgumentsSource(WrongPutQueryArgumentProvider.class) - public void shouldNotExecute(String query) { + void shouldNotExecute(String query) { Assertions.assertThrows(QueryException.class, () -> testQuery(query)); } From 3a12928f3b5f371097f06d56dbd16783b5878a96 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:39 -0300 Subject: [PATCH 159/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/query/QueryParserTest.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/QueryParserTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/QueryParserTest.java index 7617f3672..8b845a5ea 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/QueryParserTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/QueryParserTest.java @@ -25,24 +25,23 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.ArgumentsSource; - -public class QueryParserTest { +class QueryParserTest { @ParameterizedTest @ArgumentsSource(DeleteQueryArgumentProvider.class) - public void shouldExecuteQuery(String query) { + void shouldExecuteQuery(String query) { testQuery(query); } @Test - public void shouldIgnoreComments() { + void shouldIgnoreComments() { testQuery("//ignore this line \n delete from Person"); } @ParameterizedTest(name = "Should parser the query {0}") @ArgumentsSource(WrongDeleteQueryArgumentProvider.class) - public void shouldNotExecute(String query) { + void shouldNotExecute(String query) { Assertions.assertThrows(QueryException.class, () -> testQuery(query)); } From d2a84d6d5e62019c53d9c66cdce24aced68a972f Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:40 -0300 Subject: [PATCH 160/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../repository/returns/QueueRepositoryReturnTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/QueueRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/QueueRepositoryReturnTest.java index 386b8a279..606d80125 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/QueueRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/QueueRepositoryReturnTest.java @@ -44,7 +44,7 @@ class QueueRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Queue.class)); Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Deque.class)); assertFalse(repositoryReturn.isCompatible(Object.class, Person.class)); @@ -52,7 +52,7 @@ public void shouldReturnIsCompatible() { } @Test - public void shouldReturnLinkedListPage() { + void shouldReturnLinkedListPage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Person.class) @@ -71,7 +71,7 @@ public void shouldReturnLinkedListPage() { } @Test - public void shouldReturnLinkedList() { + void shouldReturnLinkedList() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withSingleResult(Optional::empty) From 2fccc75c498dfae68e91870463771b83f9f51be6 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:42 -0300 Subject: [PATCH 161/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- ...tionClassConverterJavaFieldParserTest.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionClassConverterJavaFieldParserTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionClassConverterJavaFieldParserTest.java index e7c598636..dd58b3489 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionClassConverterJavaFieldParserTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionClassConverterJavaFieldParserTest.java @@ -30,17 +30,17 @@ import static java.util.stream.Collectors.toList; import static org.junit.jupiter.api.Assertions.assertEquals; -public class ReflectionClassConverterJavaFieldParserTest { +class ReflectionClassConverterJavaFieldParserTest { private ClassConverter converter; @BeforeEach - public void setUp() { + void setUp() { this.converter = new ReflectionClassConverter(); } @Test - public void shouldReturnErrorWhenParameterIsNull() { + void shouldReturnErrorWhenParameterIsNull() { Assertions.assertThrows(NullPointerException.class, () -> { EntityMetadata entityMetadata = converter.apply(Person.class); entityMetadata.columnField(null); @@ -48,7 +48,7 @@ public void shouldReturnErrorWhenParameterIsNull() { } @Test - public void shouldReturnTheNativeName() { + void shouldReturnTheNativeName() { EntityMetadata entityMetadata = converter.apply(Worker.class); String notFound = entityMetadata.columnField("salary"); assertEquals("money", notFound); @@ -56,21 +56,21 @@ public void shouldReturnTheNativeName() { } @Test - public void shouldReturnTheSameValueWhenTheFieldDoesNotExistInTheEntityMetadata() { + void shouldReturnTheSameValueWhenTheFieldDoesNotExistInTheEntityMetadata() { EntityMetadata entityMetadata = converter.apply(Person.class); String notFound = entityMetadata.columnField("notFound"); assertEquals("notFound", notFound); } @Test - public void shouldReadFieldWhenFieldIsSubEntity() { + void shouldReadFieldWhenFieldIsSubEntity() { EntityMetadata entityMetadata = converter.apply(Address.class); String result = entityMetadata.columnField("zipCode.plusFour"); assertEquals("zipCode.plusFour", result); } @Test - public void shouldReturnAllFieldWhenSelectTheSubEntityField() { + void shouldReturnAllFieldWhenSelectTheSubEntityField() { EntityMetadata entityMetadata = converter.apply(Address.class); String result = entityMetadata.columnField("zipCode"); List resultList = Stream.of(result.split(",")).sorted().collect(toList()); @@ -79,14 +79,14 @@ public void shouldReturnAllFieldWhenSelectTheSubEntityField() { } @Test - public void shouldReadFieldWhenFieldIsEmbedded() { + void shouldReadFieldWhenFieldIsEmbedded() { EntityMetadata entityMetadata = converter.apply(Worker.class); String result = entityMetadata.columnField("job.city"); assertEquals("city", result); } @Test - public void shouldReturnAllFieldWhenSelectTheEmbeddedField() { + void shouldReturnAllFieldWhenSelectTheEmbeddedField() { EntityMetadata entityMetadata = converter.apply(Worker.class); String result = entityMetadata.columnField("job"); List resultList = Stream.of(result.split(",")).sorted().collect(toList()); @@ -96,7 +96,7 @@ public void shouldReturnAllFieldWhenSelectTheEmbeddedField() { @Test - public void shouldReturnEmbeddedFieldInCollection() { + void shouldReturnEmbeddedFieldInCollection() { EntityMetadata entityMetadata = converter.apply(AppointmentBook.class); String result = entityMetadata.columnField("contacts.name"); assertEquals("contacts.contact_name", result); From 4d2cfa45c9d05238eafa53554aa5195126985c0d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:43 -0300 Subject: [PATCH 162/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../ReflectionClassConverterTest.java | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionClassConverterTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionClassConverterTest.java index 574c7d8c9..6b205375f 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionClassConverterTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionClassConverterTest.java @@ -45,18 +45,18 @@ import static org.eclipse.jnosql.mapping.DiscriminatorColumn.DEFAULT_DISCRIMINATOR_COLUMN; import static org.junit.jupiter.api.Assertions.*; -public class ReflectionClassConverterTest { +class ReflectionClassConverterTest { private ClassConverter converter; @BeforeEach - public void setUp() { + void setUp() { this.converter = new ReflectionClassConverter(); } @Test - public void shouldCreateEntityMetadata() { + void shouldCreateEntityMetadata() { EntityMetadata entityMetadata = converter.apply(Person.class); assertEquals("Person", entityMetadata.name()); @@ -70,7 +70,7 @@ public void shouldCreateEntityMetadata() { } @Test - public void shouldEntityMetadata2() { + void shouldEntityMetadata2() { EntityMetadata entityMetadata = converter.apply(Actor.class); assertEquals("Actor", entityMetadata.name()); @@ -83,7 +83,7 @@ public void shouldEntityMetadata2() { } @Test - public void shouldCreateEntityMetadataWithEmbeddedClass() { + void shouldCreateEntityMetadataWithEmbeddedClass() { EntityMetadata entityMetadata = converter.apply(Director.class); assertEquals("Director", entityMetadata.name()); assertEquals(Director.class, entityMetadata.type()); @@ -93,7 +93,7 @@ public void shouldCreateEntityMetadataWithEmbeddedClass() { } @Test - public void shouldReturnFalseWhenThereIsNotKey() { + void shouldReturnFalseWhenThereIsNotKey() { EntityMetadata entityMetadata = converter.apply(Worker.class); boolean allMatch = entityMetadata.fields().stream().noneMatch(FieldMetadata::isId); assertTrue(allMatch); @@ -101,7 +101,7 @@ public void shouldReturnFalseWhenThereIsNotKey() { @Test - public void shouldReturnTrueWhenThereIsKey() { + void shouldReturnTrueWhenThereIsKey() { EntityMetadata entityMetadata = converter.apply(User.class); List fields = entityMetadata.fields(); @@ -114,26 +114,26 @@ public void shouldReturnTrueWhenThereIsKey() { } @Test - public void shouldReturnErrorWhenThereIsNotConstructor() { + void shouldReturnErrorWhenThereIsNotConstructor() { Assertions.assertThrows(ConstructorException.class, () -> converter.apply(NoConstructorEntity.class)); } @Test - public void shouldReturnWhenIsDefaultConstructor() { + void shouldReturnWhenIsDefaultConstructor() { EntityMetadata entityMetadata = converter.apply(Machine.class); List fields = entityMetadata.fields(); assertEquals(1, fields.size()); } @Test - public void shouldReturnEmptyInheritance() { + void shouldReturnEmptyInheritance() { EntityMetadata entityMetadata = converter.apply(Person.class); Optional inheritance = entityMetadata.inheritance(); Assertions.assertTrue(inheritance.isEmpty()); } @Test - public void shouldInheritance() { + void shouldInheritance() { EntityMetadata entity = converter.apply(SmallProject.class); Assertions.assertEquals(2, entity.fields().size()); Assertions.assertEquals(SmallProject.class, entity.type()); @@ -147,7 +147,7 @@ public void shouldInheritance() { } @Test - public void shouldInheritanceNoDiscriminatorValue() { + void shouldInheritanceNoDiscriminatorValue() { EntityMetadata entity = converter.apply(SocialMediaNotification.class); Assertions.assertEquals(4, entity.fields().size()); Assertions.assertEquals(SocialMediaNotification.class, entity.type()); @@ -161,7 +161,7 @@ public void shouldInheritanceNoDiscriminatorValue() { } @Test - public void shouldInheritanceNoDiscriminatorColumn() { + void shouldInheritanceNoDiscriminatorColumn() { EntityMetadata entity = converter.apply(EmailNotification.class); Assertions.assertEquals(4, entity.fields().size()); Assertions.assertEquals(EmailNotification.class, entity.type()); @@ -175,7 +175,7 @@ public void shouldInheritanceNoDiscriminatorColumn() { } @Test - public void shouldInheritanceSameParent() { + void shouldInheritanceSameParent() { EntityMetadata entity = converter.apply(Project.class); Assertions.assertEquals(1, entity.fields().size()); Assertions.assertEquals(Project.class, entity.type()); @@ -191,7 +191,7 @@ public void shouldInheritanceSameParent() { @Test - public void shouldCreateEntityMetadataWithConstructor() { + void shouldCreateEntityMetadataWithConstructor() { EntityMetadata entityMetadata = converter.apply(Computer.class); assertEquals("Computer", entityMetadata.name()); From 6b61b633c455e5c667efc6c392d23c1a88887072 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:44 -0300 Subject: [PATCH 163/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../reflection/ReflectionConstructorBuilderSupplierTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionConstructorBuilderSupplierTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionConstructorBuilderSupplierTest.java index 8420921e3..44b222624 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionConstructorBuilderSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionConstructorBuilderSupplierTest.java @@ -32,13 +32,13 @@ class ReflectionConstructorBuilderSupplierTest { private ReflectionConstructorBuilderSupplier supplier; @BeforeEach - public void setUp() { + void setUp() { MockitoAnnotations.openMocks(this); supplier = new ReflectionConstructorBuilderSupplier(); } @Test - public void shouldApply() { + void shouldApply() { // Mocking ConstructorBuilder ConstructorBuilder constructorBuilder = DefaultConstructorBuilder.of(constructorMetadata); when(constructorBuilder.toString()).thenReturn("MockedConstructorBuilder"); From 976dbd7e60ca0c4300cc62ec53216276c868fe5a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:46 -0300 Subject: [PATCH 164/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/ReflectionsTest.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionsTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionsTest.java index 478603015..0ae2a78eb 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionsTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/ReflectionsTest.java @@ -49,13 +49,13 @@ @EnableAutoWeld @AddPackages(value = Convert.class) @AddPackages(value = ReflectionGroupEntityMetadata.class) -public class ReflectionsTest { +class ReflectionsTest { @Inject private Reflections reflections; @Test - public void shouldReturnsEntityName() { + void shouldReturnsEntityName() { assertSoftly(softly -> { softly.assertThat(reflections.getEntityName(Person.class)) .as("getting entity name from annotated class with @Entity without name") @@ -73,7 +73,7 @@ public void shouldReturnsEntityName() { } @Test - public void shouldReturnsConstructor() { + void shouldReturnsConstructor() { assertSoftly(softly -> { Constructor personConstructor = reflections.getConstructor(Person.class); @@ -97,7 +97,7 @@ public void shouldReturnsConstructor() { } @Test - public void shouldListFields() { + void shouldListFields() { assertSoftly(softly -> { softly.assertThat(reflections.getFields(Person.class)) .as("list fields from a class with field not annotated with @Column") @@ -115,7 +115,7 @@ public void shouldListFields() { } @Test - public void shouldReturnColumnName() throws NoSuchFieldException { + void shouldReturnColumnName() throws NoSuchFieldException { Field phones = Person.class.getDeclaredField("phones"); Field id = Person.class.getDeclaredField("id"); @@ -125,20 +125,20 @@ public void shouldReturnColumnName() throws NoSuchFieldException { } @Test - public void shouldGetEntityNameWhenThereIsNoAnnotation() { + void shouldGetEntityNameWhenThereIsNoAnnotation() { String entityName = reflections.getEntityName(Person.class); assertEquals(Person.class.getSimpleName(), entityName); } @Test - public void shouldGetEntityNameFromAnnotation() { + void shouldGetEntityNameFromAnnotation() { String entityName = reflections.getEntityName(Download.class); assertEquals("download", entityName); assertEquals("vendors", reflections.getEntityName(Vendor.class)); } @Test - public void shouldGetEntityFromInheritance() { + void shouldGetEntityFromInheritance() { assertEquals("Notification", reflections.getEntityName(SocialMediaNotification.class)); assertEquals("Notification", reflections.getEntityName(SmsNotification.class)); assertEquals("Notification", reflections.getEntityName(EmailNotification.class)); @@ -148,13 +148,13 @@ public void shouldGetEntityFromInheritance() { } @Test - public void shouldReturnEmptyGetInheritance() { + void shouldReturnEmptyGetInheritance() { Optional inheritance = this.reflections.getInheritance(Person.class); assertTrue(inheritance.isEmpty()); } @Test - public void shouldReturnGetInheritance() { + void shouldReturnGetInheritance() { Optional inheritance = this.reflections.getInheritance(LargeProject.class); assertFalse(inheritance.isEmpty()); InheritanceMetadata project = inheritance.get(); @@ -165,7 +165,7 @@ public void shouldReturnGetInheritance() { } @Test - public void shouldReturnGetInheritanceWithoutColumn() { + void shouldReturnGetInheritanceWithoutColumn() { Optional inheritance = this.reflections.getInheritance(SmsNotification.class); assertFalse(inheritance.isEmpty()); InheritanceMetadata project = inheritance.get(); @@ -176,7 +176,7 @@ public void shouldReturnGetInheritanceWithoutColumn() { } @Test - public void shouldReturnGetInheritanceWithoutDiscriminatorValue() { + void shouldReturnGetInheritanceWithoutDiscriminatorValue() { Optional inheritance = this.reflections.getInheritance(SocialMediaNotification.class); assertFalse(inheritance.isEmpty()); InheritanceMetadata project = inheritance.get(); @@ -187,7 +187,7 @@ public void shouldReturnGetInheritanceWithoutDiscriminatorValue() { } @Test - public void shouldGetInheritanceParent() { + void shouldGetInheritanceParent() { Optional inheritance = this.reflections.getInheritance(Project.class); assertFalse(inheritance.isEmpty()); InheritanceMetadata project = inheritance.get(); @@ -198,7 +198,7 @@ public void shouldGetInheritanceParent() { } @Test - public void shouldReturnHasInheritanceAnnotation() { + void shouldReturnHasInheritanceAnnotation() { assertFalse(this.reflections.hasInheritanceAnnotation(Person.class)); assertFalse(this.reflections.hasInheritanceAnnotation(Worker.class)); assertFalse(this.reflections.hasInheritanceAnnotation(SmsNotification.class)); From 1675fcf31a5318cd36106a7586917559b89d797d Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:47 -0300 Subject: [PATCH 165/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/query/RemoveProviderTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/RemoveProviderTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/RemoveProviderTest.java index 63f11217a..9744ba0dc 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/RemoveProviderTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/RemoveProviderTest.java @@ -30,14 +30,14 @@ class RemoveProviderTest { private final DelQueryConverter provider = new DelQueryConverter(); @Test - public void shouldReturnErrorWhenStringIsNull() { + void shouldReturnErrorWhenStringIsNull() { Assertions.assertThrows(NullPointerException.class, () -> provider.apply(null)); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"del \"Diana\""}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { DelQuery delQuery = provider.apply(query); List> keys = delQuery.keys(); assertEquals(1, keys.size()); @@ -48,7 +48,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"del 12"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { DelQuery delQuery = provider.apply(query); List> keys = delQuery.keys(); assertEquals(1, keys.size()); @@ -59,7 +59,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"del 12.12"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { DelQuery delQuery = provider.apply(query); List> keys = delQuery.keys(); assertEquals(1, keys.size()); @@ -70,7 +70,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"del -12"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { DelQuery delQuery = provider.apply(query); List> keys = delQuery.keys(); assertEquals(1, keys.size()); @@ -81,7 +81,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"del -12.12"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { DelQuery delQuery = provider.apply(query); List> keys = delQuery.keys(); assertEquals(1, keys.size()); @@ -93,7 +93,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"del {1,12}"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { DelQuery delQuery = provider.apply(query); List> keys = delQuery.keys(); assertEquals(1, keys.size()); From e7ddc8976b96c18e2163a765cd5a7cc551aa3a4a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:48 -0300 Subject: [PATCH 166/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/query/RepositoryColumnObserverParserTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/RepositoryColumnObserverParserTest.java b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/RepositoryColumnObserverParserTest.java index b4934229b..e86293b2a 100644 --- a/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/RepositoryColumnObserverParserTest.java +++ b/jnosql-mapping/jnosql-mapping-column/src/test/java/org/eclipse/jnosql/mapping/column/query/RepositoryColumnObserverParserTest.java @@ -24,7 +24,7 @@ class RepositoryColumnObserverParserTest { @Test - public void shouldCreateFromRepository() { + void shouldCreateFromRepository() { EntityMetadata entityMetadata = Mockito.mock(EntityMetadata.class); ColumnObserverParser parser = RepositoryColumnObserverParser.of(entityMetadata); assertNotNull(parser); From eb9076e713d9da5806922d419341b383c6e87c26 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:50 -0300 Subject: [PATCH 167/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/query/RepositoryDocumentObserverParserTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/RepositoryDocumentObserverParserTest.java b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/RepositoryDocumentObserverParserTest.java index b198d2674..64307a956 100644 --- a/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/RepositoryDocumentObserverParserTest.java +++ b/jnosql-mapping/jnosql-mapping-document/src/test/java/org/eclipse/jnosql/mapping/document/query/RepositoryDocumentObserverParserTest.java @@ -24,7 +24,7 @@ class RepositoryDocumentObserverParserTest { @Test - public void shouldCreateFromRepository() { + void shouldCreateFromRepository() { EntityMetadata entityMetadata = Mockito.mock(EntityMetadata.class); DocumentObserverParser parser = RepositoryDocumentObserverParser.of(entityMetadata); assertNotNull(parser); From 27764c422ae86279cf7735a014cb8adfe46bc641 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:51 -0300 Subject: [PATCH 168/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/mapping/reflection/RepositoryFilterTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/RepositoryFilterTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/RepositoryFilterTest.java index 38db71f8f..4ed6515fe 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/RepositoryFilterTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/RepositoryFilterTest.java @@ -35,13 +35,13 @@ class RepositoryFilterTest { private Predicate> invalid; @BeforeEach - public void setUp() { + void setUp() { this.valid = RepositoryFilter.INSTANCE; this.invalid = RepositoryFilter.INSTANCE::isInvalid; } @Test - public void shouldReturnTrueWhenHasSupportRepository() { + void shouldReturnTrueWhenHasSupportRepository() { assertThat(valid.test(PersonRepository.class)).isTrue(); assertThat(valid.test(People.class)).isTrue(); assertThat(valid.test(Persons.class)).isTrue(); @@ -49,7 +49,7 @@ public void shouldReturnTrueWhenHasSupportRepository() { } @Test - public void shouldReturnFalseWhenHasNotSupportRepository() { + void shouldReturnFalseWhenHasNotSupportRepository() { assertThat(valid.test(NoSQLVendor.class)).isFalse(); assertThat(valid.test(Server.class)).isFalse(); assertThat(valid.test(StringSupplier.class)).isFalse(); @@ -57,7 +57,7 @@ public void shouldReturnFalseWhenHasNotSupportRepository() { } @Test - public void shouldReturnInvalid(){ + void shouldReturnInvalid(){ assertThat(invalid.test(PersonRepository.class)).isFalse(); assertThat(invalid.test(People.class)).isFalse(); assertThat(invalid.test(Persons.class)).isFalse(); From 670ed7e4207abf386dfb70b6b703af75b0a1c6c0 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:52 -0300 Subject: [PATCH 169/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../repository/RepositoryObserverParserTest.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/RepositoryObserverParserTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/RepositoryObserverParserTest.java index c0f5cfa8c..fb1e976a1 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/RepositoryObserverParserTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/RepositoryObserverParserTest.java @@ -40,14 +40,14 @@ class RepositoryObserverParserTest { private EntitiesMetadata entities; @Test - public void shouldCreateInstance() { + void shouldCreateInstance() { EntityMetadata metadata = entities.get(Person.class); RepositoryObserverParser parser = RepositoryObserverParser.of(metadata); org.assertj.core.api.Assertions.assertThat(parser).isNotNull(); } @Test - public void shouldFireEvent() { + void shouldFireEvent() { EntityMetadata metadata = entities.get(Person.class); RepositoryObserverParser parser = RepositoryObserverParser.of(metadata); org.assertj.core.api.Assertions.assertThat(parser) @@ -57,7 +57,7 @@ public void shouldFireEvent() { @Test - public void shouldKeepName() { + void shouldKeepName() { EntityMetadata metadata = entities.get(Person.class); RepositoryObserverParser parser = RepositoryObserverParser.of(metadata); org.assertj.core.api.Assertions.assertThat(parser) @@ -66,7 +66,7 @@ public void shouldKeepName() { } @Test - public void shouldReplaceName(){ + void shouldReplaceName(){ EntityMetadata metadata = entities.get(Worker.class); RepositoryObserverParser parser = RepositoryObserverParser.of(metadata); org.assertj.core.api.Assertions.assertThat(parser) @@ -75,7 +75,7 @@ public void shouldReplaceName(){ } @Test - public void shouldKeepWhenDoesNotFind() { + void shouldKeepWhenDoesNotFind() { EntityMetadata metadata = entities.get(Address.class); RepositoryObserverParser parser = RepositoryObserverParser.of(metadata); org.assertj.core.api.Assertions.assertThat(parser) @@ -84,7 +84,7 @@ public void shouldKeepWhenDoesNotFind() { } @Test - public void shouldConcatSmart() { + void shouldConcatSmart() { EntityMetadata metadata = entities.get(Address.class); RepositoryObserverParser parser = RepositoryObserverParser.of(metadata); org.assertj.core.api.Assertions.assertThat(parser) From 35e78356d88d6ab54c227345d015f7760d443af4 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:55 -0300 Subject: [PATCH 170/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/repository/RepositoryReflectionUtilsTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/RepositoryReflectionUtilsTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/RepositoryReflectionUtilsTest.java index 8deda28e4..f28d6abc7 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/RepositoryReflectionUtilsTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/RepositoryReflectionUtilsTest.java @@ -31,7 +31,7 @@ class RepositoryReflectionUtilsTest { @Test - public void shouldGetParams(){ + void shouldGetParams(){ Method method = PersonRepository.class.getDeclaredMethods()[0]; Map params = RepositoryReflectionUtils.INSTANCE.getParams(method, new Object[]{"Ada"}); assertThat(params) @@ -41,7 +41,7 @@ public void shouldGetParams(){ } @Test - public void shouldQuery(){ + void shouldQuery(){ Method method = PersonRepository.class.getDeclaredMethods()[0]; String query = RepositoryReflectionUtils.INSTANCE.getQuery(method); assertEquals("select * from Person where name = @name", query); From 0c39ebc5b12f3a1446e2e83b89fc68901e5c60b9 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:56 -0300 Subject: [PATCH 171/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/query/RepositoryTypeTest.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/query/RepositoryTypeTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/query/RepositoryTypeTest.java index 4c95d15fb..0e9d2845d 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/query/RepositoryTypeTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/query/RepositoryTypeTest.java @@ -34,7 +34,7 @@ class RepositoryTypeTest { @Test - public void shouldReturnDefault() throws NoSuchMethodException { + void shouldReturnDefault() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.DEFAULT, RepositoryType.of(getMethod(CrudRepository.class, "save"), CrudRepository.class)); Assertions.assertEquals(RepositoryType.DEFAULT, RepositoryType.of(getMethod(CrudRepository.class, "deleteById"), CrudRepository.class)); Assertions.assertEquals(RepositoryType.DEFAULT, RepositoryType.of(getMethod(CrudRepository.class, "findById"), CrudRepository.class)); @@ -45,49 +45,49 @@ public void shouldReturnDefault() throws NoSuchMethodException { @Test - public void shouldReturnObjectMethod() throws NoSuchMethodException { + void shouldReturnObjectMethod() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.OBJECT_METHOD, RepositoryType.of(getMethod(Object.class, "equals"), CrudRepository.class)); Assertions.assertEquals(RepositoryType.OBJECT_METHOD, RepositoryType.of(getMethod(Object.class, "hashCode"), CrudRepository.class)); } @Test - public void shouldReturnFindBy() throws NoSuchMethodException { + void shouldReturnFindBy() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.FIND_BY, RepositoryType.of(getMethod(DevRepository.class, "findByName"), CrudRepository.class)); } @Test - public void shouldReturnDeleteBy() throws NoSuchMethodException { + void shouldReturnDeleteBy() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.DELETE_BY, RepositoryType.of(getMethod(DevRepository.class, "deleteByName"), CrudRepository.class)); } @Test - public void shouldReturnFindAllBy() throws NoSuchMethodException { + void shouldReturnFindAllBy() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.FIND_ALL, RepositoryType.of(getMethod(DevRepository.class, "findAll"), CrudRepository.class)); } @Test - public void shouldReturnJNoSQLQuery() throws NoSuchMethodException { + void shouldReturnJNoSQLQuery() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.QUERY, RepositoryType.of(getMethod(DevRepository.class, "query"), CrudRepository.class)); } @Test - public void shouldReturnUnknown() throws NoSuchMethodException { + void shouldReturnUnknown() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.UNKNOWN, RepositoryType.of(getMethod(DevRepository.class, "nope"), CrudRepository.class)); } @Test - public void shouldReturnCountBy() throws NoSuchMethodException { + void shouldReturnCountBy() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.COUNT_BY, RepositoryType.of(getMethod(DevRepository.class, "countByName"), CrudRepository.class)); } @Test - public void shouldReturnExistsBy() throws NoSuchMethodException { + void shouldReturnExistsBy() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.EXISTS_BY, RepositoryType.of(getMethod(DevRepository.class, "existsByName"), CrudRepository.class)); } @Test - public void shouldReturnOrder() throws NoSuchMethodException { + void shouldReturnOrder() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.ORDER_BY, RepositoryType.of(getMethod(DevRepository.class, "order"), CrudRepository.class)); @@ -96,13 +96,13 @@ public void shouldReturnOrder() throws NoSuchMethodException { } @Test - public void shouldDefaultMethod() throws NoSuchMethodException { + void shouldDefaultMethod() throws NoSuchMethodException { Assertions.assertEquals(RepositoryType.DEFAULT_METHOD, RepositoryType.of(getMethod(DevRepository.class, "duplicate"), CrudRepository.class)); } @Test - public void shouldReturnCustom() throws NoSuchMethodException { + void shouldReturnCustom() throws NoSuchMethodException { try (MockedStatic cdi = Mockito.mockStatic(CDI.class)) { CDI current = Mockito.mock(CDI.class); Instance instance = Mockito.mock(Instance.class); @@ -115,7 +115,7 @@ public void shouldReturnCustom() throws NoSuchMethodException { } @Test - public void shouldReturnFindByCustom() throws NoSuchMethodException { + void shouldReturnFindByCustom() throws NoSuchMethodException { try (MockedStatic cdi = Mockito.mockStatic(CDI.class)) { CDI current = Mockito.mock(CDI.class); Instance instance = Mockito.mock(Instance.class); @@ -128,7 +128,7 @@ public void shouldReturnFindByCustom() throws NoSuchMethodException { } @Test - public void shouldReturnFindByCustom2() throws NoSuchMethodException { + void shouldReturnFindByCustom2() throws NoSuchMethodException { try (MockedStatic cdi = Mockito.mockStatic(CDI.class)) { CDI current = Mockito.mock(CDI.class); Instance instance = Mockito.mock(Instance.class); From a6a74aabc45001b1177eb4a1cfe959ea0b52dc90 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:57 -0300 Subject: [PATCH 172/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../communication/query/method/SelectMethodProviderTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/SelectMethodProviderTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/SelectMethodProviderTest.java index 5404142c2..3afe3d514 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/SelectMethodProviderTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/SelectMethodProviderTest.java @@ -22,7 +22,7 @@ class SelectMethodProviderTest { @Test - public void shouldCreateFromProvider() { + void shouldCreateFromProvider() { Method method = PersonRepository.class.getDeclaredMethods()[0]; SelectQuery query = SelectMethodProvider.INSTANCE.apply(method, "Person"); Assertions.assertNotNull(query); From 5e65f82a93bdd9988a3d965d582c727aae2115f5 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:35:59 -0300 Subject: [PATCH 173/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../method/SelectMethodQueryProviderTest.java | 72 +++++++++---------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/SelectMethodQueryProviderTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/SelectMethodQueryProviderTest.java index 4dc5fbb99..039719c1d 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/SelectMethodQueryProviderTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/method/SelectMethodQueryProviderTest.java @@ -41,7 +41,7 @@ class SelectMethodQueryProviderTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findBy", "countBy", "existsBy"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { String entity = "entity"; SelectQuery selectQuery = queryProvider.apply(query, entity); assertNotNull(selectQuery); @@ -56,27 +56,27 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByName", "countByName", "existsByName"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { String entity = "entity"; checkEqualsQuery(query, entity); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameEquals", "countByNameEquals", "existsByNameEquals"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { String entity = "entity"; checkEqualsQuery(query, entity); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameNotEquals", "countByNameNotEquals", "existsByNameNotEquals"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { checkNotCondition(query, Condition.EQUALS, "name"); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeGreaterThan", "countByAgeGreaterThan", "existsByAgeGreaterThan"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { Condition operator = Condition.GREATER_THAN; String variable = "age"; @@ -85,7 +85,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeNotGreaterThan", "countByAgeNotGreaterThan", "existsByAgeNotGreaterThan"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { Condition operator = Condition.GREATER_THAN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -93,7 +93,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeGreaterThanEqual", "countByAgeGreaterThanEqual", "existsByAgeGreaterThanEqual"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { Condition operator = Condition.GREATER_EQUALS_THAN; String variable = "age"; @@ -102,7 +102,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeNotGreaterThanEqual", "countByAgeNotGreaterThanEqual", "existsByAgeNotGreaterThanEqual"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { Condition operator = Condition.GREATER_EQUALS_THAN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -110,7 +110,7 @@ public void shouldReturnParserQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThan", "countByAgeLessThan", "existsByAgeLessThan"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { Condition operator = Condition.LESSER_THAN; String variable = "age"; @@ -119,7 +119,7 @@ public void shouldReturnParserQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeNotLessThan", "countByAgeNotLessThan", "existsByAgeNotLessThan"}) - public void shouldReturnParserQuery9(String query) { + void shouldReturnParserQuery9(String query) { Condition operator = Condition.LESSER_THAN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -127,7 +127,7 @@ public void shouldReturnParserQuery9(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThanEqual", "countByAgeLessThanEqual", "existsByAgeLessThanEqual"}) - public void shouldReturnParserQuery10(String query) { + void shouldReturnParserQuery10(String query) { Condition operator = Condition.LESSER_EQUALS_THAN; String variable = "age"; @@ -136,7 +136,7 @@ public void shouldReturnParserQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeNotLessThanEqual", "countByAgeNotLessThanEqual", "existsByAgeNotLessThanEqual"}) - public void shouldReturnParserQuery11(String query) { + void shouldReturnParserQuery11(String query) { Condition operator = Condition.LESSER_EQUALS_THAN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -144,7 +144,7 @@ public void shouldReturnParserQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLike", "countByAgeLike", "existsByAgeLike"}) - public void shouldReturnParserQuery12(String query) { + void shouldReturnParserQuery12(String query) { Condition operator = Condition.LIKE; String variable = "age"; @@ -153,7 +153,7 @@ public void shouldReturnParserQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeNotLike", "countByAgeNotLike", "existsByAgeNotLike"}) - public void shouldReturnParserQuery13(String query) { + void shouldReturnParserQuery13(String query) { Condition operator = Condition.LIKE; String variable = "age"; checkNotCondition(query, operator, variable); @@ -162,7 +162,7 @@ public void shouldReturnParserQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeIn", "countByAgeIn", "existsByAgeIn"}) - public void shouldReturnParserQuery14(String query) { + void shouldReturnParserQuery14(String query) { Condition operator = Condition.IN; String variable = "age"; @@ -171,7 +171,7 @@ public void shouldReturnParserQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeNotIn", "countByAgeNotIn", "existsByAgeNotIn"}) - public void shouldReturnParserQuery15(String query) { + void shouldReturnParserQuery15(String query) { Condition operator = Condition.IN; String variable = "age"; checkNotCondition(query, operator, variable); @@ -179,7 +179,7 @@ public void shouldReturnParserQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeAndName", "countByAgeAndName", "existsByAgeAndName"}) - public void shouldReturnParserQuery16(String query) { + void shouldReturnParserQuery16(String query) { Condition operator = Condition.EQUALS; Condition operator2 = Condition.EQUALS; @@ -191,7 +191,7 @@ public void shouldReturnParserQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeOrName", "countByAgeOrName", "existsByAgeOrName"}) - public void shouldReturnParserQuery17(String query) { + void shouldReturnParserQuery17(String query) { Condition operator = Condition.EQUALS; Condition operator2 = Condition.EQUALS; @@ -204,7 +204,7 @@ public void shouldReturnParserQuery17(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeOrNameLessThan", "countByAgeOrNameLessThan", "existsByAgeOrNameLessThan"}) - public void shouldReturnParserQuery18(String query) { + void shouldReturnParserQuery18(String query) { Condition operator = Condition.EQUALS; Condition operator2 = Condition.LESSER_THAN; @@ -216,7 +216,7 @@ public void shouldReturnParserQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeGreaterThanOrNameIn", "countByAgeGreaterThanOrNameIn", "existsByAgeGreaterThanOrNameIn"}) - public void shouldReturnParserQuery19(String query) { + void shouldReturnParserQuery19(String query) { Condition operator = Condition.GREATER_THAN; Condition operator2 = Condition.IN; @@ -228,26 +228,26 @@ public void shouldReturnParserQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByOrderByName", "countByOrderByName", "existsByOrderByName"}) - public void shouldReturnParserQuery20(String query) { + void shouldReturnParserQuery20(String query) { checkOrderBy(query, Direction.ASC); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByOrderByNameAsc", "countByOrderByNameAsc", "existsByOrderByNameAsc"}) - public void shouldReturnParserQuery21(String query) { + void shouldReturnParserQuery21(String query) { Direction type = Direction.ASC; checkOrderBy(query, type); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByOrderByNameDesc", "countByOrderByNameDesc", "existsByOrderByNameDesc"}) - public void shouldReturnParserQuery22(String query) { + void shouldReturnParserQuery22(String query) { checkOrderBy(query, Direction.DESC); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByOrderByNameDescAgeAsc", "countByOrderByNameDescAgeAsc", "existsByOrderByNameDescAgeAsc"}) - public void shouldReturnParserQuery23(String query) { + void shouldReturnParserQuery23(String query) { Direction type = Direction.DESC; Direction type2 = Direction.ASC; @@ -256,26 +256,26 @@ public void shouldReturnParserQuery23(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByOrderByNameDescAge", "countByOrderByNameDescAge", "existsByOrderByNameDescAge"}) - public void shouldReturnParserQuery24(String query) { + void shouldReturnParserQuery24(String query) { checkOrderBy(query, Direction.DESC, Direction.ASC); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByOrderByNameDescAgeDesc", "countByOrderByNameDescAgeDesc", "existsByOrderByNameDescAgeDesc"}) - public void shouldReturnParserQuery25(String query) { + void shouldReturnParserQuery25(String query) { checkOrderBy(query, Direction.DESC, Direction.DESC); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByOrderByNameAscAgeAsc", "countByOrderByNameAscAgeAsc", "existsByOrderByNameAscAgeAsc"}) - public void shouldReturnParserQuery26(String query) { + void shouldReturnParserQuery26(String query) { checkOrderBy(query, Direction.ASC, Direction.ASC); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeBetween", "countByAgeBetween", "existsByAgeBetween"}) - public void shouldReturnParserQuery27(String query) { + void shouldReturnParserQuery27(String query) { Condition operator = Condition.BETWEEN; String entity = "entity"; @@ -299,7 +299,7 @@ public void shouldReturnParserQuery27(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeNotBetween", "countByAgeNotBetween", "existsByAgeNotBetween"}) - public void shouldReturnParserQuery28(String query) { + void shouldReturnParserQuery28(String query) { String entity = "entity"; SelectQuery selectQuery = queryProvider.apply(query, entity); @@ -326,7 +326,7 @@ public void shouldReturnParserQuery28(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findBySalary_Currency", "countBySalary_Currency", "existsBySalary_Currency"}) - public void shouldRunQuery29(String query) { + void shouldRunQuery29(String query) { String entity = "entity"; SelectQuery selectQuery = queryProvider.apply(query, entity); assertNotNull(selectQuery); @@ -346,7 +346,7 @@ public void shouldRunQuery29(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findBySalary_CurrencyAndCredential_Role", "countBySalary_CurrencyAndCredential_Role", "existsBySalary_CurrencyAndCredential_Role"}) - public void shouldRunQuery30(String query) { + void shouldRunQuery30(String query) { String entity = "entity"; SelectQuery selectQuery = queryProvider.apply(query, entity); assertNotNull(selectQuery); @@ -369,7 +369,7 @@ public void shouldRunQuery30(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findBySalary_CurrencyAndName", "countBySalary_CurrencyAndName", "existsBySalary_CurrencyAndName"}) - public void shouldRunQuery31(String query) { + void shouldRunQuery31(String query) { String entity = "entity"; SelectQuery selectQuery = queryProvider.apply(query, entity); assertNotNull(selectQuery); @@ -392,7 +392,7 @@ public void shouldRunQuery31(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findBySalary_CurrencyOrderBySalary_Value", "countBySalary_CurrencyOrderBySalary_Value" ,"existsBySalary_CurrencyOrderBySalary_Value"}) - public void shouldRunQuery32(String query) { + void shouldRunQuery32(String query) { String entity = "entity"; SelectQuery selectQuery = queryProvider.apply(query, entity); assertNotNull(selectQuery); @@ -413,7 +413,7 @@ public void shouldRunQuery32(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByActiveTrue", "countByActiveTrue", "existsByActiveTrue"}) - public void shouldRunQuery33(String query) { + void shouldRunQuery33(String query) { String entity = "entity"; SelectQuery selectQuery = queryProvider.apply(query, entity); assertNotNull(selectQuery); @@ -432,7 +432,7 @@ public void shouldRunQuery33(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByActiveFalse", "countByActiveFalse", "existsByActiveFalse"}) - public void shouldRunQuery34(String query) { + void shouldRunQuery34(String query) { String entity = "entity"; SelectQuery selectQuery = queryProvider.apply(query, entity); assertNotNull(selectQuery); @@ -451,7 +451,7 @@ public void shouldRunQuery34(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameNot", "countByNameNot", "existsByNameNot"}) - public void shouldReturnParserQuery35(String query) { + void shouldReturnParserQuery35(String query) { checkNotCondition(query, Condition.EQUALS, "name"); } From 1618ab39d9322440442c5320f489ebc0f40eb974 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:00 -0300 Subject: [PATCH 174/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../query/SelectQueryConverterTest.java | 64 +++++++++---------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/SelectQueryConverterTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/SelectQueryConverterTest.java index 04de2d45d..41f0d9dba 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/SelectQueryConverterTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/SelectQueryConverterTest.java @@ -35,20 +35,20 @@ class SelectQueryConverterTest { private final SelectQueryConverter selectQueryConverter = new SelectQueryConverter(); @Test - public void shouldReturnErrorWhenStringIsNull() { + void shouldReturnErrorWhenStringIsNull() { Assertions.assertThrows(NullPointerException.class, () -> selectQueryConverter.apply(null)); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertFalse(selectQuery.where().isPresent()); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select name, address from God"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("God", selectQuery.entity()); assertFalse(selectQuery.fields().isEmpty()); @@ -61,7 +61,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select name, address from God order by name"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("God", selectQuery.entity()); assertFalse(selectQuery.fields().isEmpty()); @@ -76,7 +76,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select name, address from God order by name desc"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("God", selectQuery.entity()); assertFalse(selectQuery.fields().isEmpty()); @@ -91,7 +91,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select name, address from God order by name desc age asc"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("God", selectQuery.entity()); assertFalse(selectQuery.fields().isEmpty()); @@ -107,7 +107,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God skip 12"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("God", selectQuery.entity()); assertTrue(selectQuery.fields().isEmpty()); @@ -119,7 +119,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God limit 12"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("God", selectQuery.entity()); assertTrue(selectQuery.fields().isEmpty()); @@ -131,7 +131,7 @@ public void shouldReturnParserQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God skip 10 limit 12"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("God", selectQuery.entity()); assertTrue(selectQuery.fields().isEmpty()); @@ -144,7 +144,7 @@ public void shouldReturnParserQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = 10"}) - public void shouldReturnParserQuery9(String query) { + void shouldReturnParserQuery9(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -159,7 +159,7 @@ public void shouldReturnParserQuery9(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina > 10.23"}) - public void shouldReturnParserQuery10(String query) { + void shouldReturnParserQuery10(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -174,7 +174,7 @@ public void shouldReturnParserQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina >= 10.23"}) - public void shouldReturnParserQuery11(String query) { + void shouldReturnParserQuery11(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -189,7 +189,7 @@ public void shouldReturnParserQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina <= 10.23"}) - public void shouldReturnParserQuery12(String query) { + void shouldReturnParserQuery12(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -204,7 +204,7 @@ public void shouldReturnParserQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina < 10.23"}) - public void shouldReturnParserQuery13(String query) { + void shouldReturnParserQuery13(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -220,7 +220,7 @@ public void shouldReturnParserQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age between 10 and 30"}) - public void shouldReturnParserQuery14(String query) { + void shouldReturnParserQuery14(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -238,7 +238,7 @@ public void shouldReturnParserQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"diana\""}) - public void shouldReturnParserQuery15(String query) { + void shouldReturnParserQuery15(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -253,7 +253,7 @@ public void shouldReturnParserQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = 'diana'"}) - public void shouldReturnParserQuery16(String query) { + void shouldReturnParserQuery16(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -268,7 +268,7 @@ public void shouldReturnParserQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = {\"diana\"}"}) - public void shouldReturnParserQuery17(String query) { + void shouldReturnParserQuery17(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -286,7 +286,7 @@ public void shouldReturnParserQuery17(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = {\"diana\", 17, 20.21}"}) - public void shouldReturnParserQuery18(String query) { + void shouldReturnParserQuery18(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -305,7 +305,7 @@ public void shouldReturnParserQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery19(String query) { + void shouldReturnParserQuery19(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -322,7 +322,7 @@ public void shouldReturnParserQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = @name"}) - public void shouldReturnParserQuery20(String query) { + void shouldReturnParserQuery20(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -337,7 +337,7 @@ public void shouldReturnParserQuery20(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = convert(12, java.lang.Integer)"}) - public void shouldReturnParserQuery21(String query) { + void shouldReturnParserQuery21(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -356,7 +356,7 @@ public void shouldReturnParserQuery21(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name in (\"Ada\", \"Apollo\")"}) - public void shouldReturnParserQuery22(String query) { + void shouldReturnParserQuery22(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -373,7 +373,7 @@ public void shouldReturnParserQuery22(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name like \"Ada\""}) - public void shouldReturnParserQuery23(String query) { + void shouldReturnParserQuery23(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -388,7 +388,7 @@ public void shouldReturnParserQuery23(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name not like \"Ada\""}) - public void shouldReturnParserQuery24(String query) { + void shouldReturnParserQuery24(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -411,7 +411,7 @@ public void shouldReturnParserQuery24(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20 and" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery25(String query) { + void shouldReturnParserQuery25(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -450,7 +450,7 @@ public void shouldReturnParserQuery25(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" or age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery26(String query) { + void shouldReturnParserQuery26(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -490,7 +490,7 @@ public void shouldReturnParserQuery26(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery27(String query) { + void shouldReturnParserQuery27(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -540,7 +540,7 @@ public void shouldReturnParserQuery27(String query) { @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"} or birthday =" + " convert(\"2007-12-03\", java.time.LocalDate)"}) - public void shouldReturnParserQuery28(String query) { + void shouldReturnParserQuery28(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -603,7 +603,7 @@ public void shouldReturnParserQuery28(String query) { @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"} and birthday =" + " convert(\"2007-12-03\", java.time.LocalDate)"}) - public void shouldReturnParserQuery29(String query) { + void shouldReturnParserQuery29(String query) { DefaultSelectQuery selectQuery = checkSelectFromStart(query); assertTrue(selectQuery.where().isPresent()); @@ -662,7 +662,7 @@ public void shouldReturnParserQuery29(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from my-prefix-user where user_id = 123"}) - public void shouldReturnParserQuery30(String query) { + void shouldReturnParserQuery30(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("my-prefix-user", selectQuery.entity()); @@ -684,7 +684,7 @@ public void shouldReturnParserQuery30(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from my-prefix-user where enable = true"}) - public void shouldReturnParserQuery31(String query) { + void shouldReturnParserQuery31(String query) { DefaultSelectQuery selectQuery = selectQueryConverter.apply(query); assertEquals("my-prefix-user", selectQuery.entity()); From f8b3889f097726a9655e0158b0a3e35144f63c78 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:01 -0300 Subject: [PATCH 175/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../graph/query/SelectQueryConverterTest.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/SelectQueryConverterTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/SelectQueryConverterTest.java index df0d73abe..d08bc4c53 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/SelectQueryConverterTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/query/SelectQueryConverterTest.java @@ -67,26 +67,26 @@ class SelectQueryConverterTest { private Graph graph; @BeforeEach - public void setUp() { + void setUp() { graph.traversal().E().toList().forEach(Edge::remove); graph.traversal().V().toList().forEach(Vertex::remove); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByName"}) - public void shouldRunQuery(String methodName) { + void shouldRunQuery(String methodName) { checkEquals(methodName); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameEquals"}) - public void shouldRunQuery1(String methodName) { + void shouldRunQuery1(String methodName) { checkEquals(methodName); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameNotEquals"}) - public void shouldRunQuery2(String methodName) { + void shouldRunQuery2(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -105,7 +105,7 @@ public void shouldRunQuery2(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThan"}) - public void shouldRunQuery3(String methodName) { + void shouldRunQuery3(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -123,7 +123,7 @@ public void shouldRunQuery3(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThanEqual"}) - public void shouldRunQuery4(String methodName) { + void shouldRunQuery4(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -143,7 +143,7 @@ public void shouldRunQuery4(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeGreaterThan"}) - public void shouldRunQuery5(String methodName) { + void shouldRunQuery5(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -161,7 +161,7 @@ public void shouldRunQuery5(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeGreaterThanEqual"}) - public void shouldRunQuery6(String methodName) { + void shouldRunQuery6(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -180,7 +180,7 @@ public void shouldRunQuery6(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeBetween"}) - public void shouldRunQuery7(String methodName) { + void shouldRunQuery7(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -200,7 +200,7 @@ public void shouldRunQuery7(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThanOrderByName"}) - public void shouldRunQuery8(String methodName) { + void shouldRunQuery8(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -221,7 +221,7 @@ public void shouldRunQuery8(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThanOrderByNameDesc"}) - public void shouldRunQuery9(String methodName) { + void shouldRunQuery9(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -241,7 +241,7 @@ public void shouldRunQuery9(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeLessThanOrderByNameDescAgeAsc"}) - public void shouldRunQuery10(String methodName) { + void shouldRunQuery10(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -261,7 +261,7 @@ public void shouldRunQuery10(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByAgeIn"}) - public void shouldRunQuery11(String methodName) { + void shouldRunQuery11(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); @@ -282,7 +282,7 @@ public void shouldRunQuery11(String methodName) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"findByNameIn"}) - public void shouldRunQuery12(String methodName) { + void shouldRunQuery12(String methodName) { Method method = Stream.of(PersonRepository.class.getMethods()) .filter(m -> m.getName().equals(methodName)).findFirst().get(); From 04f40a5d3dd4018c6a98381a25e78a3e3667b783 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:02 -0300 Subject: [PATCH 176/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/SelectQueryParserTest.java | 56 +++++++++---------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/SelectQueryParserTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/SelectQueryParserTest.java index d322c9858..3936aa3e7 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/SelectQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/SelectQueryParserTest.java @@ -38,7 +38,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -public class SelectQueryParserTest { +class SelectQueryParserTest { private final SelectQueryParser parser = new SelectQueryParser(); @@ -50,7 +50,7 @@ public class SelectQueryParserTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select name, address from God"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -66,7 +66,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God order by name"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -82,7 +82,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God order by name asc"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -98,7 +98,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God order by name desc"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -114,7 +114,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God order by name desc age asc"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); @@ -132,7 +132,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God skip 12"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -144,7 +144,7 @@ public void shouldReturnParserQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God limit 12"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -156,7 +156,7 @@ public void shouldReturnParserQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God skip 10 limit 12"}) - public void shouldReturnParserQuery9(String query) { + void shouldReturnParserQuery9(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -172,7 +172,7 @@ public void shouldReturnParserQuery9(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = 10"}) - public void shouldReturnParserQuery10(String query) { + void shouldReturnParserQuery10(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -188,7 +188,7 @@ public void shouldReturnParserQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina > 10.23"}) - public void shouldReturnParserQuery11(String query) { + void shouldReturnParserQuery11(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -204,7 +204,7 @@ public void shouldReturnParserQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina >= -10.23"}) - public void shouldReturnParserQuery12(String query) { + void shouldReturnParserQuery12(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); @@ -221,7 +221,7 @@ public void shouldReturnParserQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina <= -10.23"}) - public void shouldReturnParserQuery13(String query) { + void shouldReturnParserQuery13(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -237,7 +237,7 @@ public void shouldReturnParserQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina < -10.23"}) - public void shouldReturnParserQuery14(String query) { + void shouldReturnParserQuery14(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -253,7 +253,7 @@ public void shouldReturnParserQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age between 10 and 30"}) - public void shouldReturnParserQuery15(String query) { + void shouldReturnParserQuery15(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -269,7 +269,7 @@ public void shouldReturnParserQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"diana\""}) - public void shouldReturnParserQuery16(String query) { + void shouldReturnParserQuery16(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -285,7 +285,7 @@ public void shouldReturnParserQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery18(String query) { + void shouldReturnParserQuery18(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -306,7 +306,7 @@ public void shouldReturnParserQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = convert(12, java.lang.Integer)"}) - public void shouldReturnParserQuery19(String query) { + void shouldReturnParserQuery19(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -325,7 +325,7 @@ public void shouldReturnParserQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name in (\"Ada\", \"Apollo\")"}) - public void shouldReturnParserQuery20(String query) { + void shouldReturnParserQuery20(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -344,7 +344,7 @@ public void shouldReturnParserQuery20(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name like \"Ada\""}) - public void shouldReturnParserQuery21(String query) { + void shouldReturnParserQuery21(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -361,7 +361,7 @@ public void shouldReturnParserQuery21(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name not like \"Ada\""}) - public void shouldReturnParserQuery22(String query) { + void shouldReturnParserQuery22(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -381,7 +381,7 @@ public void shouldReturnParserQuery22(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20"}) - public void shouldReturnParserQuery23(String query) { + void shouldReturnParserQuery23(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -400,7 +400,7 @@ public void shouldReturnParserQuery23(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" or age = 20"}) - public void shouldReturnParserQuery24(String query) { + void shouldReturnParserQuery24(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -420,7 +420,7 @@ public void shouldReturnParserQuery24(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery25(String query) { + void shouldReturnParserQuery25(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); @@ -444,7 +444,7 @@ public void shouldReturnParserQuery25(String query) { @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"} and birthday =" + " convert(\"2007-12-03\", java.time.LocalDate)"}) - public void shouldReturnParserQuery26(String query) { + void shouldReturnParserQuery26(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); parser.query(query, manager, observer); Mockito.verify(manager).select(captor.capture()); @@ -465,7 +465,7 @@ public void shouldReturnParserQuery26(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldReturnErrorWhenIsQueryWithParam(String query) { + void shouldReturnErrorWhenIsQueryWithParam(String query) { assertThrows(QueryException.class, () -> parser.query(query, manager, observer)); @@ -475,7 +475,7 @@ public void shouldReturnErrorWhenIsQueryWithParam(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldReturnErrorWhenDontBindParameters(String query) { + void shouldReturnErrorWhenDontBindParameters(String query) { ColumnPreparedStatement prepare = parser.prepare(query, manager, observer); assertThrows(QueryException.class, prepare::result); @@ -483,7 +483,7 @@ public void shouldReturnErrorWhenDontBindParameters(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnQuery.class); ColumnPreparedStatement prepare = parser.prepare(query, manager, observer); From c37728573e43f896de76e8d73746a657e2e0480b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:03 -0300 Subject: [PATCH 177/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/SelectQueryParserTest.java | 56 +++++++++---------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/SelectQueryParserTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/SelectQueryParserTest.java index 1aea55206..b8a183a8a 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/SelectQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/SelectQueryParserTest.java @@ -38,7 +38,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -public class SelectQueryParserTest { +class SelectQueryParserTest { private final SelectQueryParser parser = new SelectQueryParser(); @@ -50,7 +50,7 @@ public class SelectQueryParserTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select name, address from God"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -66,7 +66,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God order by name"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -82,7 +82,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God order by name asc"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); DocumentObserverParser observer = new DocumentObserverParser() { }; @@ -100,7 +100,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God order by name desc"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -116,7 +116,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God order by name desc age asc"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); @@ -134,7 +134,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God skip 12"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -146,7 +146,7 @@ public void shouldReturnParserQuery7(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God limit 12"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); DocumentObserverParser observer = new DocumentObserverParser() { }; @@ -160,7 +160,7 @@ public void shouldReturnParserQuery8(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God skip 10 limit 12"}) - public void shouldReturnParserQuery9(String query) { + void shouldReturnParserQuery9(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -176,7 +176,7 @@ public void shouldReturnParserQuery9(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = 10"}) - public void shouldReturnParserQuery10(String query) { + void shouldReturnParserQuery10(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -192,7 +192,7 @@ public void shouldReturnParserQuery10(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina > 10.23"}) - public void shouldReturnParserQuery11(String query) { + void shouldReturnParserQuery11(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -208,7 +208,7 @@ public void shouldReturnParserQuery11(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina >= -10.23"}) - public void shouldReturnParserQuery12(String query) { + void shouldReturnParserQuery12(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); DocumentObserverParser observer = new DocumentObserverParser() { }; @@ -226,7 +226,7 @@ public void shouldReturnParserQuery12(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina <= -10.23"}) - public void shouldReturnParserQuery13(String query) { + void shouldReturnParserQuery13(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -242,7 +242,7 @@ public void shouldReturnParserQuery13(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where stamina < -10.23"}) - public void shouldReturnParserQuery14(String query) { + void shouldReturnParserQuery14(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -258,7 +258,7 @@ public void shouldReturnParserQuery14(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age between 10 and 30"}) - public void shouldReturnParserQuery15(String query) { + void shouldReturnParserQuery15(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -274,7 +274,7 @@ public void shouldReturnParserQuery15(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"diana\""}) - public void shouldReturnParserQuery16(String query) { + void shouldReturnParserQuery16(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -290,7 +290,7 @@ public void shouldReturnParserQuery16(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery18(String query) { + void shouldReturnParserQuery18(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -311,7 +311,7 @@ public void shouldReturnParserQuery18(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = convert(12, java.lang.Integer)"}) - public void shouldReturnParserQuery19(String query) { + void shouldReturnParserQuery19(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -330,7 +330,7 @@ public void shouldReturnParserQuery19(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name in (\"Ada\", \"Apollo\")"}) - public void shouldReturnParserQuery20(String query) { + void shouldReturnParserQuery20(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -349,7 +349,7 @@ public void shouldReturnParserQuery20(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name like \"Ada\""}) - public void shouldReturnParserQuery21(String query) { + void shouldReturnParserQuery21(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -366,7 +366,7 @@ public void shouldReturnParserQuery21(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name not like \"Ada\""}) - public void shouldReturnParserQuery22(String query) { + void shouldReturnParserQuery22(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -386,7 +386,7 @@ public void shouldReturnParserQuery22(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20"}) - public void shouldReturnParserQuery23(String query) { + void shouldReturnParserQuery23(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -405,7 +405,7 @@ public void shouldReturnParserQuery23(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" or age = 20"}) - public void shouldReturnParserQuery24(String query) { + void shouldReturnParserQuery24(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -425,7 +425,7 @@ public void shouldReturnParserQuery24(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"}"}) - public void shouldReturnParserQuery25(String query) { + void shouldReturnParserQuery25(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); @@ -449,7 +449,7 @@ public void shouldReturnParserQuery25(String query) { @ValueSource(strings = {"select * from God where name = \"Ada\" and age = 20 or" + " siblings = {\"apollo\": \"Brother\", \"Zeus\": \"Father\"} and birthday =" + " convert(\"2007-12-03\", java.time.LocalDate)"}) - public void shouldReturnParserQuery26(String query) { + void shouldReturnParserQuery26(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); parser.query(query, documentCollection, observer); Mockito.verify(documentCollection).select(captor.capture()); @@ -470,7 +470,7 @@ public void shouldReturnParserQuery26(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldReturnErrorWhenIsQueryWithParam(String query) { + void shouldReturnErrorWhenIsQueryWithParam(String query) { assertThrows(QueryException.class, () -> parser.query(query, documentCollection, observer)); @@ -480,7 +480,7 @@ public void shouldReturnErrorWhenIsQueryWithParam(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldReturnErrorWhenDontBindParameters(String query) { + void shouldReturnErrorWhenDontBindParameters(String query) { DocumentPreparedStatement prepare = parser.prepare(query, documentCollection, observer); assertThrows(QueryException.class, prepare::result); @@ -488,7 +488,7 @@ public void shouldReturnErrorWhenDontBindParameters(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"select * from God where age = @age"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DefaultDocumentQuery.class); DocumentPreparedStatement prepare = parser.prepare(query, documentCollection, observer); From 480f8a2c1424d46397263e6e4c781ffb51249413 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:04 -0300 Subject: [PATCH 178/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/query/SelectQueryTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/SelectQueryTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/SelectQueryTest.java index 83330b903..af0cb32a7 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/SelectQueryTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/SelectQueryTest.java @@ -26,22 +26,22 @@ import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.ArgumentsSource; -public class SelectQueryTest { +class SelectQueryTest { @ParameterizedTest @ArgumentsSource(SelectQueryArgumentProvider.class) - public void shouldExecuteQuery(String query) { + void shouldExecuteQuery(String query) { testQuery(query); } @Test - public void shouldIgnoreComments() { + void shouldIgnoreComments() { testQuery("//ignore this line \n select * from Person"); } @ParameterizedTest @ArgumentsSource(WrongSelectQueryArgumentProvider.class) - public void shouldNotExecute(String query) { + void shouldNotExecute(String query) { Assertions.assertThrows(QueryException.class, () -> testQuery(query)); } From f56a8fff987a738b76e9abbfb239c322a4181c05 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:05 -0300 Subject: [PATCH 179/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/repository/returns/SetRepositoryReturnTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/SetRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/SetRepositoryReturnTest.java index 9cf432299..9d4d3aed6 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/SetRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/SetRepositoryReturnTest.java @@ -42,14 +42,14 @@ class SetRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Set.class)); assertFalse(repositoryReturn.isCompatible(Object.class, Person.class)); assertFalse(repositoryReturn.isCompatible(Person.class, Object.class)); } @Test - public void shouldReturnSet() { + void shouldReturnSet() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Person.class) @@ -69,7 +69,7 @@ public void shouldReturnSet() { } @Test - public void shouldReturnSetPage() { + void shouldReturnSetPage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Person.class) From 1ad2719c957a290b1eaac5624548e3bb391410b7 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:06 -0300 Subject: [PATCH 180/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/collection/SetSupplierTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/SetSupplierTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/SetSupplierTest.java index a5440ea43..3baa237c4 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/SetSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/SetSupplierTest.java @@ -29,18 +29,18 @@ class SetSupplierTest { private CollectionSupplier supplier; @BeforeEach - public void setUp() { + void setUp() { this.supplier = new SetSupplier(); } @Test - public void shouldTest() { + void shouldTest() { Assertions.assertTrue(supplier.test(Set.class)); Assertions.assertFalse(supplier.test(List.class)); } @Test - public void shouldGet() { + void shouldGet() { final Collection collection = this.supplier.get(); Assertions.assertNotNull(collection); Assertions.assertTrue(collection instanceof HashSet); From 11f90a856a099e8a7835e26c9fdf77bc88e27855 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:07 -0300 Subject: [PATCH 181/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../returns/SortedSetRepositoryReturnTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/SortedSetRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/SortedSetRepositoryReturnTest.java index 5ba688c26..baebd9431 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/SortedSetRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/SortedSetRepositoryReturnTest.java @@ -45,7 +45,7 @@ class SortedSetRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, NavigableSet.class)); Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, SortedSet.class)); assertFalse(repositoryReturn.isCompatible(Object.class, Person.class)); @@ -54,7 +54,7 @@ public void shouldReturnIsCompatible() { @Test - public void shouldReturnTreeSetPage() { + void shouldReturnTreeSetPage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Person.class) @@ -73,7 +73,7 @@ public void shouldReturnTreeSetPage() { } @Test - public void shouldReturnTreeSet() { + void shouldReturnTreeSet() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withSingleResult(Optional::empty) @@ -88,7 +88,7 @@ public void shouldReturnTreeSet() { } @Test - public void shouldReturnErrorOnTreeSetPage() { + void shouldReturnErrorOnTreeSetPage() { Animal animal = new Animal(); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Animal.class) @@ -104,7 +104,7 @@ public void shouldReturnErrorOnTreeSetPage() { } @Test - public void shouldReturnErrorOnTreeSet() { + void shouldReturnErrorOnTreeSet() { Animal animal = new Animal(); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Animal.class) From 199f259c7082dcfc061975afb4629596bc292200 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:08 -0300 Subject: [PATCH 182/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../repository/SpecialParametersTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/SpecialParametersTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/SpecialParametersTest.java index 5e6737846..adb99d6ca 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/SpecialParametersTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/SpecialParametersTest.java @@ -33,19 +33,19 @@ class SpecialParametersTest { //should keep the precedence @Test - public void shouldReturnEmpty() { + void shouldReturnEmpty() { SpecialParameters parameters = SpecialParameters.of(new Object[0]); assertTrue(parameters.isEmpty()); } @Test - public void shouldReturnEmptyNonSpecialParameters() { + void shouldReturnEmptyNonSpecialParameters() { SpecialParameters parameters = SpecialParameters.of(new Object[]{10, "Otavio"}); assertTrue(parameters.isEmpty()); } @Test - public void shouldReturnPageable() { + void shouldReturnPageable() { Pageable pageable = Pageable.ofPage(10); SpecialParameters parameters = SpecialParameters.of(new Object[]{10, "Otavio", pageable}); assertFalse(parameters.isEmpty()); @@ -54,7 +54,7 @@ public void shouldReturnPageable() { } @Test - public void shouldReturnPageableWithSort() { + void shouldReturnPageableWithSort() { Pageable pageable = Pageable.ofPage(10).sortBy(Sort.asc("name"), Sort.desc("age")); SpecialParameters parameters = SpecialParameters.of(new Object[]{10, "Otavio", pageable}); @@ -67,7 +67,7 @@ public void shouldReturnPageableWithSort() { } @Test - public void shouldReturnSort() { + void shouldReturnSort() { Sort sort = Sort.asc("name"); SpecialParameters parameters = SpecialParameters.of(new Object[]{10, "Otavio", sort}); assertFalse(parameters.isEmpty()); @@ -79,7 +79,7 @@ public void shouldReturnSort() { } @Test - public void shouldKeepOrder() { + void shouldKeepOrder() { Sort sort = Sort.asc("name"); Pageable pageable = Pageable.ofPage(10).sortBy(Sort.asc("name"), Sort.desc("age")); @@ -95,7 +95,7 @@ public void shouldKeepOrder() { } @Test - public void shouldReturnLimit() { + void shouldReturnLimit() { SpecialParameters parameters = SpecialParameters.of(new Object[]{10, "Otavio", Limit.of(10)}); assertFalse(parameters.isEmpty()); Optional limit = parameters.limit(); @@ -106,7 +106,7 @@ public void shouldReturnLimit() { } @Test - public void shouldReturnIterableSort(){ + void shouldReturnIterableSort(){ SpecialParameters parameters = SpecialParameters.of(new Object[]{10, "Otavio", List.of(Sort.asc("name"), Sort.desc("age"))}); assertFalse(parameters.isEmpty()); From b65cf14b73a19073e45c147194b1e18300497781 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:10 -0300 Subject: [PATCH 183/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../repository/returns/StreamRepositoryReturnTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/StreamRepositoryReturnTest.java b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/StreamRepositoryReturnTest.java index 6ad9abc87..81c8be736 100644 --- a/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/StreamRepositoryReturnTest.java +++ b/jnosql-mapping/jnosql-mapping-core/src/test/java/org/eclipse/jnosql/mapping/repository/returns/StreamRepositoryReturnTest.java @@ -41,7 +41,7 @@ class StreamRepositoryReturnTest { private Page page; @Test - public void shouldReturnIsCompatible() { + void shouldReturnIsCompatible() { Assertions.assertTrue(repositoryReturn.isCompatible(Person.class, Stream.class)); assertFalse(repositoryReturn.isCompatible(Object.class, Person.class)); assertFalse(repositoryReturn.isCompatible(Person.class, Object.class)); @@ -49,7 +49,7 @@ public void shouldReturnIsCompatible() { @Test - public void shouldReturnStreamPage() { + void shouldReturnStreamPage() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withClassSource(Person.class) @@ -69,7 +69,7 @@ public void shouldReturnStreamPage() { @Test - public void shouldReturnStream() { + void shouldReturnStream() { Person ada = new Person("Ada"); DynamicReturn dynamic = DynamicReturn.builder() .withSingleResult(Optional::empty) From 455a6454067cd07f09567721ca0ac1d8cb865ec5 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:11 -0300 Subject: [PATCH 184/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../eclipse/jnosql/communication/reader/StringReaderTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/reader/StringReaderTest.java b/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/reader/StringReaderTest.java index 4607015c8..74419c2f9 100644 --- a/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/reader/StringReaderTest.java +++ b/jnosql-communication/jnosql-communication-core/src/test/java/org/eclipse/jnosql/communication/reader/StringReaderTest.java @@ -26,7 +26,7 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.SoftAssertions.assertSoftly; -public class StringReaderTest { +class StringReaderTest { private final ValueReader valueReader = new StringReader(); From 0b1d67515e3bf9da7d6c980b4e68cc1ebaf6390a Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:12 -0300 Subject: [PATCH 185/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/StringUtilsTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/StringUtilsTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/StringUtilsTest.java index 9e044b68f..e0c61faf4 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/StringUtilsTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/StringUtilsTest.java @@ -24,42 +24,42 @@ class StringUtilsTest { @Test - public void testIsBlankWithNull() { + void testIsBlankWithNull() { assertTrue(StringUtils.isBlank(null)); } @Test - public void testIsBlankWithEmptyString() { + void testIsBlankWithEmptyString() { assertTrue(StringUtils.isBlank("")); } @Test - public void testIsBlankWithSpaces() { + void testIsBlankWithSpaces() { assertTrue(StringUtils.isBlank(" ")); } @Test - public void testIsBlankWithNonBlankString() { + void testIsBlankWithNonBlankString() { assertFalse(StringUtils.isBlank("Hello, world!")); } @Test - public void testIsNotBlankWithNull() { + void testIsNotBlankWithNull() { assertFalse(StringUtils.isNotBlank(null)); } @Test - public void testIsNotBlankWithEmptyString() { + void testIsNotBlankWithEmptyString() { assertFalse(StringUtils.isNotBlank("")); } @Test - public void testIsNotBlankWithSpaces() { + void testIsNotBlankWithSpaces() { assertFalse(StringUtils.isNotBlank(" ")); } @Test - public void testIsNotBlankWithNonBlankString() { + void testIsNotBlankWithNonBlankString() { assertTrue(StringUtils.isNotBlank("Hello, world!")); } From 9cc7eab1cabb1c649a46130cc9b0db0b32a4db39 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:13 -0300 Subject: [PATCH 186/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../org/eclipse/jnosql/mapping/graph/TemplateGraphTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/TemplateGraphTest.java b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/TemplateGraphTest.java index ed6299b79..052559f2a 100644 --- a/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/TemplateGraphTest.java +++ b/jnosql-mapping/jnosql-mapping-graph/src/test/java/org/eclipse/jnosql/mapping/graph/TemplateGraphTest.java @@ -34,7 +34,7 @@ @AddPackages(BookRepository.class) @AddPackages(Reflections.class) @AddExtensions({EntityMetadataExtension.class, GraphExtension.class}) -public class TemplateGraphTest { +class TemplateGraphTest { @Inject private Template template; @@ -44,12 +44,12 @@ public class TemplateGraphTest { private Template qualifier; @Test - public void shouldInjectTemplate() { + void shouldInjectTemplate() { Assertions.assertNotNull(template); } @Test - public void shouldInjectQualifier() { + void shouldInjectQualifier() { Assertions.assertNotNull(qualifier); } } From 469b006349f262ef4959b32523148f66fa680cbd Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:14 -0300 Subject: [PATCH 187/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../mapping/reflection/collection/TreeSetSupplierTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/TreeSetSupplierTest.java b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/TreeSetSupplierTest.java index 8d94cb466..37baf8900 100644 --- a/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/TreeSetSupplierTest.java +++ b/jnosql-mapping/jnosql-mapping-reflection/src/test/java/org/eclipse/jnosql/mapping/reflection/collection/TreeSetSupplierTest.java @@ -30,19 +30,19 @@ class TreeSetSupplierTest { private CollectionSupplier supplier; @BeforeEach - public void setUp() { + void setUp() { this.supplier = new TreeSetSupplier(); } @Test - public void shouldTest() { + void shouldTest() { Assertions.assertTrue(supplier.test(NavigableSet.class)); Assertions.assertTrue(supplier.test(SortedSet.class)); Assertions.assertFalse(supplier.test(Set.class)); } @Test - public void shouldGet() { + void shouldGet() { final Collection collection = this.supplier.get(); Assertions.assertNotNull(collection); Assertions.assertTrue(collection instanceof TreeSet); From 19c1028bd4995a52c4645de430c78791f25560fc Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:15 -0300 Subject: [PATCH 188/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../query/UpdateQueryConverterTest.java | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/UpdateQueryConverterTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/UpdateQueryConverterTest.java index bcdc61424..9a3ccb837 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/UpdateQueryConverterTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/UpdateQueryConverterTest.java @@ -25,18 +25,18 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertTrue; -public class UpdateQueryConverterTest { +class UpdateQueryConverterTest { private final UpdateQueryConverter update = new UpdateQueryConverter(); @Test - public void shouldReturnErrorWhenStringIsNull() { + void shouldReturnErrorWhenStringIsNull() { Assertions.assertThrows(NullPointerException.class, () -> update.apply(null)); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = \"Diana\")"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { UpdateQuery updateQuery = checkUpdateFromStart(query); List conditions = updateQuery.conditions(); assertEquals(1, conditions.size()); @@ -50,7 +50,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (age = 30)"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { UpdateQuery updateQuery = checkUpdateFromStart(query); List conditions = updateQuery.conditions(); assertEquals(1, conditions.size()); @@ -64,7 +64,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (stamina = 32.23)"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { UpdateQuery updateQuery = checkUpdateFromStart(query); List conditions = updateQuery.conditions(); assertEquals(1, conditions.size()); @@ -78,7 +78,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (siblings = {\"Apollo\": \"Brother\", \"Zeus\": \"Father\"})"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { UpdateQuery updateQuery = checkUpdateFromStart(query); List conditions = updateQuery.conditions(); assertEquals(1, conditions.size()); @@ -94,7 +94,7 @@ public void shouldReturnParserQuery3(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (age = @age)"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { UpdateQuery updateQuery = checkUpdateFromStart(query); List conditions = updateQuery.conditions(); assertEquals(1, conditions.size()); @@ -108,7 +108,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (birthday = convert(\"1988-01-01\", java.time.LocalDate))"}) - public void shouldReturnParserQuery5(String query) { + void shouldReturnParserQuery5(String query) { UpdateQuery updateQuery = checkUpdateFromStart(query); List conditions = updateQuery.conditions(); assertEquals(1, conditions.size()); @@ -127,7 +127,7 @@ public void shouldReturnParserQuery5(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (age = 30, name = \"Artemis\")"}) - public void shouldReturnParserQuery6(String query) { + void shouldReturnParserQuery6(String query) { UpdateQuery updateQuery = checkUpdateFromStart(query); List conditions = updateQuery.conditions(); assertEquals(2, conditions.size()); @@ -148,7 +148,7 @@ public void shouldReturnParserQuery6(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update Person {\"name\":\"Ada Lovelace\"}"}) - public void shouldReturnParserQuery7(String query) { + void shouldReturnParserQuery7(String query) { UpdateQuery updateQuery = update.apply(query); assertEquals("Person", updateQuery.entity()); Assertions.assertTrue(updateQuery.conditions().isEmpty()); @@ -163,7 +163,7 @@ public void shouldReturnParserQuery7(String query) { @ValueSource(strings = {"update Person {\"name\": \"Ada Lovelace\", \"age\": 12, \"sibling\":" + " [\"Ana\" ,\"Maria\"]," + " \"address\":{\"country\": \"United Kingdom\", \"city\": \"London\"}}"}) - public void shouldReturnParserQuery8(String query) { + void shouldReturnParserQuery8(String query) { UpdateQuery updateQuery = update.apply(query); assertEquals("Person", updateQuery.entity()); Assertions.assertTrue(updateQuery.conditions().isEmpty()); From 4d9306dd85468bb1fbf573885ccd53535469e97c Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:16 -0300 Subject: [PATCH 189/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../column/UpdateQueryParserTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/UpdateQueryParserTest.java b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/UpdateQueryParserTest.java index 0a904bde4..b5b51233e 100644 --- a/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/UpdateQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-column/src/test/java/org/eclipse/jnosql/communication/column/UpdateQueryParserTest.java @@ -42,7 +42,7 @@ class UpdateQueryParserTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = \"Diana\")"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); parser.query(query, manager, observer); Mockito.verify(manager).update(captor.capture()); @@ -55,7 +55,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (age = 30, name = \"Artemis\")"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); parser.query(query, manager, observer); Mockito.verify(manager).update(captor.capture()); @@ -68,13 +68,13 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = @name)"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { assertThrows(QueryException.class, () -> parser.query(query, manager, observer)); } @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update Person {\"name\":\"Ada Lovelace\"}"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); @@ -91,7 +91,7 @@ public void shouldReturnParserQuery3(String query) { @ValueSource(strings = {"update Person {\"name\": \"Ada Lovelace\", \"age\": 12, \"sibling\":" + " [\"Ana\" ,\"Maria\"]," + " \"address\":{\"country\": \"United Kingdom\", \"city\": \"London\"}}"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); @@ -113,7 +113,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = @name)"}) - public void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { + void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { ColumnPreparedStatement prepare = parser.prepare(query, manager, observer); assertThrows(QueryException.class, prepare::result); @@ -121,7 +121,7 @@ public void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = @name)"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(ColumnEntity.class); ColumnPreparedStatement prepare = parser.prepare(query, manager, observer); prepare.bind("name", "Diana"); From 00aaeb95ba4432e3d69355c6fa198d03f8b39b73 Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:17 -0300 Subject: [PATCH 190/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../document/UpdateQueryParserTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/UpdateQueryParserTest.java b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/UpdateQueryParserTest.java index 35f526f37..3e3d087fd 100644 --- a/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/UpdateQueryParserTest.java +++ b/jnosql-communication/jnosql-communication-document/src/test/java/org/eclipse/jnosql/communication/document/UpdateQueryParserTest.java @@ -42,7 +42,7 @@ class UpdateQueryParserTest { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = \"Diana\")"}) - public void shouldReturnParserQuery(String query) { + void shouldReturnParserQuery(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); parser.query(query, manager, observer); Mockito.verify(manager).update(captor.capture()); @@ -55,7 +55,7 @@ public void shouldReturnParserQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (age = 30, name = \"Artemis\")"}) - public void shouldReturnParserQuery1(String query) { + void shouldReturnParserQuery1(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); parser.query(query, manager, observer); Mockito.verify(manager).update(captor.capture()); @@ -68,7 +68,7 @@ public void shouldReturnParserQuery1(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = @name)"}) - public void shouldReturnParserQuery2(String query) { + void shouldReturnParserQuery2(String query) { assertThrows(QueryException.class, () -> parser.query(query, manager, observer)); } @@ -76,7 +76,7 @@ public void shouldReturnParserQuery2(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update Person {\"name\":\"Ada Lovelace\"}"}) - public void shouldReturnParserQuery3(String query) { + void shouldReturnParserQuery3(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); @@ -93,7 +93,7 @@ public void shouldReturnParserQuery3(String query) { @ValueSource(strings = {"update Person {\"name\": \"Ada Lovelace\", \"age\": 12, \"sibling\":" + " [\"Ana\" ,\"Maria\"]," + " \"address\":{\"country\": \"United Kingdom\", \"city\": \"London\"}}"}) - public void shouldReturnParserQuery4(String query) { + void shouldReturnParserQuery4(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); @@ -115,7 +115,7 @@ public void shouldReturnParserQuery4(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = @name)"}) - public void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { + void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { DocumentPreparedStatement prepare = parser.prepare(query, manager, observer); assertThrows(QueryException.class, prepare::result); @@ -124,7 +124,7 @@ public void shouldReturnErrorWhenDoesNotBindBeforeExecuteQuery(String query) { @ParameterizedTest(name = "Should parser the query {0}") @ValueSource(strings = {"update God (name = @name)"}) - public void shouldExecutePrepareStatement(String query) { + void shouldExecutePrepareStatement(String query) { ArgumentCaptor captor = ArgumentCaptor.forClass(DocumentEntity.class); DocumentPreparedStatement prepare = parser.prepare(query, manager, observer); prepare.bind("name", "Diana"); From 8a62676b285817bdfb0e0385e605bf74eed6044b Mon Sep 17 00:00:00 2001 From: Maximillian Arruda Date: Sun, 12 Nov 2023 04:36:22 -0300 Subject: [PATCH 191/191] refactor: remove public modifier at test class and its methods Signed-off-by: Maximillian Arruda --- .../jnosql/communication/query/UpdateQueryTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/UpdateQueryTest.java b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/UpdateQueryTest.java index 57e08eb3d..ab1ea7519 100644 --- a/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/UpdateQueryTest.java +++ b/jnosql-communication/jnosql-communication-query/src/test/java/org/eclipse/jnosql/communication/query/UpdateQueryTest.java @@ -28,22 +28,22 @@ import static org.assertj.core.api.Assertions.assertThat; -public class UpdateQueryTest { +class UpdateQueryTest { @ParameterizedTest @ArgumentsSource(UpdateQueryArgumentProvider.class) - public void shouldExecuteQuery(String query) { + void shouldExecuteQuery(String query) { testQuery(query); } @Test - public void shouldIgnoreComments() { + void shouldIgnoreComments() { testQuery("//ignore this line \n update Person (name = \"Ada Lovelace\")"); } @ParameterizedTest @ArgumentsSource(WrongUpdateQueryArgumentProvider.class) - public void shouldNotExecute(String query) { + void shouldNotExecute(String query) { Assertions.assertThrows(QueryException.class, () -> testQuery(query)); }