Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest LSP4J release (cuts off some dependencies) #3209

Closed
mickaelistria opened this issue Jul 5, 2024 · 3 comments · Fixed by #3232
Closed

Use latest LSP4J release (cuts off some dependencies) #3209

mickaelistria opened this issue Jul 5, 2024 · 3 comments · Fixed by #3232
Labels
dependencies Pull requests that update a dependency file

Comments

@mickaelistria
Copy link
Contributor

JDT-LS seems to still depend on older LSP4J, which requires xbase and other dependencies. The latest release removes needs for some dependencies. This would make it noticeably simpler to set up some non-standard dev environments mixing various projects.

@rgrunber rgrunber added the dependencies Pull requests that update a dependency file label Jul 22, 2024
@rgrunber
Copy link
Contributor

Do you know which dependencies? We use xbase in our code for custom protocol classes, and pretty much only to annotate with @Pure.

I don't see any reductions in dependencies going from LSP4J 0.22.0 to 0.23.1.

@mickaelistria
Copy link
Contributor Author

I think the main one I had in mind was xbase. Also, IIRC moving to latest LSP4J allows to get rid of 1 older version of guava.

@rgrunber
Copy link
Contributor

It updated guava and gson but the duplicate version of guava I think was fixed a while ago in a previous lsp4j.

com.google.gson_2.10.1.v20230109-0753.jar
	com.google.gson_2.11.0.jar
com.google.guava_33.0.0.jre.jar
	com.google.guava_33.2.0.jre.jar
org.eclipse.lsp4j_0.22.0.v20240213-2011.jar
	org.eclipse.lsp4j_0.23.1.v20240521-1815.jar
org.eclipse.lsp4j.jsonrpc_0.22.0.v20240213-2011.jar
	org.eclipse.lsp4j.jsonrpc_0.23.1.v20240521-1815.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants