Javac-based diagnostics not producing IProblem.PackageIsNotExpectedPackage

[mickaelistria]

JDT produces IProblem.PackageIsNotExpectedPackage when the folder doesn't match the package declaration. Javac doesn't provide that.
An extra check should probably be added to create this problem in the JavacCompilationUnitResolver or/and in JavacProblemConverter.

[fbricon]

that's actually one of javac's particular differences compared to ECJ. ECJ's pretty anal about package names matching the underlying folder, when javac compiles fine. I vaguely remember we've had users complaining about it in the past. So I think we might need a preference to toggle this particular diagnostic

[testforstephen]

Agree with @fbricon. One of package name issues for ECJ is that it does not support the folder name with dot characters. redhat-developer/vscode-java#1406

[mickaelistria]

If this behavior is not required by VSCode-Java or JDT-LS, then I would recommend that we remove the associated test cases so we can evolve more freely. What do you think?

[testforstephen]

how about skipping these tests in the command line when running javac test but keeping them for the normal jdt.ls?