No respect for --release flag

[akurtakov]

The following java file in a project:

import java.util.Locale;

public class Test {

	public static void main(String[] args) {
		new Locale("bg");
	}

}

produces

but the project has Java -17 JVM (a real 17 JVM) but the deprecation warnings shouldn't be there with --release 17 .
Console usage of javac gives (warning on Java 21 but not on 17):`

akurtakov@localhost:~/work/jdt.ui/testa/src/testa$ javac Test.java -Xlint:deprecation --release=21
Test.java:6: warning: [deprecation] Locale(String) in Locale has been deprecated
		new Locale("bg");
		^
1 warning
akurtakov@localhost:~/work/jdt.ui/testa/src/testa$ javac Test.java -Xlint:deprecation --release=17
akurtakov@localhost:~/work/jdt.ui/testa/src/testa$ 

[mickaelistria]

Are you sure the project has the "release" setting enabled?

[akurtakov]

[akurtakov]

[mickaelistria]

JDT's CompilerOptions is enforcing OPTION_Release to "disabled". This has to be fixed.

[mickaelistria]

There are (at least) 2 issues:

• one seems to be JDT not forwarding the value of the release option to AbstractImageBuilder (I've got a patch for it, that I'll push upstream when I confirm a full fix)
• another issue is that the classloading is different with javac CLI vs our Javac integration: what we get with the right option in JDT is a different c.classfile for the class symbol of Locale. CLI one is an instanceof JDKPlatformManager$1 (expected) while the one with our Javac integration is a JavacFileManager returning a different object (not so correct).

[mickaelistria]

The JavacCompiler must be using JavacTool.getTask() to ensure proper arguments being passed.

[mickaelistria]

Should be fixed with #1168