Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#getInstalledExtensions() never called in container #694

Closed
dansiviter opened this issue Apr 2, 2020 · 2 comments
Closed

#getInstalledExtensions() never called in container #694

dansiviter opened this issue Apr 2, 2020 · 2 comments

Comments

@dansiviter
Copy link
Contributor

dansiviter commented Apr 2, 2020 •
edited
Loading

It seems there is no way of defining default Extensions to be used in Tyrus (e.g. per-message deflate). It seems the TyrusServerContainer#getInstalledExtensions() is never called and therefore does not get populated into DefaultServerEndpointConfig.

The only way is to manually define the application via DefaultServerEndpointConfig.Builder which precludes annotated endpoints from using it. There is a separate question about weather @ServerEndpoint annotation should also define a extensions field, but I've raised that in the Spec project (jakartaee/websocket#327).
@dansiviter dansiviter mentioned this issue Apr 2, 2020
Closed
@dansiviter
Copy link
Contributor Author

FYI it appears Undertow uses #installedExtensions as a basis of all endpoints if defined but Tyrus doesn't. The spec isn't all that clear, but I would have imagined that it would use the #installedExtensions as a basis and append any that are also defined in ServerEndpointConfig#extensions

dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 5, 2020
@dansiviter
Resolves eclipse-ee4j#694
699ec90
dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 5, 2020
@dansiviter
Resolves eclipse-ee4j#694
f23cf37
dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 5, 2020
@dansiviter
Resolves eclipse-ee4j#694
b401024
dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 16, 2020
@dansiviter
[694] Linking installed extensions into annotated endpoints.
d8c3a1e 
Annotated endpoints will default the available extensions to
WebSocketContainer#getInstalledExtensions if available.

Signed-off-by: Dan Siviter <[email protected]>
Bug: eclipse-ee4j#694
dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 16, 2020
@dansiviter
[694] Linking installed extensions into annotated endpoints.
cced268 
Annotated endpoints will default the available extensions to
WebSocketContainer#getInstalledExtensions if available.

Signed-off-by: Dan Siviter <[email protected]>
Bug: eclipse-ee4j#694
dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 16, 2020
@dansiviter
[694] Linking installed extensions into annotated endpoints.
4ae3cc3 
Annotated endpoints will default the available extensions to
WebSocketContainer#getInstalledExtensions if available.

Signed-off-by: Dan Siviter <[email protected]>
Bug: eclipse-ee4j#694
dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 17, 2020
@dansiviter
[694] Linking installed extensions into annotated endpoints.
1df0c55 
Annotated endpoints will default the available extensions to
WebSocketContainer#getInstalledExtensions if available.

Signed-off-by: Dan Siviter <[email protected]>
Bug: eclipse-ee4j#694
dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 17, 2020
@dansiviter
[694] Linking installed extensions into annotated endpoints.
60bb734 
Annotated endpoints will default the available extensions to
WebSocketContainer#getInstalledExtensions if available.

Signed-off-by: Dan Siviter <[email protected]>
Bug: eclipse-ee4j#694
dansiviter added a commit to dansiviter/tyrus that referenced this issue Apr 17, 2020
@dansiviter
[694] Linking installed extensions into annotated endpoints.
3e9e30c 
Annotated endpoints will default the available extensions to
WebSocketContainer#getInstalledExtensions if available.

Signed-off-by: Dan Siviter <[email protected]>
Bug: eclipse-ee4j#694
jansupol pushed a commit that referenced this issue Apr 22, 2020
@dansiviter @jansupol
[694] Linking installed extensions into annotated endpoints.
f393e93 
Annotated endpoints will default the available extensions to
WebSocketContainer#getInstalledExtensions if available.

Signed-off-by: Dan Siviter <[email protected]>
Bug: #694
@jansupol
Copy link
Contributor

Fixed by #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dansiviter @jansupol