Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhances line terminator for chunk-size in Chunked Transfer Coding #2217

Open
carryel opened this issue Dec 15, 2024 · 0 comments
Open

Enhances line terminator for chunk-size in Chunked Transfer Coding #2217

carryel opened this issue Dec 15, 2024 · 0 comments

Comments

@carryel
Copy link
Contributor

carryel commented Dec 15, 2024

The chunk size and chunk extension are terminated by a CRLF sequence.

RFC 9112 Chunked Transfer Coding

  chunk          = chunk-size [ chunk-ext ] CRLF

However, Grizzly allows even if the line terminator is only a single LF.

This can lead to unintended behavior with incorrect chunk-ext in reverse proxy solution environments.

Therefore, we should safely provide the ability to only allow CRLF.
carryel added a commit to carryel/grizzly that referenced this issue Dec 16, 2024
@carryel
Issue eclipse-ee4j#2217 "Enhances line terminator for chunk-size in C…
582420d 
…hunked Transfer Coding" (eclipse-ee4j#2217)

+ When the org.glassfish.grizzly.http.STRICT_CHUNKED_TRANSFER_CODING_LINE_TERMINATOR_RFC_9112 option is enabled, only CRLF is allowed as the chunk-size line terminator in Chunked Transfer Coding.
+ Added testcase depending on whether option is present or not
@carryel carryel mentioned this issue Dec 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carryel