Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpRequestLoggerServer does not close connection #157

Closed
iwasakims opened this issue Nov 20, 2023 · 0 comments · Fixed by #158
Closed

HttpRequestLoggerServer does not close connection #157

iwasakims opened this issue Nov 20, 2023 · 0 comments · Fixed by #158

Comments

@iwasakims
Copy link
Contributor

iwasakims commented Nov 20, 2023

Bug Report

Describe the Bug

$ docker build -t http-request-logger util/http-request-logger
$ docker run -p 4000:4000 http-request-logger
$ curl -i -X POST --data baz localhost:4000/foo/bar
HTTP/1.1 200 OK
Date: Mon, 20 Nov 2023 08:08:10 GMT
Transfer-encoding: chunked

(curl keeps waiting for response body from server)

While there is no error on the sample, data-plane-http of eclipse-edc/Connector may have potential issue in response handling. The sample senario of transfer-03-provider-push failed if I set "nonChunkedTransfer": "true" to the dataDestination in resources/start-transfer.json at least.

Possible Implementation

The stream for the response body should be closed in the server if Transfer-encoding: chunked. If server needs no response body, it should set Content-length: 0 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant