Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect parameters' order in dataplane logs regarding DataFlow Id #4804

Open
bmg13 opened this issue Feb 7, 2025 · 1 comment
Open
Labels
refactoring Cleaning up code and dependencies

Comments

@bmg13
Copy link
Contributor

bmg13 commented Feb 7, 2025

Bug Report

Describe the Bug

In this PR adding the DataFlow ID to the DataPlane logs, the order of the parameters added is not correct and needs to be updated.

Expected Behavior

The log is should be printed as follows.

Transferring from AmazonS3 to AmazonS3 for flow id: c9a1d5e9-b4a7-4a31-a508-c27a7ca61419.

Observed Behavior

The log is disconnected
Transferring from c9a1d5e9-b4a7-4a31-a508-c27a7ca61419 to AmazonS3 for flow id: AmazonS3.

AwsS3 used as an example here, but issue applies to any type of TP.

Same is seen for Unknown data source and Unknown data sink type logs.

Steps to Reproduce

Perform any TP and can be confirmed in the logs

Possible Implementation

This is a very small change, only needs to update the (three) logs on this class.

@bmg13 bmg13 added bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification labels Feb 7, 2025
@ndr-brt
Copy link
Member

ndr-brt commented Feb 7, 2025

definitely not a bug as logs are there only for debug purposes but yes, this should be fixed anyway

@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies and removed bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

No branches or pull requests

2 participants