Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tag for PostgreSQL integration test should be consistent with the annotation name #4001

Closed
iwasakims opened this issue Mar 13, 2024 · 0 comments · Fixed by #4005
Closed

The tag for PostgreSQL integration test should be consistent with the annotation name #4001

iwasakims opened this issue Mar 13, 2024 · 0 comments · Fixed by #4005
Labels
good first issue Good for newcomers refactoring Cleaning up code and dependencies triage all new issues awaiting classification

Comments

@iwasakims
Copy link
Contributor

Bug Report

Describe the Bug

The tag is PostgresqlIntegrationTest while the annotation is PostgresqlDbIntegrationTest.

Expected Behavior

It would be better to have consistent name as done for IntegrationTest annotation in order to keep users from setting invalid option like -DincludeTags=PostgresqlDbIntegrationTest.

Possible Implementation

renaming the PostgresqlDbIntegrationTest to PostgresqlIntegrationTest.
@iwasakims iwasakims added refactoring Cleaning up code and dependencies bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification labels Mar 13, 2024
@ndr-brt ndr-brt removed the bug_report Suspected bugs, awaiting triage label Mar 13, 2024
@paullatzelsperger paullatzelsperger added the good first issue Good for newcomers label Mar 13, 2024
@iwasakims iwasakims mentioned this issue Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring Cleaning up code and dependencies triage all new issues awaiting classification
Projects
None yet
Milestone
No milestone
3 participants
@iwasakims @ndr-brt @paullatzelsperger